-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reporting for Administrator Commissioning attributes. #23589
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:fix-reporting-admin-commissioning
Nov 18, 2022
Merged
Fix reporting for Administrator Commissioning attributes. #23589
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:fix-reporting-admin-commissioning
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
November 12, 2022 13:08
pullapprove
bot
requested review from
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 12, 2022 13:08
PR #23589: Size comparison from 008df4d to 71f964b Increases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-reporting-admin-commissioning
branch
from
November 14, 2022 13:07
71f964b
to
c4ede15
Compare
PR #23589: Size comparison from 030bd45 to c4ede15 Increases (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-reporting-admin-commissioning
branch
2 times, most recently
from
November 14, 2022 17:18
42a7f16
to
cfc5724
Compare
andy31415
approved these changes
Nov 14, 2022
PR #23589: Size comparison from e072098 to cfc5724 Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
fix-reporting-admin-commissioning
branch
from
November 15, 2022 02:58
cfc5724
to
beccbdf
Compare
PR #23589: Size comparison from 9a41c9c to beccbdf Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 16, 2022
bzbarsky-apple
force-pushed
the
fix-reporting-admin-commissioning
branch
from
November 17, 2022 00:36
e30de8c
to
fe96ff5
Compare
PR #23589: Size comparison from 6221fe1 to fe96ff5 Increases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Nothing was marking the attributes dirty when the data backing them changed. * Remove the dependency of af-types.h from reporting.h, so reporting.h can be part of the SDK library, not the app. * Move reporting.h to the same library as the other reporting files. * Fix the one example app that was using the EmberAfAttributeType bits in reporting.h. * Fix color control server depending on reporting.h to get af-types.h. * Add convenience MakeNullable methods, like we have for Optional. * Make sure we call MatterReportingAttributeChangeCallback as needed in CommissioningWindowManager. * Add a unit test that fails without these changes. * Fix the existing TestCommissioningWindow unit test to not hardcode fabric indices, since that's not needed anymore.
bzbarsky-apple
force-pushed
the
fix-reporting-admin-commissioning
branch
from
November 18, 2022 03:22
fe96ff5
to
9134cc9
Compare
PR #23589: Size comparison from 6978de7 to 9134cc9 Increases (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…ip#23589) * Fix reporting for Administrator Commissioning attributes. Nothing was marking the attributes dirty when the data backing them changed. * Remove the dependency of af-types.h from reporting.h, so reporting.h can be part of the SDK library, not the app. * Move reporting.h to the same library as the other reporting files. * Fix the one example app that was using the EmberAfAttributeType bits in reporting.h. * Fix color control server depending on reporting.h to get af-types.h. * Add convenience MakeNullable methods, like we have for Optional. * Make sure we call MatterReportingAttributeChangeCallback as needed in CommissioningWindowManager. * Add a unit test that fails without these changes. * Fix the existing TestCommissioningWindow unit test to not hardcode fabric indices, since that's not needed anymore. * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing was marking the attributes dirty when the data backing them changed.