-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/ble_defines_mem_monitoring #23531
Merged
jmartinez-silabs
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/ble_defines_mem_monitoring
Nov 18, 2022
Merged
bugfix/ble_defines_mem_monitoring #23531
jmartinez-silabs
merged 6 commits into
project-chip:master
from
lpbeliveau-silabs:bugfix/ble_defines_mem_monitoring
Nov 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt,
mspang and
rgoliver
November 7, 2022 17:17
auto-merge was automatically disabled
November 8, 2022 18:38
Head branch was pushed to by a user without write access
lpbeliveau-silabs
force-pushed
the
bugfix/ble_defines_mem_monitoring
branch
from
November 8, 2022 18:38
675b8e6
to
d9a3c1b
Compare
lpbeliveau-silabs
force-pushed
the
bugfix/ble_defines_mem_monitoring
branch
2 times, most recently
from
November 9, 2022 19:36
617c8ac
to
bebfbe6
Compare
PR #23531: Size comparison from 64abaf1 to b657422 Increases (10 builds for bl602, cc13x2_26x2, esp32, k32w, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/ble_defines_mem_monitoring
branch
from
November 10, 2022 14:40
b657422
to
cf61c7e
Compare
andy31415
reviewed
Nov 10, 2022
PR #23531: Size comparison from 008df4d to e1d104f Increases (2 builds for esp32, telink)
Decreases (8 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lpbeliveau-silabs
force-pushed
the
bugfix/ble_defines_mem_monitoring
branch
2 times, most recently
from
November 11, 2022 16:42
edf6393
to
f0774b3
Compare
…oring and to have significative names when using heap monitoring
lpbeliveau-silabs
force-pushed
the
bugfix/ble_defines_mem_monitoring
branch
from
November 14, 2022 14:20
f0774b3
to
69904db
Compare
PR #23531: Size comparison from c89c388 to 2909fbd Increases (1 build for telink)
Decreases (2 builds for bl702, telink)
Full report (14 builds for bl702, k32w, linux, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 15, 2022
PR #23531: Size comparison from 6519b91 to 61391b4 Increases (8 builds for bl602, bl702, psoc6, telink)
Decreases (3 builds for cyw30739, esp32, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Added defines for BLE tasks to allow heap monitoring to get their task handles * Adjustements to keep previous task names size unless using heap monitoring and to have significative names when using heap monitoring * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two defines for BLE tasks used in heap monitoring task were removed previously.
This PR adds them back so MemMonitoring the task is able to get the handle of the BLE STACK and LINK tasks.