Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply API review fixes for MTRReadParams and MTRSubscribeParams. #23491

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Apply API review fixes for MTRReadParams and MTRSubscribeParams. #23491

merged 1 commit into from
Nov 4, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This is a re-landing of PR #22592 but modified to preserve the old APIs.

  • Move minInterval and maxInterval into MTRSubscribeParams.

  • Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to the default) instead of "NSNumber with nil meaning default".

The header changes not accompanied by backwards-compat shims are OK for the following reasons:

  • In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs.
  • The changes to MTRDeviceController+XPC.h are source+binary compatible.
  • MTRDeviceOverXPC.h is not a public header.
  • In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.

@bzbarsky-apple
Apply API review fixes for MTRReadParams and MTRSubscribeParams.
c97f6bb 
This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs.

* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs.
* The changes to MTRDeviceController+XPC.h are source+binary compatible.
* MTRDeviceOverXPC.h is not a public header.
* In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

PR #23491: Size comparison from d066463 to c97f6bb

Increases (3 builds for cc13x2_26x2, cyw30739)
platform target config section d066463 c97f6bb change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174156 174164 8 0.0
pump-app LP_CC2652R7 (read only) 688591 688599 8 0.0
.text 597548 597556 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544394 544402 8 0.0
.app_xip_area 426076 426084 8 0.0
Decreases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
platform target config section d066463 c97f6bb change % change
bl602 lighting-app bl602 .text 1068760 1068758 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 42004560 42004558 -2 -0.0
.text 1030782 1030778 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677387 677379 -8 -0.0
.text 587528 587520 -8 -0.0
pump-app LP_CC2652R7 (read/write) 160824 160816 -8 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26762577 26762576 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22228025 22228024 -1 -0.0
lock cy8ckit_062s2_43012 .debug_info 22461403 22461401 -2 -0.0
qpg lighting-app qpg6105+debug (read/write) 1149520 1149512 -8 -0.0
.text 596620 596612 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 648608 648606 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 612578 612576 -2 -0.0
light-switch-app tlsr9518adk80d text 554108 554104 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874468 874460 -8 -0.0
text 624086 624084 -2 -0.0
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section d066463 c97f6bb change % change
bl602 lighting-app bl602 (read/write) 1388990 1388990 0 0.0
.bss 90729 90729 0 0.0
.data 9936 9936 0 0.0
.text 1068760 1068758 -2 -0.0
bl602+rpc (read/write) 1434454 1434454 0 0.0
.bss 98161 98161 0 0.0
.data 10320 10320 0 0.0
.text 1100362 1100362 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188163 1188163 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67126 67126 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1514492 1514492 0 0.0
.debug_aranges 132064 132064 0 0.0
.debug_frame 484664 484664 0 0.0
.debug_info 38087205 38087205 0 0.0
.debug_line 5271085 5271085 0 0.0
.debug_loc 3373269 3373269 0 0.0
.debug_ranges 359744 359744 0 0.0
.debug_str 3451959 3451959 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116168 116168 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565774 565774 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957074 957074 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284075 1284075 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75158 75158 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1651926 1651926 0 0.0
.debug_aranges 139568 139568 0 0.0
.debug_frame 510036 510036 0 0.0
.debug_info 42004560 42004558 -2 -0.0
.debug_line 5647232 5647232 0 0.0
.debug_loc 3566096 3566096 0 0.0
.debug_ranges 382544 382544 0 0.0
.debug_str 3848087 3848087 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129560 129560 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624947 624947 0 0.0
.symtab 189792 189792 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030782 1030778 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677387 677379 -8 -0.0
(read/write) 174156 174164 8 0.0
.bss 81236 81236 0 0.0
.data 3380 3380 0 0.0
.rodata 89547 89547 0 0.0
.text 587528 587520 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 641635 641635 0 0.0
(read/write) 158004 158004 0 0.0
.bss 80508 80508 0 0.0
.data 3380 3380 0 0.0
.rodata 78683 78683 0 0.0
.text 562632 562632 0 0.0
lock-ftd LP_CC2652R7 (read only) 676151 676151 0 0.0
(read/write) 172528 172528 0 0.0
.bss 78460 78460 0 0.0
.data 3304 3304 0 0.0
.rodata 77071 77071 0 0.0
.text 598600 598600 0 0.0
lock-mtd LP_CC2652R7 (read only) 659939 659939 0 0.0
(read/write) 184428 184428 0 0.0
.bss 74148 74148 0 0.0
.data 3304 3304 0 0.0
.rodata 102923 102923 0 0.0
.text 556536 556536 0 0.0
pump-app LP_CC2652R7 (read only) 688591 688599 8 0.0
(read/write) 160824 160816 -8 -0.0
.bss 78428 78428 0 0.0
.data 3296 3296 0 0.0
.rodata 90559 90559 0 0.0
.text 597548 597556 8 0.0
pump-controller-app LP_CC2652R7 (read only) 672899 672899 0 0.0
(read/write) 176612 176612 0 0.0
.bss 78524 78524 0 0.0
.data 3292 3292 0 0.0
.rodata 86107 86107 0 0.0
.text 586312 586312 0 0.0
shell LP_CC2652R7 (read only) 668606 668606 0 0.0
(read/write) 185256 185256 0 0.0
.bss 83556 83556 0 0.0
.data 3376 3376 0 0.0
.rodata 86294 86294 0 0.0
.text 581996 581996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588270 588270 0 0.0
.app_xip_area 464872 464872 0 0.0
.bss 65816 65816 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592318 592318 0 0.0
.app_xip_area 463624 463624 0 0.0
.bss 71104 71104 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544394 544402 8 0.0
.app_xip_area 426076 426084 8 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974252 974252 0 0.0
.bss 152260 152260 0 0.0
.data 2248 2248 0 0.0
.text 819724 819724 0 0.0
BRD4161A+rs911x (read/write) 1034792 1034792 0 0.0
.bss 186728 186728 0 0.0
.data 2092 2092 0 0.0
.text 845948 845948 0 0.0
BRD4187C (read/write) 1146656 1146656 0 0.0
.bss 138648 138648 0 0.0
.data 2596 2596 0 0.0
.text 980816 980816 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160072 1160072 0 0.0
.bss 158256 158256 0 0.0
.data 2100 2100 0 0.0
.text 999692 999692 0 0.0
window-app BRD4187C (read/write) 1139876 1139876 0 0.0
.bss 140064 140064 0 0.0
.data 2620 2620 0 0.0
.text 972596 972596 0 0.0
k32w contact k32w0+release (read/write) 661212 661212 0 0.0
.bss 77024 77024 0 0.0
.data 2104 2104 0 0.0
.text 562972 562972 0 0.0
light k32w0+release (read/write) 671256 671256 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591644 591644 0 0.0
lock k32w0+release (read/write) 632732 632732 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552340 552340 0 0.0
linux all-clusters-app debug (read only) 3088105 3088105 0 0.0
(read/write) 158352 158352 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87016 87016 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 281291 281291 0 0.0
.text 2622450 2622450 0 0.0
all-clusters-minimal-app debug (read only) 2913913 2913913 0 0.0
(read/write) 149784 149784 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 280811 280811 0 0.0
.text 2451682 2451682 0 0.0
bridge-app debug+rpc (read only) 2413737 2413737 0 0.0
(read/write) 129552 129552 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68680 68680 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 211104 211104 0 0.0
.text 2035106 2035106 0 0.0
chip-tool debug (read only) 11082657 11082657 0 0.0
(read/write) 658408 658408 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623080 623080 0 0.0
.dynamic 608 608 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 592253 592253 0 0.0
.text 8966484 8966484 0 0.0
chip-tool-ipv6only arm64 (read only) 10438300 10438300 0 0.0
(read/write) 706417 706417 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518364 518364 0 0.0
.text 8264100 8264100 0 0.0
lighting-app debug+rpc (read only) 2641089 2641089 0 0.0
(read/write) 132240 132240 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 227968 227968 0 0.0
.text 2237170 2237170 0 0.0
lock-app debug (read only) 2603209 2603209 0 0.0
(read/write) 127288 127288 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70728 70728 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 244200 244200 0 0.0
.text 2187426 2187426 0 0.0
ota-provider-app debug (read only) 2399729 2399729 0 0.0
(read/write) 120816 120816 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64648 64648 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 216776 216776 0 0.0
.text 2014434 2014434 0 0.0
ota-requestor-app debug (read only) 2564865 2564865 0 0.0
(read/write) 129128 129128 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 223856 223856 0 0.0
.text 2163394 2163394 0 0.0
shell debug (read only) 2624377 2624377 0 0.0
(read/write) 142880 142880 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77936 77936 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 239602 239602 0 0.0
.text 2225394 2225394 0 0.0
thermostat-no-ble arm64 (read only) 2394748 2394748 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2007216 2007216 0 0.0
tv-app debug (read only) 3234673 3234673 0 0.0
(read/write) 261616 261616 0 0.0
.bss 170552 170552 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80144 80144 0 0.0
.dynamic 608 608 0 0.0
.got 4976 4976 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 267640 267640 0 0.0
.text 2773954 2773954 0 0.0
tv-casting-app debug (read only) 5582745 5582745 0 0.0
(read/write) 161728 161728 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101096 101096 0 0.0
.dynamic 608 608 0 0.0
.got 4888 4888 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355481 355481 0 0.0
.text 4952162 4952162 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452224 2452224 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414868 1414868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187759 1187759 0 0.0
bss 145285 145285 0 0.0
rodata 144436 144436 0 0.0
text 816968 816968 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167123 1167123 0 0.0
bss 144512 144512 0 0.0
rodata 136224 136224 0 0.0
text 805458 805458 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746036 1746036 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235810 1235810 0 0.0
.debug_aranges 110736 110736 0 0.0
.debug_frame 371344 371344 0 0.0
.debug_info 2702594 2702594 0 0.0
.debug_line 3685828 3685828 0 0.0
.debug_loc 3603682 3603682 0 0.0
.debug_ranges 339560 339560 0 0.0
.debug_str 3435682 3435682 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570280 570280 0 0.0
.symtab 421424 421424 0 0.0
.text 1546272 1546272 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1688644 1688644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227653 1227653 0 0.0
.debug_aranges 110208 110208 0 0.0
.debug_frame 374424 374424 0 0.0
.debug_info 26762577 26762576 -1 -0.0
.debug_line 3706812 3706812 0 0.0
.debug_loc 3591319 3591319 0 0.0
.debug_ranges 338176 338176 0 0.0
.debug_str 3424711 3424711 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534369 534369 0 0.0
.symtab 407856 407856 0 0.0
.text 1489616 1489616 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1606972 1606972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062114 1062114 0 0.0
.debug_aranges 102408 102408 0 0.0
.debug_frame 344740 344740 0 0.0
.debug_info 22228025 22228024 -1 -0.0
.debug_line 3276154 3276154 0 0.0
.debug_loc 3289030 3289030 0 0.0
.debug_ranges 303472 303472 0 0.0
.debug_str 3230138 3230138 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470694 470694 0 0.0
.symtab 376240 376240 0 0.0
.text 1416128 1416128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640764 1640764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064089 1064089 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346612 346612 0 0.0
.debug_info 22461403 22461401 -2 -0.0
.debug_line 3273048 3273048 0 0.0
.debug_loc 3316624 3316624 0 0.0
.debug_ranges 305416 305416 0 0.0
.debug_str 3249609 3249609 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473097 473097 0 0.0
.symtab 377920 377920 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149520 1149512 -8 -0.0
.bss 110596 110596 0 0.0
.data 848 848 0 0.0
.text 596620 596612 -8 -0.0
lock-app qpg6105+debug (read/write) 1114312 1114312 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 561408 561408 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 936772 936772 0 0.0
bss 81616 81616 0 0.0
noinit 43440 43440 0 0.0
text 648608 648606 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 874748 874748 0 0.0
bss 80840 80840 0 0.0
noinit 43440 43440 0 0.0
text 612578 612576 -2 -0.0
light-switch-app tlsr9518adk80d (read/write) 790244 790244 0 0.0
bss 72464 72464 0 0.0
noinit 43520 43520 0 0.0
text 554108 554104 -4 -0.0
lighting-app tlsr9518adk80d (read/write) 874468 874460 -8 -0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624086 624084 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 804736 804736 0 0.0
bss 74036 74036 0 0.0
noinit 43520 43520 0 0.0
text 565484 565484 0 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 4, 2022
Closed
@bzbarsky-apple bzbarsky-apple linked an issue Nov 4, 2022 that may be closed by this pull request
Figure out what to do with MTRCluster.h API changes #23124
Closed
@bzbarsky-apple bzbarsky-apple merged commit c530f63 into project-chip:master Nov 4, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-reland-PR-22592 branch November 4, 2022 21:04
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Apply API review fixes for MTRReadParams and MTRSubscribeParams. (pro…
5284405 
…ject-chip#23491)

This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs.

* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs.
* The changes to MTRDeviceController+XPC.h are source+binary compatible.
* MTRDeviceOverXPC.h is not a public header.
* In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Apply API review fixes for MTRReadParams and MTRSubscribeParams. (pro…
7c7da74 
…ject-chip#23491)

This is a re-landing of PR project-chip#22592 but modified to preserve the old APIs.

* Move minInterval and maxInterval into MTRSubscribeParams.

* Make the booleans in MTRSubsribeParams and MTRReadParams just BOOL (inited to
  the default) instead of "NSNumber with nil meaning default".

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* In MTRBaseDevice, the changes are to MTR_NEWLY_AVAILABLE APIs.
* The changes to MTRDeviceController+XPC.h are source+binary compatible.
* MTRDeviceOverXPC.h is not a public header.
* In MTRBaseClusters.h, the changes are to MTR_NEWLY_AVAILABLE APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out what to do with MTRCluster.h API changes
3 participants
@bzbarsky-apple @andy31415 @jtung-apple