-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Simulated Test] Simulated node does not have a chance to send the in… #23224
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:SimulatedTest_AsyncSuccess
Oct 18, 2022
Merged
[Simulated Test] Simulated node does not have a chance to send the in… #23224
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:SimulatedTest_AsyncSuccess
Oct 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi and
electrocucaracha
October 17, 2022 10:05
pullapprove
bot
requested review from
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
October 17, 2022 10:05
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
October 17, 2022 10:05
PR #23224: Size comparison from 9f08fc1 to b505cd4 Increases (3 builds for bl602, esp32, telink)
Decreases (5 builds for bl602, bl702, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Oct 17, 2022
bzbarsky-apple
approved these changes
Oct 17, 2022
…teraction response for the last step on success
vivien-apple
force-pushed
the
SimulatedTest_AsyncSuccess
branch
from
October 18, 2022 07:39
b505cd4
to
df02fa2
Compare
PR #23224: Size comparison from 0a08651 to df02fa2 Increases (3 builds for cc13x2_26x2, qpg, telink)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Oct 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…teraction response for the last step on success (project-chip#23224)
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…teraction response for the last step on success (project-chip#23224)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…teraction response for the last step on success
Problem
Fix #23104
The last step of the test are not really skipped, but the runner does not have a chance to send the interaction response.
This PR does an async exit so the interaction response can be sent properly.