-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use docker image 0.6.03 and change BLE notification to indication #23031
Conversation
pankore
commented
Oct 5, 2022
•
edited
Loading
edited
- use docker image 0.6.03
- switch from ble notification to indication in ameba BLEManager
PR #23031: Size comparison from 36d08bb to 217e615 Increases (1 build for bl602)
Full report (4 builds for bl602, bl702)
|
Hi @andy31415 , please kindly help to update the dockerhub container. |
PR #23031: Size comparison from a7475d3 to 7850e20 Increases (7 builds for bl702, cc13x2_26x2, esp32, psoc6)
Decreases (8 builds for bl602, cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23031: Size comparison from a7475d3 to c4db337 Decreases (12 builds for cyw30739, efr32, esp32, mbed, nrfconnect, psoc6)
Full report (17 builds for cyw30739, efr32, esp32, mbed, nrfconnect, psoc6)
|
@andy31415 Thanks for the review. May I also request this change to be included in the v1.0-branch? |
You can create a PR for that. however for 1.0, I believe you should only update the image for your own plaform and not for all platforms. |
…oject-chip#23031) * use docker image 0.6.03 * [BLE] Change notification to indication as required by Matter specs Co-authored-by: Andrei Litvin <[email protected]>
…oject-chip#23031) * use docker image 0.6.03 * [BLE] Change notification to indication as required by Matter specs Co-authored-by: Andrei Litvin <[email protected]>