Stop spitting out binary TXT records as text. #22172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk and
saurabhst
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
andy31415
approved these changes
Aug 25, 2022
woody-apple
approved these changes
Aug 25, 2022
|
PR #22172: Size comparison from 40d5dab to 4b75d38 Increases (2 builds for cc13x2_26x2, esp32)
Decreases (2 builds for bl602, cc13x2_26x2)
Full report (23 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, linux, mbed, telink)
|
jmartinez-silabs
approved these changes
Aug 26, 2022
Instead, actually look at record lengths, remove the lengths in favor
of comma-separating the records, replace various things that are not
printable with hex escape sequences.
The new output ends up looking something like:
TXT:"SII=5000,SAI=2000,T=1"
Fixes project-chip#21867
bzbarsky-apple
force-pushed
the
better-TXT-logging
branch
from
4b75d38 to
96b0eb1
Compare
|
PR #22172: Size comparison from 3d7cc78 to 96b0eb1 Increases (8 builds for cc13x2_26x2, cyw30739, efr32, esp32, nrfconnect)
Decreases (8 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Instead, actually look at record lengths, remove the lengths in favor
of comma-separating the records, replace various things that are not
printable with hex escape sequences.
The new output ends up looking something like:
TXT:"SII=5000,SAI=2000,T=1"
Fixes project-chip#21867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, actually look at record lengths, remove the lengths in favor
of comma-separating the records, replace various things that are not
printable with hex escape sequences.
The new output ends up looking something like:
Fixes #21867
Problem
Spitting out things with non-printable chars as text, leading to weird behavior depending the values of those bytes.
Change overview
Don't do that.
Testing
Tested chip-tool commissioning to see how it behaves with the new setup.