-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS #22
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
requested review from
anush-apple,
chrisdecenzo,
gerickson,
hawk248 and
robszewczyk
as code owners
March 10, 2020 18:30
@robszewczyk Do you understand why @BroderickCarlin & @tpmanley aren't showing up as owners? |
No, but they are not showing up on the new pull requests either. |
Does @BroderickCarlin have push access? |
That did it, thank you!!! |
doublemis1
referenced
this pull request
in doublemis1/connectedhomeip
Jul 7, 2021
Add the test_client sample program
andy31415
pushed a commit
that referenced
this pull request
Jul 9, 2022
It's not safe to access line editing state from the IO thread while inside readline() on the main thread. Remove the code that attempts to redraw readline after printing logs. This avoids segfaults during logging at the cost of those logs overwriting the prompt (this is not trivial to fix as readline is a blocking API). ================== WARNING: ThreadSanitizer: data race (pid=63005) Write of size 1 at 0x55f81c7745ff by main thread: #0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911) #1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594) #2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478) #3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #6 main <null> (chip-tool+0x569c0a) Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185): #0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479) #1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc) #2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a) #3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746) #4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec) #5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4) #6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a) #7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73) #8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d) #9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a) #10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10) #11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91) #12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b) #13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426) #14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa) #15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728) #16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b) #17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0) #18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89) #19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563) #20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227) #21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff) Mutex M185 (0x55f81c776180) created at: #0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90) #2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5) #3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147) #4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Thread T5 (tid=63013, running) created by main thread at: #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a) #2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2) #3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417) #4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353) #5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #8 main <null> (chip-tool+0x569c0a) SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*) ==================
github-actions bot
pushed a commit
that referenced
this pull request
Jul 9, 2022
It's not safe to access line editing state from the IO thread while inside readline() on the main thread. Remove the code that attempts to redraw readline after printing logs. This avoids segfaults during logging at the cost of those logs overwriting the prompt (this is not trivial to fix as readline is a blocking API). ================== WARNING: ThreadSanitizer: data race (pid=63005) Write of size 1 at 0x55f81c7745ff by main thread: #0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911) #1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594) #2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478) #3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #6 main <null> (chip-tool+0x569c0a) Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185): #0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479) #1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc) #2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a) #3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746) #4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec) #5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4) #6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a) #7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73) #8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d) #9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a) #10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10) #11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91) #12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b) #13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426) #14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa) #15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728) #16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b) #17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0) #18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89) #19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563) #20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227) #21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff) Mutex M185 (0x55f81c776180) created at: #0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90) #2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5) #3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147) #4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Thread T5 (tid=63013, running) created by main thread at: #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a) #2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2) #3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417) #4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353) #5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #8 main <null> (chip-tool+0x569c0a) SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*) ==================
woody-apple
added a commit
that referenced
this pull request
Jul 9, 2022
It's not safe to access line editing state from the IO thread while inside readline() on the main thread. Remove the code that attempts to redraw readline after printing logs. This avoids segfaults during logging at the cost of those logs overwriting the prompt (this is not trivial to fix as readline is a blocking API). ================== WARNING: ThreadSanitizer: data race (pid=63005) Write of size 1 at 0x55f81c7745ff by main thread: #0 InteractiveStartCommand::ParseCommand(char*) ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 (chip-tool+0x874911) #1 InteractiveStartCommand::RunCommand() ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:85 (chip-tool+0x874594) #2 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:408 (chip-tool+0x83e478) #3 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #4 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #5 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #6 main <null> (chip-tool+0x569c0a) Previous read of size 1 at 0x55f81c7745ff by thread T5 (mutexes: write M185): #0 LoggingCallback ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:46 (chip-tool+0x874479) #1 chip::Logging::LogV(unsigned char, unsigned char, char const*, __va_list_tag*) ../../src/lib/support/logging/CHIPLogging.cpp:221 (chip-tool+0x8ee4dc) #2 chip::Logging::Log(unsigned char, unsigned char, char const*, ...) ../../src/lib/support/logging/CHIPLogging.cpp:172 (chip-tool+0x8ee30a) #3 chip::app::ReadClient::RefreshLivenessCheckTimer() <null> (chip-tool+0x8b1746) #4 chip::app::ReadClient::ProcessSubscribeResponse(chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:845 (chip-tool+0x8b20ec) #5 chip::app::ReadClient::OnMessageReceived(chip::Messaging::ExchangeContext*, chip::PayloadHeader const&, chip::System::PacketBufferHandle&&) ../../src/app/ReadClient.cpp:409 (chip-tool+0x8ae2a4) #6 chip::Messaging::ExchangeContext::HandleMessage(unsigned int, chip::PayloadHeader const&, chip::BitFlags<chip::Messaging::MessageFlagValues, unsigned int>, chip::System::PacketBufferHandle&&) <null> (chip-tool+0xa0517a) #7 operator()<chip::Messaging::ExchangeContext> ../../src/messaging/ExchangeMgr.cpp:219 (chip-tool+0xa08c73) #8 Call ../../src/lib/support/Pool.h:126 (chip-tool+0xa0912d) #9 chip::internal::HeapObjectList::ForEachNode(void*, chip::Loop (*)(void*, void*)) ../../src/lib/support/Pool.cpp:127 (chip-tool+0x8ee05a) #10 ForEachActiveObject<chip::Messaging::ExchangeManager::OnMessageReceived(const chip::PacketHeader&, const chip::PayloadHeader&, const chip::SessionHandle&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&)::<lambda(auto:2*)> > ../../src/lib/support/Pool.h:396 (chip-tool+0xa08d10) #11 chip::Messaging::ExchangeManager::OnMessageReceived(chip::PacketHeader const&, chip::PayloadHeader const&, chip::SessionHandle const&, chip::SessionMessageDelegate::DuplicateMessage, chip::System::PacketBufferHandle&&) ../../src/messaging/ExchangeMgr.cpp:212 (chip-tool+0xa07e91) #12 chip::SessionManager::SecureUnicastMessageDispatch(chip::PacketHeader const&, chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:616 (chip-tool+0xa1548b) #13 chip::SessionManager::OnMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/SessionManager.cpp:443 (chip-tool+0xa14426) #14 chip::TransportMgrBase::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/TransportMgrBase.cpp:76 (chip-tool+0xa17dfa) #15 chip::Transport::Base::HandleMessageReceived(chip::Transport::PeerAddress const&, chip::System::PacketBufferHandle&&) ../../src/transport/raw/Base.h:102 (chip-tool+0xb19728) #16 chip::Transport::UDP::OnUdpReceive(chip::Inet::UDPEndPoint*, chip::System::PacketBufferHandle&&, chip::Inet::IPPacketInfo const*) ../../src/transport/raw/UDP.cpp:122 (chip-tool+0xb1a48b) #17 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>) ../../src/inet/UDPEndPointImplSockets.cpp:688 (chip-tool+0xb00aa0) #18 chip::Inet::UDPEndPointImplSockets::HandlePendingIO(chip::BitFlags<chip::System::SocketEventFlags, unsigned char>, long) ../../src/inet/UDPEndPointImplSockets.cpp:569 (chip-tool+0xafff89) #19 chip::System::LayerImplSelect::HandleEvents() ../../src/system/SystemLayerImplSelect.cpp:406 (chip-tool+0xb07563) #20 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:181 (chip-tool+0x98a227) #21 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #22 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Location is global '(anonymous namespace)::gIsCommandRunning' of size 1 at 0x55f81c7745ff (chip-tool+0x000000c485ff) Mutex M185 (0x55f81c776180) created at: #0 pthread_mutex_lock ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:4240 (libtsan.so.0+0x4f30a) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_LockChipStack() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:78 (chip-tool+0x989e90) #2 chip::DeviceLayer::PlatformManager::LockChipStack() ../../src/include/platform/PlatformManager.h:410 (chip-tool+0x988fa5) #3 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_RunEventLoop() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:170 (chip-tool+0x98a147) #4 chip::DeviceLayer::PlatformManager::RunEventLoop() ../../src/include/platform/PlatformManager.h:362 (chip-tool+0x988f75) #5 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::EventLoopTaskMain(void*) ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:205 (chip-tool+0x98a87c) Thread T5 (tid=63013, running) created by main thread at: #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x5ad75) #1 chip::DeviceLayer::Internal::GenericPlatformManagerImpl_POSIX<chip::DeviceLayer::PlatformManagerImpl>::_StartEventLoopTask() ../../src/include/platform/internal/GenericPlatformManagerImpl_POSIX.ipp:231 (chip-tool+0x98a40a) #2 chip::DeviceLayer::PlatformManager::StartEventLoopTask() ../../src/include/platform/PlatformManager.h:375 (chip-tool+0xaacca2) #3 chip::Controller::DeviceControllerFactory::ServiceEvents() ../../src/controller/CHIPDeviceControllerFactory.cpp:331 (chip-tool+0xab0417) #4 CHIPCommand::StartWaiting(std::chrono::duration<unsigned int, std::ratio<1l, 1000l> >) ../../examples/chip-tool/commands/common/CHIPCommand.cpp:403 (chip-tool+0x83e353) #5 CHIPCommand::Run() ../../examples/chip-tool/commands/common/CHIPCommand.cpp:187 (chip-tool+0x83c839) #6 Commands::RunCommand(int, char**, bool) ../../examples/chip-tool/commands/common/Commands.cpp:147 (chip-tool+0x85d4f7) #7 Commands::Run(int, char**) ../../examples/chip-tool/commands/common/Commands.cpp:51 (chip-tool+0x85c288) #8 main <null> (chip-tool+0x569c0a) SUMMARY: ThreadSanitizer: data race ../../examples/chip-tool/commands/interactive/InteractiveCommands.cpp:127 in InteractiveStartCommand::ParseCommand(char*) ================== Co-authored-by: Michael Spang <[email protected]>
lpbeliveau-silabs
pushed a commit
to lpbeliveau-silabs/connectedhomeip
that referenced
this pull request
Sep 12, 2022
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
nipatel-silabs
pushed a commit
to nipatel-silabs/connectedhomeip
that referenced
this pull request
Oct 19, 2022
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
jculbert
pushed a commit
to jculbert/connectedhomeip
that referenced
this pull request
Jan 10, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
Thirsrin
pushed a commit
to Thirsrin/connectedhomeip
that referenced
this pull request
Jul 12, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Oct 5, 2023
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Jan 11, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
suveshpratapa
pushed a commit
to suveshpratapa/connectedhomeip
that referenced
this pull request
May 22, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
mykrupp
pushed a commit
to mykrupp/connectedhomeip
that referenced
this pull request
Jul 18, 2024
Merge in WMN_TOOLS/matter from minor_bugfix_BT to silabs Squashed commit of the following: commit 5f721726e1b9d5be71b8330009dbdfb2dc5b6fc2 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:55:35 2022 -0400 🔨 If value is greater than max level, set to max level. commit cb8a4a27a7a5573413cf1b0ffe71024b58bc6a60 Author: Elfelsoufi-SiLabs <[email protected]> Date: Fri Aug 5 16:52:40 2022 -0400 🐛 Return if wrong level value is received. commit c639c6b6f205763c4b97e5abf557ac3c86295f6c Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 19:40:13 2022 -0400 🎨 Remove color enum. Use color struct. commit 1bd420a2d8786a9386bd70be1d22ec5d1fb776b4 Author: Elfelsoufi-SiLabs <[email protected]> Date: Thu Aug 4 14:37:38 2022 -0400 ⛳ Remove all endpoints from the code. commit f45cf02c47e4508802fe0dcb6e764debe8a9e404 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 19:01:32 2022 -0400 ✨ Remove useless callback. commit da69394d72f7febe170278fb5bbba652f8d2655b Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 18:48:15 2022 -0400 📬 Post Light Control event using PostEvent. Remove LightControl Callback. commit 5b58d6ba1ddd6ce318e89dbf89669bc3181bc942 Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Aug 3 14:43:48 2022 -0400 🎨 Use current level as the parameter value in the HSV to RGB conversion. commit 11e02cdd7b1312f8737817974989502d08d53c4e Author: Elfelsoufi-SiLabs <[email protected]> Date: Tue Aug 2 19:49:27 2022 -0400 ✨ Code improvements. commit 40e9fa1c8d37a18dfd5218307582c0d215e01021 Author: Elfelsoufi-SiLabs <[email protected]> Date: Mon Jul 25 12:22:31 2022 -0400 🎬 Change currentLevel attribute to 254 in ZAP generated files for New-Light. commit 94fe176c33826d3b4dc7aac1faf2db9ca32228df Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:20:07 2022 -0400 🎨 Scale color with current level. commit 2c7958ec31fe61e4a15d83c94159b38ad599a0d9 Author: Elfelsoufi-SiLabs <[email protected]> Date: Sun Jul 24 19:18:59 2022 -0400 🐛 Fix Hardfault in LightingManager.cpp. commit 057fd61fdb35b98bd23936cdff4d833c99d04d7d Author: Elfelsoufi-SiLabs <[email protected]> Date: Wed Jul 20 14:29:51 2022 -0400 🐛 Bugfix for Light Level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing, please ignore