-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFR: Fix efr lock rpc build #21772
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
rgoliver:fix-efr-rpc-flash
Aug 10, 2022
Merged
EFR: Fix efr lock rpc build #21772
tcarmelveilleux
merged 1 commit into
project-chip:master
from
rgoliver:fix-efr-rpc-flash
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Aug 9, 2022
Build was running out of flash, disable show_qr_code.
rgoliver
force-pushed
the
fix-efr-rpc-flash
branch
from
August 9, 2022 22:29
8b8911e
to
1880ec4
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
August 9, 2022 22:30
pullapprove
bot
requested review from
mspang,
saurabhst,
tcarmelveilleux,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 9, 2022 22:30
tcarmelveilleux
approved these changes
Aug 10, 2022
PR #21772: Size comparison from a6cdfbb to 1880ec4 Increases (1 build for cyw30739)
Decreases (4 builds for bl602, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Build was running out of flash, disable show_qr_code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
efr32-brd4161a-lock-rpc build is failing to build from insufficient flash.
Change overview
Disable
show_qr_code
on the RPC variant, as it's not needed.Testing
Compiled the example.