Fix compilation of transport/SessionHandle.h #21765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
I'm not super happy about this, but being able to compile the code is important and our internal build system rejects this code unless certain strictures are relaxed. The order dependence is extremely subtle prior to this change, but it's there, and this change makes it clearer. |
woody-apple
approved these changes
Aug 9, 2022
arkq
approved these changes
Aug 9, 2022
|
PR #21765: Size comparison from 93d72d2 to 68c6155 Decreases (1 build for bl602)
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
force-pushed
the
for-chip/session-compile
branch
from
68c6155 to
1a32336
Compare
mrjerryjohns
approved these changes
Aug 9, 2022
|
PR #21765: Size comparison from bf89608 to 1a32336 Increases (2 builds for cc13x2_26x2, telink)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (36 builds for bl602, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
Currently SessionHandle, SessionHolder, and Session must be defined in order. Any other order will not compile. Merge these headers in order to satisfy the following objectives: 1) All headers compile in isolation 2) Header order inclusion does not matter This is the simplest way to fix the problem, and seems to be the only way to fix it without changing the class definitions.
woody-apple
force-pushed
the
for-chip/session-compile
branch
from
1a32336 to
f445562
Compare
|
PR #21765: Size comparison from 3860268 to f445562 Increases (5 builds for bl602, efr32, telink)
Decreases (1 build for esp32)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Currently SessionHandle, SessionHolder, and Session must be defined in order. Any other order will not compile. Merge these headers in order to satisfy the following objectives: 1) All headers compile in isolation 2) Header order inclusion does not matter This is the simplest way to fix the problem, and seems to be the only way to fix it without changing the class definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently SessionHandle, SessionHolder, and Session must be defined
in order. Any other order will not compile.
Change overview
Merge these headers in order to satisfy the following objectives:
This is the simplest way to fix the problem, and seems to be the only
way to fix it without changing the class definitions.
Testing
Compile.