-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify bridge app to conform to the latest Matter specification #21738
Merged
woody-apple
merged 1 commit into
project-chip:master
from
nivi-apple:bridge_app_conform_to_Spec
Aug 10, 2022
Merged
Modify bridge app to conform to the latest Matter specification #21738
woody-apple
merged 1 commit into
project-chip:master
from
nivi-apple:bridge_app_conform_to_Spec
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver and
robszewczyk
August 8, 2022 21:17
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 8, 2022 21:17
nivi-apple
force-pushed
the
bridge_app_conform_to_Spec
branch
2 times, most recently
from
August 8, 2022 21:28
7996efa
to
c6473e5
Compare
PR #21738: Size comparison from 4b366e2 to c6473e5 Increases (2 builds for bl602, cc13x2_26x2)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Aug 8, 2022
- Add the aggregate node device type at endpoint 1 and add all the bridged nodes as endpoint 1 as the parent.
woody-apple
force-pushed
the
bridge_app_conform_to_Spec
branch
from
August 10, 2022 05:46
c6473e5
to
dd9a128
Compare
PR #21738: Size comparison from 397d642 to dd9a128 Increases (1 build for cc13x2_26x2)
Decreases (3 builds for bl602, cc13x2_26x2, telink)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
dhrishi
approved these changes
Aug 10, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ect-chip#21738) - Add the aggregate node device type at endpoint 1 and add all the bridged nodes as endpoint 1 as the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endpoint 1 as the parent.
Problem
What is being fixed? Examples:
Change overview
Modify the esp32 bridge app to add an aggregate node on endpoint 1 instead of endpoint 0. Also we add the bridged nodes as children of the aggregate node at endpoint 1.
Testing
How was this tested? (at least one bullet point required)
Tested with the m5 stack