Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric scoped commands in idl generation #21053

Merged

Conversation

woody-apple
Copy link
Contributor

Problem

#21022 added fabric scope command to xml and codegen.
Would like to see this data in more human-friendly format as well as make use of it if needed in codegen based on idl (java codegen does this)

Change overview

Minimal change for if fabric scoped add "fabric" tag to the command

Testing

Visual inspection, change is trivial.
Ran ./scripts/idl/matter_idl_parser.py examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter and a few other files to test that parsing succeeds.

* Detect fabric-scoped commands and flag them in matter idl

* zap regen
@woody-apple woody-apple enabled auto-merge (squash) July 21, 2022 16:09
@github-actions
Copy link

github-actions bot commented Jul 21, 2022

PR #21053: Size comparison from da2b545 to daf743c

Increases (3 builds for cc13x2_26x2, cyw30739, telink)
platform target config section da2b545 daf743c change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 653527 653535 8 0.0
.text 551864 551872 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581738 581746 8 0.0
.app_xip_area 460272 460280 8 0.0
telink light-switch-app tlsr9518adk80d text 566764 566766 2 0.0
Decreases (2 builds for cc13x2_26x2, nrfconnect)
platform target config section da2b545 daf743c change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 183680 183672 -8 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 812280 812276 -4 -0.0
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section da2b545 daf743c change % change
bl602 lighting-app bl602 (read/write) 1380658 1380658 0 0.0
.bss 117482 117482 0 0.0
.data 4480 4480 0 0.0
.text 1050776 1050776 0 0.0
bl602+rpc (read/write) 1426090 1426090 0 0.0
.bss 124930 124930 0 0.0
.data 4600 4600 0 0.0
.text 1082460 1082460 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 668151 668151 0 0.0
(read/write) 183192 183192 0 0.0
.bss 74236 74236 0 0.0
.data 3356 3356 0 0.0
.rodata 88311 88311 0 0.0
.text 579524 579524 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 633759 633759 0 0.0
(read/write) 157804 157804 0 0.0
.bss 73532 73532 0 0.0
.data 3356 3356 0 0.0
.rodata 77551 77551 0 0.0
.text 555884 555884 0 0.0
lock-ftd LP_CC2652R7 (read only) 671251 671251 0 0.0
(read/write) 170268 170268 0 0.0
.bss 71300 71300 0 0.0
.data 3280 3280 0 0.0
.rodata 76443 76443 0 0.0
.text 594328 594328 0 0.0
lock-mtd LP_CC2652R7 (read only) 653527 653535 8 0.0
(read/write) 183680 183672 -8 -0.0
.bss 66988 66988 0 0.0
.data 3280 3280 0 0.0
.rodata 101183 101183 0 0.0
.text 551864 551872 8 0.0
pump-app LP_CC2652R7 (read only) 680267 680267 0 0.0
(read/write) 162108 162108 0 0.0
.bss 71388 71388 0 0.0
.data 3280 3280 0 0.0
.rodata 88811 88811 0 0.0
.text 590972 590972 0 0.0
pump-controller-app LP_CC2652R7 (read only) 666043 666043 0 0.0
(read/write) 176452 176452 0 0.0
.bss 71508 71508 0 0.0
.data 3276 3276 0 0.0
.rodata 84667 84667 0 0.0
.text 580896 580896 0 0.0
shell LP_CC2652R7 (read only) 660626 660626 0 0.0
(read/write) 186220 186220 0 0.0
.bss 76540 76540 0 0.0
.data 3360 3360 0 0.0
.rodata 85090 85090 0 0.0
.text 575220 575220 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 581738 581746 8 0.0
.app_xip_area 460272 460280 8 0.0
.bss 64404 64404 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587646 587646 0 0.0
.app_xip_area 461452 461452 0 0.0
.bss 69132 69132 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 585118 585118 0 0.0
.app_xip_area 464500 464500 0 0.0
.bss 63612 63612 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1086680 1086680 0 0.0
.bss 133220 133220 0 0.0
.data 2048 2048 0 0.0
.text 951392 951392 0 0.0
BRD4161A+rpc (read/write) 1141004 1141004 0 0.0
.bss 149892 149892 0 0.0
.data 2260 2260 0 0.0
.text 988828 988828 0 0.0
BRD4161A+rs911x (read/write) 972796 972796 0 0.0
.bss 161672 161672 0 0.0
.data 2048 2048 0 0.0
.text 809056 809056 0 0.0
lock-app BRD4161A+wf200 (read/write) 1127984 1127984 0 0.0
.bss 144312 144312 0 0.0
.data 2056 2056 0 0.0
.text 981596 981596 0 0.0
window-app BRD4161A (read/write) 1080156 1080156 0 0.0
.bss 134692 134692 0 0.0
.data 2076 2076 0 0.0
.text 943368 943368 0 0.0
esp32 all-clusters-app c3devkit (read only) 1022058 1022058 0 0.0
(read/write) 1486298 1486298 0 0.0
.dram0.bss 70248 70248 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 216008 216008 0 0.0
.flash.text 1022058 1022058 0 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1075791 1075791 0 0.0
(read/write) 488320 488320 0 0.0
.dram0.bss 75768 75768 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246412 246412 0 0.0
.flash.text 1070407 1070407 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 660464 660464 0 0.0
.bss 69668 69668 0 0.0
.data 1992 1992 0 0.0
.text 583004 583004 0 0.0
lock k32w061+release (read/write) 687468 687468 0 0.0
.bss 70140 70140 0 0.0
.data 2004 2004 0 0.0
.text 609524 609524 0 0.0
linux chip-tool-ipv6only arm64 (read only) 9774108 9774108 0 0.0
(read/write) 679441 679441 0 0.0
.bss 32833 32833 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 624824 624824 0 0.0
.dynamic 560 560 0 0.0
.got 13552 13552 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 457340 457340 0 0.0
.text 7732372 7732372 0 0.0
thermostat-no-ble arm64 (read only) 2341028 2341028 0 0.0
(read/write) 141297 141297 0 0.0
.bss 55265 55265 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75616 75616 0 0.0
.dynamic 560 560 0 0.0
.got 4984 4984 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 139420 139420 0 0.0
.text 1964800 1964800 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448968 2448968 0 0.0
.bss 214460 214460 0 0.0
.data 5872 5872 0 0.0
.text 1411612 1411612 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1176415 1176415 0 0.0
bss 143068 143068 0 0.0
rodata 142200 142200 0 0.0
text 812280 812276 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156479 1156479 0 0.0
bss 142304 142304 0 0.0
rodata 133744 133744 0 0.0
text 801592 801592 0 0.0
p6 all-clusters-app default (read only) 881616 881616 0 0.0
(read/write) 1686796 1686796 0 0.0
.bss 149080 149080 0 0.0
.data 2648 2648 0 0.0
.text 1526680 1526680 0 0.0
all-clusters-minimal-app default (read only) 882336 882336 0 0.0
(read/write) 1630908 1630908 0 0.0
.bss 148360 148360 0 0.0
.data 2648 2648 0 0.0
.text 1471512 1471512 0 0.0
light-app default (read only) 890640 890640 0 0.0
(read/write) 1550924 1550924 0 0.0
.bss 140264 140264 0 0.0
.data 2440 2440 0 0.0
.text 1399832 1399832 0 0.0
lock-app default (read only) 886168 886168 0 0.0
(read/write) 1588516 1588516 0 0.0
.bss 144720 144720 0 0.0
.data 2456 2456 0 0.0
.text 1432952 1432952 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 798796 798796 0 0.0
bss 70744 70744 0 0.0
noinit 40416 40416 0 0.0
text 566764 566766 2 0.0
lighting-app tlsr9518adk80d (read/write) 818844 818844 0 0.0
bss 71588 71588 0 0.0
noinit 40416 40416 0 0.0
text 583310 583310 0 0.0

@woody-apple woody-apple merged commit a8b89c5 into sve Jul 21, 2022
@woody-apple woody-apple deleted the cherry-pick-33aecf84e2dc27a5bf0f17a4f64186f83efc41b7 branch July 21, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants