-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabric scoped commands in idl generation #21053
Merged
woody-apple
merged 1 commit into
sve
from
cherry-pick-33aecf84e2dc27a5bf0f17a4f64186f83efc41b7
Jul 21, 2022
Merged
Fabric scoped commands in idl generation #21053
woody-apple
merged 1 commit into
sve
from
cherry-pick-33aecf84e2dc27a5bf0f17a4f64186f83efc41b7
Jul 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Detect fabric-scoped commands and flag them in matter idl * zap regen
PR #21053: Size comparison from da2b545 to daf743c Increases (3 builds for cc13x2_26x2, cyw30739, telink)
Decreases (2 builds for cc13x2_26x2, nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
deleted the
cherry-pick-33aecf84e2dc27a5bf0f17a4f64186f83efc41b7
branch
July 21, 2022 17:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21022 added fabric scope command to xml and codegen.
Would like to see this data in more human-friendly format as well as make use of it if needed in codegen based on idl (java codegen does this)
Change overview
Minimal change for
if fabric scoped add "fabric" tag to the command
Testing
Visual inspection, change is trivial.
Ran
./scripts/idl/matter_idl_parser.py examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter
and a few other files to test that parsing succeeds.