Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groups cluster: Check that keys are set before AddGroup. #20688

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Groups cluster: Check that keys are set before AddGroup. #20688

merged 2 commits into from
Jul 14, 2022

Conversation

rcasallas-silabs
Copy link
Contributor

@rcasallas-silabs rcasallas-silabs commented Jul 13, 2022 •
edited
Loading

Problem

  • Fixes #20401: Group keys needs to be added before groups.

Change overview

  • Added check in AddGroup to verify that keys exists for the new endpoint/group.
  • Group, and GroupKeyManagement YAML tests updated accordingly.

Testing

Group, and GroupKeyManagement tests executed successfully.

@boring-cyborg boring-cyborg bot added the app label Jul 13, 2022
@github-actions
Copy link

github-actions bot commented Jul 13, 2022 •
edited
Loading

PR #20688: Size comparison from cbabee6 to 142e6f4

Increases (37 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cbabee6 142e6f4 change % change
bl602 lighting-app bl602 (read/write) 1397634 1397746 112 0.0
.text 1058640 1058752 112 0.0
bl602+rpc (read/write) 1443066 1443178 112 0.0
.text 1090324 1090436 112 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666275 666371 96 0.0
.text 577820 577916 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632083 632171 88 0.0
.text 554380 554468 88 0.0
lock-ftd LP_CC2652R7 (read only) 669183 669279 96 0.0
.text 592424 592520 96 0.0
lock-mtd LP_CC2652R7 (read only) 618591 618687 96 0.0
.text 541944 542040 96 0.0
pump-controller-app LP_CC2652R7 (read only) 664247 664255 8 0.0
.text 579200 579208 8 0.0
shell LP_CC2652R7 (read only) 658774 658870 96 0.0
.text 573540 573636 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579718 96 0.0
.app_xip_area 458376 458472 96 0.0
lock cyw930739m2evb_01 (read/write) 585574 585670 96 0.0
.app_xip_area 459600 459696 96 0.0
efr32 lighting-app BRD4161A (read/write) 1081700 1081812 112 0.0
.text 946636 946748 112 0.0
BRD4161A+rpc (read/write) 1136012 1136124 112 0.0
.text 984056 984168 112 0.0
BRD4161A+rs911x (read/write) 948172 948284 112 0.0
.text 805336 805448 112 0.0
lock-app BRD4161A+wf200 (read/write) 1129096 1129192 96 0.0
.text 982828 982924 96 0.0
window-app BRD4161A (read/write) 1075508 1075604 96 0.0
.text 938940 939036 96 0.0
esp32 all-clusters-app c3devkit (read only) 1020152 1020248 96 0.0
.flash.text 1020152 1020248 96 0.0
m5stack (read only) 1074031 1074155 124 0.0
.flash.text 1068647 1068771 124 0.0
k32w light k32w061+release (read/write) 658832 658928 96 0.0
.text 581524 581620 96 0.0
lock k32w061+release (read/write) 685684 685780 96 0.0
.text 607900 607996 96 0.0
linux all-clusters-app debug (read only) 2961225 2961673 448 0.0
.text 2520210 2520658 448 0.0
all-clusters-minimal-app debug (read only) 2813801 2814249 448 0.0
.text 2373234 2373682 448 0.0
chip-tool debug (read only) 10347505 10353825 6320 0.1
.rodata 516533 516757 224 0.0
.text 8400580 8406676 6096 0.1
chip-tool-ipv6only arm64 (read only) 10066476 10070908 4432 0.0
.rodata 479532 479756 224 0.0
.text 8024356 8028564 4208 0.1
lighting-app debug+rpc (read only) 2551577 2552025 448 0.0
.text 2167714 2168162 448 0.0
lock-app debug (read only) 2516313 2516761 448 0.0
.text 2122210 2122658 448 0.0
shell debug (read only) 2551569 2552001 432 0.0
.text 2166514 2166946 432 0.0
thermostat-no-ble arm64 (read only) 2595668 2595972 304 0.0
.text 2190224 2190528 304 0.0
tv-casting-app debug (read only) 5563561 5563993 432 0.0
.text 4944082 4944514 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448312 2448440 128 0.0
.text 1410956 1411084 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175411 1175507 96 0.0
text 811544 811640 96 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155607 1155703 96 0.0
text 800988 801084 96 0.0
p6 all-clusters-app default (read/write) 2566392 2566504 112 0.0
.text 1524656 1524768 112 0.0
all-clusters-minimal-app default (read/write) 2511688 2511784 96 0.0
.text 1469952 1470048 96 0.0
light-app default (read/write) 2441616 2441728 112 0.0
.text 1399880 1399992 112 0.0
lock-app default (read/write) 2468768 2468864 96 0.0
.text 1427032 1427128 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797540 797644 104 0.0
text 565736 565836 100 0.0
lighting-app tlsr9518adk80d (read/write) 817372 817468 96 0.0
text 582060 582160 100 0.0
Decreases (4 builds for cc13x2_26x2)
platform target config section cbabee6 142e6f4 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 184948 184852 -96 -0.1
lock-ftd LP_CC2652R7 (read/write) 172184 172088 -96 -0.1
pump-controller-app LP_CC2652R7 (read/write) 178088 178080 -8 -0.0
shell LP_CC2652R7 (read/write) 187952 187856 -96 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section cbabee6 142e6f4 change % change
bl602 lighting-app bl602 (read/write) 1397634 1397746 112 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1058640 1058752 112 0.0
bl602+rpc (read/write) 1443066 1443178 112 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090324 1090436 112 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666275 666371 96 0.0
(read/write) 184948 184852 -96 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88139 88139 0 0.0
.text 577820 577916 96 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632083 632171 88 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77379 77379 0 0.0
.text 554380 554468 88 0.0
lock-ftd LP_CC2652R7 (read only) 669183 669279 96 0.0
(read/write) 172184 172088 -96 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76279 76279 0 0.0
.text 592424 592520 96 0.0
lock-mtd LP_CC2652R7 (read only) 618591 618687 96 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76159 76159 0 0.0
.text 541944 542040 96 0.0
pump-app LP_CC2652R7 (read only) 678423 678423 0 0.0
(read/write) 163792 163792 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88703 88703 0 0.0
.text 589236 589236 0 0.0
pump-controller-app LP_CC2652R7 (read only) 664247 664255 8 0.0
(read/write) 178088 178080 -8 -0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84567 84567 0 0.0
.text 579200 579208 8 0.0
shell LP_CC2652R7 (read only) 658774 658870 96 0.0
(read/write) 187952 187856 -96 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84918 84918 0 0.0
.text 573540 573636 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579622 579718 96 0.0
.app_xip_area 458376 458472 96 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585574 585670 96 0.0
.app_xip_area 459600 459696 96 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583018 583018 0 0.0
.app_xip_area 462620 462620 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1081700 1081812 112 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 946636 946748 112 0.0
BRD4161A+rpc (read/write) 1136012 1136124 112 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 984056 984168 112 0.0
BRD4161A+rs911x (read/write) 948172 948284 112 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805336 805448 112 0.0
lock-app BRD4161A+wf200 (read/write) 1129096 1129192 96 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982828 982924 96 0.0
window-app BRD4161A (read/write) 1075508 1075604 96 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 938940 939036 96 0.0
esp32 all-clusters-app c3devkit (read only) 1020152 1020248 96 0.0
(read/write) 1485842 1485842 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215728 215728 0 0.0
.flash.text 1020152 1020248 96 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1074031 1074155 124 0.0
(read/write) 487904 487904 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246164 246164 0 0.0
.flash.text 1068647 1068771 124 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658832 658928 96 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581524 581620 96 0.0
lock k32w061+release (read/write) 685684 685780 96 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 607900 607996 96 0.0
linux all-clusters-app debug (read only) 2961225 2961673 448 0.0
(read/write) 154752 154752 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 263805 263805 0 0.0
.text 2520210 2520658 448 0.0
all-clusters-minimal-app debug (read only) 2813801 2814249 448 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265533 265533 0 0.0
.text 2373234 2373682 448 0.0
bridge-app debug+rpc (read only) 2315849 2315849 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198208 198208 0 0.0
.text 1955906 1955906 0 0.0
chip-tool debug (read only) 10347505 10353825 6320 0.1
(read/write) 621728 621728 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 587360 587360 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 516533 516757 224 0.0
.text 8400580 8406676 6096 0.1
chip-tool-ipv6only arm64 (read only) 10066476 10070908 4432 0.0
(read/write) 686913 686913 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 622984 622984 0 0.0
.dynamic 528 528 0 0.0
.got 13736 13736 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 479532 479756 224 0.0
.text 8024356 8028564 4208 0.1
lighting-app debug+rpc (read only) 2551577 2552025 448 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213896 213896 0 0.0
.text 2167714 2168162 448 0.0
lock-app debug (read only) 2516313 2516761 448 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 228936 228936 0 0.0
.text 2122210 2122658 448 0.0
ota-provider-app debug (read only) 2322689 2322689 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203704 203704 0 0.0
.text 1956210 1956210 0 0.0
ota-requestor-app debug (read only) 2439761 2439761 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207488 207488 0 0.0
.text 2061122 2061122 0 0.0
shell debug (read only) 2551569 2552001 432 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227954 227954 0 0.0
.text 2166514 2166946 432 0.0
thermostat-no-ble arm64 (read only) 2595668 2595972 304 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165668 165668 0 0.0
.text 2190224 2190528 304 0.0
tv-app debug (read only) 3102609 3102609 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2665490 2665490 0 0.0
tv-casting-app debug (read only) 5563561 5563993 432 0.0
(read/write) 161456 161456 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102536 102536 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 342825 342825 0 0.0
.text 4944082 4944514 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448312 2448440 128 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1410956 1411084 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175411 1175507 96 0.0
bss 142900 142900 0 0.0
rodata 142076 142076 0 0.0
text 811544 811640 96 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155607 1155703 96 0.0
bss 142136 142136 0 0.0
rodata 133608 133608 0 0.0
text 800988 801084 96 0.0
p6 all-clusters-app default (read/write) 2566392 2566504 112 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1524656 1524768 112 0.0
all-clusters-minimal-app default (read/write) 2511688 2511784 96 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1469952 1470048 96 0.0
light-app default (read/write) 2441616 2441728 112 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1399880 1399992 112 0.0
lock-app default (read/write) 2468768 2468864 96 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1427032 1427128 96 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797540 797644 104 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565736 565836 100 0.0
lighting-app tlsr9518adk80d (read/write) 817372 817468 96 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 582060 582160 100 0.0

@restyled-io restyled-io bot mentioned this pull request Jul 14, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 14, 2022 •
edited
Loading

PR #20688: Size comparison from ccd41c6 to 77c3c3c

Increases (36 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ccd41c6 77c3c3c change % change
bl602 lighting-app bl602 (read/write) 1398034 1398202 168 0.0
.text 1059008 1059176 168 0.0
bl602+rpc (read/write) 1443466 1443634 168 0.0
.text 1090696 1090864 168 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666415 666527 112 0.0
.text 577932 578044 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632215 632311 96 0.0
.text 554484 554580 96 0.0
lock-ftd LP_CC2652R7 (read only) 669315 669419 104 0.0
.text 592528 592632 104 0.0
lock-mtd LP_CC2652R7 (read only) 618731 618827 96 0.0
.text 542056 542152 96 0.0
shell LP_CC2652R7 (read only) 658906 659018 112 0.0
.text 573644 573756 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579702 579806 104 0.0
.app_xip_area 458456 458560 104 0.0
lock cyw930739m2evb_01 (read/write) 585654 585766 112 0.0
.app_xip_area 459680 459792 112 0.0
efr32 lighting-app BRD4161A (read/write) 1082220 1082364 144 0.0
.text 947156 947300 144 0.0
BRD4161A+rpc (read/write) 1136532 1136692 160 0.0
.text 984576 984736 160 0.0
BRD4161A+rs911x (read/write) 948696 948840 144 0.0
.text 805860 806004 144 0.0
lock-app BRD4161A+wf200 (read/write) 1129232 1129328 96 0.0
.text 982968 983064 96 0.0
window-app BRD4161A (read/write) 1076036 1076180 144 0.0
.text 939468 939612 144 0.0
esp32 all-clusters-app c3devkit (read only) 1020256 1020366 110 0.0
.flash.text 1020256 1020366 110 0.0
m5stack (read only) 1074191 1074343 152 0.0
.flash.text 1068807 1068959 152 0.0
k32w light k32w061+release (read/write) 658944 659056 112 0.0
.text 581636 581748 112 0.0
lock k32w061+release (read/write) 685808 685920 112 0.0
.text 608024 608136 112 0.0
linux all-clusters-app debug (read only) 2961321 2961817 496 0.0
.text 2520306 2520802 496 0.0
all-clusters-minimal-app debug (read only) 2813897 2814393 496 0.0
.text 2373330 2373826 496 0.0
chip-tool debug (read only) 10369889 10376209 6320 0.1
.rodata 519061 519285 224 0.0
.text 8418180 8424276 6096 0.1
chip-tool-ipv6only arm64 (read only) 10088444 1009295 4512 0.0
.rodata 481788 482028 240 0.0
.text 8041796 8046068 4272 0.1
lighting-app debug+rpc (read only) 2551673 2552169 496 0.0
.text 2167810 2168306 496 0.0
lock-app debug (read only) 2516409 2516905 496 0.0
.text 2122306 2122802 496 0.0
shell debug (read only) 2551649 2552145 496 0.0
.text 2166594 2167090 496 0.0
thermostat-no-ble arm64 (read only) 2595780 2596196 416 0.0
.text 2190336 2190752 416 0.0
tv-casting-app debug (read only) 5566969 5567449 480 0.0
.text 4947074 4947554 480 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2448400 2448528 128 0.0
.text 1411044 1411172 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175459 1175571 112 0.0
text 811596 811700 104 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155655 1155767 112 0.0
text 801040 801140 100 0.0
p6 all-clusters-app default (read/write) 2566920 2567080 160 0.0
.text 1525184 1525344 160 0.0
all-clusters-minimal-app default (read/write) 2512216 2512376 160 0.0
.text 1470480 1470640 160 0.0
light-app default (read/write) 2442160 2442320 160 0.0
.text 1400424 1400584 160 0.0
lock-app default (read/write) 2469304 2469448 144 0.0
.text 1427568 1427712 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797596 797716 120 0.0
text 565792 565910 118 0.0
lighting-app tlsr9518adk80d (read/write) 817428 817548 120 0.0
text 582116 582234 118 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section ccd41c6 77c3c3c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 184808 184696 -112 -0.1
lock-ftd LP_CC2652R7 (read/write) 172052 171948 -104 -0.1
shell LP_CC2652R7 (read/write) 187820 187708 -112 -0.1
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ccd41c6 77c3c3c change % change
bl602 lighting-app bl602 (read/write) 1398034 1398202 168 0.0
.bss 116978 116978 0 0.0
.data 4480 4480 0 0.0
.text 1059008 1059176 168 0.0
bl602+rpc (read/write) 1443466 1443634 168 0.0
.bss 124418 124418 0 0.0
.data 4600 4600 0 0.0
.text 1090696 1090864 168 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 666415 666527 112 0.0
(read/write) 184808 184696 -112 -0.1
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88167 88167 0 0.0
.text 577932 578044 112 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 632215 632311 96 0.0
(read/write) 157684 157684 0 0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 77407 77407 0 0.0
.text 554484 554580 96 0.0
lock-ftd LP_CC2652R7 (read only) 669315 669419 104 0.0
(read/write) 172052 171948 -104 -0.1
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76307 76307 0 0.0
.text 592528 592632 104 0.0
lock-mtd LP_CC2652R7 (read only) 618731 618827 96 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76187 76187 0 0.0
.text 542056 542152 96 0.0
pump-app LP_CC2652R7 (read only) 678563 678563 0 0.0
(read/write) 163652 163652 0 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88731 88731 0 0.0
.text 589348 589348 0 0.0
pump-controller-app LP_CC2652R7 (read only) 664379 664379 0 0.0
(read/write) 177956 177956 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84595 84595 0 0.0
.text 579304 579304 0 0.0
shell LP_CC2652R7 (read only) 658906 659018 112 0.0
(read/write) 187820 187708 -112 -0.1
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84946 84946 0 0.0
.text 573644 573756 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 579702 579806 104 0.0
.app_xip_area 458456 458560 104 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 585654 585766 112 0.0
.app_xip_area 459680 459792 112 0.0
.bss 68912 68912 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583154 583154 0 0.0
.app_xip_area 462756 462756 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1082220 1082364 144 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 947156 947300 144 0.0
BRD4161A+rpc (read/write) 1136532 1136692 160 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 984576 984736 160 0.0
BRD4161A+rs911x (read/write) 948696 948840 144 0.0
.bss 140768 140768 0 0.0
.data 2048 2048 0 0.0
.text 805860 806004 144 0.0
lock-app BRD4161A+wf200 (read/write) 1129232 1129328 96 0.0
.bss 144184 144184 0 0.0
.data 2060 2060 0 0.0
.text 982968 983064 96 0.0
window-app BRD4161A (read/write) 1076036 1076180 144 0.0
.bss 134468 134468 0 0.0
.data 2076 2076 0 0.0
.text 939468 939612 144 0.0
esp32 all-clusters-app c3devkit (read only) 1020256 1020366 110 0.0
(read/write) 1485874 1485874 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14600 14600 0 0.0
.flash.rodata 215760 215760 0 0.0
.flash.text 1020256 1020366 110 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1074191 1074343 152 0.0
(read/write) 487928 487928 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 246188 246188 0 0.0
.flash.text 1068807 1068959 152 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658944 659056 112 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 581636 581748 112 0.0
lock k32w061+release (read/write) 685808 685920 112 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 608024 608136 112 0.0
linux all-clusters-app debug (read only) 2961321 2961817 496 0.0
(read/write) 154752 154752 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84968 84968 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 263805 263805 0 0.0
.text 2520306 2520802 496 0.0
all-clusters-minimal-app debug (read only) 2813897 2814393 496 0.0
(read/write) 146688 146688 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77608 77608 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 265533 265533 0 0.0
.text 2373330 2373826 496 0.0
bridge-app debug+rpc (read only) 2315945 2315945 0 0.0
(read/write) 125504 125504 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66984 66984 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198208 198208 0 0.0
.text 1956002 1956002 0 0.0
chip-tool debug (read only) 10369889 10376209 6320 0.1
(read/write) 622720 622720 0 0.0
.bss 24728 24728 0 0.0
.data 3234 3234 0 0.0
.data.rel.ro 588352 588352 0 0.0
.dynamic 608 608 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519061 519285 224 0.0
.text 8418180 8424276 6096 0.1
chip-tool-ipv6only arm64 (read only) 10088444 1009295 4512 0.0
(read/write) 687921 687921 0 0.0
.bss 42961 42961 0 0.0
.data 3304 3304 0 0.0
.data.rel.ro 623984 623984 0 0.0
.dynamic 528 528 0 0.0
.got 13744 13744 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 481788 482028 240 0.0
.text 8041796 8046068 4272 0.1
lighting-app debug+rpc (read only) 2551673 2552169 496 0.0
(read/write) 129528 129528 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72136 72136 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213896 213896 0 0.0
.text 2167810 2168306 496 0.0
lock-app debug (read only) 2516409 2516905 496 0.0
(read/write) 124512 124512 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69096 69096 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 228936 228936 0 0.0
.text 2122306 2122802 496 0.0
ota-provider-app debug (read only) 2322785 2322785 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63096 63096 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203704 203704 0 0.0
.text 1956306 1956306 0 0.0
ota-requestor-app debug (read only) 2439857 2439857 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67288 67288 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207488 207488 0 0.0
.text 2061218 2061218 0 0.0
shell debug (read only) 2551649 2552145 496 0.0
(read/write) 141104 141104 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76688 76688 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 227954 227954 0 0.0
.text 2166594 2167090 496 0.0
thermostat-no-ble arm64 (read only) 2595780 2596196 416 0.0
(read/write) 158289 158289 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83240 83240 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165668 165668 0 0.0
.text 2190336 2190752 416 0.0
tv-app debug (read only) 3102753 3102753 0 0.0
(read/write) 257704 257704 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79392 79392 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249216 249216 0 0.0
.text 2665634 2665634 0 0.0
tv-casting-app debug (read only) 5566969 5567449 480 0.0
(read/write) 161456 161456 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102536 102536 0 0.0
.dynamic 608 608 0 0.0
.got 4744 4744 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343241 343241 0 0.0
.text 4947074 4947554 480 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2448400 2448528 128 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1411044 1411172 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175459 1175571 112 0.0
bss 142900 142900 0 0.0
rodata 142060 142060 0 0.0
text 811596 811700 104 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1155655 1155767 112 0.0
bss 142136 142136 0 0.0
rodata 133608 133608 0 0.0
text 801040 801140 100 0.0
p6 all-clusters-app default (read/write) 2566920 2567080 160 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1525184 1525344 160 0.0
all-clusters-minimal-app default (read/write) 2512216 2512376 160 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1470480 1470640 160 0.0
light-app default (read/write) 2442160 2442320 160 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1400424 1400584 160 0.0
lock-app default (read/write) 2469304 2469448 144 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1427568 1427712 144 0.0
telink light-switch-app tlsr9518adk80d (read/write) 797596 797716 120 0.0
bss 70576 70576 0 0.0
noinit 40416 40416 0 0.0
text 565792 565910 118 0.0
lighting-app tlsr9518adk80d (read/write) 817428 817548 120 0.0
bss 71420 71420 0 0.0
noinit 40416 40416 0 0.0
text 582116 582234 118 0.0

@woody-apple woody-apple merged commit 5aa5e8e into project-chip:master Jul 14, 2022
github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
@rcasallas-silabs @web-flow
Groups cluster: Check that keys are set before AddGroup. (#20688)
f7c5a3e 
* Groups cluster: Check that keys are set before AddGroup.

* Groups cluster: Review comments applied.
andy31415 pushed a commit that referenced this pull request Jul 15, 2022
@woody-apple @rcasallas-silabs
Groups cluster: Check that keys are set before AddGroup. (#20688) (#2…
c749324 
…0773)

* Groups cluster: Check that keys are set before AddGroup.

* Groups cluster: Review comments applied.

Co-authored-by: Ricardo Casallas <[email protected]>
@rcasallas-silabs rcasallas-silabs deleted the groups_key_check branch October 5, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved sve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GroupIds need to be added to Group Key Management before Groups
4 participants
@rcasallas-silabs @andy31415 @woody-apple @jmartinez-silabs