-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tizen] Change advertised struct size #20573
Merged
andy31415
merged 1 commit into
sve
from
cherry-pick-19f2d7d70bc5e878d7fecf90a491d6570559aebb
Jul 12, 2022
Merged
[Tizen] Change advertised struct size #20573
andy31415
merged 1 commit into
sve
from
cherry-pick-19f2d7d70bc5e878d7fecf90a491d6570559aebb
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #20573: Size comparison from 7037068 to febdd6e Increases (2 builds for telink)
Decreases (1 build for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Tizen device wasn't recognized as a chip device via BLE. The problem was with the advertised struct size. It was a hardcoded value, while the test checks if received data has a size of ChipBLEDeviceIdentificationInfo struct.
Change overview
Use the size of the struct as data length.
Testing
Deploy and start examples/lighting-app on the Tizen device.
On PC run: