-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ESP32 timeout. #19972
Merged
Merged
Bump ESP32 timeout. #19972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are hitting this a fair amount. The actual sub-step timeouts sum to 115, but there's some slop in those, so this should be ok.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran and
hawk248
June 24, 2022 21:47
pullapprove
bot
requested review from
wbschiller,
lazarkov,
woody-apple,
LuDuda,
xylophone21,
mlepage-google,
yufengwangca,
msandstedt,
yunhanw-google,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs and
vivien-apple
June 24, 2022 21:47
PR #19972: Size comparison from e5e09f5 to 537cdcb Increases (4 builds for cc13x2_26x2, nrfconnect)
Decreases (6 builds for cc13x2_26x2, cyw30739, nrfconnect, telink)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
dhrishi
approved these changes
Jun 24, 2022
arkq
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are hitting this a fair amount. The actual sub-step timeouts sum
to 115, but there's some slop in those, so this should be ok.
Problem
Timeouts.
Change overview
Give it more time.
Testing
CI will tell.