Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement shadow fail-safe data in FabricTable #19819

Merged
merged 58 commits into from
Jun 24, 2022
Merged

Implement shadow fail-safe data in FabricTable #19819

merged 58 commits into from
Jun 24, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

  • FabricTable management during commissioning did not properly
    handle the fact that committing needs to only be done on
    CommissioningComplete, which prevented the AddTrustedRootCertificate,
    UpdateNOC and AddNOC command semantics to be implemented properly
    and prevented proper state observation of operational credential
    clusters server

Fixes #7695
Issue #8905
Fixes #18633
Issue #17208
Fixes #15585

Change overview

  • Removes direct access to FabricInfo from everywhere, which caused
    possibly stale FabricInfo references during commissioning.
  • Remove immediate committing of fabric table on UpdateNOC.
  • Make Fabrics, NOCs and TrustedRootCertificates attributes reflect
    proper partial state during fail-safe, by using the shadow data
    capabilities of OperationalCertificateStore and by updates to
    FabricInfo
  • Make it possible to unit test fabric table by providing the necessary
    lifecycle public APIs to test every modality of the commissioning flow
  • Make Server and DeviceController use OperationalCertificateStore to
    allow proper external lifecycle management of the operational cert
    chain.
  • Update all examples/controller code to new API
  • Remove dangerous internal APIs from FabricTable and replace with
    direct accessors where needed
  • Add more of the necessary spec validations to the UpdateNOC and AddNOC
    flows

Testing

  • Updated all unit tests, all pass
  • Cert tests still pass as before
  • Working on further integration tests and unit tests as a follow-up
    noting that current state has not regressed on existing test coverage,
    and that new usage of OperationalCertificateStore class in FabricTable
    gains a large amount of additional coverage transitively via some
    of the existing tests making use of FabricTable.

@tcarmelveilleux
Implement shadow fail-safe data in FabricTable
54b18f9 
- FabricTable management during commissioning did not properly
  handle the fact that committing needs to only be done on
  CommissioningComplete, which prevented the AddTrustedRootCertificate,
  UpdateNOC and AddNOC command semantics to be implemented properly
  and prevented proper state observation of operational credential
  clusters server

Fixes project-chip#7695
Issue project-chip#8905
Fixes project-chip#18633
Issue project-chip#17208
Fixes project-chip#15585

This PR:

- Removes direct access to FabricInfo from everywhere, which caused
  possibly stale FabricInfo references during commissioning.
- Remove immediate committing of fabric table on UpdateNOC.
- Make Fabrics, NOCs and TrustedRootCertificates attributes reflect
  proper partial state during fail-safe, by using the shadow data
  capabilities of OperationalCertificateStore and by updates to
  FabricInfo
- Make it possible to unit test fabric table by providing the necessary
  lifecycle public APIs to test every modality of the commissioning flow
- Make Server and DeviceController use OperationalCertificateStore to
  allow proper external lifecycle management of the operational cert
  chain.
- Update all examples/controller code to new API
- Remove dangerous internal APIs from FabricTable and replace with
  direct accessors where needed
- Add more of the necessary spec validations to the UpdateNOC and AddNOC
  flows

Testing done:
- Updated all unit tests, all pass
- Cert tests still pass as before
- Working on further integration tests and unit tests as a follow-up
  noting that current state has not regressed on existing test coverage,
  and that new usage of OperationalCertificateStore class in FabricTable
  gains a large amount of additional coverage transitively via some
  of the existing tests making use of FabricTable.
@project-chip project-chip deleted a comment from github-actions bot Jun 24, 2022
@project-chip project-chip deleted a comment from github-actions bot Jun 24, 2022
@project-chip project-chip deleted a comment from github-actions bot Jun 24, 2022
@project-chip project-chip deleted a comment from github-actions bot Jun 24, 2022
@project-chip project-chip deleted a comment from github-actions bot Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

PR #19819: Size comparison from 776c2b8 to d8864e3

Increases above 0.2%:

platform target config section 776c2b8 d8864e3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664787 4064 0.6
.bss 75572 75852 280 0.4
.rodata 87107 88027 920 1.1
.text 573304 576448 3144 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653547 3924 0.6
(read/write) 159128 198708 39580 24.9
.bss 74860 75148 288 0.4
.rodata 90719 91531 812 0.9
.text 558584 561704 3120 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667787 4080 0.6
.bss 72604 72884 280 0.4
.rodata 75227 76147 920 1.2
.text 588000 591160 3160 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
.bss 68340 68620 280 0.4
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
.bss 72700 72972 272 0.4
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663395 3892 0.6
.bss 72812 73092 280 0.4
.rodata 83719 84523 804 1.0
.text 575304 578392 3088 0.5
shell LP_CC2652R7 (read/write) 157620 191208 33588 21.3
.bss 77876 78156 280 0.4
cyw30739 light cyw930739m2evb_01 .data 712 716 4 0.6
lock cyw930739m2evb_01 .data 716 720 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 656 660 4 0.6
k32w light k32w061+release .bss 70996 71268 272 0.4
lock k32w061+release .bss 71468 71740 272 0.4
linux all-clusters-app debug (read only) 2939537 2957697 18160 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.rodata 261597 263325 1728 0.7
.text 2501378 2517474 16096 0.6
all-clusters-minimal-app debug (read only) 2793617 2811745 18128 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.rodata 263229 264925 1696 0.6
.text 2356002 2372098 16096 0.7
bridge-app debug+rpc (read only) 2297681 2316033 18352 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.rodata 196416 198112 1696 0.9
.text 1939938 1956210 16272 0.8
chip-tool debug (read only) 10167965 10192997 25032 0.2
.rodata 508645 510053 1408 0.3
.text 8251045 8274261 23216 0.3
chip-tool-no-interactive-ipv6only arm64 .rodata 471564 473348 1784 0.4
.text 7894164 7914740 20576 0.3
lighting-app debug+rpc (read only) 2534369 2552817 18448 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.rodata 212168 213832 1664 0.8
.text 2152290 2168690 16400 0.8
lock-app debug (read only) 2496553 2514897 18344 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.rodata 227016 228712 1696 0.7
.text 2104786 2121074 16288 0.8
ota-provider-app debug (read only) 2305513 2323913 18400 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.rodata 202072 203736 1664 0.8
.text 1941074 1957426 16352 0.8
ota-requestor-app debug (read only) 2422585 2441049 18464 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.rodata 205920 207648 1728 0.8
.text 2045922 2062274 16352 0.8
shell debug .data 1232 1264 32 2.6
thermostat-no-ble arm64 (read only) 2579964 2596548 16584 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.rodata 164812 166148 1336 0.8
.text 2175856 2190624 14768 0.7
tv-app debug (read only) 3083369 3104233 20864 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.rodata 247936 249536 1600 0.6
.text 2648402 2667330 18928 0.7
tv-casting-app debug (read only) 5572889 5591153 18264 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.rodata 341865 343657 1792 0.5
.text 4954626 4970738 16112 0.3
mbed lock-app CY8CPROTO_062_4343W+release .bss 214732 215732 1000 0.5
p6 all-clusters-app default (read/write) 2556232 2563504 7272 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521768 7272 0.5
all-clusters-minimal-app default (read/write) 2502096 2509352 7256 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467616 7256 0.5
light-app default (read/write) 2432840 2440104 7264 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398368 7264 0.5
lock-app default (read/write) 2459120 2466368 7248 0.3
.bss 141088 142096 1008 0.7
.text 1417384 1424632 7248 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798156 4752 0.6
bss 71932 72332 400 0.6
text 561382 564940 3558 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818468 4752 0.6
bss 72780 73180 400 0.5
text 577844 581404 3560 0.6
Increases (32 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 776c2b8 d8864e3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664787 4064 0.6
.bss 75572 75852 280 0.4
.data 3352 3356 4 0.1
.rodata 87107 88027 920 1.1
.text 573304 576448 3144 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653547 3924 0.6
(read/write) 159128 198708 39580 24.9
.bss 74860 75148 288 0.4
.data 3352 3356 4 0.1
.rodata 90719 91531 812 0.9
.text 558584 561704 3120 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667787 4080 0.6
.bss 72604 72884 280 0.4
.data 3276 3280 4 0.1
.rodata 75227 76147 920 1.2
.text 588000 591160 3160 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
(read/write) 145732 146016 284 0.2
.bss 68340 68620 280 0.4
.data 3276 3280 4 0.1
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
.bss 72700 72972 272 0.4
.data 3276 3280 4 0.1
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663395 3892 0.6
.bss 72812 73092 280 0.4
.data 3272 3276 4 0.1
.rodata 83719 84523 804 1.0
.text 575304 578392 3088 0.5
shell LP_CC2652R7 (read/write) 157620 191208 33588 21.3
.bss 77876 78156 280 0.4
.data 3356 3360 4 0.1
cyw30739 light cyw930739m2evb_01 .data 712 716 4 0.6
lock cyw930739m2evb_01 .data 716 720 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 656 660 4 0.6
k32w light k32w061+release .bss 70996 71268 272 0.4
.data 1988 1992 4 0.2
lock k32w061+release .bss 71468 71740 272 0.4
.data 2000 2004 4 0.2
linux all-clusters-app debug (read only) 2939537 2957697 18160 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 84728 84872 144 0.2
.rodata 261597 263325 1728 0.7
.text 2501378 2517474 16096 0.6
all-clusters-minimal-app debug (read only) 2793617 2811745 18128 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 77368 77512 144 0.2
.rodata 263229 264925 1696 0.6
.text 2356002 2372098 16096 0.7
bridge-app debug+rpc (read only) 2297681 2316033 18352 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.rodata 196416 198112 1696 0.9
.text 1939938 1956210 16272 0.8
chip-tool debug (read only) 10167965 10192997 25032 0.2
(read/write) 610696 610856 160 0.0
.data.rel.ro 578896 579064 168 0.0
.rodata 508645 510053 1408 0.3
.text 8251045 8274261 23216 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9904844 9927764 22920 0.2
(read/write) 675345 675697 352 0.1
.data.rel.ro 614272 614632 360 0.1
.rodata 471564 473348 1784 0.4
.text 7894164 7914740 20576 0.3
lighting-app debug+rpc (read only) 2534369 2552817 18448 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.rodata 212168 213832 1664 0.8
.text 2152290 2168690 16400 0.8
lock-app debug (read only) 2496553 2514897 18344 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.rodata 227016 228712 1696 0.7
.text 2104786 2121074 16288 0.8
ota-provider-app debug (read only) 2305513 2323913 18400 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.rodata 202072 203736 1664 0.8
.text 1941074 1957426 16352 0.8
ota-requestor-app debug (read only) 2422585 2441049 18464 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.rodata 205920 207648 1728 0.8
.text 2045922 2062274 16352 0.8
shell debug .data 1232 1264 32 2.6
thermostat-no-ble arm64 (read only) 2579964 2596548 16584 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.rodata 164812 166148 1336 0.8
.text 2175856 2190624 14768 0.7
tv-app debug (read only) 3083369 3104233 20864 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.data.rel.ro 79080 79232 152 0.2
.rodata 247936 249536 1600 0.6
.text 2648402 2667330 18928 0.7
tv-casting-app debug (read only) 5572889 5591153 18264 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.data.rel.ro 102640 102792 152 0.1
.rodata 341865 343657 1792 0.5
.text 4954626 4970738 16112 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2444432 2447552 3120 0.1
.bss 214732 215732 1000 0.5
.text 1407076 1410196 3120 0.2
p6 all-clusters-app default (read/write) 2556232 2563504 7272 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521768 7272 0.5
all-clusters-minimal-app default (read/write) 2502096 2509352 7256 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467616 7256 0.5
light-app default (read/write) 2432840 2440104 7264 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398368 7264 0.5
lock-app default (read/write) 2459120 2466368 7248 0.3
.bss 141088 142096 1008 0.7
.text 1417384 1424632 7248 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798156 4752 0.6
bss 71932 72332 400 0.6
text 561382 564940 3558 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818468 4752 0.6
bss 72780 73180 400 0.5
text 577844 581404 3560 0.6
Decreases (12 builds for cc13x2_26x2, cyw30739, k32w, linux)
platform target config section 776c2b8 d8864e3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191956 188172 -3784 -2.0
lock-ftd LP_CC2652R7 (read/write) 179116 175316 -3800 -2.1
pump-app LP_CC2652R7 (read/write) 170056 166444 -3612 -2.1
pump-controller-app LP_CC2652R7 (read/write) 184296 180684 -3612 -2.0
shell LP_CC2652R7 (read only) 690562 657254 -33308 -4.8
.rodata 109970 84782 -25188 -22.9
.text 580280 572160 -8120 -1.4
cyw30739 light cyw930739m2evb_01 (read/write) 592786 580174 -12612 -2.1
.app_xip_area 462892 457200 -5692 -1.2
.bss 72864 65936 -6928 -9.5
lock cyw930739m2evb_01 (read/write) 594394 581734 -12660 -2.1
.app_xip_area 464292 458568 -5724 -1.2
.bss 73064 66128 -6936 -9.5
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595422 583874 -11548 -1.9
.app_xip_area 466400 461748 -4652 -1.0
.bss 72048 65144 -6904 -9.6
k32w light k32w061+release (read/write) 663008 659840 -3168 -0.5
.text 584224 580780 -3444 -0.6
lock k32w061+release (read/write) 695304 686248 -9056 -1.3
.text 616036 606704 -9332 -1.5
linux chip-tool-no-interactive-ipv6only arm64 .got 13472 13456 -16 -0.1
shell debug (read only) 2613521 2547841 -65680 -2.5
(read/write) 196184 164416 -31768 -16.2
.bss 111336 80904 -30432 -27.3
.data.rel.ro 77864 76608 -1256 -1.6
.got 4168 4096 -72 -1.7
.init_array 936 912 -24 -2.6
.rodata 231666 227538 -4128 -1.8
.text 2222002 2164178 -57824 -2.6
Full report (32 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, p6, telink)
platform target config section 776c2b8 d8864e3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664787 4064 0.6
(read/write) 191956 188172 -3784 -2.0
.bss 75572 75852 280 0.4
.data 3352 3356 4 0.1
.rodata 87107 88027 920 1.1
.text 573304 576448 3144 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653547 3924 0.6
(read/write) 159128 198708 39580 24.9
.bss 74860 75148 288 0.4
.data 3352 3356 4 0.1
.rodata 90719 91531 812 0.9
.text 558584 561704 3120 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667787 4080 0.6
(read/write) 179116 175316 -3800 -2.1
.bss 72604 72884 280 0.4
.data 3276 3280 4 0.1
.rodata 75227 76147 920 1.2
.text 588000 591160 3160 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
(read/write) 145732 146016 284 0.2
.bss 68340 68620 280 0.4
.data 3276 3280 4 0.1
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
(read/write) 170056 166444 -3612 -2.1
.bss 72700 72972 272 0.4
.data 3276 3280 4 0.1
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663395 3892 0.6
(read/write) 184296 180684 -3612 -2.0
.bss 72812 73092 280 0.4
.data 3272 3276 4 0.1
.rodata 83719 84523 804 1.0
.text 575304 578392 3088 0.5
shell LP_CC2652R7 (read only) 690562 657254 -33308 -4.8
(read/write) 157620 191208 33588 21.3
.bss 77876 78156 280 0.4
.data 3356 3360 4 0.1
.rodata 109970 84782 -25188 -22.9
.text 580280 572160 -8120 -1.4
cyw30739 light cyw930739m2evb_01 (read/write) 592786 580174 -12612 -2.1
.app_xip_area 462892 457200 -5692 -1.2
.bss 72864 65936 -6928 -9.5
.data 712 716 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594394 581734 -12660 -2.1
.app_xip_area 464292 458568 -5724 -1.2
.bss 73064 66128 -6936 -9.5
.data 716 720 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595422 583874 -11548 -1.9
.app_xip_area 466400 461748 -4652 -1.0
.bss 72048 65144 -6904 -9.6
.data 656 660 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 663008 659840 -3168 -0.5
.bss 70996 71268 272 0.4
.data 1988 1992 4 0.2
.text 584224 580780 -3444 -0.6
lock k32w061+release (read/write) 695304 686248 -9056 -1.3
.bss 71468 71740 272 0.4
.data 2000 2004 4 0.2
.text 616036 606704 -9332 -1.5
linux all-clusters-app debug (read only) 2939537 2957697 18160 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 84728 84872 144 0.2
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261597 263325 1728 0.7
.text 2501378 2517474 16096 0.6
all-clusters-minimal-app debug (read only) 2793617 2811745 18128 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 77368 77512 144 0.2
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263229 264925 1696 0.6
.text 2356002 2372098 16096 0.7
bridge-app debug+rpc (read only) 2297681 2316033 18352 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196416 198112 1696 0.9
.text 1939938 1956210 16272 0.8
chip-tool debug (read only) 10167965 10192997 25032 0.2
(read/write) 610696 610856 160 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578896 579064 168 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508645 510053 1408 0.3
.text 8251045 8274261 23216 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9904844 9927764 22920 0.2
(read/write) 675345 675697 352 0.1
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614272 614632 360 0.1
.dynamic 528 528 0 0.0
.got 13472 13456 -16 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471564 473348 1784 0.4
.text 7894164 7914740 20576 0.3
lighting-app debug+rpc (read only) 2534369 2552817 18448 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212168 213832 1664 0.8
.text 2152290 2168690 16400 0.8
lock-app debug (read only) 2496553 2514897 18344 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 227016 228712 1696 0.7
.text 2104786 2121074 16288 0.8
ota-provider-app debug (read only) 2305513 2323913 18400 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202072 203736 1664 0.8
.text 1941074 1957426 16352 0.8
ota-requestor-app debug (read only) 2422585 2441049 18464 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205920 207648 1728 0.8
.text 2045922 2062274 16352 0.8
shell debug (read only) 2613521 2547841 -65680 -2.5
(read/write) 196184 164416 -31768 -16.2
.bss 111336 80904 -30432 -27.3
.data 1232 1264 32 2.6
.data.rel.ro 77864 76608 -1256 -1.6
.dynamic 608 608 0 0.0
.got 4168 4096 -72 -1.7
.init 27 27 0 0.0
.init_array 936 912 -24 -2.6
.rodata 231666 227538 -4128 -1.8
.text 2222002 2164178 -57824 -2.6
thermostat-no-ble arm64 (read only) 2579964 2596548 16584 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164812 166148 1336 0.8
.text 2175856 2190624 14768 0.7
tv-app debug (read only) 3083369 3104233 20864 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.data.rel.ro 79080 79232 152 0.2
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247936 249536 1600 0.6
.text 2648402 2667330 18928 0.7
tv-casting-app debug (read only) 5572889 5591153 18264 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.data 2416 2416 0 0.0
.data.rel.ro 102640 102792 152 0.1
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341865 343657 1792 0.5
.text 4954626 4970738 16112 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444432 2447552 3120 0.1
.bss 214732 215732 1000 0.5
.data 5872 5872 0 0.0
.text 1407076 1410196 3120 0.2
p6 all-clusters-app default (read/write) 2556232 2563504 7272 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521768 7272 0.5
all-clusters-minimal-app default (read/write) 2502096 2509352 7256 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467616 7256 0.5
light-app default (read/write) 2432840 2440104 7264 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398368 7264 0.5
lock-app default (read/write) 2459120 2466368 7248 0.3
.bss 141088 142096 1008 0.7
.data 2600 2600 0 0.0
.text 1417384 1424632 7248 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798156 4752 0.6
bss 71932 72332 400 0.6
noinit 40416 40416 0 0.0
text 561382 564940 3558 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818468 4752 0.6
bss 72780 73180 400 0.5
noinit 40416 40416 0 0.0
text 577844 581404 3560 0.6

tcarmelveilleux
tcarmelveilleux commented Jun 24, 2022
View reviewed changes
Copy link
Contributor Author

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All follow-ups are ready to go. @bzbarsky-apple asked me to make all follow-ups in a separate PR to avoid needing to-review such a large change.

@msandstedt msandstedt self-requested a review June 24, 2022 17:52
bzbarsky-apple
bzbarsky-apple approved these changes Jun 24, 2022
View reviewed changes
src/credentials/FabricTable.h Show resolved Hide resolved
src/credentials/FabricTable.h Show resolved Hide resolved
src/credentials/FabricTable.h Show resolved Hide resolved
src/credentials/FabricTable.h Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

PR #19819: Size comparison from 776c2b8 to 444cbd5

Increases above 0.2%:

platform target config section 776c2b8 444cbd5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664795 4072 0.6
.bss 75572 75852 280 0.4
.rodata 87107 88027 920 1.1
.text 573304 576456 3152 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653555 3932 0.6
(read/write) 159128 198700 39572 24.9
.bss 74860 75148 288 0.4
.rodata 90719 91531 812 0.9
.text 558584 561712 3128 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667795 4088 0.6
.bss 72604 72884 280 0.4
.rodata 75227 76147 920 1.2
.text 588000 591168 3168 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
.bss 68340 68620 280 0.4
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
.bss 72700 72972 272 0.4
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663403 3900 0.6
.bss 72812 73092 280 0.4
.rodata 83719 84523 804 1.0
.text 575304 578400 3096 0.5
shell LP_CC2652R7 (read/write) 157620 191200 33580 21.3
.bss 77876 78156 280 0.4
cyw30739 light cyw930739m2evb_01 .data 712 716 4 0.6
lock cyw930739m2evb_01 .data 716 720 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 656 660 4 0.6
efr32 lighting-app BRD4161A (read/write) 1073484 1081100 7616 0.7
.bss 134324 134716 392 0.3
.text 937096 944316 7220 0.8
BRD4161A+rpc (read/write) 1127572 1135396 7824 0.7
.bss 151012 151404 392 0.3
.text 974284 981712 7428 0.8
BRD4161A+rs911x (read/write) 937672 945236 7564 0.8
.bss 140096 140488 392 0.3
.text 795508 802680 7172 0.9
lock-app BRD4161A+wf200 (read/write) 1117780 1122080 4300 0.4
.bss 140544 140936 392 0.3
.text 975160 979060 3900 0.4
window-app BRD4161A (read/write) 1058752 1066380 7628 0.7
.bss 134396 134796 400 0.3
.text 922264 929484 7220 0.8
esp32 all-clusters-app c3devkit (read only) 1014490 1018442 3952 0.4
.dram0.bss 71432 71824 392 0.5
.flash.rodata 214272 215056 784 0.4
.flash.text 1014490 1018442 3952 0.4
m5stack (read only) 1068787 1072455 3668 0.3
.dram0.bss 76944 77344 400 0.5
.flash.rodata 244772 245520 748 0.3
.flash.text 1063403 1067071 3668 0.3
k32w light k32w061+release .bss 70996 71268 272 0.4
lock k32w061+release .bss 71468 71740 272 0.4
linux all-clusters-app debug (read only) 2939537 2957729 18192 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.rodata 261597 263325 1728 0.7
.text 2501378 2517506 16128 0.6
all-clusters-minimal-app debug (read only) 2793617 2811761 18144 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.rodata 263229 264925 1696 0.6
.text 2356002 2372114 16112 0.7
bridge-app debug+rpc (read only) 2297681 2316049 18368 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.rodata 196416 198112 1696 0.9
.text 1939938 1956226 16288 0.8
chip-tool debug (read only) 10167965 1019317 25208 0.2
.rodata 508645 510053 1408 0.3
.text 8251045 8274341 23296 0.3
chip-tool-no-interactive-ipv6only arm64 .rodata 471564 473348 1784 0.4
.text 7894164 7914756 20592 0.3
lighting-app debug+rpc (read only) 2534369 2552833 18464 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.rodata 212168 213832 1664 0.8
.text 2152290 2168706 16416 0.8
lock-app debug (read only) 2496553 2514913 18360 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.rodata 227016 228712 1696 0.7
.text 2104786 2121090 16304 0.8
ota-provider-app debug (read only) 2305513 2323945 18432 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.rodata 202072 203736 1664 0.8
.text 1941074 1957458 16384 0.8
ota-requestor-app debug (read only) 2422585 2441065 18480 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.rodata 205920 207648 1728 0.8
.text 2045922 2062290 16368 0.8
shell debug .data 1232 1264 32 2.6
thermostat-no-ble arm64 (read only) 2579964 2596564 16600 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.rodata 164812 166148 1336 0.8
.text 2175856 2190640 14784 0.7
tv-app debug (read only) 3083369 3104401 21032 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.rodata 247936 249536 1600 0.6
.text 2648402 2667394 18992 0.7
tv-casting-app debug (read only) 5572889 5591313 18424 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.rodata 341865 343657 1792 0.5
.text 4954626 4970802 16176 0.3
mbed lock-app CY8CPROTO_062_4343W+release .bss 214732 215732 1000 0.5
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170507 1174971 4464 0.4
bss 144254 144650 396 0.3
rodata 140884 141660 776 0.6
text 806560 809728 3168 0.4
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1151503 1155839 4336 0.4
bss 143490 143886 396 0.3
rodata 132816 133592 776 0.6
text 796264 799436 3172 0.4
lighting-app nrf52840dk_nrf52840 (read/write) 1163279 1167643 4364 0.4
bss 145833 146229 396 0.3
rodata 123272 124068 796 0.6
text 815296 818480 3184 0.4
nrf52840dk_nrf52840+rpc (read/write) 1133367 1137799 4432 0.4
bss 146278 146674 396 0.3
rodata 114816 115616 800 0.7
text 793024 796276 3252 0.4
nrf52840dongle_nrf52840 (read/write) 1070107 1074479 4372 0.4
bss 153064 153460 396 0.3
rodata 92332 93112 780 0.8
text 743688 746896 3208 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1066938 1071354 4416 0.4
bss 142204 142600 396 0.3
rodata 115680 116480 800 0.7
text 728020 731208 3188 0.4
lock-app nrf52840dk_nrf52840 (read/write) 1120955 1125319 4364 0.4
bss 135809 136205 396 0.3
rodata 140460 141256 796 0.6
text 765808 768992 3184 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1024818 1029182 4364 0.4
bss 132212 132608 396 0.3
rodata 132928 133724 796 0.6
text 678592 681776 3184 0.5
pump-app nrf52840dk_nrf52840 (read/write) 1076263 1080611 4348 0.4
bss 135728 136124 396 0.3
rodata 116656 117452 796 0.7
text 745008 748176 3168 0.4
pump-controller-app nrf52840dk_nrf52840 (read/write) 1064167 1068511 4344 0.4
bss 135523 135919 396 0.3
rodata 113440 114232 792 0.7
text 736388 739564 3176 0.4
p6 all-clusters-app default (read/write) 2556232 2563520 7288 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521784 7288 0.5
all-clusters-minimal-app default (read/write) 2502096 2509368 7272 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467632 7272 0.5
light-app default (read/write) 2432840 2440136 7296 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398400 7296 0.5
lock-app default (read/write) 2459120 2466400 7280 0.3
.bss 141088 142096 1008 0.7
.text 1417384 1424664 7280 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798512 5108 0.6
bss 71932 72360 428 0.6
text 561382 564972 3590 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818476 4760 0.6
bss 72780 73180 400 0.5
text 577844 581410 3566 0.6
Increases (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 776c2b8 444cbd5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664795 4072 0.6
.bss 75572 75852 280 0.4
.data 3352 3356 4 0.1
.rodata 87107 88027 920 1.1
.text 573304 576456 3152 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653555 3932 0.6
(read/write) 159128 198700 39572 24.9
.bss 74860 75148 288 0.4
.data 3352 3356 4 0.1
.rodata 90719 91531 812 0.9
.text 558584 561712 3128 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667795 4088 0.6
.bss 72604 72884 280 0.4
.data 3276 3280 4 0.1
.rodata 75227 76147 920 1.2
.text 588000 591168 3168 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
(read/write) 145732 146016 284 0.2
.bss 68340 68620 280 0.4
.data 3276 3280 4 0.1
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
.bss 72700 72972 272 0.4
.data 3276 3280 4 0.1
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663403 3900 0.6
.bss 72812 73092 280 0.4
.data 3272 3276 4 0.1
.rodata 83719 84523 804 1.0
.text 575304 578400 3096 0.5
shell LP_CC2652R7 (read/write) 157620 191200 33580 21.3
.bss 77876 78156 280 0.4
.data 3356 3360 4 0.1
cyw30739 light cyw930739m2evb_01 .data 712 716 4 0.6
lock cyw930739m2evb_01 .data 716 720 4 0.6
ota-requestor-no-progress-logging cyw930739m2evb_01 .data 656 660 4 0.6
efr32 lighting-app BRD4161A (read/write) 1073484 1081100 7616 0.7
.bss 134324 134716 392 0.3
.data 2044 2048 4 0.2
.text 937096 944316 7220 0.8
BRD4161A+rpc (read/write) 1127572 1135396 7824 0.7
.bss 151012 151404 392 0.3
.data 2256 2260 4 0.2
.text 974284 981712 7428 0.8
BRD4161A+rs911x (read/write) 937672 945236 7564 0.8
.bss 140096 140488 392 0.3
.data 2044 2048 4 0.2
.text 795508 802680 7172 0.9
lock-app BRD4161A+wf200 (read/write) 1117780 1122080 4300 0.4
.bss 140544 140936 392 0.3
.data 2056 2060 4 0.2
.text 975160 979060 3900 0.4
window-app BRD4161A (read/write) 1058752 1066380 7628 0.7
.bss 134396 134796 400 0.3
.data 2072 2076 4 0.2
.text 922264 929484 7220 0.8
esp32 all-clusters-app c3devkit (read only) 1014490 1018442 3952 0.4
(read/write) 1485762 1486930 1168 0.1
.dram0.bss 71432 71824 392 0.5
.flash.rodata 214272 215056 784 0.4
.flash.text 1014490 1018442 3952 0.4
m5stack (read only) 1068787 1072455 3668 0.3
(read/write) 487856 489004 1148 0.2
.dram0.bss 76944 77344 400 0.5
.flash.rodata 244772 245520 748 0.3
.flash.text 1063403 1067071 3668 0.3
k32w light k32w061+release .bss 70996 71268 272 0.4
.data 1988 1992 4 0.2
lock k32w061+release .bss 71468 71740 272 0.4
.data 2000 2004 4 0.2
linux all-clusters-app debug (read only) 2939537 2957729 18192 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 84728 84872 144 0.2
.rodata 261597 263325 1728 0.7
.text 2501378 2517506 16128 0.6
all-clusters-minimal-app debug (read only) 2793617 2811761 18144 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 77368 77512 144 0.2
.rodata 263229 264925 1696 0.6
.text 2356002 2372114 16112 0.7
bridge-app debug+rpc (read only) 2297681 2316049 18368 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.rodata 196416 198112 1696 0.9
.text 1939938 1956226 16288 0.8
chip-tool debug (read only) 10167965 1019317 25208 0.2
(read/write) 610696 610856 160 0.0
.data.rel.ro 578896 579064 168 0.0
.got 5008 5016 8 0.2
.rodata 508645 510053 1408 0.3
.text 8251045 8274341 23296 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9904844 9927780 22936 0.2
(read/write) 675345 675697 352 0.1
.data.rel.ro 614272 614632 360 0.1
.rodata 471564 473348 1784 0.4
.text 7894164 7914756 20592 0.3
lighting-app debug+rpc (read only) 2534369 2552833 18464 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.rodata 212168 213832 1664 0.8
.text 2152290 2168706 16416 0.8
lock-app debug (read only) 2496553 2514913 18360 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.rodata 227016 228712 1696 0.7
.text 2104786 2121090 16304 0.8
ota-provider-app debug (read only) 2305513 2323945 18432 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.rodata 202072 203736 1664 0.8
.text 1941074 1957458 16384 0.8
ota-requestor-app debug (read only) 2422585 2441065 18480 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.rodata 205920 207648 1728 0.8
.text 2045922 2062290 16368 0.8
shell debug .data 1232 1264 32 2.6
thermostat-no-ble arm64 (read only) 2579964 2596564 16600 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.rodata 164812 166148 1336 0.8
.text 2175856 2190640 14784 0.7
tv-app debug (read only) 3083369 3104401 21032 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.data.rel.ro 79080 79232 152 0.2
.got 4840 4848 8 0.2
.rodata 247936 249536 1600 0.6
.text 2648402 2667394 18992 0.7
tv-casting-app debug (read only) 5572889 5591313 18424 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.data.rel.ro 102640 102792 152 0.1
.got 4712 4720 8 0.2
.rodata 341865 343657 1792 0.5
.text 4954626 4970802 16176 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2444432 2447616 3184 0.1
.bss 214732 215732 1000 0.5
.text 1407076 1410260 3184 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170507 1174971 4464 0.4
bss 144254 144650 396 0.3
rodata 140884 141660 776 0.6
text 806560 809728 3168 0.4
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1151503 1155839 4336 0.4
bss 143490 143886 396 0.3
rodata 132816 133592 776 0.6
text 796264 799436 3172 0.4
lighting-app nrf52840dk_nrf52840 (read/write) 1163279 1167643 4364 0.4
bss 145833 146229 396 0.3
rodata 123272 124068 796 0.6
text 815296 818480 3184 0.4
nrf52840dk_nrf52840+rpc (read/write) 1133367 1137799 4432 0.4
bss 146278 146674 396 0.3
rodata 114816 115616 800 0.7
text 793024 796276 3252 0.4
nrf52840dongle_nrf52840 (read/write) 1070107 1074479 4372 0.4
bss 153064 153460 396 0.3
rodata 92332 93112 780 0.8
text 743688 746896 3208 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1066938 1071354 4416 0.4
bss 142204 142600 396 0.3
rodata 115680 116480 800 0.7
text 728020 731208 3188 0.4
lock-app nrf52840dk_nrf52840 (read/write) 1120955 1125319 4364 0.4
bss 135809 136205 396 0.3
rodata 140460 141256 796 0.6
text 765808 768992 3184 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1024818 1029182 4364 0.4
bss 132212 132608 396 0.3
rodata 132928 133724 796 0.6
text 678592 681776 3184 0.5
pump-app nrf52840dk_nrf52840 (read/write) 1076263 1080611 4348 0.4
bss 135728 136124 396 0.3
rodata 116656 117452 796 0.7
text 745008 748176 3168 0.4
pump-controller-app nrf52840dk_nrf52840 (read/write) 1064167 1068511 4344 0.4
bss 135523 135919 396 0.3
rodata 113440 114232 792 0.7
text 736388 739564 3176 0.4
p6 all-clusters-app default (read/write) 2556232 2563520 7288 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521784 7288 0.5
all-clusters-minimal-app default (read/write) 2502096 2509368 7272 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467632 7272 0.5
light-app default (read/write) 2432840 2440136 7296 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398400 7296 0.5
lock-app default (read/write) 2459120 2466400 7280 0.3
.bss 141088 142096 1008 0.7
.text 1417384 1424664 7280 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798512 5108 0.6
bss 71932 72360 428 0.6
text 561382 564972 3590 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818476 4760 0.6
bss 72780 73180 400 0.5
text 577844 581410 3566 0.6
Decreases (12 builds for cc13x2_26x2, cyw30739, k32w, linux)
platform target config section 776c2b8 444cbd5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 191956 188164 -3792 -2.0
lock-ftd LP_CC2652R7 (read/write) 179116 175308 -3808 -2.1
pump-app LP_CC2652R7 (read/write) 170056 166444 -3612 -2.1
pump-controller-app LP_CC2652R7 (read/write) 184296 180676 -3620 -2.0
shell LP_CC2652R7 (read only) 690562 657262 -33300 -4.8
.rodata 109970 84782 -25188 -22.9
.text 580280 572168 -8112 -1.4
cyw30739 light cyw930739m2evb_01 (read/write) 592786 580174 -12612 -2.1
.app_xip_area 462892 457200 -5692 -1.2
.bss 72864 65936 -6928 -9.5
lock cyw930739m2evb_01 (read/write) 594394 581734 -12660 -2.1
.app_xip_area 464292 458568 -5724 -1.2
.bss 73064 66128 -6936 -9.5
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595422 583882 -11540 -1.9
.app_xip_area 466400 461756 -4644 -1.0
.bss 72048 65144 -6904 -9.6
k32w light k32w061+release (read/write) 663008 659840 -3168 -0.5
.text 584224 580780 -3444 -0.6
lock k32w061+release (read/write) 695304 686248 -9056 -1.3
.text 616036 606704 -9332 -1.5
linux chip-tool-no-interactive-ipv6only arm64 .got 13472 13456 -16 -0.1
shell debug (read only) 2613521 2547857 -65664 -2.5
(read/write) 196184 164416 -31768 -16.2
.bss 111336 80904 -30432 -27.3
.data.rel.ro 77864 76608 -1256 -1.6
.got 4168 4096 -72 -1.7
.init_array 936 912 -24 -2.6
.rodata 231666 227538 -4128 -1.8
.text 2222002 2164194 -57808 -2.6
Full report (49 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 776c2b8 444cbd5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660723 664795 4072 0.6
(read/write) 191956 188164 -3792 -2.0
.bss 75572 75852 280 0.4
.data 3352 3356 4 0.1
.rodata 87107 88027 920 1.1
.text 573304 576456 3152 0.5
all-clusters-minimal-app LP_CC2652R7 (read only) 649623 653555 3932 0.6
(read/write) 159128 198700 39572 24.9
.bss 74860 75148 288 0.4
.data 3352 3356 4 0.1
.rodata 90719 91531 812 0.9
.text 558584 561712 3128 0.6
lock-ftd LP_CC2652R7 (read only) 663707 667795 4088 0.6
(read/write) 179116 175308 -3808 -2.1
.bss 72604 72884 280 0.4
.data 3276 3280 4 0.1
.rodata 75227 76147 920 1.2
.text 588000 591168 3168 0.5
lock-mtd LP_CC2652R7 (read only) 613123 617195 4072 0.7
(read/write) 145732 146016 284 0.2
.bss 68340 68620 280 0.4
.data 3276 3280 4 0.1
.rodata 75107 76027 920 1.2
.text 537528 540680 3152 0.6
pump-app LP_CC2652R7 (read only) 673631 677515 3884 0.6
(read/write) 170056 166444 -3612 -2.1
.bss 72700 72972 272 0.4
.data 3276 3280 4 0.1
.rodata 87879 88683 804 0.9
.text 585268 588348 3080 0.5
pump-controller-app LP_CC2652R7 (read only) 659503 663403 3900 0.6
(read/write) 184296 180676 -3620 -2.0
.bss 72812 73092 280 0.4
.data 3272 3276 4 0.1
.rodata 83719 84523 804 1.0
.text 575304 578400 3096 0.5
shell LP_CC2652R7 (read only) 690562 657262 -33300 -4.8
(read/write) 157620 191200 33580 21.3
.bss 77876 78156 280 0.4
.data 3356 3360 4 0.1
.rodata 109970 84782 -25188 -22.9
.text 580280 572168 -8112 -1.4
cyw30739 light cyw930739m2evb_01 (read/write) 592786 580174 -12612 -2.1
.app_xip_area 462892 457200 -5692 -1.2
.bss 72864 65936 -6928 -9.5
.data 712 716 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594394 581734 -12660 -2.1
.app_xip_area 464292 458568 -5724 -1.2
.bss 73064 66128 -6936 -9.5
.data 716 720 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 595422 583882 -11540 -1.9
.app_xip_area 466400 461756 -4644 -1.0
.bss 72048 65144 -6904 -9.6
.data 656 660 4 0.6
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1073484 1081100 7616 0.7
.bss 134324 134716 392 0.3
.data 2044 2048 4 0.2
.text 937096 944316 7220 0.8
BRD4161A+rpc (read/write) 1127572 1135396 7824 0.7
.bss 151012 151404 392 0.3
.data 2256 2260 4 0.2
.text 974284 981712 7428 0.8
BRD4161A+rs911x (read/write) 937672 945236 7564 0.8
.bss 140096 140488 392 0.3
.data 2044 2048 4 0.2
.text 795508 802680 7172 0.9
lock-app BRD4161A+wf200 (read/write) 1117780 1122080 4300 0.4
.bss 140544 140936 392 0.3
.data 2056 2060 4 0.2
.text 975160 979060 3900 0.4
window-app BRD4161A (read/write) 1058752 1066380 7628 0.7
.bss 134396 134796 400 0.3
.data 2072 2076 4 0.2
.text 922264 929484 7220 0.8
esp32 all-clusters-app c3devkit (read only) 1014490 1018442 3952 0.4
(read/write) 1485762 1486930 1168 0.1
.dram0.bss 71432 71824 392 0.5
.dram0.data 14624 14624 0 0.0
.flash.rodata 214272 215056 784 0.4
.flash.text 1014490 1018442 3952 0.4
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068787 1072455 3668 0.3
(read/write) 487856 489004 1148 0.2
.dram0.bss 76944 77344 400 0.5
.dram0.data 34144 34144 0 0.0
.flash.rodata 244772 245520 748 0.3
.flash.text 1063403 1067071 3668 0.3
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 663008 659840 -3168 -0.5
.bss 70996 71268 272 0.4
.data 1988 1992 4 0.2
.text 584224 580780 -3444 -0.6
lock k32w061+release (read/write) 695304 686248 -9056 -1.3
.bss 71468 71740 272 0.4
.data 2000 2004 4 0.2
.text 616036 606704 -9332 -1.5
linux all-clusters-app debug (read only) 2939537 2957729 18192 0.6
(read/write) 177136 178096 960 0.5
.bss 84192 84992 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 84728 84872 144 0.2
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261597 263325 1728 0.7
.text 2501378 2517506 16128 0.6
all-clusters-minimal-app debug (read only) 2793617 2811761 18144 0.6
(read/write) 169040 170032 992 0.6
.bss 83520 84320 800 1.0
.data 2016 2048 32 1.6
.data.rel.ro 77368 77512 144 0.2
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 263229 264925 1696 0.6
.text 2356002 2372114 16112 0.7
bridge-app debug+rpc (read only) 2297681 2316049 18368 0.8
(read/write) 147968 148928 960 0.6
.bss 71616 72384 768 1.1
.data 3792 3824 32 0.8
.data.rel.ro 66792 66952 160 0.2
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 196416 198112 1696 0.9
.text 1939938 1956226 16288 0.8
chip-tool debug (read only) 10167965 1019317 25208 0.2
(read/write) 610696 610856 160 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 578896 579064 168 0.0
.dynamic 624 624 0 0.0
.got 5008 5016 8 0.2
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508645 510053 1408 0.3
.text 8251045 8274341 23296 0.3
chip-tool-no-interactive-ipv6only arm64 (read only) 9904844 9927780 22936 0.2
(read/write) 675345 675697 352 0.1
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614272 614632 360 0.1
.dynamic 528 528 0 0.0
.got 13472 13456 -16 -0.1
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471564 473348 1784 0.4
.text 7894164 7914756 20592 0.3
lighting-app debug+rpc (read only) 2534369 2552833 18464 0.7
(read/write) 151992 152984 992 0.7
.bss 72096 72896 800 1.1
.data 2064 2096 32 1.6
.data.rel.ro 71944 72088 144 0.2
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 212168 213832 1664 0.8
.text 2152290 2168706 16416 0.8
lock-app debug (read only) 2496553 2514913 18360 0.7
(read/write) 147000 147928 928 0.6
.bss 70528 71296 768 1.1
.data 1680 1712 32 1.9
.data.rel.ro 68920 69064 144 0.2
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 227016 228712 1696 0.7
.text 2104786 2121090 16304 0.8
ota-provider-app debug (read only) 2305513 2323945 18432 0.8
(read/write) 140808 141800 992 0.7
.bss 70176 70976 800 1.1
.data 1912 1944 32 1.7
.data.rel.ro 62904 63064 160 0.3
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 202072 203736 1664 0.8
.text 1941074 1957458 16384 0.8
ota-requestor-app debug (read only) 2422585 2441065 18480 0.8
(read/write) 147680 148640 960 0.7
.bss 72544 73312 768 1.1
.data 2200 2232 32 1.5
.data.rel.ro 67080 67240 160 0.2
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205920 207648 1728 0.8
.text 2045922 2062290 16368 0.8
shell debug (read only) 2613521 2547857 -65664 -2.5
(read/write) 196184 164416 -31768 -16.2
.bss 111336 80904 -30432 -27.3
.data 1232 1264 32 2.6
.data.rel.ro 77864 76608 -1256 -1.6
.dynamic 608 608 0 0.0
.got 4168 4096 -72 -1.7
.init 27 27 0 0.0
.init_array 936 912 -24 -2.6
.rodata 231666 227538 -4128 -1.8
.text 2222002 2164194 -57808 -2.6
thermostat-no-ble arm64 (read only) 2579964 2596564 16600 0.6
(read/write) 180705 181793 1088 0.6
.bss 87921 88721 800 0.9
.data 1696 1704 8 0.5
.data.rel.ro 82984 83256 272 0.3
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164812 166148 1336 0.8
.text 2175856 2190640 14784 0.7
tv-app debug (read only) 3083369 3104401 21032 0.7
(read/write) 277896 278856 960 0.3
.bss 187720 188488 768 0.4
.data 4656 4688 32 0.7
.data.rel.ro 79080 79232 152 0.2
.dynamic 608 608 0 0.0
.got 4840 4848 8 0.2
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247936 249536 1600 0.6
.text 2648402 2667394 18992 0.7
tv-casting-app debug (read only) 5572889 5591313 18424 0.3
(read/write) 184144 185104 960 0.5
.bss 72872 73672 800 1.1
.data 2416 2416 0 0.0
.data.rel.ro 102640 102792 152 0.1
.dynamic 608 608 0 0.0
.got 4712 4720 8 0.2
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341865 343657 1792 0.5
.text 4954626 4970802 16176 0.3
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2444432 2447616 3184 0.1
.bss 214732 215732 1000 0.5
.data 5872 5872 0 0.0
.text 1407076 1410260 3184 0.2
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170507 1174971 4464 0.4
bss 144254 144650 396 0.3
rodata 140884 141660 776 0.6
text 806560 809728 3168 0.4
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1151503 1155839 4336 0.4
bss 143490 143886 396 0.3
rodata 132816 133592 776 0.6
text 796264 799436 3172 0.4
lighting-app nrf52840dk_nrf52840 (read/write) 1163279 1167643 4364 0.4
bss 145833 146229 396 0.3
rodata 123272 124068 796 0.6
text 815296 818480 3184 0.4
nrf52840dk_nrf52840+rpc (read/write) 1133367 1137799 4432 0.4
bss 146278 146674 396 0.3
rodata 114816 115616 800 0.7
text 793024 796276 3252 0.4
nrf52840dongle_nrf52840 (read/write) 1070107 1074479 4372 0.4
bss 153064 153460 396 0.3
rodata 92332 93112 780 0.8
text 743688 746896 3208 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1066938 1071354 4416 0.4
bss 142204 142600 396 0.3
rodata 115680 116480 800 0.7
text 728020 731208 3188 0.4
lock-app nrf52840dk_nrf52840 (read/write) 1120955 1125319 4364 0.4
bss 135809 136205 396 0.3
rodata 140460 141256 796 0.6
text 765808 768992 3184 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 1024818 1029182 4364 0.4
bss 132212 132608 396 0.3
rodata 132928 133724 796 0.6
text 678592 681776 3184 0.5
pump-app nrf52840dk_nrf52840 (read/write) 1076263 1080611 4348 0.4
bss 135728 136124 396 0.3
rodata 116656 117452 796 0.7
text 745008 748176 3168 0.4
pump-controller-app nrf52840dk_nrf52840 (read/write) 1064167 1068511 4344 0.4
bss 135523 135919 396 0.3
rodata 113440 114232 792 0.7
text 736388 739564 3176 0.4
p6 all-clusters-app default (read/write) 2556232 2563520 7288 0.3
.bss 149880 150896 1016 0.7
.data 2768 2776 8 0.3
.text 1514496 1521784 7288 0.5
all-clusters-minimal-app default (read/write) 2502096 2509368 7272 0.3
.bss 149160 150176 1016 0.7
.data 2768 2776 8 0.3
.text 1460360 1467632 7272 0.5
light-app default (read/write) 2432840 2440136 7296 0.3
.bss 141240 142248 1008 0.7
.data 2584 2592 8 0.3
.text 1391104 1398400 7296 0.5
lock-app default (read/write) 2459120 2466400 7280 0.3
.bss 141088 142096 1008 0.7
.data 2600 2600 0 0.0
.text 1417384 1424664 7280 0.5
telink light-switch-app tlsr9518adk80d (read/write) 793404 798512 5108 0.6
bss 71932 72360 428 0.6
noinit 40416 40416 0 0.0
text 561382 564972 3590 0.6
lighting-app tlsr9518adk80d (read/write) 813716 818476 4760 0.6
bss 72780 73180 400 0.5
noinit 40416 40416 0 0.0
text 577844 581410 3566 0.6

@tcarmelveilleux tcarmelveilleux merged commit e5e09f5 into project-chip:master Jun 24, 2022
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Jun 24, 2022
@tcarmelveilleux
Fix project-chip#19819 (comment)
5a2065a
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Jun 24, 2022
@tcarmelveilleux
Fix project-chip#19819 (comment)
264bc80
@tcarmelveilleux tcarmelveilleux mentioned this pull request Jun 24, 2022
Merged
tcarmelveilleux added a commit that referenced this pull request Jun 26, 2022
@tcarmelveilleux @bzbarsky-apple
Apply review follow-ups of PR #19819 on FabricTable (#19970)
c38e915 
* Don't notify attribute changes on commit

* Apply follow-up comments from @bzbarsky-apple, all style/nits

* Simplify AddOrUpdateInner from @msandstedt comment

* Restyled

* Fix comment editorials from @bzbarsky-apple

* Add test for AddNOC fail-safe handling

* Add test for UpdateNOC failsafe handling

* Fix #19819 (comment)

* Add Persistence Unit test

* Restyled

* Update src/credentials/FabricTable.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

* Fix CI

* Restyled

Co-authored-by: Boris Zbarsky <[email protected]>
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Jun 27, 2022
@tcarmelveilleux
Properly handle crashes/reboots during FabricTable commit
ab6ac10 
- Since project-chip#19819, commits are very small and safer. There is less surface
  to fail during commit. The previous large-scale fail-safe behavior
  stored too much data, for too long and could cause larger reverts
  even if nothing was committed yet. FabricTable data no longer is
  ever persisted without commit.
- The existing code deleted fabrics unwittingly when not required,
  such as when powering off a light during a fail-safe for an
  update when there was nothing committed yet, assuming we still
  committed immediately.

This change:
- Detects failed commits
- Only deletes data on failed commits
- Fixes Thread driver to detect stale data where a backup was done
  (since we cannot prevent internal commits from OpenThread)

Testing done:
- Added unit test to FabricTable to generate the condition
- Did manual testing of all-clusters-app/chip-tool Linux that
  aborted on second commissioning, during commit. Found that
  cleanup occurred as expected on restart
- Integration/cert testing (including Cirque that validates
  fail-safe) still pass
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Jun 27, 2022
@tcarmelveilleux
Properly handle crashes/reboots during FabricTable commit
25bbf2e 
- Since project-chip#19819, commits are very small and safer. There is less surface
  to fail during commit. The previous large-scale fail-safe behavior
  stored too much data, for too long and could cause larger reverts
  even if nothing was committed yet. FabricTable data no longer is
  ever persisted without commit.
- The existing code deleted fabrics unwittingly when not required,
  such as when powering off a light during a fail-safe for an
  update when there was nothing committed yet, assuming we still
  committed immediately.

This change:
- Detects failed commits
- Only deletes data on failed commits
- Fixes Thread driver to detect stale data where a backup was done
  (since we cannot prevent internal commits from OpenThread)

Testing done:
- Added unit test to FabricTable to generate the condition
- Did manual testing of all-clusters-app/chip-tool Linux that
  aborted on second commissioning, during commit. Found that
  cleanup occurred as expected on restart
- Integration/cert testing (including Cirque that validates
  fail-safe) still pass
@tcarmelveilleux tcarmelveilleux mentioned this pull request Jun 27, 2022
Merged
tcarmelveilleux added a commit that referenced this pull request Jun 29, 2022
@tcarmelveilleux @restyled-commits
Properly handle crashes/reboots during FabricTable commit (#20010)
b91727b 
* Properly handle crashes/reboots during FabricTable commit

- Since #19819, commits are very small and safer. There is less surface
  to fail during commit. The previous large-scale fail-safe behavior
  stored too much data, for too long and could cause larger reverts
  even if nothing was committed yet. FabricTable data no longer is
  ever persisted without commit.
- The existing code deleted fabrics unwittingly when not required,
  such as when powering off a light during a fail-safe for an
  update when there was nothing committed yet, assuming we still
  committed immediately.

This change:
- Detects failed commits
- Only deletes data on failed commits
- Fixes Thread driver to detect stale data where a backup was done
  (since we cannot prevent internal commits from OpenThread)

Testing done:
- Added unit test to FabricTable to generate the condition
- Did manual testing of all-clusters-app/chip-tool Linux that
  aborted on second commissioning, during commit. Found that
  cleanup occurred as expected on restart
- Integration/cert testing (including Cirque that validates
  fail-safe) still pass

* Restyled by clang-format

* Restyled by gn

* Clear commit token after deferred cleanup

* Applied code review comments

* Restyled by clang-format

* Fix CI

* Fix CI

* Remove revert at restart of openthread after other changes

* Apply review comments

* Try to fix nRF CI

* Another attempt to fix nrfconnect CI

* Fix CI some more

* Fix CI again

Co-authored-by: Restyled.io <[email protected]>
tcarmelveilleux added a commit to tcarmelveilleux/connectedhomeip that referenced this pull request Aug 17, 2022
@tcarmelveilleux
Implement 2 missing tests in FabricTable
a5ec099 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
@tcarmelveilleux tcarmelveilleux mentioned this pull request Aug 17, 2022
Merged
andy31415 pushed a commit that referenced this pull request Aug 17, 2022
@tcarmelveilleux
Implement 2 missing tests in FabricTable (#21948)
69d3d59 
- In #19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes #21946
Fixes #21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@tcarmelveilleux @isiu-apple
Implement 2 missing tests in FabricTable (project-chip#21948)
206ad9f 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@woody-apple woody-apple woody-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app controller examples review - approved
Projects
None yet
Milestone
No milestone
6 participants
@tcarmelveilleux @andy31415 @msandstedt @woody-apple @bzbarsky-apple @restyled-commits