-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spec] Make temperature measurement app cluster definitions spec-compliant #19366
Merged
andy31415
merged 1 commit into
project-chip:master
from
shubhamdp:fix_temp_measurement_app_zap
Jun 10, 2022
Merged
[spec] Make temperature measurement app cluster definitions spec-compliant #19366
andy31415
merged 1 commit into
project-chip:master
from
shubhamdp:fix_temp_measurement_app_zap
Jun 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt,
mspang and
rgoliver
June 9, 2022 05:57
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 9, 2022 05:57
shubhamdp
force-pushed
the
fix_temp_measurement_app_zap
branch
from
June 9, 2022 06:18
0708425
to
e3ce3d6
Compare
shubhamdp
changed the title
Make temperature measurement app cluster definitions spec-compliant
[spec] Make temperature measurement app cluster definitions spec-compliant
Jun 9, 2022
PR #19366: Size comparison from 89290d9 to e3ce3d6 Decreases (2 builds for esp32, telink)
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jun 9, 2022
/rebase |
shubhamdp
force-pushed
the
fix_temp_measurement_app_zap
branch
from
June 9, 2022 18:16
e3ce3d6
to
339dc48
Compare
PR #19366: Size comparison from ac8bdbf to 339dc48 Increases (3 builds for cc13x2_26x2, esp32)
Decreases (4 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
shubhamdp
force-pushed
the
fix_temp_measurement_app_zap
branch
from
June 10, 2022 02:59
339dc48
to
c513875
Compare
PR #19366: Size comparison from 668938e to c513875 Increases (2 builds for cc13x2_26x2, esp32)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 10, 2022
dhrishi
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Testing