[nrfconnect] Fixed window covering bug in updating cluster attributes #18752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
Damian-Nordic
approved these changes
May 24, 2022
Nrfconnect window covering example doesn't update window covering cluster attributes properly. * Moved PostAttributeChange method from window-covering-server.cpp to header. * Called PostAttributeChange method in nrfconnect implementation of MatterWindowCoveringClusterServerAttributeChangedCallback * Changed mode default value from 0x14 to 0.
kkasperczyk-no
force-pushed
the
issue_18371_fix
branch
from
a61f33f to
6918d9a
Compare
|
Please hold on with the merge, we need to retest. |
|
PR #18752: Size comparison from 7582608 to 6918d9a Full report (43 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…ack. Signed-off-by: Marcin Kajor <[email protected]>
I pushed a change which aims to avoid using blocking calls in chip attribute change callback. Without it, the UI becomes quite unresponsive (i.e. LEDs brightness stops changing fluently when calling up-or-open/down-or-close). So instead I used async call with PlatformMgr().ScheduleWork(). Tested both UI and the fix for 18371 itself - works fine. |
markaj-nordic
approved these changes
May 24, 2022
|
PR #18752: Size comparison from 7582608 to bd70e62 Full report (45 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
May 24, 2022
|
@kkasperczyk-no I was not asking you to modify the cluster code. But I was asking for decent API docs on the API being added to the cluster, and that did not happen..... |
@bzbarsky-apple sorry about that, I forgot to do the change after answering on your comment. Pushed followup PR: #18840 |
Damian-Nordic
pushed a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Jun 15, 2022
…ter attributes (project-chip#18752) * [nrfconnect] Fixed window covering bug in updating cluster attributes Nrfconnect window covering example doesn't update window covering cluster attributes properly. * Moved PostAttributeChange method from window-covering-server.cpp to header. * Called PostAttributeChange method in nrfconnect implementation of MatterWindowCoveringClusterServerAttributeChangedCallback * Changed mode default value from 0x14 to 0. * [nrfconnect] window-app: do not block in chip attribute changed callback. Signed-off-by: Marcin Kajor <[email protected]> Co-authored-by: Marcin Kajor <[email protected]> (cherry picked from commit a3fdd05)
Damian-Nordic
added a commit
to markaj-nordic/connectedhomeip
that referenced
this pull request
Aug 5, 2022
…ing cluster attributes (project-chip#18752)" This reverts commit fc6a52c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Nrfconnect window covering example doesn't update window covering cluster attributes properly.
Change overview
Testing
Reproduced manually tests described in: #18371
Fixes: #18371