-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip SetCurrentHeapHighWatermark if GetCurrentHeapUsed is not impleme… #18130
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/software
May 10, 2022
Merged
Skip SetCurrentHeapHighWatermark if GetCurrentHeapUsed is not impleme… #18130
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/cluster/software
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
May 6, 2022 02:47
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21,
robszewczyk,
yunhanw-google,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs and
vivien-apple
May 6, 2022 02:47
bzbarsky-apple
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
PR #18130: Size comparison from 50eae82 to 97a74b2 Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (5 builds for cc13x2_26x2, mbed)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
src/app/clusters/software-diagnostics-server/software-diagnostics-server.cpp
Outdated
Show resolved
Hide resolved
PR #18130: Size comparison from 3c3a422 to b9d4e64 Increases (19 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect)
Decreases (24 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nted
Problem
What is being fixed? Examples:
Change overview
Skip SetCurrentHeapHighWatermark if GetCurrentHeapUsed is not implemented.
Testing
How was this tested? (at least one bullet point required)