-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IM] Subscribing to an event crashes #17841
Merged
tcarmelveilleux
merged 4 commits into
project-chip:master
from
vivien-apple:IM_CrashEventSubscription
Apr 28, 2022
Merged
[IM] Subscribing to an event crashes #17841
tcarmelveilleux
merged 4 commits into
project-chip:master
from
vivien-apple:IM_CrashEventSubscription
Apr 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Apr 28, 2022
PR #17841: Size comparison from 8c836f1 to b270b7f Increases (5 builds for cc13x2_26x2, esp32, linux, nrfconnect, telink)
Decreases (1 build for esp32)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #16811, running
./out/debug/standalone/chip-tool otasoftwareupdaterequestor subscribe-event state-transition 5 10 0x12344321 0
ends up crashing the server.I found it while trying to look at #17764
Change overview
TLVReader
Testing
Without the changes in
InteractionModelEngine.cpp
the test crashes, with the changes it does not.