Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IM] Subscribing to an event crashes #17841

Merged

Conversation

vivien-apple
Copy link
Contributor

Problem

After #16811, running ./out/debug/standalone/chip-tool otasoftwareupdaterequestor subscribe-event state-transition 5 10 0x12344321 0 ends up crashing the server.

I found it while trying to look at #17764

Change overview

  • Use the right TLVReader
  • Add a yaml test to subscribe to an event
  • Update the YAML backend to make it possible to wait for an event report

Testing

Without the changes in InteractionModelEngine.cpp the test crashes, with the changes it does not.

@github-actions
Copy link

github-actions bot commented Apr 28, 2022

PR #17841: Size comparison from 8c836f1 to b270b7f

Increases (5 builds for cc13x2_26x2, esp32, linux, nrfconnect, telink)
platform target config section 8c836f1f b270b7f change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 637611 637619 8 0.0
.text 534068 534076 8 0.0
esp32 all-clusters-app c3devkit (read only) 999288 999290 2 0.0
.flash.text 999288 999290 2 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8276372 8278980 2608 0.0
.rodata 423572 423668 96 0.0
.text 6634452 6636964 2512 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 808660 808664 4 0.0
telink lighting-app tlsr9518adk80d text 571416 571418 2 0.0
Decreases (1 build for esp32)
platform target config section 8c836f1f b270b7f change % change
esp32 all-clusters-app m5stack (read only) 1054687 1054683 -4 -0.0
.flash.text 1049303 1049299 -4 -0.0
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8c836f1f b270b7f change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688059 688059 0 0.0
(read/write) 164188 164188 0 0.0
.bss 75228 75228 0 0.0
.data 3396 3396 0 0.0
.rodata 101507 101507 0 0.0
.text 586072 586072 0 0.0
lock-ftd LP_CC2652R7 (read only) 688875 688875 0 0.0
(read/write) 154676 154676 0 0.0
.bss 73588 73588 0 0.0
.data 3220 3220 0 0.0
.rodata 103171 103171 0 0.0
.text 585220 585220 0 0.0
lock-mtd LP_CC2652R7 (read only) 637611 637619 8 0.0
(read/write) 146388 146388 0 0.0
.bss 69308 69308 0 0.0
.data 3220 3220 0 0.0
.rodata 103051 103051 0 0.0
.text 534068 534076 8 0.0
pump-app LP_CC2652R7 (read only) 661639 661639 0 0.0
(read/write) 183112 183112 0 0.0
.bss 73764 73764 0 0.0
.data 3252 3252 0 0.0
.rodata 80351 80351 0 0.0
.text 580808 580808 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654575 654575 0 0.0
(read/write) 189968 189968 0 0.0
.bss 73812 73812 0 0.0
.data 3216 3216 0 0.0
.rodata 83383 83383 0 0.0
.text 570712 570712 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626918 626918 0 0.0
.app_xip_area 529468 529468 0 0.0
.bss 80108 80108 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621518 621518 0 0.0
.app_xip_area 525540 525540 0 0.0
.bss 78668 78668 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574634 574634 0 0.0
.app_xip_area 469012 469012 0 0.0
.bss 88016 88016 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907760 907760 0 0.0
(read/write) 135112 135112 0 0.0
.bss 133064 133064 0 0.0
.data 2044 2044 0 0.0
.text 907752 907752 0 0.0
BRD4161A+rpc (read only) 942112 942112 0 0.0
(read/write) 151792 151792 0 0.0
.bss 149544 149544 0 0.0
.data 2248 2248 0 0.0
.text 942104 942104 0 0.0
window-app BRD4161A (read only) 844952 844952 0 0.0
(read/write) 133200 133200 0 0.0
.bss 131240 131240 0 0.0
.data 1956 1956 0 0.0
.text 844944 844944 0 0.0
esp32 all-clusters-app c3devkit (read only) 999288 999290 2 0.0
(read/write) 1473778 1473778 0 0.0
.dram0.bss 68360 68360 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206536 206536 0 0.0
.flash.text 999288 999290 2 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1054687 1054683 -4 -0.0
(read/write) 476200 476200 0 0.0
.dram0.bss 73880 73880 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 236316 236316 0 0.0
.flash.text 1049303 1049299 -4 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688788 688788 0 0.0
.bss 81312 81312 0 0.0
.data 2000 2000 0 0.0
.text 599676 599676 0 0.0
lock k32w061+release (read/write) 729648 729648 0 0.0
.bss 81720 81720 0 0.0
.data 1960 1960 0 0.0
.text 640168 640168 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8276372 8278980 2608 0.0
(read/write) 539601 539601 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 479608 479608 0 0.0
.dynamic 560 560 0 0.0
.got 14088 14088 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 423572 423668 96 0.0
.text 6634452 6636964 2512 0.0
thermostat-no-ble arm64 (read only) 2366892 2366892 0 0.0
(read/write) 174513 174513 0 0.0
.bss 86257 86257 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79000 79000 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145980 145980 0 0.0
.text 1991856 1991856 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411340 2411340 0 0.0
.bss 205860 205860 0 0.0
.data 5848 5848 0 0.0
.text 1373940 1373940 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179447 1179447 0 0.0
bss 141992 141992 0 0.0
rodata 150104 150104 0 0.0
text 808660 808664 4 0.0
p6 all-clusters-app default (read/write) 2526824 2526824 0 0.0
.bss 139248 139248 0 0.0
.data 2784 2784 0 0.0
.text 1485088 1485088 0 0.0
light-app default (read/write) 2418768 2418768 0 0.0
.bss 132720 132720 0 0.0
.data 2584 2584 0 0.0
.text 1377032 1377032 0 0.0
lock-app default (read/write) 2422848 2422848 0 0.0
.bss 132520 132520 0 0.0
.data 2544 2544 0 0.0
.text 1381112 1381112 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807680 807680 0 0.0
bss 75424 75424 0 0.0
noinit 40416 40416 0 0.0
text 571416 571418 2 0.0

@tcarmelveilleux tcarmelveilleux merged commit fb68954 into project-chip:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants