Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrfconnect] Fixed using Kconfig.features options #17313

Merged

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Kconfig.features is currently sourced after Kconfig.defaults,
so the default values from Kconfig.defaults are used and features
cannot modify it.

Change overview

Removed Kconfig.features to be sourced before Kconfig.defaults.

Kconfig.features is currently sourced after Kconfig.defaults,
so the default values from Kconfig.defaults are used and features
cannot modify it.

Removed Kconfig.features to be sourced before Kconfig.defaults.
@kkasperczyk-no kkasperczyk-no force-pushed the configuration_features_fix branch from 5d93030 to b720876 Compare April 13, 2022 10:02
@github-actions
Copy link

github-actions bot commented Apr 13, 2022

PR #17313: Size comparison from faabdf9 to b720876

Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section faabdf9 b720876 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640211 640211 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80163 80163 0 0.0
.text 559556 559556 0 0.0
lock-mtd LP_CC2652R7 (read only) 588947 588947 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80043 80043 0 0.0
.text 508412 508412 0 0.0
pump-app LP_CC2652R7 (read only) 648287 648287 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75351 75351 0 0.0
.text 572448 572448 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642267 642267 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78987 78987 0 0.0
.text 562792 562792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618818 618818 0 0.0
.app_xip_area 525528 525528 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576414 576414 0 0.0
.app_xip_area 484660 484660 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564938 564938 0 0.0
.app_xip_area 463556 463556 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907300 907300 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907292 907292 0 0.0
BRD4161A+rpc (read only) 941668 941668 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941660 941660 0 0.0
window-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844284 844284 0 0.0
esp32 all-clusters-app c3devkit (read only) 979702 979702 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979702 979702 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035283 1035283 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029899 1029899 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687036 687036 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601072 601072 0 0.0
lock k32w061+release (read/write) 691652 691652 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605152 605152 0 0.0
linux all-clusters-app debug (read only) 2696513 2696513 0 0.0
(read/write) 149120 149120 0 0.0
.bss 60192 60192 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 80984 80984 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 232421 232421 0 0.0
.text 2290098 2290098 0 0.0
bridge-app debug+rpc (read only) 1836109 1836109 0 0.0
(read/write) 91760 91760 0 0.0
.bss 44480 44480 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39280 39280 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148473 148473 0 0.0
.text 1569205 1569205 0 0.0
chip-tool debug (read only) 10676677 10676677 0 0.0
(read/write) 371832 371832 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341728 341728 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538005 538005 0 0.0
.text 9309365 9309365 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10277348 10277348 0 0.0
(read/write) 492209 492209 0 0.0
.bss 41025 41025 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388816 388816 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512244 512244 0 0.0
.text 8661844 8661844 0 0.0
door-lock-app debug (read only) 2107489 2107489 0 0.0
(read/write) 119504 119504 0 0.0
.bss 48064 48064 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64408 64408 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186697 186697 0 0.0
.text 1765090 1765090 0 0.0
lighting-app debug+rpc (read only) 2312329 2312329 0 0.0
(read/write) 127824 127824 0 0.0
.bss 50272 50272 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69896 69896 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 182665 182665 0 0.0
.text 1963826 1963826 0 0.0
ota-provider-app debug (read only) 2044673 2044673 0 0.0
(read/write) 114944 114944 0 0.0
.bss 47968 47968 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59624 59624 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172483 172483 0 0.0
.text 1716002 1716002 0 0.0
ota-requestor-app debug (read only) 2075049 2075049 0 0.0
(read/write) 118296 118296 0 0.0
.bss 48960 48960 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61864 61864 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169356 169356 0 0.0
.text 1747634 1747634 0 0.0
shell debug (read only) 2524353 2524353 0 0.0
(read/write) 149968 149968 0 0.0
.bss 67624 67624 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 75368 75368 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214706 214706 0 0.0
.text 2148482 2148482 0 0.0
thermostat-no-ble arm64 (read only) 2352444 2352444 0 0.0
(read/write) 150993 150993 0 0.0
.bss 63153 63153 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144540 144540 0 0.0
.text 1979328 1979328 0 0.0
tv-app debug (read only) 2795825 2795825 0 0.0
(read/write) 250688 250688 0 0.0
.bss 164112 164112 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75912 75912 0 0.0
.dynamic 592 592 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213259 213259 0 0.0
.text 2401266 2401266 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156151 1156151 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 795236 795236 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1142339 1142339 0 0.0
bss 139200 139200 0 0.0
rodata 121812 121812 0 0.0
text 802696 802696 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1106575 1106575 0 0.0
bss 139436 139436 0 0.0
rodata 112936 112936 0 0.0
text 775108 775108 0 0.0
nrf52840dongle_nrf52840 (read/write) 1051243 1051243 0 0.0
bss 146448 146448 0 0.0
rodata 91964 91964 0 0.0
text 731916 731916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1051082 1051082 0 0.0
bss 136264 136264 0 0.0
rodata 114984 114984 0 0.0
text 717860 717860 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1042563 1042563 0 0.0
bss 129144 129144 0 0.0
rodata 114596 114596 0 0.0
text 720416 720416 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 951666 951666 0 0.0
bss 126240 126240 0 0.0
rodata 107824 107824 0 0.0
text 635736 635736 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 558183 558183 0 0.0
bss 70792 70792 0 0.0
rodata 45368 45368 0 0.0
text 382552 382552 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1062399 1062399 0 0.0
bss 129152 129152 0 0.0
rodata 117280 117280 0 0.0
text 737408 737408 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1044135 1044135 0 0.0
bss 128872 128872 0 0.0
rodata 113288 113288 0 0.0
text 723432 723432 0 0.0
shell nrf52840dk_nrf52840 (read/write) 803595 803595 0 0.0
bss 118400 118400 0 0.0
rodata 73772 73772 0 0.0
text 537784 537784 0 0.0
p6 all-clusters-app default (read/write) 2514704 2514704 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472968 1472968 0 0.0
light-app default (read/write) 2415176 2415176 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373440 1373440 0 0.0
lock-app default (read/write) 2378744 2378744 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1337008 1337008 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801264 801264 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569958 569958 0 0.0

@Damian-Nordic Damian-Nordic merged commit 4ee7cc4 into project-chip:master Apr 14, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Kconfig.features is currently sourced after Kconfig.defaults,
so the default values from Kconfig.defaults are used and features
cannot modify it.

Removed Kconfig.features to be sourced before Kconfig.defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants