-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Fixed using Kconfig.features options #17313
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
kkasperczyk-no:configuration_features_fix
Apr 14, 2022
Merged
[nrfconnect] Fixed using Kconfig.features options #17313
Damian-Nordic
merged 1 commit into
project-chip:master
from
kkasperczyk-no:configuration_features_fix
Apr 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang and
sagar-apple
April 13, 2022 09:54
pullapprove
bot
requested review from
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
April 13, 2022 09:54
Kconfig.features is currently sourced after Kconfig.defaults, so the default values from Kconfig.defaults are used and features cannot modify it. Removed Kconfig.features to be sourced before Kconfig.defaults.
kkasperczyk-no
force-pushed
the
configuration_features_fix
branch
from
April 13, 2022 10:02
5d93030
to
b720876
Compare
PR #17313: Size comparison from faabdf9 to b720876 Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Apr 13, 2022
bzbarsky-apple
approved these changes
Apr 13, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Kconfig.features is currently sourced after Kconfig.defaults, so the default values from Kconfig.defaults are used and features cannot modify it. Removed Kconfig.features to be sourced before Kconfig.defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Kconfig.features is currently sourced after Kconfig.defaults,
so the default values from Kconfig.defaults are used and features
cannot modify it.
Change overview
Removed Kconfig.features to be sourced before Kconfig.defaults.