Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable content app platform on android #17302

Merged
merged 9 commits into from
Apr 19, 2022
Merged

enable content app platform on android #17302

merged 9 commits into from
Apr 19, 2022

Conversation

chrisdecenzo
Copy link
Contributor

Problem

Change overview

  • include content-app platform version of tv-app clusters
  • include content-app platform initializers
  • include commissioner

Testing

  • Tested using tv-app on android, running in android tv emulator
  • Regression tested using linux/docker tv-app

@restyled-io restyled-io bot mentioned this pull request Apr 13, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17302: Size comparison from 3af5410 to 72af118

Full report (6 builds for esp32, k32w, mbed, nrfconnect)
platform target config section 3af5410 72af118 change % change
esp32 all-clusters-app c3devkit (read only) 979702 979702 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979702 979702 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035283 1035283 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029899 1029899 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687036 687036 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601072 601072 0 0.0
lock k32w061+release (read/write) 691652 691652 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605152 605152 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156151 1156151 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 795236 795236 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17302: Size comparison from 94e8197 to 95232a8

Full report (5 builds for esp32, mbed, nrfconnect, telink)
platform target config section 94e8197 95232a8 change % change
esp32 all-clusters-app c3devkit (read only) 979972 979972 0 0.0
(read/write) 1397578 1397578 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201616 201616 0 0.0
.flash.text 979972 979972 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035459 1035459 0 0.0
(read/write) 465316 465316 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231184 231184 0 0.0
.flash.text 1030075 1030075 0 0.0
.iram0.text 123107 123107 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368516 2368516 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1331116 1331116 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1163459 1163459 0 0.0
bss 136528 136528 0 0.0
rodata 147364 147364 0 0.0
text 800940 800940 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801516 801516 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 570132 570132 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 15, 2022 •
edited
Loading

PR #17302: Size comparison from 4967c0e to a9f06ae

Full report (2 builds for mbed, nrfconnect)
platform target config section 4967c0e a9f06ae change % change
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410188 2410188 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372788 1372788 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164051 1164051 0 0.0
bss 136504 136504 0 0.0
rodata 147444 147444 0 0.0
text 801444 801444 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 18, 2022 •
edited
Loading

PR #17302: Size comparison from 20e1a4a to cc8f77e

Full report (12 builds for cc13x2_26x2, esp32, linux, mbed, nrfconnect, telink)
platform target config section 20e1a4a cc8f77e change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684415 684415 0 0.0
(read/write) 168752 168752 0 0.0
.bss 76152 76152 0 0.0
.data 3380 3380 0 0.0
.rodata 103367 103367 0 0.0
.text 580568 580568 0 0.0
lock-ftd LP_CC2652R7 (read only) 677311 677311 0 0.0
(read/write) 166800 166800 0 0.0
.bss 74152 74152 0 0.0
.data 3212 3212 0 0.0
.rodata 98847 98847 0 0.0
.text 577980 577980 0 0.0
lock-mtd LP_CC2652R7 (read only) 626055 626055 0 0.0
(read/write) 146940 146940 0 0.0
.bss 69872 69872 0 0.0
.data 3212 3212 0 0.0
.rodata 98727 98727 0 0.0
.text 526836 526836 0 0.0
pump-app LP_CC2652R7 (read only) 649455 649455 0 0.0
(read/write) 152476 152476 0 0.0
.bss 74608 74608 0 0.0
.data 3244 3244 0 0.0
.rodata 75671 75671 0 0.0
.text 573296 573296 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642791 642791 0 0.0
(read/write) 152144 152144 0 0.0
.bss 74312 74312 0 0.0
.data 3208 3208 0 0.0
.rodata 79007 79007 0 0.0
.text 563296 563296 0 0.0
esp32 all-clusters-app c3devkit (read only) 980476 980476 0 0.0
(read/write) 1397826 1397826 0 0.0
.dram0.bss 62600 62600 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201896 201896 0 0.0
.flash.text 980476 980476 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035975 1035975 0 0.0
(read/write) 465552 465552 0 0.0
.dram0.bss 68112 68112 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231452 231452 0 0.0
.flash.text 1030591 1030591 0 0.0
.iram0.text 123107 123107 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10388564 10388564 0 0.0
(read/write) 493489 493489 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 390224 390224 0 0.0
.dynamic 560 560 0 0.0
.got 57408 57408 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 514340 514340 0 0.0
.text 8767108 8767108 0 0.0
thermostat-no-ble arm64 (read only) 2359028 2359028 0 0.0
(read/write) 151137 151137 0 0.0
.bss 62945 62945 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145300 145300 0 0.0
.text 1984736 1984736 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410124 2410124 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372724 1372724 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164339 1164339 0 0.0
bss 136504 136504 0 0.0
rodata 147524 147524 0 0.0
text 801660 801660 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801956 801956 0 0.0
bss 69952 69952 0 0.0
noinit 40416 40416 0 0.0
text 570550 570550 0 0.0

@chrisdecenzo chrisdecenzo merged commit 8793870 into master Apr 19, 2022
@chrisdecenzo chrisdecenzo deleted the tv-apps-android branch April 19, 2022 01:59
@andy31415 andy31415 mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitnj amitnj amitnj approved these changes

@xylophone21 xylophone21 xylophone21 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@lazarkov lazarkov Awaiting requested review from lazarkov

Assignees
No one assigned
Labels
examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android tv-app does not support content app platform
4 participants
@chrisdecenzo @xylophone21 @lazarkov @amitnj