Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage documentation/example to DecodableList. #17184

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Add usage documentation/example to DecodableList. #17184

merged 1 commit into from
Apr 7, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Need better docs.

Change overview

Add docs.

Testing

Comment changes only.

@boring-cyborg boring-cyborg bot added the app label Apr 7, 2022
@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

PR #17184: Size comparison from b67c944 to fa0ac7a

Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section b67c944 fa0ac7a change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674515 674515 0 0.0
(read/write) 176964 176964 0 0.0
.bss 81520 81520 0 0.0
.data 3216 3216 0 0.0
.rodata 80563 80563 0 0.0
.text 593472 593472 0 0.0
lock-mtd LP_CC2652R7 (read only) 623651 623651 0 0.0
(read/write) 154320 154320 0 0.0
.bss 77248 77248 0 0.0
.data 3216 3216 0 0.0
.rodata 80451 80451 0 0.0
.text 542712 542712 0 0.0
pump-app LP_CC2652R7 (read only) 681875 681875 0 0.0
(read/write) 170780 170780 0 0.0
.bss 81928 81928 0 0.0
.data 3248 3248 0 0.0
.rodata 75243 75243 0 0.0
.text 606148 606148 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676219 676219 0 0.0
(read/write) 176164 176164 0 0.0
.bss 81656 81656 0 0.0
.data 3212 3212 0 0.0
.rodata 79027 79027 0 0.0
.text 596708 596708 0 0.0
efr32 lighting-app BRD4161A (read only) 904908 904908 0 0.0
(read/write) 133160 133160 0 0.0
.bss 131120 131120 0 0.0
.data 2040 2040 0 0.0
.text 904900 904900 0 0.0
BRD4161A+rpc (read only) 932780 932780 0 0.0
(read/write) 149108 149108 0 0.0
.bss 146888 146888 0 0.0
.data 2220 2220 0 0.0
.text 932772 932772 0 0.0
window-app BRD4161A (read only) 842196 842196 0 0.0
(read/write) 131228 131228 0 0.0
.bss 129280 129280 0 0.0
.data 1948 1948 0 0.0
.text 842188 842188 0 0.0
esp32 all-clusters-app c3devkit (read only) 991900 991900 0 0.0
(read/write) 1461762 1461762 0 0.0
.dram0.bss 62936 62936 0 0.0
.dram0.data 14356 14356 0 0.0
.flash.rodata 198984 198984 0 0.0
.flash.text 991900 991900 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044615 1044615 0 0.0
(read/write) 462816 462816 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228048 228048 0 0.0
.flash.text 1039231 1039231 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 685148 685148 0 0.0
.bss 78208 78208 0 0.0
.data 2036 2036 0 0.0
.text 599104 599104 0 0.0
lock k32w061+release (read/write) 689932 689932 0 0.0
.bss 78784 78784 0 0.0
.data 1996 1996 0 0.0
.text 603352 603352 0 0.0
linux all-clusters-app debug (read only) 2622689 2622689 0 0.0
(read/write) 145640 145640 0 0.0
.bss 57664 57664 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 80264 80264 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222405 222405 0 0.0
.text 2231410 2231410 0 0.0
bridge-app debug+rpc (read only) 1831421 1831421 0 0.0
(read/write) 91304 91304 0 0.0
.bss 44344 44344 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148281 148281 0 0.0
.text 1565669 1565669 0 0.0
chip-tool debug (read only) 10678997 10678997 0 0.0
(read/write) 371736 371736 0 0.0
.bss 22752 22752 0 0.0
.data 1104 1104 0 0.0
.data.rel.ro 341632 341632 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538357 538357 0 0.0
.text 9311701 9311701 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10280588 10280588 0 0.0
(read/write) 492145 492145 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388776 388776 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512524 512524 0 0.0
.text 8665028 8665028 0 0.0
door-lock-app debug (read only) 2102513 2102513 0 0.0
(read/write) 119024 119024 0 0.0
.bss 47936 47936 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 64056 64056 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186313 186313 0 0.0
.text 1761554 1761554 0 0.0
lighting-app debug+rpc (read only) 2305017 2305017 0 0.0
(read/write) 127344 127344 0 0.0
.bss 50144 50144 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 69544 69544 0 0.0
.dynamic 608 608 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 181513 181513 0 0.0
.text 1958770 1958770 0 0.0
ota-provider-app debug (read only) 2040353 2040353 0 0.0
(read/write) 114592 114592 0 0.0
.bss 47840 47840 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 59384 59384 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172323 172323 0 0.0
.text 1712466 1712466 0 0.0
ota-requestor-app debug (read only) 2069657 2069657 0 0.0
(read/write) 117880 117880 0 0.0
.bss 48800 48800 0 0.0
.data 1864 1864 0 0.0
.data.rel.ro 61624 61624 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 168716 168716 0 0.0
.text 1743602 1743602 0 0.0
shell debug (read only) 2517473 2517473 0 0.0
(read/write) 149168 149168 0 0.0
.bss 67368 67368 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 74808 74808 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 214002 214002 0 0.0
.text 2144082 2144082 0 0.0
thermostat-no-ble arm64 (read only) 2348476 2348476 0 0.0
(read/write) 150497 150497 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78264 78264 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144428 144428 0 0.0
.text 1976576 1976576 0 0.0
tv-app debug (read only) 2793393 2793393 0 0.0
(read/write) 251096 251096 0 0.0
.bss 165032 165032 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 75408 75408 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 213291 213291 0 0.0
.text 2400386 2400386 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366844 2366844 0 0.0
.bss 185060 185060 0 0.0
.data 5840 5840 0 0.0
.text 1329444 1329444 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153375 1153375 0 0.0
bss 135540 135540 0 0.0
rodata 145832 145832 0 0.0
text 793388 793388 0 0.0
p6 all-clusters-app default (read/write) 2512552 2512552 0 0.0
.bss 118464 118464 0 0.0
.data 2768 2768 0 0.0
.text 1470816 1470816 0 0.0
light-app default (read/write) 2413576 2413576 0 0.0
.bss 111960 111960 0 0.0
.data 2576 2576 0 0.0
.text 1371840 1371840 0 0.0
lock-app default (read/write) 2377208 2377208 0 0.0
.bss 111704 111704 0 0.0
.data 2536 2536 0 0.0
.text 1335472 1335472 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799240 799240 0 0.0
bss 70064 70064 0 0.0
noinit 40416 40416 0 0.0
text 568274 568274 0 0.0

@andy31415 andy31415 merged commit 31cb002 into project-chip:master Apr 7, 2022
@bzbarsky-apple bzbarsky-apple deleted the document-decodable-list branch April 7, 2022 20:33
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Add usage documentation/example to DecodableList. (project-chip#17184)
4b73c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@anush-apple anush-apple Awaiting requested review from anush-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
app fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @andy31415