-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap usages of src/ble/... with CONFIG_NETWORK_LAYER_BLE #16414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
March 18, 2022 05:50
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 18, 2022 05:50
bzbarsky-apple
approved these changes
Mar 18, 2022
PR #16414: Size comparison from f68cca0 to e3b68e4 Decreases (2 builds for linux, telink)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Mar 18, 2022
mspang
approved these changes
Mar 18, 2022
wendythewan
changed the title
Wrap usages of src/ble/BleLayer with CONFIG_NETWORK_LAYER_BLE
Wrap usages of src/ble/... with CONFIG_NETWORK_LAYER_BLE
Mar 18, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…p#16414) * Wrap usages of src/ble/BleLayer with CONFIG_NETWORK_LAYER_BLE * Restyle Server.cpp * Restyle CHIPDeviceControllerFactory * Restyle CASEServer.cpp * Update Server.cpp * Restyle change * Restyle change * Restyle * Restyle * Restyle * Remove whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
src/ble
in CHIPDeviceLayer.h because it is not needed.Testing
How was this tested? (at least one bullet point required)