Docker development environment #162

woody-apple · 2020-03-31T04:19:34Z

Problem

#155

Summary of Changes

Setting up a simple docker development image.

Need to:
• Document
• Publish

Minor: Fix incorrect code format Merging based on 3 approvals, thank you!

Fix Ubuntu build issue for inet folder Merging based on 3 approvals, thank you!

Import SystemPacketBuffer to CHIP project Merging based on 3 approvals, thank you!

Import tunnel config to CHIP Merging based on 3 approvals, thank you!

Add TLV Parser Merging per 3 approvals. Thanks

Import BLE code to CHIP Merging per 3 approvals. Thanks

Build TunEndPoint as part of inet Thanks, merging base on the approvals!

Allow 'make run_tests' from top-level

- `docker_build.sh` builds all - `docker_build.sh clean` build clean - `docker_build.sh run_tests` builds and runs tests

woody-apple · 2020-03-31T04:20:21Z

More changes to come, opening up for feedback. Also going to document visual studio code flow

rwalker-apple · 2020-03-31T15:31:54Z

why "tools"? what's the difference between "tools" and "integrations" in your view of the tree?

rwalker-apple · 2020-03-31T15:33:17Z

tools/environment/Dockerfile

+        shellcheck
+
+RUN useradd -ms /bin/bash developer
+RUN mkdir -p /home/developer/connectedhomeip


legibility with multiple RUN statements is nice. each RUN implies a docker layer, though, right? any downsides to that?

asking mostly for my own edification

In my experience, multiple runs for clarity helps the reader/maintainer, and while it does mean you have technically separate images, but - there's no overhead to that.

I like that view of it.

Sounds like we could move @pan-apple's docker_run.sh back here.

Please note, going to move things around a bit now, found a cleaner way to get VSCode working too!

woody-apple · 2020-03-31T15:33:57Z

Integrations seemed to me like things to help this CHIP repository to build & integrate with the world. To me, a local docker container is a tool to help me (the developer) do my job. Open to feedback.

hawk248

excellent

rwalker-apple · 2020-03-31T16:22:43Z

tools/environment/Dockerfile

@@ -0,0 +1,21 @@
+FROM ubuntu:bionic


Would you consider FROMing this on the integrations/docker/chip-build image instead? This Dockerfile would only have the parts for interactive work, all the tooling would match that of our CI image.

…quirements Merge in WMN_TOOLS/matter from cherry-pick/module_documentation to silabs_1.0 Squashed commit of the following: commit 9ae8e2e2849866a290dc6ff603be68a250346077 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 15:38:38 2022 +0000 Pull request project-chip#162: Add modules to hardware requirements Merge in WMN_TOOLS/matter from feature/module_doc to silabs Squashed commit of the following: commit 228a1dce75f057d65c18cc46b274faa5d4ebe245 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 11:15:34 2022 -0400 Clean up documentation changes commit 689675c21978d99b3fefde895dad68e8b7d67b09 Author: Mathieu Kardous <[email protected]> Date: Thu Oct 6 14:25:33 2022 -0400 Add BRD4316A/17A to hardware requirements

Merge in WMN_TOOLS/matter from feature/module_doc to silabs Squashed commit of the following: commit 228a1dce75f057d65c18cc46b274faa5d4ebe245 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 11:15:34 2022 -0400 Clean up documentation changes commit 689675c21978d99b3fefde895dad68e8b7d67b09 Author: Mathieu Kardous <[email protected]> Date: Thu Oct 6 14:25:33 2022 -0400 Add BRD4316A/17A to hardware requirements

Merge in WMN_TOOLS/matter from cherry-pick/module_documentation to silabs_1.0 Squashed commit of the following: commit 9ae8e2e2849866a290dc6ff603be68a250346077 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 15:38:38 2022 +0000 Pull request #162: Add modules to hardware requirements Merge in WMN_TOOLS/matter from feature/module_doc to silabs Squashed commit of the following: commit 228a1dce75f057d65c18cc46b274faa5d4ebe245 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 11:15:34 2022 -0400 Clean up documentation changes commit 689675c21978d99b3fefde895dad68e8b7d67b09 Author: Mathieu Kardous <[email protected]> Date: Thu Oct 6 14:25:33 2022 -0400 Add BRD4316A/17A to hardware requirements

…quirements Merge in WMN_TOOLS/matter from cherry-pick/module_documentation to silabs_1.0 Squashed commit of the following: commit 9ae8e2e2849866a290dc6ff603be68a250346077 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 15:38:38 2022 +0000 Pull request project-chip#162: Add modules to hardware requirements Merge in WMN_TOOLS/matter from feature/module_doc to silabs Squashed commit of the following: commit 228a1dce75f057d65c18cc46b274faa5d4ebe245 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 11:15:34 2022 -0400 Clean up documentation changes commit 689675c21978d99b3fefde895dad68e8b7d67b09 Author: Mathieu Kardous <[email protected]> Date: Thu Oct 6 14:25:33 2022 -0400 Add BRD4316A/17A to hardware requirements

Merge in WMN_TOOLS/matter from feature/module_doc to silabs Squashed commit of the following: commit 228a1dce75f057d65c18cc46b274faa5d4ebe245 Author: Mathieu Kardous <[email protected]> Date: Fri Oct 7 11:15:34 2022 -0400 Clean up documentation changes commit 689675c21978d99b3fefde895dad68e8b7d67b09 Author: Mathieu Kardous <[email protected]> Date: Thu Oct 6 14:25:33 2022 -0400 Add BRD4316A/17A to hardware requirements

pan-apple and others added 30 commits March 10, 2020 13:16

Modify SystemPacketBuffer to use chip namespace

1a3ec49

Makefile changes to build SystemPacketBuffer

a4a78d6

Import tunnel config

fa17638

Modify tunnel config to CHIP namespace

5b6fbec

Merge pull request #27 from sagar-apple/lint

0b95284

Minor: Fix incorrect code format Merging based on 3 approvals, thank you!

Merge pull request #25 from pan-apple/inet

d800354

Fix Ubuntu build issue for inet folder Merging based on 3 approvals, thank you!

Merge pull request #26 from pan-apple/packet_buffer

7dddb69

Import SystemPacketBuffer to CHIP project Merging based on 3 approvals, thank you!

Merge pull request #28 from pan-apple/tunnel_config

49ab8a7

Import tunnel config to CHIP Merging based on 3 approvals, thank you!

Build TunEndPoint as part of inet

4b79cad

Import ble code

ac04cb3

Change BLE namespace to CHIP

6e6b033

Import FlagUtils and FaultInjection

1641f9b

update fault injection to CHIP namespace

8e2eaa9

Bring in WeaveTLV

904200e

Rename from Weave to CHIP

acd25ff

Add CHIP TLV to libcore

c203c09

Updates to compile BLE

dfa3130

Merge pull request #30 from sagar-apple/tlv

17eeab5

Add TLV Parser Merging per 3 approvals. Thanks

Merge pull request #31 from pan-apple/ble

10fcfcf

Import BLE code to CHIP Merging per 3 approvals. Thanks

Merge pull request #29 from pan-apple/inet

da65a49

Build TunEndPoint as part of inet Thanks, merging base on the approvals!

Allow 'make run_tests' from top-level

7cd561c

Merge pull request #32 from turon/pr/run_tests

0a84f0b

Allow 'make run_tests' from top-level

Fix build warnings

e909f70

Build for Ubuntu using docker container

4d9208c

- `docker_build.sh` builds all - `docker_build.sh clean` build clean - `docker_build.sh run_tests` builds and runs tests

Update readme for docker information

0fa24d7

Remove unnecessary tabs in Makefiles

5852da5

Update style guide

5c5d69e

Move Makefile style guide to its own file

8669353

Undo whitespace deletion

b0c2c6f

remove Language C from .clang_format

37d03bd

Update README.md

1c7164a

gerickson approved these changes Mar 31, 2020

View reviewed changes

rwalker-apple reviewed Mar 31, 2020

View reviewed changes

hawk248 approved these changes Mar 31, 2020

View reviewed changes

rwalker-apple reviewed Mar 31, 2020

View reviewed changes

Updating this to be VSCode friendly + build support

6b7a8fa

woody-apple closed this Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker development environment #162

Docker development environment #162

woody-apple commented Mar 31, 2020

woody-apple commented Mar 31, 2020

rwalker-apple commented Mar 31, 2020

rwalker-apple Mar 31, 2020

woody-apple Mar 31, 2020

rwalker-apple Mar 31, 2020

woody-apple Mar 31, 2020

woody-apple commented Mar 31, 2020

hawk248 left a comment

rwalker-apple Mar 31, 2020 •

edited

Loading

Docker development environment #162

Docker development environment #162

Conversation

woody-apple commented Mar 31, 2020

Problem

Summary of Changes

woody-apple commented Mar 31, 2020

rwalker-apple commented Mar 31, 2020

rwalker-apple Mar 31, 2020

Choose a reason for hiding this comment

woody-apple Mar 31, 2020

Choose a reason for hiding this comment

rwalker-apple Mar 31, 2020

Choose a reason for hiding this comment

woody-apple Mar 31, 2020

Choose a reason for hiding this comment

woody-apple commented Mar 31, 2020

hawk248 left a comment

Choose a reason for hiding this comment

rwalker-apple Mar 31, 2020 • edited Loading

Choose a reason for hiding this comment

rwalker-apple Mar 31, 2020 •

edited

Loading