Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't kill a wildcard subscription on Darwin if there is an error for one attribute #15943

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Don't kill a wildcard subscription on Darwin if there is an error for one attribute #15943

merged 1 commit into from
Mar 8, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Instead just report the error to the subscription client.

Problem

Subscription getting torn down because the server failed a specific attribute read.

Change overview

Don't do that. Just tell the client and let them deal.

Testing

Tried a wildcard subscription (as in #15928) to all-clusters-app (which has always-failing attributes) and observed it working fine.

@boring-cyborg boring-cyborg bot added the darwin label Mar 8, 2022
@bzbarsky-apple
Don't kill a wildcard subscription on Darwin if there is an error for
b19afe6 
one attribute.

Instead just report the error to the subscription client.
@bzbarsky-apple bzbarsky-apple force-pushed the dont-kill-subscription-on-one-attr-error branch from f0ec504 to b19afe6 Compare March 8, 2022 02:56
@github-actions
Copy link

github-actions bot commented Mar 8, 2022 •
edited
Loading

PR #15943: Size comparison from bade418 to b19afe6

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bade418 b19afe6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 602062 602062 0 0.0
.app_xip_area 506596 506596 0 0.0
.bss 78148 78148 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 559982 559982 0 0.0
.app_xip_area 466052 466052 0 0.0
.bss 76652 76652 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 582170 582170 0 0.0
.app_xip_area 478560 478560 0 0.0
.bss 85980 85980 0 0.0
.data 592 592 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921196 921196 0 0.0
(read/write) 128848 128848 0 0.0
.bss 126768 126768 0 0.0
.data 2080 2080 0 0.0
.text 921188 921188 0 0.0
BRD4161A+rpc (read only) 950032 950032 0 0.0
(read/write) 144808 144808 0 0.0
.bss 142544 142544 0 0.0
.data 2260 2260 0 0.0
.text 950024 950024 0 0.0
window-app BRD4161A (read only) 854224 854224 0 0.0
(read/write) 126840 126840 0 0.0
.bss 124912 124912 0 0.0
.data 1924 1924 0 0.0
.text 854216 854216 0 0.0
esp32 all-clusters-app c3devkit (read only) 957614 957614 0 0.0
(read/write) 1393658 1393658 0 0.0
.dram0.bss 63432 63432 0 0.0
.dram0.data 14236 14236 0 0.0
.flash.rodata 197072 197072 0 0.0
.flash.text 957614 957614 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1012475 1012475 0 0.0
(read/write) 460764 460764 0 0.0
.dram0.bss 68960 68960 0 0.0
.dram0.data 34080 34080 0 0.0
.flash.rodata 225888 225888 0 0.0
.flash.text 1007091 1007091 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 694956 694956 0 0.0
.bss 77704 77704 0 0.0
.data 1964 1964 0 0.0
.text 609488 609488 0 0.0
lock k32w061+release (read/write) 696560 696560 0 0.0
.bss 77672 77672 0 0.0
.data 1972 1972 0 0.0
.text 611116 611116 0 0.0
linux all-clusters-app debug (read only) 2427697 2427697 0 0.0
(read/write) 145760 145760 0 0.0
.bss 60128 60128 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 78504 78504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205509 205509 0 0.0
.text 2059058 2059058 0 0.0
bridge-app debug+rpc (read only) 1732725 1732725 0 0.0
(read/write) 92720 92720 0 0.0
.bss 47432 47432 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38144 38144 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 141748 141748 0 0.0
.text 1474837 1474837 0 0.0
chip-tool debug (read only) 9761509 9761509 0 0.0
(read/write) 338776 338776 0 0.0
.bss 25544 25544 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 306048 306048 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 510868 510868 0 0.0
.text 8510965 8510965 0 0.0
chip-tool-ipv6only arm64 (read only) 9433156 9433156 0 0.0
(read/write) 454433 454433 0 0.0
.bss 43841 43841 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 351216 351216 0 0.0
.dynamic 560 560 0 0.0
.got 54376 54376 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 486604 486604 0 0.0
.text 7942308 7942308 0 0.0
door-lock-app debug (read only) 1947049 1947049 0 0.0
(read/write) 119136 119136 0 0.0
.bss 50432 50432 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 173660 173660 0 0.0
.text 1624578 1624578 0 0.0
lighting-app debug+rpc (read only) 2079121 2079121 0 0.0
(read/write) 124536 124536 0 0.0
.bss 51296 51296 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 66184 66184 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165852 165852 0 0.0
.text 1757490 1757490 0 0.0
ota-provider-app debug (read only) 1879905 1879905 0 0.0
(read/write) 114768 114768 0 0.0
.bss 50240 50240 0 0.0
.data 1352 1352 0 0.0
.data.rel.ro 57544 57544 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 158899 158899 0 0.0
.text 1570114 1570114 0 0.0
ota-requestor-app debug (read only) 1901905 1901905 0 0.0
(read/write) 117512 117512 0 0.0
.bss 51296 51296 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 59256 59256 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 154188 154188 0 0.0
.text 1597490 1597490 0 0.0
shell debug (read only) 2394481 2394481 0 0.0
(read/write) 149976 149976 0 0.0
.bss 70216 70216 0 0.0
.data 864 864 0 0.0
.data.rel.ro 73232 73232 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205458 205458 0 0.0
.text 2032114 2032114 0 0.0
thermostat-no-ble arm64 (read only) 2175540 2175540 0 0.0
(read/write) 148609 148609 0 0.0
.bss 65201 65201 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 75136 75136 0 0.0
.dynamic 560 560 0 0.0
.got 4224 4224 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 133012 133012 0 0.0
.text 1823904 1823904 0 0.0
tv-app debug (read only) 2620025 2620025 0 0.0
(read/write) 250872 250872 0 0.0
.bss 167936 167936 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73704 73704 0 0.0
.dynamic 592 592 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 199549 199549 0 0.0
.text 2246194 2246194 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2350980 2350980 0 0.0
.bss 186084 186084 0 0.0
.data 5800 5800 0 0.0
.text 1313580 1313580 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151915 1151915 0 0.0
bss 146792 146792 0 0.0
rodata 144340 144340 0 0.0
text 785584 785584 0 0.0
p6 all-clusters-app default (read/write) 2494368 2494368 0 0.0
.bss 119504 119504 0 0.0
.data 2696 2696 0 0.0
.text 1452632 1452632 0 0.0
light-app default (read/write) 2397816 2397816 0 0.0
.bss 112976 112976 0 0.0
.data 2544 2544 0 0.0
.text 1356080 1356080 0 0.0
lock-app default (read/write) 2361248 2361248 0 0.0
.bss 112720 112720 0 0.0
.data 2504 2504 0 0.0
.text 1319512 1319512 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 889050 889050 0 0.0
bss 86928 86928 0 0.0
noinit 37160 37160 0 0.0
text 628374 628374 0 0.0

woody-apple
woody-apple approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fast tracking platform changes.

@woody-apple woody-apple merged commit c07247d into project-chip:master Mar 8, 2022
@bzbarsky-apple bzbarsky-apple deleted the dont-kill-subscription-on-one-attr-error branch March 8, 2022 04:36
mykrupp referenced this pull request in mykrupp/connectedhomeip-1 Mar 8, 2022
@bzbarsky-apple @mykrupp
Don't kill a wildcard subscription on Darwin if there is an error for…
1ce8956 
… (#15943)

one attribute.

Instead just report the error to the subscription client.
This was referenced Mar 8, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
darwin review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bzbarsky-apple @woody-apple