Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLV test uses wrong size on strncmp #15358

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Feb 18, 2022

Problem

TLV test causes a compiler warning because the strncmp size is larger than the given buffer size.

Change overview

Change GetString and strncmp calls to use actual buf size.

Testing

Changes are in a test - tests run.

@github-actions
Copy link

github-actions bot commented Feb 18, 2022

PR #15358: Size comparison from 2353c7d to 3ff6731

Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 2353c7d 3ff6731 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 599310 599310 0 0.0
.app_xip_area 503236 503236 0 0.0
.bss 78772 78772 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 557346 557346 0 0.0
.app_xip_area 462816 462816 0 0.0
.bss 77268 77268 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 578582 578582 0 0.0
.app_xip_area 474628 474628 0 0.0
.bss 86364 86364 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916220 916220 0 0.0
(read/write) 129508 129508 0 0.0
.bss 127472 127472 0 0.0
.data 2036 2036 0 0.0
.text 916212 916212 0 0.0
BRD4161A+rpc (read only) 944928 944928 0 0.0
(read/write) 146424 146424 0 0.0
.bss 144248 144248 0 0.0
.data 2176 2176 0 0.0
.text 944920 944920 0 0.0
window-app BRD4161A (read only) 850044 850044 0 0.0
(read/write) 127424 127424 0 0.0
.bss 125520 125520 0 0.0
.data 1904 1904 0 0.0
.text 850036 850036 0 0.0
esp32 all-clusters-app c3devkit (read only) 950408 950408 0 0.0
(read/write) 1400290 1400290 0 0.0
.dram0.bss 67144 67144 0 0.0
.dram0.data 14156 14156 0 0.0
.flash.rodata 200088 200088 0 0.0
.flash.text 950408 950408 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 999903 999903 0 0.0
(read/write) 465560 465560 0 0.0
.dram0.bss 72296 72296 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227072 227072 0 0.0
.flash.text 994519 994519 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 692492 692492 0 0.0
.bss 78392 78392 0 0.0
.data 1912 1912 0 0.0
.text 606388 606388 0 0.0
lock k32w061+release (read/write) 695040 695040 0 0.0
.bss 78608 78608 0 0.0
.data 1952 1952 0 0.0
.text 608680 608680 0 0.0
linux all-clusters-app debug (read only) 2386393 2386393 0 0.0
(read/write) 149696 149696 0 0.0
.bss 64032 64032 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78632 78632 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206949 206949 0 0.0
.text 2015906 2015906 0 0.0
bridge-app debug+rpc (read only) 1734973 1734973 0 0.0
(read/write) 94840 94840 0 0.0
.bss 49312 49312 0 0.0
.data 2010 2010 0 0.0
.data.rel.ro 38376 38376 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 142644 142644 0 0.0
.text 1475493 1475493 0 0.0
chip-tool debug (read only) 9031717 9031717 0 0.0
(read/write) 320176 320176 0 0.0
.bss 40728 40728 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 272232 272232 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 476725 476725 0 0.0
.text 7895397 7895397 0 0.0
chip-tool-ipv6only arm64 (read only) 8753260 8753260 0 0.0
(read/write) 432193 432193 0 0.0
.bss 58977 58977 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 317488 317488 0 0.0
.dynamic 560 560 0 0.0
.got 50720 50720 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 453140 453140 0 0.0
.text 7386804 7386804 0 0.0
door-lock-app debug (read only) 1947505 1947505 0 0.0
(read/write) 120904 120904 0 0.0
.bss 52000 52000 0 0.0
.data 986 986 0 0.0
.data.rel.ro 62496 62496 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 174172 174172 0 0.0
.text 1623826 1623826 0 0.0
lighting-app debug+rpc (read only) 2073969 2073969 0 0.0
(read/write) 125880 125880 0 0.0
.bss 52992 52992 0 0.0
.data 1376 1376 0 0.0
.data.rel.ro 65984 65984 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166737 166737 0 0.0
.text 1751586 1751586 0 0.0
ota-provider-app debug (read only) 1880873 1880873 0 0.0
(read/write) 116568 116568 0 0.0
.bss 51872 51872 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57816 57816 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 159003 159003 0 0.0
.text 1570258 1570258 0 0.0
ota-requestor-app debug (read only) 1893905 1893905 0 0.0
(read/write) 117952 117952 0 0.0
.bss 52288 52288 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 59080 59080 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153388 153388 0 0.0
.text 1590578 1590578 0 0.0
shell debug (read only) 2361265 2361265 0 0.0
(read/write) 152112 152112 0 0.0
.bss 72384 72384 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73216 73216 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207986 207986 0 0.0
.text 1995874 1995874 0 0.0
thermostat-no-ble arm64 (read only) 2167740 2167740 0 0.0
(read/write) 151137 151137 0 0.0
.bss 67521 67521 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75384 75384 0 0.0
.dynamic 560 560 0 0.0
.got 4216 4216 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 134060 134060 0 0.0
.text 1814240 1814240 0 0.0
tv-app debug (read only) 2543385 2543385 0 0.0
(read/write) 152064 152064 0 0.0
.bss 69248 69248 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73576 73576 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 199117 199117 0 0.0
.text 2169922 2169922 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2430660 2430660 0 0.0
.bss 194564 194564 0 0.0
.data 5328 5328 0 0.0
.text 1393232 1393232 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2392780 2392780 0 0.0
.bss 188432 188432 0 0.0
.data 5632 5632 0 0.0
.text 1355352 1355352 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2328224 2328224 0 0.0
.bss 187432 187432 0 0.0
.data 5608 5608 0 0.0
.text 1290824 1290824 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2319124 2319124 0 0.0
.bss 185980 185980 0 0.0
.data 5440 5440 0 0.0
.text 1281696 1281696 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1023355 1023355 0 0.0
bss 123532 123532 0 0.0
rodata 120904 120904 0 0.0
text 699908 699908 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 992667 992667 0 0.0
bss 120720 120720 0 0.0
rodata 112448 112448 0 0.0
text 679812 679812 0 0.0
nrf52840dongle_nrf52840 (read/write) 1038111 1038111 0 0.0
bss 124752 124752 0 0.0
rodata 119736 119736 0 0.0
text 703720 703720 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929966 929966 0 0.0
bss 120092 120092 0 0.0
rodata 114160 114160 0 0.0
text 614936 614936 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 952119 952119 0 0.0
bss 121760 121760 0 0.0
rodata 109740 109740 0 0.0
text 642024 642024 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 859598 859598 0 0.0
bss 118352 118352 0 0.0
rodata 102912 102912 0 0.0
text 557828 557828 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 950695 950695 0 0.0
bss 121480 121480 0 0.0
rodata 108692 108692 0 0.0
text 641844 641844 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 946659 946659 0 0.0
bss 121484 121484 0 0.0
rodata 108392 108392 0 0.0
text 638084 638084 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811335 811335 0 0.0
bss 113328 113328 0 0.0
rodata 79676 79676 0 0.0
text 540684 540684 0 0.0
p6 all-clusters-app default (read/write) 2489048 2489048 0 0.0
.bss 122872 122872 0 0.0
.data 2672 2672 0 0.0
.text 1447312 1447312 0 0.0
light-app default (read/write) 2394600 2394600 0 0.0
.bss 113896 113896 0 0.0
.data 2528 2528 0 0.0
.text 1352864 1352864 0 0.0
lock-app default (read/write) 2358176 2358176 0 0.0
.bss 113648 113648 0 0.0
.data 2488 2488 0 0.0
.text 1316440 1316440 0 0.0
qpg lighting-app qpg6105+debug (read only) 600132 600132 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90952 90952 0 0.0
.data 1112 1112 0 0.0
.text 594812 594812 0 0.0
lock-app qpg6105+debug (read only) 565900 565900 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90960 90960 0 0.0
.data 1064 1064 0 0.0
.text 560580 560580 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 878750 878750 0 0.0
bss 87504 87504 0 0.0
noinit 37160 37160 0 0.0
text 618916 618916 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking test

@woody-apple woody-apple merged commit b82add6 into project-chip:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants