Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESP32: Maximum length of NVS key should be 15 characters #15240

Merged
merged 4 commits into from
Feb 17, 2022
Merged

ESP32: Maximum length of NVS key should be 15 characters #15240

merged 4 commits into from
Feb 17, 2022

Conversation

jadhavrohit924
Copy link
Contributor

@jadhavrohit924 jadhavrohit924 commented Feb 16, 2022 •
edited
Loading

Problem

  • Length of kConfigKey_RegulatoryLocation's name was more than 15 characters.

Change overview
Maximum length of key name should be 15 characters

Testing
Before the fix we were not able to read the parameter, with the fix we can

@dhrishi dhrishi changed the title Maximum length of key name should be 15 characters ESP32: Maximum length of NVS key should be 15 characters Feb 16, 2022
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15240: Size comparison from d671a52 to 47e390f

Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section d671a52 47e390f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594282 594282 0 0.0
.app_xip_area 499880 499880 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552226 552226 0 0.0
.app_xip_area 459392 459392 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573322 573322 0 0.0
.app_xip_area 471056 471056 0 0.0
.bss 84676 84676 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 912724 912724 0 0.0
(read/write) 127432 127432 0 0.0
.bss 125400 125400 0 0.0
.data 2032 2032 0 0.0
.text 912716 912716 0 0.0
BRD4161A+rpc (read only) 941448 941448 0 0.0
(read/write) 144352 144352 0 0.0
.bss 142176 142176 0 0.0
.data 2172 2172 0 0.0
.text 941440 941440 0 0.0
window-app BRD4161A (read only) 846576 846576 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846568 846568 0 0.0
esp32 all-clusters-app c3devkit (read only) 946454 946454 0 0.0
(read/write) 1398818 1398818 0 0.0
.dram0.bss 66208 66208 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199448 199448 0 0.0
.flash.text 946454 946454 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 996279 996279 0 0.0
(read/write) 464080 464080 0 0.0
.dram0.bss 71344 71344 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226544 226544 0 0.0
.flash.text 990895 990895 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 688312 688312 0 0.0
.bss 76712 76712 0 0.0
.data 1908 1908 0 0.0
.text 603892 603892 0 0.0
lock k32w061+release (read/write) 690928 690928 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 606252 606252 0 0.0
linux all-clusters-app debug (read only) 2367177 2367177 0 0.0
(read/write) 142144 142144 0 0.0
.bss 56480 56480 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 206245 206245 0 0.0
.text 1998274 1998274 0 0.0
bridge-app debug+rpc (read only) 1728589 1728589 0 0.0
(read/write) 85672 85672 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141964 141964 0 0.0
.text 1470005 1470005 0 0.0
chip-tool debug (read only) 8575653 8575653 0 0.0
(read/write) 245952 245952 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4792 4792 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459637 459637 0 0.0
.text 7599525 7599525 0 0.0
chip-tool-ipv6only arm64 (read only) 8328468 8328468 0 0.0
(read/write) 353745 353745 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49256 49256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435500 435500 0 0.0
.text 7130292 7130292 0 0.0
door-lock-app debug (read only) 1933889 1933889 0 0.0
(read/write) 111576 111576 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173426 173426 0 0.0
.text 1611874 1611874 0 0.0
lighting-app debug+rpc (read only) 2060113 2060113 0 0.0
(read/write) 116920 116920 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166033 166033 0 0.0
.text 1739266 1739266 0 0.0
ota-provider-app debug (read only) 1867321 1867321 0 0.0
(read/write) 107320 107320 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 158283 158283 0 0.0
.text 1558354 1558354 0 0.0
ota-requestor-app debug (read only) 1880425 1880425 0 0.0
(read/write) 108736 108736 0 0.0
.bss 43392 43392 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 153052 153052 0 0.0
.text 1578194 1578194 0 0.0
shell debug (read only) 2346313 2346313 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64832 64832 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 207090 207090 0 0.0
.text 1982418 1982418 0 0.0
thermostat-no-ble arm64 (read only) 2153276 2153276 0 0.0
(read/write) 141825 141825 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133052 133052 0 0.0
.text 1801920 1801920 0 0.0
tv-app debug (read only) 2531385 2531385 0 0.0
(read/write) 142560 142560 0 0.0
.bss 60320 60320 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197765 197765 0 0.0
.text 2160578 2160578 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427148 2427148 0 0.0
.bss 189252 189252 0 0.0
.data 5328 5328 0 0.0
.text 1389720 1389720 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390284 2390284 0 0.0
.bss 181784 181784 0 0.0
.data 5624 5624 0 0.0
.text 1352856 1352856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2325728 2325728 0 0.0
.bss 180760 180760 0 0.0
.data 5600 5600 0 0.0
.text 1288328 1288328 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316556 2316556 0 0.0
.bss 179308 179308 0 0.0
.data 5432 5432 0 0.0
.text 1279128 1279128 0 0.0
p6 all-clusters-app default (read/write) 2484408 2484408 0 0.0
.bss 117568 117568 0 0.0
.data 2672 2672 0 0.0
.text 1442672 1442672 0 0.0
light-app default (read/write) 2391288 2391288 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349552 1349552 0 0.0
lock-app default (read/write) 2354752 2354752 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1313016 1313016 0 0.0
qpg lighting-app qpg6105+debug (read only) 597492 597492 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89072 89072 0 0.0
.data 1108 1108 0 0.0
.text 592172 592172 0 0.0
lock-app qpg6105+debug (read only) 563116 563116 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89056 89056 0 0.0
.data 1060 1060 0 0.0
.text 557796 557796 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877166 877166 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616816 616816 0 0.0

@restyled-io restyled-io bot mentioned this pull request Feb 16, 2022
Closed
@github-actions
Copy link

github-actions bot commented Feb 16, 2022 •
edited
Loading

PR #15240: Size comparison from 6103a69 to 4d166e9

Increases above 0.2%:

platform target config section 6103a69 4d166e9 change % change
esp32 all-clusters-app c3devkit .dram0.bss 66208 66416 208 0.3
m5stack .dram0.bss 71344 71552 208 0.3
Increases (2 builds for esp32)
platform target config section 6103a69 4d166e9 change % change
esp32 all-clusters-app c3devkit (read only) 946454 947078 624 0.1
(read/write) 1398818 1398922 104 0.0
.dram0.bss 66208 66416 208 0.3
.flash.rodata 199448 199456 8 0.0
.flash.text 946454 947078 624 0.1
m5stack (read only) 996279 996711 432 0.0
(read/write) 464080 464172 92 0.0
.dram0.bss 71344 71552 208 0.3
.flash.text 990895 991327 432 0.0
Decreases (2 builds for esp32)
platform target config section 6103a69 4d166e9 change % change
esp32 all-clusters-app c3devkit .dram0.data 14268 14156 -112 -0.8
m5stack .flash.rodata 226544 226428 -116 -0.1
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6103a69 4d166e9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 594282 594282 0 0.0
.app_xip_area 499880 499880 0 0.0
.bss 77100 77100 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 552226 552226 0 0.0
.app_xip_area 459392 459392 0 0.0
.bss 75572 75572 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573322 573322 0 0.0
.app_xip_area 471056 471056 0 0.0
.bss 84676 84676 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 912724 912724 0 0.0
(read/write) 127432 127432 0 0.0
.bss 125400 125400 0 0.0
.data 2032 2032 0 0.0
.text 912716 912716 0 0.0
BRD4161A+rpc (read only) 941448 941448 0 0.0
(read/write) 144352 144352 0 0.0
.bss 142176 142176 0 0.0
.data 2172 2172 0 0.0
.text 941440 941440 0 0.0
window-app BRD4161A (read only) 846576 846576 0 0.0
(read/write) 125328 125328 0 0.0
.bss 123424 123424 0 0.0
.data 1900 1900 0 0.0
.text 846568 846568 0 0.0
esp32 all-clusters-app c3devkit (read only) 946454 947078 624 0.1
(read/write) 1398818 1398922 104 0.0
.dram0.bss 66208 66416 208 0.3
.dram0.data 14268 14156 -112 -0.8
.flash.rodata 199448 199456 8 0.0
.flash.text 946454 947078 624 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 996279 996711 432 0.0
(read/write) 464080 464172 92 0.0
.dram0.bss 71344 71552 208 0.3
.dram0.data 34064 34064 0 0.0
.flash.rodata 226544 226428 -116 -0.1
.flash.text 990895 991327 432 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 688312 688312 0 0.0
.bss 76712 76712 0 0.0
.data 1908 1908 0 0.0
.text 603892 603892 0 0.0
lock k32w061+release (read/write) 690928 690928 0 0.0
.bss 76928 76928 0 0.0
.data 1948 1948 0 0.0
.text 606252 606252 0 0.0
linux all-clusters-app debug (read only) 2370817 2370817 0 0.0
(read/write) 142176 142176 0 0.0
.bss 56480 56480 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 78664 78664 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205957 205957 0 0.0
.text 2001922 2001922 0 0.0
bridge-app debug+rpc (read only) 1725901 1725901 0 0.0
(read/write) 85640 85640 0 0.0
.bss 40400 40400 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141836 141836 0 0.0
.text 1467733 1467733 0 0.0
chip-tool debug (read only) 8574629 8574629 0 0.0
(read/write) 245920 245920 0 0.0
.bss 31816 31816 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206896 206896 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 459477 459477 0 0.0
.text 7598741 7598741 0 0.0
chip-tool-ipv6only arm64 (read only) 8327764 8327764 0 0.0
(read/write) 353713 353713 0 0.0
.bss 50113 50113 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249344 249344 0 0.0
.dynamic 560 560 0 0.0
.got 49256 49256 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 435468 435468 0 0.0
.text 7129700 7129700 0 0.0
door-lock-app debug (read only) 1937569 1937569 0 0.0
(read/write) 111608 111608 0 0.0
.bss 43088 43088 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62080 62080 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173138 173138 0 0.0
.text 1615570 1615570 0 0.0
lighting-app debug+rpc (read only) 2063833 2063833 0 0.0
(read/write) 116952 116952 0 0.0
.bss 44192 44192 0 0.0
.data 1400 1400 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 165777 165777 0 0.0
.text 1742962 1742962 0 0.0
ota-provider-app debug (read only) 1870993 1870993 0 0.0
(read/write) 107352 107352 0 0.0
.bss 42976 42976 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57480 57480 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157995 157995 0 0.0
.text 1562034 1562034 0 0.0
ota-requestor-app debug (read only) 1884129 1884129 0 0.0
(read/write) 108768 108768 0 0.0
.bss 43392 43392 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58744 58744 0 0.0
.dynamic 592 592 0 0.0
.got 4200 4200 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 152796 152796 0 0.0
.text 1581874 1581874 0 0.0
shell debug (read only) 2345513 2345513 0 0.0
(read/write) 144560 144560 0 0.0
.bss 64832 64832 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73224 73224 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206962 206962 0 0.0
.text 1981746 1981746 0 0.0
thermostat-no-ble arm64 (read only) 2157660 2157660 0 0.0
(read/write) 141841 141841 0 0.0
.bss 58641 58641 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75000 75000 0 0.0
.dynamic 560 560 0 0.0
.got 4192 4192 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 133244 133244 0 0.0
.text 1805888 1805888 0 0.0
tv-app debug (read only) 2532761 2532761 0 0.0
(read/write) 142592 142592 0 0.0
.bss 60320 60320 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 73008 73008 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 197925 197925 0 0.0
.text 2161522 2161522 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2427148 2427148 0 0.0
.bss 189252 189252 0 0.0
.data 5328 5328 0 0.0
.text 1389720 1389720 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2390284 2390284 0 0.0
.bss 181784 181784 0 0.0
.data 5624 5624 0 0.0
.text 1352856 1352856 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2325728 2325728 0 0.0
.bss 180760 180760 0 0.0
.data 5600 5600 0 0.0
.text 1288328 1288328 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316556 2316556 0 0.0
.bss 179308 179308 0 0.0
.data 5432 5432 0 0.0
.text 1279128 1279128 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1018755 1018755 0 0.0
bss 121460 121460 0 0.0
rodata 120368 120368 0 0.0
text 698024 698024 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 988051 988051 0 0.0
bss 118648 118648 0 0.0
rodata 111896 111896 0 0.0
text 677924 677924 0 0.0
nrf52840dongle_nrf52840 (read/write) 1033703 1033703 0 0.0
bss 122680 122680 0 0.0
rodata 119184 119184 0 0.0
text 701916 701916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 925462 925462 0 0.0
bss 118024 118024 0 0.0
rodata 113608 113608 0 0.0
text 613040 613040 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 947459 947459 0 0.0
bss 119664 119664 0 0.0
rodata 109064 109064 0 0.0
text 640216 640216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 854986 854986 0 0.0
bss 116256 116256 0 0.0
rodata 102236 102236 0 0.0
text 556008 556008 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 946035 946035 0 0.0
bss 119384 119384 0 0.0
rodata 108016 108016 0 0.0
text 640036 640036 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 941999 941999 0 0.0
bss 119388 119388 0 0.0
rodata 107716 107716 0 0.0
text 636276 636276 0 0.0
shell nrf52840dk_nrf52840 (read/write) 807447 807447 0 0.0
bss 111236 111236 0 0.0
rodata 79132 79132 0 0.0
text 539384 539384 0 0.0
p6 all-clusters-app default (read/write) 2484408 2484408 0 0.0
.bss 117568 117568 0 0.0
.data 2672 2672 0 0.0
.text 1442672 1442672 0 0.0
light-app default (read/write) 2391288 2391288 0 0.0
.bss 107248 107248 0 0.0
.data 2520 2520 0 0.0
.text 1349552 1349552 0 0.0
lock-app default (read/write) 2354752 2354752 0 0.0
.bss 106976 106976 0 0.0
.data 2480 2480 0 0.0
.text 1313016 1313016 0 0.0
qpg lighting-app qpg6105+debug (read only) 597492 597492 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89072 89072 0 0.0
.data 1108 1108 0 0.0
.text 592172 592172 0 0.0
lock-app qpg6105+debug (read only) 563116 563116 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89056 89056 0 0.0
.data 1060 1060 0 0.0
.text 557796 557796 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877166 877166 0 0.0
bss 88600 88600 0 0.0
noinit 37160 37160 0 0.0
text 616816 616816 0 0.0

@shubhamdp
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Feb 17, 2022 •
edited
Loading

PR #15240: Size comparison from b03bc9f to 6005d4d

Increases above 0.2%:

platform target config section b03bc9f 6005d4d change % change
esp32 all-clusters-app c3devkit .dram0.bss 68296 68504 208 0.3
m5stack .dram0.bss 73432 73640 208 0.3
Increases (2 builds for esp32)
platform target config section b03bc9f 6005d4d change % change
esp32 all-clusters-app c3devkit (read only) 947906 948530 624 0.1
(read/write) 1401178 1401266 88 0.0
.dram0.bss 68296 68504 208 0.3
.flash.text 947906 948530 624 0.1
m5stack (read only) 997671 998091 420 0.0
(read/write) 466420 466512 92 0.0
.dram0.bss 73432 73640 208 0.3
.flash.text 992287 992707 420 0.0
Decreases (2 builds for esp32)
platform target config section b03bc9f 6005d4d change % change
esp32 all-clusters-app c3devkit .dram0.data 14268 14156 -112 -0.8
.flash.rodata 199712 199704 -8 -0.0
m5stack .flash.rodata 226796 226680 -116 -0.1
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b03bc9f 6005d4d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 597578 597578 0 0.0
.app_xip_area 501496 501496 0 0.0
.bss 78780 78780 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 555526 555526 0 0.0
.app_xip_area 461012 461012 0 0.0
.bss 77252 77252 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 576630 576630 0 0.0
.app_xip_area 472684 472684 0 0.0
.bss 86356 86356 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914580 914580 0 0.0
(read/write) 129524 129524 0 0.0
.bss 127488 127488 0 0.0
.data 2036 2036 0 0.0
.text 914572 914572 0 0.0
BRD4161A+rpc (read only) 943272 943272 0 0.0
(read/write) 146440 146440 0 0.0
.bss 144264 144264 0 0.0
.data 2176 2176 0 0.0
.text 943264 943264 0 0.0
window-app BRD4161A (read only) 848440 848440 0 0.0
(read/write) 127416 127416 0 0.0
.bss 125512 125512 0 0.0
.data 1904 1904 0 0.0
.text 848432 848432 0 0.0
esp32 all-clusters-app c3devkit (read only) 947906 948530 624 0.1
(read/write) 1401178 1401266 88 0.0
.dram0.bss 68296 68504 208 0.3
.dram0.data 14268 14156 -112 -0.8
.flash.rodata 199712 199704 -8 -0.0
.flash.text 947906 948530 624 0.1
.iram0.text 62056 62056 0 0.0
m5stack (read only) 997671 998091 420 0.0
(read/write) 466420 466512 92 0.0
.dram0.bss 73432 73640 208 0.3
.dram0.data 34064 34064 0 0.0
.flash.rodata 226796 226680 -116 -0.1
.flash.text 992287 992707 420 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691596 691596 0 0.0
.bss 78384 78384 0 0.0
.data 1912 1912 0 0.0
.text 605500 605500 0 0.0
lock k32w061+release (read/write) 694228 694228 0 0.0
.bss 78600 78600 0 0.0
.data 1952 1952 0 0.0
.text 607876 607876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8333284 8333284 0 0.0
(read/write) 362609 362609 0 0.0
.bss 58961 58961 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 249368 249368 0 0.0
.dynamic 560 560 0 0.0
.got 49272 49272 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 435820 435820 0 0.0
.text 7134772 7134772 0 0.0
thermostat-no-ble arm64 (read only) 2163132 2163132 0 0.0
(read/write) 150737 150737 0 0.0
.bss 67489 67489 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 75024 75024 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 133596 133596 0 0.0
.text 1810912 1810912 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2428700 2428700 0 0.0
.bss 195916 195916 0 0.0
.data 5328 5328 0 0.0
.text 1391272 1391272 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2391900 2391900 0 0.0
.bss 188448 188448 0 0.0
.data 5632 5632 0 0.0
.text 1354472 1354472 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327344 2327344 0 0.0
.bss 187424 187424 0 0.0
.data 5608 5608 0 0.0
.text 1289944 1289944 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2318108 2318108 0 0.0
.bss 185972 185972 0 0.0
.data 5440 5440 0 0.0
.text 1280680 1280680 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022539 1022539 0 0.0
bss 123548 123548 0 0.0
rodata 120664 120664 0 0.0
text 699328 699328 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991835 991835 0 0.0
bss 120736 120736 0 0.0
rodata 112192 112192 0 0.0
text 679228 679228 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037359 1037359 0 0.0
bss 124768 124768 0 0.0
rodata 119480 119480 0 0.0
text 703216 703216 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 929154 929154 0 0.0
bss 120112 120112 0 0.0
rodata 113908 113908 0 0.0
text 614340 614340 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951243 951243 0 0.0
bss 121752 121752 0 0.0
rodata 109360 109360 0 0.0
text 641516 641516 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858706 858706 0 0.0
bss 118344 118344 0 0.0
rodata 102532 102532 0 0.0
text 557308 557308 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527595 527595 0 0.0
bss 53632 53632 0 0.0
rodata 49976 49976 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949695 949695 0 0.0
bss 121472 121472 0 0.0
rodata 108316 108316 0 0.0
text 641336 641336 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945767 945767 0 0.0
bss 121476 121476 0 0.0
rodata 108012 108012 0 0.0
text 637576 637576 0 0.0
shell nrf52840dk_nrf52840 (read/write) 810767 810767 0 0.0
bss 113324 113324 0 0.0
rodata 79348 79348 0 0.0
text 540444 540444 0 0.0
p6 all-clusters-app default (read/write) 2486304 2486304 0 0.0
.bss 124232 124232 0 0.0
.data 2672 2672 0 0.0
.text 1444568 1444568 0 0.0
light-app default (read/write) 2393192 2393192 0 0.0
.bss 113912 113912 0 0.0
.data 2528 2528 0 0.0
.text 1351456 1351456 0 0.0
lock-app default (read/write) 2356656 2356656 0 0.0
.bss 113640 113640 0 0.0
.data 2488 2488 0 0.0
.text 1314920 1314920 0 0.0
qpg lighting-app qpg6105+debug (read only) 599068 599068 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90744 90744 0 0.0
.data 1112 1112 0 0.0
.text 593748 593748 0 0.0
lock-app qpg6105+debug (read only) 564700 564700 0 0.0
(read/write) 146940 146940 0 0.0
.bss 90728 90728 0 0.0
.data 1064 1064 0 0.0
.text 559380 559380 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877890 877890 0 0.0
bss 87520 87520 0 0.0
noinit 37160 37160 0 0.0
text 618302 618302 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 18a6458 into project-chip:master Feb 17, 2022
@jadhavrohit924 jadhavrohit924 mentioned this pull request Mar 22, 2022
Merged
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@jadhavrohit924 @restyled-commits @fuxingguo16
ESP32: Maximum length of NVS key should be 15 characters (project-chi…
5cd2a6b 
…p#15240)

* Maximum length of key name should be 15 charactors

* Addressed review comment

* Restyled by whitespace

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
@jadhavrohit924 jadhavrohit924 deleted the nvs-storage branch August 16, 2022 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@dhrishi dhrishi dhrishi approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
esp32 platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jadhavrohit924 @shubhamdp @dhrishi @bzbarsky-apple @restyled-commits