Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate dac verification parameters into struct. #15090

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Consolidate dac verification parameters into struct. #15090

merged 3 commits into from
Feb 17, 2022

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Feb 11, 2022

Problem

The function calls are long. Per request in #14845, issue #14758
Fixes #14758

Change overview

Consolidate many args into struct with many args.

Testing

Can still commission, unit test updated in PR

@github-actions
Copy link

github-actions bot commented Feb 11, 2022 •
edited
Loading

PR #15090: Size comparison from 0bd4b85 to 3544e69

Increases (3 builds for linux)
platform target config section 0bd4b85 3544e69 change % change
linux chip-tool debug (read only) 8383997 8384013 16 0.0
.text 7408629 7408645 16 0.0
chip-tool-ipv6only arm64 (read only) 8195452 8195516 64 0.0
.text 6998484 6998548 64 0.0
tv-app debug (read only) 2528953 2528969 16 0.0
.text 2157938 2157954 16 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 0bd4b85 3544e69 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 595258 595258 0 0.0
.app_xip_area 496672 496672 0 0.0
.bss 81284 81284 0 0.0
.data 644 644 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 553062 553062 0 0.0
.app_xip_area 456044 456044 0 0.0
.bss 79756 79756 0 0.0
.data 608 608 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 571998 571998 0 0.0
.app_xip_area 465724 465724 0 0.0
.bss 88684 88684 0 0.0
.data 552 552 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909688 909688 0 0.0
(read/write) 129104 129104 0 0.0
.bss 127072 127072 0 0.0
.data 2032 2032 0 0.0
.text 909680 909680 0 0.0
BRD4161A+rpc (read only) 897132 897132 0 0.0
(read/write) 145764 145764 0 0.0
.bss 143632 143632 0 0.0
.data 2132 2132 0 0.0
.text 897124 897124 0 0.0
window-app BRD4161A (read only) 844752 844752 0 0.0
(read/write) 127168 127168 0 0.0
.bss 125264 125264 0 0.0
.data 1900 1900 0 0.0
.text 844744 844744 0 0.0
esp32 all-clusters-app c3devkit (read only) 945558 945558 0 0.0
(read/write) 1400402 1400402 0 0.0
.dram0.bss 68128 68128 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 199112 199112 0 0.0
.flash.text 945558 945558 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 995227 995227 0 0.0
(read/write) 465680 465680 0 0.0
.dram0.bss 73272 73272 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 226216 226216 0 0.0
.flash.text 989843 989843 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 685744 685744 0 0.0
.bss 78376 78376 0 0.0
.data 1904 1904 0 0.0
.text 599664 599664 0 0.0
lock k32w061+release (read/write) 691172 691172 0 0.0
.bss 78768 78768 0 0.0
.data 1948 1948 0 0.0
.text 604656 604656 0 0.0
linux all-clusters-app debug (read only) 2356761 2356761 0 0.0
(read/write) 141600 141600 0 0.0
.bss 56128 56128 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 78488 78488 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 205893 205893 0 0.0
.text 1988642 1988642 0 0.0
bridge-app debug+rpc (read only) 1725829 1725829 0 0.0
(read/write) 85768 85768 0 0.0
.bss 40528 40528 0 0.0
.data 2034 2034 0 0.0
.data.rel.ro 38056 38056 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 141740 141740 0 0.0
.text 1467589 1467589 0 0.0
chip-tool debug (read only) 8383997 8384013 16 0.0
(read/write) 246912 246912 0 0.0
.bss 33416 33416 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 206264 206264 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 460021 460021 0 0.0
.text 7408629 7408645 16 0.0
chip-tool-ipv6only arm64 (read only) 8195452 8195516 64 0.0
(read/write) 354385 354385 0 0.0
.bss 51681 51681 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 248680 248680 0 0.0
.dynamic 560 560 0 0.0
.got 49008 49008 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 436132 436132 0 0.0
.text 6998484 6998548 64 0.0
door-lock-app debug (read only) 1930985 1930985 0 0.0
(read/write) 112088 112088 0 0.0
.bss 43600 43600 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 173138 173138 0 0.0
.text 1609378 1609378 0 0.0
lighting-app debug+rpc (read only) 2055273 2055273 0 0.0
(read/write) 117368 117368 0 0.0
.bss 44576 44576 0 0.0
.data 1464 1464 0 0.0
.data.rel.ro 65832 65832 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 166641 166641 0 0.0
.text 1733842 1733842 0 0.0
ota-provider-app debug (read only) 1864529 1864529 0 0.0
(read/write) 107768 107768 0 0.0
.bss 43456 43456 0 0.0
.data 1224 1224 0 0.0
.data.rel.ro 57432 57432 0 0.0
.dynamic 608 608 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 157619 157619 0 0.0
.text 1556370 1556370 0 0.0
ota-requestor-app debug (read only) 1859985 1859985 0 0.0
(read/write) 108856 108856 0 0.0
.bss 43744 43744 0 0.0
.data 1160 1160 0 0.0
.data.rel.ro 58504 58504 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 151300 151300 0 0.0
.text 1559890 1559890 0 0.0
shell debug (read only) 2330553 2330553 0 0.0
(read/write) 144496 144496 0 0.0
.bss 64928 64928 0 0.0
.data 832 832 0 0.0
.data.rel.ro 73040 73040 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 206930 206930 0 0.0
.text 1967202 1967202 0 0.0
thermostat-no-ble arm64 (read only) 2150316 2150316 0 0.0
(read/write) 142225 142225 0 0.0
.bss 59105 59105 0 0.0
.data 1032 1032 0 0.0
.data.rel.ro 74984 74984 0 0.0
.dynamic 560 560 0 0.0
.got 4144 4144 0 0.0
.init 24 24 0 0.0
.init_array 328 328 0 0.0
.rodata 132908 132908 0 0.0
.text 1799264 1799264 0 0.0
tv-app debug (read only) 2528953 2528969 16 0.0
(read/write) 140960 140960 0 0.0
.bss 58752 58752 0 0.0
.data 3200 3200 0 0.0
.data.rel.ro 72984 72984 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 198093 198093 0 0.0
.text 2157938 2157954 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2398352 2398352 0 0.0
.bss 190196 190196 0 0.0
.data 5320 5320 0 0.0
.text 1360952 1360952 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360184 2360184 0 0.0
.bss 182808 182808 0 0.0
.data 5624 5624 0 0.0
.text 1322784 1322784 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323776 2323776 0 0.0
.bss 182696 182696 0 0.0
.data 5600 5600 0 0.0
.text 1286376 1286376 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139648 1139648 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103032 103032 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309204 2309204 0 0.0
.bss 179948 179948 0 0.0
.data 5424 5424 0 0.0
.text 1271776 1271776 0 0.0
p6 all-clusters-app default (read/write) 2484056 2484056 0 0.0
.bss 119816 119816 0 0.0
.data 2672 2672 0 0.0
.text 1442320 1442320 0 0.0
light-app default (read/write) 2390640 2390640 0 0.0
.bss 109464 109464 0 0.0
.data 2520 2520 0 0.0
.text 1348904 1348904 0 0.0
lock-app default (read/write) 2354096 2354096 0 0.0
.bss 109184 109184 0 0.0
.data 2480 2480 0 0.0
.text 1312360 1312360 0 0.0
qpg lighting-app qpg6105+debug (read only) 595636 595636 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90656 90656 0 0.0
.data 1108 1108 0 0.0
.text 590316 590316 0 0.0
lock-app qpg6105+debug (read only) 561388 561388 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90640 90640 0 0.0
.data 1060 1060 0 0.0
.text 556068 556068 0 0.0
persistent-storage-app qpg6105+debug (read only) 99520 99520 0 0.0
(read/write) 146940 146940 0 0.0
.bss 24004 24004 0 0.0
.data 176 176 0 0.0
.text 94200 94200 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 877134 877134 0 0.0
bss 90456 90456 0 0.0
noinit 37160 37160 0 0.0
text 615198 615198 0 0.0

@cecille cecille marked this pull request as draft February 11, 2022 17:15
@cecille cecille marked this pull request as ready for review February 16, 2022 14:23
@bzbarsky-apple bzbarsky-apple merged commit b541dee into project-chip:master Feb 17, 2022
@cecille cecille deleted the consolidate_dac_verification_parameters branch February 18, 2022 19:33
jamesluo11 pushed a commit to jamesluo11/connectedhomeip that referenced this pull request Apr 26, 2022
@cecille @fuxingguo16
Consolidate dac verification parameters into struct. (project-chip#15090
abebb45 
)

* Consolidate dac verification parameters into struct.

Per request in project-chip#14845, issue project-chip#14758

* make struct not use references.

* Fix up some naming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor VerifyAttestationInformation argument list into a struct
3 participants
@cecille @tcarmelveilleux @bzbarsky-apple