-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling Basic Information Cluster in the ota-provider app #14765
Merged
harsha-rajendran
merged 1 commit into
project-chip:master
from
harsha-rajendran:Add-Basic-info-cluster-to-ota-provider
Feb 4, 2022
Merged
Enabling Basic Information Cluster in the ota-provider app #14765
harsha-rajendran
merged 1 commit into
project-chip:master
from
harsha-rajendran:Add-Basic-info-cluster-to-ota-provider
Feb 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
sagar-apple
February 3, 2022 22:40
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
February 3, 2022 22:40
harsha-rajendran
commented
Feb 3, 2022
examples/light-switch-app/light-switch-common/light-switch-app.matter
Outdated
Show resolved
Hide resolved
PR #14765: Size comparison from 792167c to f869728 Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
tcarmelveilleux
approved these changes
Feb 3, 2022
carol-apple
approved these changes
Feb 3, 2022
selissia
approved these changes
Feb 4, 2022
/rebase |
woody-apple
force-pushed
the
Add-Basic-info-cluster-to-ota-provider
branch
from
February 4, 2022 08:07
f869728
to
1b3ab37
Compare
PR #14765: Size comparison from a7d7d8d to 1b3ab37 Increases above 0.2%:
Increases (1 build for linux)
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#14764
Commissioning the ota-provider-app fail, when using the CHIP-tool. Without the Basic Information Cluster enabled, the CHIP-tool fails commissioning after it tries to read the VendorID attribute.
Change overview
Used ZAP tool to enable the Basic Information Cluster in the ota-provider app.
Testing