Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for SPAKE2P Parameters Storage. #14350

Merged
merged 2 commits into from
Jan 29, 2022
Merged

Add Support for SPAKE2P Parameters Storage. #14350

merged 2 commits into from
Jan 29, 2022

Conversation

emargolis
Copy link
Contributor

Problem

Currently only Setup PIN Code storage is supported.
Need to add support for other SPAKE2P parameters storage:
SPAKE2P Iteration Counter
SPAKE2P Salt
SPAKE2P Verifier

Change overview

Added support

Testing

Added unit tests

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14350: Size comparison from 3bd289d to 80fae7e

Increases above 0.2%:

platform target config section 3bd289d 80fae7e change % change
linux thermostat-no-ble arm64 .got 4128 4152 24 0.6
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 98344 98552 208 0.2
shell nrf52840dk_nrf52840 rodata 78288 78496 208 0.3
Increases (23 builds for efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 3bd289d 80fae7e change % change
efr32 lighting-app BRD4161A (read only) 843316 843828 512 0.1
.text 843308 843820 512 0.1
BRD4161A+rpc (read only) 830672 831192 520 0.1
.text 830664 831184 520 0.1
window-app BRD4161A (read only) 815948 816452 504 0.1
.text 815940 816444 504 0.1
k32w light k32w061+release (read/write) 665192 665652 460 0.1
.text 579896 580356 460 0.1
lock k32w061+release (read/write) 666080 666540 460 0.1
.text 580496 580956 460 0.1
linux chip-tool-ipv6only arm64 (read only) 8904716 8906604 1888 0.0
(read/write) 393649 393761 112 0.0
.data.rel.ro 263656 263752 96 0.0
.got 69728 69752 24 0.0
.rodata 542916 543076 160 0.0
.text 7514868 7516244 1376 0.0
thermostat-no-ble arm64 (read only) 2061828 2064324 2496 0.1
(read/write) 148113 148241 128 0.1
.data.rel.ro 73712 73808 96 0.1
.got 4128 4152 24 0.6
.rodata 131428 131684 256 0.2
.text 1714416 1716304 1888 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2355056 2355760 704 0.0
.text 1317656 1318360 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341048 2341688 640 0.0
.text 1303648 1304288 640 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307792 2308496 704 0.0
.text 1270392 1271096 704 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2294060 2294756 696 0.0
.text 1256632 1257328 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 984187 544 0.1
rodata 116480 116688 208 0.2
text 668512 668844 332 0.0
nrf52840dk_nrf52840+rpc (read/write) 967507 968051 544 0.1
rodata 108016 108224 208 0.2
text 663184 663516 332 0.1
nrf52840dongle_nrf52840 (read/write) 999731 1000275 544 0.1
rodata 115332 115540 208 0.2
text 673900 674232 332 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892866 893390 524 0.1
rodata 109780 109984 204 0.2
text 584692 585024 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916227 916767 540 0.1
rodata 105120 105324 204 0.2
text 614460 614792 332 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826790 544 0.1
rodata 98344 98552 208 0.2
text 531412 531744 332 0.1
pump-app nrf52840dk_nrf52840 (read/write) 918883 919427 544 0.1
rodata 105504 105712 208 0.2
text 616924 617256 332 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914611 544 0.1
rodata 104608 104816 208 0.2
text 612956 613288 332 0.1
shell nrf52840dk_nrf52840 (read/write) 798219 798747 528 0.1
rodata 78288 78496 208 0.3
text 533652 533972 320 0.1
qpg lighting-app qpg6105+debug (read only) 571964 572416 452 0.1
.text 566644 567096 452 0.1
lock-app qpg6105+debug (read only) 518060 518504 444 0.1
.text 512740 513184 444 0.1
telink lighting-app tlsr9518adk80d (read/write) 848046 848598 552 0.1
text 592818 593160 342 0.1
Full report (26 builds for efr32, k32w, linux, mbed, nrfconnect, qpg, telink)
platform target config section 3bd289d 80fae7e change % change
efr32 lighting-app BRD4161A (read only) 843316 843828 512 0.1
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843308 843820 512 0.1
BRD4161A+rpc (read only) 830672 831192 520 0.1
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830664 831184 520 0.1
window-app BRD4161A (read only) 815948 816452 504 0.1
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 815940 816444 504 0.1
k32w light k32w061+release (read/write) 665192 665652 460 0.1
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579896 580356 460 0.1
lock k32w061+release (read/write) 666080 666540 460 0.1
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580496 580956 460 0.1
linux chip-tool-ipv6only arm64 (read only) 8904716 8906604 1888 0.0
(read/write) 393649 393761 112 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 263656 263752 96 0.0
.dynamic 560 560 0 0.0
.got 69728 69752 24 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 542916 543076 160 0.0
.text 7514868 7516244 1376 0.0
thermostat-no-ble arm64 (read only) 2061828 2064324 2496 0.1
(read/write) 148113 148241 128 0.1
.bss 66417 66417 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73712 73808 96 0.1
.dynamic 560 560 0 0.0
.got 4128 4152 24 0.6
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131428 131684 256 0.2
.text 1714416 1716304 1888 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355056 2355760 704 0.0
.bss 189580 189580 0 0.0
.data 5296 5296 0 0.0
.text 1317656 1318360 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341048 2341688 640 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303648 1304288 640 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307792 2308496 704 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270392 1271096 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294060 2294756 696 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256632 1257328 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983643 984187 544 0.1
bss 120860 120860 0 0.0
rodata 116480 116688 208 0.2
text 668512 668844 332 0.0
nrf52840dk_nrf52840+rpc (read/write) 967507 968051 544 0.1
bss 117904 117904 0 0.0
rodata 108016 108224 208 0.2
text 663184 663516 332 0.1
nrf52840dongle_nrf52840 (read/write) 999731 1000275 544 0.1
bss 122032 122032 0 0.0
rodata 115332 115540 208 0.2
text 673900 674232 332 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892866 893390 524 0.1
bss 117648 117648 0 0.0
rodata 109780 109984 204 0.2
text 584692 585024 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916227 916767 540 0.1
bss 119240 119240 0 0.0
rodata 105120 105324 204 0.2
text 614460 614792 332 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826246 826790 544 0.1
bss 116056 116056 0 0.0
rodata 98344 98552 208 0.2
text 531412 531744 332 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918883 919427 544 0.1
bss 118984 118984 0 0.0
rodata 105504 105712 208 0.2
text 616924 617256 332 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914067 914611 544 0.1
bss 119012 119012 0 0.0
rodata 104608 104816 208 0.2
text 612956 613288 332 0.1
shell nrf52840dk_nrf52840 (read/write) 798219 798747 528 0.1
bss 109776 109776 0 0.0
rodata 78288 78496 208 0.3
text 533652 533972 320 0.1
qpg lighting-app qpg6105+debug (read only) 571964 572416 452 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566644 567096 452 0.1
lock-app qpg6105+debug (read only) 518060 518504 444 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512740 513184 444 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848046 848598 552 0.1
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592818 593160 342 0.1

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the emargolis/feature/spake-param-storage branch from 80fae7e to 4c18b3c Compare January 27, 2022 03:07
@github-actions
Copy link

PR #14350: Size comparison from 777fec7 to 4c18b3c

Increases above 0.2%:

platform target config section 777fec7 4c18b3c change % change
linux thermostat-no-ble arm64 .got 4128 4152 24 0.6
Increases (5 builds for linux, qpg, telink)
platform target config section 777fec7 4c18b3c change % change
linux chip-tool-ipv6only arm64 (read only) 8934988 8936876 1888 0.0
(read/write) 394817 394945 128 0.0
.data.rel.ro 264536 264632 96 0.0
.got 70024 70048 24 0.0
.rodata 544340 544500 160 0.0
.text 7540980 7542356 1376 0.0
thermostat-no-ble arm64 (read only) 2062772 2065284 2512 0.1
(read/write) 148209 148321 112 0.1
.data.rel.ro 73800 73896 96 0.1
.got 4128 4152 24 0.6
.rodata 131492 131748 256 0.2
.text 1715232 1717120 1888 0.1
qpg lighting-app qpg6105+debug (read only) 572100 572552 452 0.1
.text 566780 567232 452 0.1
lock-app qpg6105+debug (read only) 518180 518624 444 0.1
.text 512860 513304 444 0.1
telink lighting-app tlsr9518adk80d (read/write) 848182 848734 552 0.1
text 592954 593296 342 0.1
Full report (6 builds for linux, qpg, telink)
platform target config section 777fec7 4c18b3c change % change
linux chip-tool-ipv6only arm64 (read only) 8934988 8936876 1888 0.0
(read/write) 394817 394945 128 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264536 264632 96 0.0
.dynamic 560 560 0 0.0
.got 70024 70048 24 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544340 544500 160 0.0
.text 7540980 7542356 1376 0.0
thermostat-no-ble arm64 (read only) 2062772 2065284 2512 0.1
(read/write) 148209 148321 112 0.1
.bss 66417 66417 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73800 73896 96 0.1
.dynamic 560 560 0 0.0
.got 4128 4152 24 0.6
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131492 131748 256 0.2
.text 1715232 1717120 1888 0.1
qpg lighting-app qpg6105+debug (read only) 572100 572552 452 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566780 567232 452 0.1
lock-app qpg6105+debug (read only) 518180 518624 444 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512860 513304 444 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848182 848734 552 0.1
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592954 593296 342 0.1

@emargolis emargolis force-pushed the emargolis/feature/spake-param-storage branch from 4c18b3c to 5977386 Compare January 27, 2022 03:59
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14350: Size comparison from 812f820 to 5977386

Increases above 0.2%:

platform target config section 812f820 5977386 change % change
nrfconnect lock-app nrf5340dk_nrf5340_cpuapp rodata 98344 98552 208 0.2
shell nrf52840dk_nrf52840 rodata 78288 78496 208 0.3
Increases (27 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 812f820 5977386 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580894 452 0.1
.app_xip_area 485336 485788 452 0.1
efr32 lighting-app BRD4161A (read only) 843492 844004 512 0.1
.text 843484 843996 512 0.1
BRD4161A+rpc (read only) 830864 831368 504 0.1
.text 830856 831360 504 0.1
window-app BRD4161A (read only) 816108 816596 488 0.1
.text 816100 816588 488 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923660 362 0.0
(read/write) 1384986 1385210 224 0.0
.dram0.data 14252 14276 24 0.2
.flash.rodata 180936 181128 192 0.1
.flash.text 923298 923660 362 0.0
m5stack (read only) 972227 972575 348 0.0
(read/write) 452016 452224 208 0.0
.flash.rodata 210232 210440 208 0.1
.flash.text 966843 967191 348 0.0
k32w light k32w061+release (read/write) 665224 665684 460 0.1
.text 579928 580388 460 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.text 580608 581068 460 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2357376 2358080 704 0.0
.text 1319976 1320680 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2341728 640 0.0
.text 1303688 1304328 640 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307832 2308536 704 0.0
.text 1270432 1271136 704 0.1
shell CY8CPROTO_062_4343W+release (read/write) 2294036 2294732 696 0.0
.text 1256608 1257304 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 984251 544 0.1
rodata 116480 116688 208 0.2
text 668576 668908 332 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 968115 544 0.1
rodata 108016 108224 208 0.2
text 663248 663580 332 0.1
nrf52840dongle_nrf52840 (read/write) 999827 1000371 544 0.1
rodata 115332 115540 208 0.2
text 674004 674336 332 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893454 524 0.1
rodata 109780 109984 204 0.2
text 584756 585088 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916323 916863 540 0.1
rodata 105120 105324 204 0.2
text 614560 614892 332 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826886 528 0.1
rodata 98344 98552 208 0.2
text 531512 531844 332 0.1
pump-app nrf52840dk_nrf52840 (read/write) 919187 919731 544 0.1
rodata 105632 105840 208 0.2
text 617096 617428 332 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914915 544 0.1
rodata 104736 104944 208 0.2
text 613132 613464 332 0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798731 528 0.1
rodata 78288 78496 208 0.3
text 533640 533960 320 0.1
p6 all-clusters-app default (read/write) 2418240 2419072 832 0.0
.text 1376504 1377336 832 0.1
light-app default (read/write) 2339064 2339904 840 0.0
.text 1297328 1298168 840 0.1
lock-app default (read/write) 2304584 2305408 824 0.0
.text 1262848 1263672 824 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572488 452 0.1
.text 566716 567168 452 0.1
lock-app qpg6105+debug (read only) 518164 518608 444 0.1
.text 512844 513288 444 0.1
telink lighting-app tlsr9518adk80d (read/write) 848158 848710 552 0.1
text 592932 593274 342 0.1
Full report (30 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, qpg, telink)
platform target config section 812f820 5977386 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580442 580894 452 0.1
.app_xip_area 485336 485788 452 0.1
.bss 77852 77852 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 843492 844004 512 0.1
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843996 512 0.1
BRD4161A+rpc (read only) 830864 831368 504 0.1
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 831360 504 0.1
window-app BRD4161A (read only) 816108 816596 488 0.1
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816588 488 0.1
esp32 all-clusters-app c3devkit (read only) 923298 923660 362 0.0
(read/write) 1384986 1385210 224 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14276 24 0.2
.flash.rodata 180936 181128 192 0.1
.flash.text 923298 923660 362 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972227 972575 348 0.0
(read/write) 452016 452224 208 0.0
.dram0.bss 75624 75624 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 210232 210440 208 0.1
.flash.text 966843 967191 348 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665684 460 0.1
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 580388 460 0.1
lock k32w061+release (read/write) 666192 666652 460 0.1
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 581068 460 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357376 2358080 704 0.0
.bss 189588 189588 0 0.0
.data 5296 5296 0 0.0
.text 1319976 1320680 704 0.1
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2341728 640 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303688 1304328 640 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307832 2308536 704 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270432 1271136 704 0.1
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294036 2294732 696 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256608 1257304 696 0.1
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 984251 544 0.1
bss 120860 120860 0 0.0
rodata 116480 116688 208 0.2
text 668576 668908 332 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 968115 544 0.1
bss 117904 117904 0 0.0
rodata 108016 108224 208 0.2
text 663248 663580 332 0.1
nrf52840dongle_nrf52840 (read/write) 999827 1000371 544 0.1
bss 122032 122032 0 0.0
rodata 115332 115540 208 0.2
text 674004 674336 332 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893454 524 0.1
bss 117648 117648 0 0.0
rodata 109780 109984 204 0.2
text 584756 585088 332 0.1
lock-app nrf52840dk_nrf52840 (read/write) 916323 916863 540 0.1
bss 119240 119240 0 0.0
rodata 105120 105324 204 0.2
text 614560 614892 332 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826886 528 0.1
bss 116056 116056 0 0.0
rodata 98344 98552 208 0.2
text 531512 531844 332 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919731 544 0.1
bss 118992 118992 0 0.0
rodata 105632 105840 208 0.2
text 617096 617428 332 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914915 544 0.1
bss 119016 119016 0 0.0
rodata 104736 104944 208 0.2
text 613132 613464 332 0.1
shell nrf52840dk_nrf52840 (read/write) 798203 798731 528 0.1
bss 109776 109776 0 0.0
rodata 78288 78496 208 0.3
text 533640 533960 320 0.1
p6 all-clusters-app default (read/write) 2418240 2419072 832 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1377336 832 0.1
light-app default (read/write) 2339064 2339904 840 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1298168 840 0.1
lock-app default (read/write) 2304584 2305408 824 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1263672 824 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572488 452 0.1
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 567168 452 0.1
lock-app qpg6105+debug (read only) 518164 518608 444 0.1
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 513288 444 0.1
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848158 848710 552 0.1
bss 87640 87640 0 0.0
noinit 37160 37160 0 0.0
text 592932 593274 342 0.1

@emargolis emargolis force-pushed the emargolis/feature/spake-param-storage branch from 5977386 to 5869ca6 Compare January 27, 2022 07:48
@github-actions
Copy link

github-actions bot commented Jan 27, 2022 •
edited
Loading

PR #14350: Size comparison from c62489b to 5869ca6

Increases above 0.2%:

platform target config section c62489b 5869ca6 change % change
esp32 all-clusters-app c3devkit .flash.rodata 180936 181584 648 0.4
m5stack .flash.rodata 210264 210920 656 0.3
linux thermostat-no-ble arm64 .got 4144 4168 24 0.6
.rodata 131940 132580 640 0.5
Increases (28 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c62489b 5869ca6 change % change
efr32 lighting-app BRD4161A (read only) 843492 843724 232 0.0
.text 843484 843716 232 0.0
BRD4161A+rpc (read only) 830864 831096 232 0.0
.text 830856 831088 232 0.0
window-app BRD4161A (read only) 816108 816340 232 0.0
.text 816100 816332 232 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923712 414 0.0
(read/write) 1384986 1385666 680 0.0
.dram0.data 14252 14276 24 0.2
.flash.rodata 180936 181584 648 0.4
.flash.text 923298 923712 414 0.0
m5stack (read only) 972395 972723 328 0.0
(read/write) 450904 451560 656 0.1
.flash.rodata 210264 210920 656 0.3
.flash.text 967011 967339 328 0.0
k32w light k32w061+release (read/write) 665224 665408 184 0.0
.text 579928 580112 184 0.0
lock k32w061+release (read/write) 666192 666376 184 0.0
.text 580608 580792 184 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 8936988 1296 0.0
(read/write) 394801 394913 112 0.0
.data.rel.ro 264512 264608 96 0.0
.got 70024 70048 24 0.0
.rodata 544356 544372 16 0.0
.text 7541700 7542612 912 0.0
thermostat-no-ble arm64 (read only) 2082804 2085268 2464 0.1
(read/write) 150977 151089 112 0.1
.data.rel.ro 74208 74304 96 0.1
.got 4144 4168 24 0.6
.rodata 131940 132580 640 0.5
.text 1733616 1735072 1456 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2357384 2357760 376 0.0
.text 1319984 1320360 376 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2341088 2341464 376 0.0
.text 1303688 1304064 376 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2307840 2308216 376 0.0
.text 1270440 1270816 376 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2294044 2294412 368 0.0
.text 1256616 1256984 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983975 268 0.0
rodata 116480 116556 76 0.1
text 668576 668764 188 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967839 268 0.0
rodata 108016 108092 76 0.1
text 663248 663436 188 0.0
nrf52840dongle_nrf52840 (read/write) 999827 1000095 268 0.0
rodata 115332 115408 76 0.1
text 674004 674192 188 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893178 248 0.0
rodata 109780 109852 72 0.1
text 584756 584944 188 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916587 264 0.0
rodata 105120 105192 72 0.1
text 614560 614748 188 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826610 252 0.0
rodata 98344 98420 76 0.1
text 531512 531700 188 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919455 268 0.0
rodata 105632 105708 76 0.1
text 617096 617284 188 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914639 268 0.0
rodata 104736 104812 76 0.1
text 613132 613320 188 0.0
shell nrf52840dk_nrf52840 (read/write) 798303 798555 252 0.0
rodata 78324 78400 76 0.1
text 534564 534740 176 0.0
p6 all-clusters-app default (read/write) 2418240 2419344 1104 0.0
.text 1376504 1377608 1104 0.1
light-app default (read/write) 2339064 2340176 1112 0.0
.text 1297328 1298440 1112 0.1
lock-app default (read/write) 2304584 2305688 1104 0.0
.text 1262848 1263952 1104 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572212 176 0.0
.text 566716 566892 176 0.0
lock-app qpg6105+debug (read only) 518164 518332 168 0.0
.text 512844 513012 168 0.0
telink lighting-app tlsr9518adk80d (read/write) 848810 849086 276 0.0
text 594022 594222 200 0.0
Full report (31 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c62489b 5869ca6 change % change
efr32 lighting-app BRD4161A (read only) 843492 843724 232 0.0
(read/write) 127396 127396 0 0.0
.bss 125496 125496 0 0.0
.data 1900 1900 0 0.0
.text 843484 843716 232 0.0
BRD4161A+rpc (read only) 830864 831096 232 0.0
(read/write) 144056 144056 0 0.0
.bss 142056 142056 0 0.0
.data 2000 2000 0 0.0
.text 830856 831088 232 0.0
window-app BRD4161A (read only) 816108 816340 232 0.0
(read/write) 126052 126052 0 0.0
.bss 124196 124196 0 0.0
.data 1856 1856 0 0.0
.text 816100 816332 232 0.0
esp32 all-clusters-app c3devkit (read only) 923298 923712 414 0.0
(read/write) 1384986 1385666 680 0.0
.dram0.bss 70880 70880 0 0.0
.dram0.data 14252 14276 24 0.2
.flash.rodata 180936 181584 648 0.4
.flash.text 923298 923712 414 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 972395 972723 328 0.0
(read/write) 450904 451560 656 0.1
.dram0.bss 74480 74480 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 210264 210920 656 0.3
.flash.text 967011 967339 328 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 665224 665408 184 0.0
.bss 77628 77628 0 0.0
.data 1868 1868 0 0.0
.text 579928 580112 184 0.0
lock k32w061+release (read/write) 666192 666376 184 0.0
.bss 77892 77892 0 0.0
.data 1892 1892 0 0.0
.text 580608 580792 184 0.0
linux chip-tool-ipv6only arm64 (read only) 8935692 8936988 1296 0.0
(read/write) 394801 394913 112 0.0
.bss 55377 55377 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 264512 264608 96 0.0
.dynamic 560 560 0 0.0
.got 70024 70048 24 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 544356 544372 16 0.0
.text 7541700 7542612 912 0.0
thermostat-no-ble arm64 (read only) 2082804 2085268 2464 0.1
(read/write) 150977 151089 112 0.1
.bss 68689 68689 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74208 74304 96 0.1
.dynamic 560 560 0 0.0
.got 4144 4168 24 0.6
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131940 132580 640 0.5
.text 1733616 1735072 1456 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357384 2357760 376 0.0
.bss 189588 189588 0 0.0
.data 5296 5296 0 0.0
.text 1319984 1320360 376 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2341088 2341464 376 0.0
.bss 181104 181104 0 0.0
.data 5584 5584 0 0.0
.text 1303688 1304064 376 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307840 2308216 376 0.0
.bss 181000 181000 0 0.0
.data 5568 5568 0 0.0
.text 1270440 1270816 376 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2294044 2294412 368 0.0
.bss 177732 177732 0 0.0
.data 5384 5384 0 0.0
.text 1256616 1256984 368 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983707 983975 268 0.0
bss 120860 120860 0 0.0
rodata 116480 116556 76 0.1
text 668576 668764 188 0.0
nrf52840dk_nrf52840+rpc (read/write) 967571 967839 268 0.0
bss 117904 117904 0 0.0
rodata 108016 108092 76 0.1
text 663248 663436 188 0.0
nrf52840dongle_nrf52840 (read/write) 999827 1000095 268 0.0
bss 122032 122032 0 0.0
rodata 115332 115408 76 0.1
text 674004 674192 188 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892930 893178 248 0.0
bss 117648 117648 0 0.0
rodata 109780 109852 72 0.1
text 584756 584944 188 0.0
lock-app nrf52840dk_nrf52840 (read/write) 916323 916587 264 0.0
bss 119240 119240 0 0.0
rodata 105120 105192 72 0.1
text 614560 614748 188 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826358 826610 252 0.0
bss 116056 116056 0 0.0
rodata 98344 98420 76 0.1
text 531512 531700 188 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 919187 919455 268 0.0
bss 118992 118992 0 0.0
rodata 105632 105708 76 0.1
text 617096 617284 188 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 914371 914639 268 0.0
bss 119016 119016 0 0.0
rodata 104736 104812 76 0.1
text 613132 613320 188 0.0
shell nrf52840dk_nrf52840 (read/write) 798303 798555 252 0.0
bss 108908 108908 0 0.0
rodata 78324 78400 76 0.1
text 534564 534740 176 0.0
p6 all-clusters-app default (read/write) 2418240 2419344 1104 0.0
.bss 117932 117932 0 0.0
.data 2592 2592 0 0.0
.text 1376504 1377608 1104 0.1
light-app default (read/write) 2339064 2340176 1112 0.0
.bss 105684 105684 0 0.0
.data 2408 2408 0 0.0
.text 1297328 1298440 1112 0.1
lock-app default (read/write) 2304584 2305688 1104 0.0
.bss 105428 105428 0 0.0
.data 2360 2360 0 0.0
.text 1262848 1263952 1104 0.1
qpg lighting-app qpg6105+debug (read only) 572036 572212 176 0.0
(read/write) 146936 146936 0 0.0
.bss 89840 89840 0 0.0
.data 1060 1060 0 0.0
.text 566716 566892 176 0.0
lock-app qpg6105+debug (read only) 518164 518332 168 0.0
(read/write) 146940 146940 0 0.0
.bss 89312 89312 0 0.0
.data 992 992 0 0.0
.text 512844 513012 168 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 848810 849086 276 0.0
bss 87164 87164 0 0.0
noinit 37160 37160 0 0.0
text 594022 594222 200 0.0

@emargolis emargolis force-pushed the emargolis/feature/spake-param-storage branch from 5869ca6 to 7b6a65e Compare January 28, 2022 08:55
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #14350: Size comparison from d2fded9 to 7b6a65e

Increases above 0.2%:

platform target config section d2fded9 7b6a65e change % change
esp32 all-clusters-app c3devkit .flash.rodata 194480 195112 632 0.3
m5stack .flash.rodata 221108 221748 640 0.3
linux thermostat-no-ble arm64 .got 4144 4168 24 0.6
.rodata 129932 130572 640 0.5
Increases (30 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d2fded9 7b6a65e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578230 100 0.0
.app_xip_area 484224 484324 100 0.0
lock-app CYW30739 (read/write) 536142 536242 100 0.0
.app_xip_area 443780 443880 100 0.0
efr32 lighting-app BRD4161A (read only) 842984 843128 144 0.0
.text 842976 843120 144 0.0
BRD4161A+rpc (read only) 830336 830488 152 0.0
.text 830328 830480 152 0.0
window-app BRD4161A (read only) 815560 815712 152 0.0
.text 815552 815704 152 0.0
esp32 all-clusters-app c3devkit (read only) 932870 933214 344 0.0
(read/write) 1397322 1397970 648 0.0
.dram0.data 14244 14268 24 0.2
.flash.rodata 194480 195112 632 0.3
.flash.text 932870 933214 344 0.0
m5stack (read only) 980767 981023 256 0.0
(read/write) 461692 462332 640 0.1
.flash.rodata 221108 221748 640 0.3
.flash.text 975383 975639 256 0.0
k32w light k32w061+release (read/write) 662940 663048 108 0.0
.text 578844 578952 108 0.0
lock k32w061+release (read/write) 663844 663952 108 0.0
.text 579460 579568 108 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6766580 960 0.0
(read/write) 279201 279297 96 0.0
.data.rel.ro 175984 176056 72 0.0
.got 42784 42808 24 0.1
.rodata 386892 386924 32 0.0
.text 5806628 5807268 640 0.0
thermostat-no-ble arm64 (read only) 2080620 2082716 2096 0.1
(read/write) 149537 149633 96 0.1
.data.rel.ro 74288 74360 72 0.1
.got 4144 4168 24 0.6
.rodata 129932 130572 640 0.5
.text 1733344 1734512 1168 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2382408 2382704 296 0.0
.text 1345008 1345304 296 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2338200 2338496 296 0.0
.text 1300800 1301096 296 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2302240 2302536 296 0.0
.text 1264840 1265136 296 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2292980 2293276 296 0.0
.text 1255552 1255848 296 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981563 188 0.0
rodata 115684 115744 60 0.1
text 668228 668348 120 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 967099 176 0.0
rodata 107160 107224 64 0.1
text 664672 664788 116 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997635 176 0.0
rodata 114516 114580 64 0.1
text 673656 673776 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890738 192 0.0
rodata 108964 109028 64 0.1
text 584416 584532 116 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 914147 192 0.0
rodata 104320 104384 64 0.1
text 614212 614332 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824198 192 0.0
rodata 97528 97592 64 0.1
text 531172 531288 116 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 917011 192 0.0
rodata 104832 104896 64 0.1
text 616748 616868 120 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912195 192 0.0
rodata 103936 104000 64 0.1
text 612788 612904 116 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798379 176 0.0
rodata 78288 78352 64 0.1
text 533640 533752 112 0.0
p6 all-clusters-app default (read/write) 2441656 2442624 968 0.0
.text 1399920 1400888 968 0.1
light-app default (read/write) 2338568 2339536 968 0.0
.text 1296832 1297800 968 0.1
lock-app default (read/write) 2304080 2305048 968 0.0
.text 1262344 1263312 968 0.1
qpg lighting-app qpg6105+debug (read only) 570884 570992 108 0.0
.text 565564 565672 108 0.0
lock-app qpg6105+debug (read only) 517004 517112 108 0.0
.text 511684 511792 108 0.0
telink lighting-app tlsr9518adk80d (read/write) 845770 845970 200 0.0
text 592508 592644 136 0.0
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d2fded9 7b6a65e change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578130 578230 100 0.0
.app_xip_area 484224 484324 100 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536142 536242 100 0.0
.app_xip_area 443780 443880 100 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842984 843128 144 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842976 843120 144 0.0
BRD4161A+rpc (read only) 830336 830488 152 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830328 830480 152 0.0
window-app BRD4161A (read only) 815560 815712 152 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815552 815704 152 0.0
esp32 all-clusters-app c3devkit (read only) 932870 933214 344 0.0
(read/write) 1397322 1397970 648 0.0
.dram0.bss 69688 69688 0 0.0
.dram0.data 14244 14268 24 0.2
.flash.rodata 194480 195112 632 0.3
.flash.text 932870 933214 344 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 980767 981023 256 0.0
(read/write) 461692 462332 640 0.1
.dram0.bss 74432 74432 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 221108 221748 640 0.3
.flash.text 975383 975639 256 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 662940 663048 108 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578844 578952 108 0.0
lock k32w061+release (read/write) 663844 663952 108 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579460 579568 108 0.0
linux chip-tool-ipv6only arm64 (read only) 6765620 6766580 960 0.0
(read/write) 279201 279297 96 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 175984 176056 72 0.0
.dynamic 560 560 0 0.0
.got 42784 42808 24 0.1
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 386892 386924 32 0.0
.text 5806628 5807268 640 0.0
thermostat-no-ble arm64 (read only) 2080620 2082716 2096 0.1
(read/write) 149537 149633 96 0.1
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74360 72 0.1
.dynamic 560 560 0 0.0
.got 4144 4168 24 0.6
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 130572 640 0.5
.text 1733344 1734512 1168 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2382408 2382704 296 0.0
.bss 188588 188588 0 0.0
.data 5288 5288 0 0.0
.text 1345008 1345304 296 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2338200 2338496 296 0.0
.bss 179304 179304 0 0.0
.data 5584 5584 0 0.0
.text 1300800 1301096 296 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2302240 2302536 296 0.0
.bss 179208 179208 0 0.0
.data 5552 5552 0 0.0
.text 1264840 1265136 296 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292980 2293276 296 0.0
.bss 176532 176532 0 0.0
.data 5384 5384 0 0.0
.text 1255552 1255848 296 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 981375 981563 188 0.0
bss 119660 119660 0 0.0
rodata 115684 115744 60 0.1
text 668228 668348 120 0.0
nrf52840dk_nrf52840+rpc (read/write) 966923 967099 176 0.0
bss 116704 116704 0 0.0
rodata 107160 107224 64 0.1
text 664672 664788 116 0.0
nrf52840dongle_nrf52840 (read/write) 997459 997635 176 0.0
bss 120832 120832 0 0.0
rodata 114516 114580 64 0.1
text 673656 673776 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 890546 890738 192 0.0
bss 116448 116448 0 0.0
rodata 108964 109028 64 0.1
text 584416 584532 116 0.0
lock-app nrf52840dk_nrf52840 (read/write) 913955 914147 192 0.0
bss 118040 118040 0 0.0
rodata 104320 104384 64 0.1
text 614212 614332 120 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824006 824198 192 0.0
bss 114856 114856 0 0.0
rodata 97528 97592 64 0.1
text 531172 531288 116 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 916819 917011 192 0.0
bss 117792 117792 0 0.0
rodata 104832 104896 64 0.1
text 616748 616868 120 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 912003 912195 192 0.0
bss 117816 117816 0 0.0
rodata 103936 104000 64 0.1
text 612788 612904 116 0.0
shell nrf52840dk_nrf52840 (read/write) 798203 798379 176 0.0
bss 109776 109776 0 0.0
rodata 78288 78352 64 0.1
text 533640 533752 112 0.0
p6 all-clusters-app default (read/write) 2441656 2442624 968 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1399920 1400888 968 0.1
light-app default (read/write) 2338568 2339536 968 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296832 1297800 968 0.1
lock-app default (read/write) 2304080 2305048 968 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1263312 968 0.1
qpg lighting-app qpg6105+debug (read only) 570884 570992 108 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565564 565672 108 0.0
lock-app qpg6105+debug (read only) 517004 517112 108 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511684 511792 108 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845770 845970 200 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592508 592644 136 0.0

@emargolis
Add Support for SPAKE2P Parameters Storage.
274e4e1
@emargolis
Addressed review comments:
d8257c4 
  * Removed Spake2p paramantes setters. The factory provisioning
    process will use different APIs.
@emargolis emargolis force-pushed the emargolis/feature/spake-param-storage branch from 7b6a65e to d8257c4 Compare January 28, 2022 18:29
@github-actions
Copy link

github-actions bot commented Jan 28, 2022 •
edited
Loading

PR #14350: Size comparison from c14afc5 to d8257c4

Increases above 0.2%:

platform target config section c14afc5 d8257c4 change % change
linux thermostat-no-ble arm64 .got 4144 4168 24 0.6
.rodata 129932 130572 640 0.5
Increases (15 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section c14afc5 d8257c4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578114 578214 100 0.0
.app_xip_area 484208 484308 100 0.0
lock-app CYW30739 (read/write) 536142 536242 100 0.0
.app_xip_area 443780 443880 100 0.0
efr32 lighting-app BRD4161A (read only) 842968 843096 128 0.0
.text 842960 843088 128 0.0
BRD4161A+rpc (read only) 830320 830456 136 0.0
.text 830312 830448 136 0.0
window-app BRD4161A (read only) 815560 815712 152 0.0
.text 815552 815704 152 0.0
k32w light k32w061+release (read/write) 662940 663048 108 0.0
.text 578844 578952 108 0.0
lock k32w061+release (read/write) 663844 663952 108 0.0
.text 579460 579568 108 0.0
linux chip-tool-ipv6only arm64 (read only) 6787188 6788148 960 0.0
(read/write) 279985 280081 96 0.0
.data.rel.ro 176472 176544 72 0.0
.got 43072 43096 24 0.1
.rodata 388348 388380 32 0.0
.text 5824948 5825588 640 0.0
thermostat-no-ble arm64 (read only) 2080748 2082844 2096 0.1
(read/write) 149537 149633 96 0.1
.data.rel.ro 74288 74360 72 0.1
.got 4144 4168 24 0.6
.rodata 129932 130572 640 0.5
.text 1733472 1734640 1168 0.1
p6 all-clusters-app default (read/write) 2441720 2442688 968 0.0
.text 1399984 1400952 968 0.1
light-app default (read/write) 2338536 2339504 968 0.0
.text 1296800 1297768 968 0.1
lock-app default (read/write) 2304080 2305048 968 0.0
.text 1262344 1263312 968 0.1
qpg lighting-app qpg6105+debug (read only) 570868 570976 108 0.0
.text 565548 565656 108 0.0
lock-app qpg6105+debug (read only) 517004 517112 108 0.0
.text 511684 511792 108 0.0
telink lighting-app tlsr9518adk80d (read/write) 845778 845978 200 0.0
text 592512 592648 136 0.0
Full report (16 builds for cyw30739, efr32, k32w, linux, p6, qpg, telink)
platform target config section c14afc5 d8257c4 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 578114 578214 100 0.0
.app_xip_area 484208 484308 100 0.0
.bss 76652 76652 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock-app CYW30739 (read/write) 536142 536242 100 0.0
.app_xip_area 443780 443880 100 0.0
.bss 75148 75148 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842968 843096 128 0.0
(read/write) 126200 126200 0 0.0
.bss 124296 124296 0 0.0
.data 1900 1900 0 0.0
.text 842960 843088 128 0.0
BRD4161A+rpc (read only) 830320 830456 136 0.0
(read/write) 142856 142856 0 0.0
.bss 140856 140856 0 0.0
.data 2000 2000 0 0.0
.text 830312 830448 136 0.0
window-app BRD4161A (read only) 815560 815712 152 0.0
(read/write) 124852 124852 0 0.0
.bss 122996 122996 0 0.0
.data 1856 1856 0 0.0
.text 815552 815704 152 0.0
k32w light k32w061+release (read/write) 662940 663048 108 0.0
.bss 76428 76428 0 0.0
.data 1868 1868 0 0.0
.text 578844 578952 108 0.0
lock k32w061+release (read/write) 663844 663952 108 0.0
.bss 76692 76692 0 0.0
.data 1892 1892 0 0.0
.text 579460 579568 108 0.0
linux chip-tool-ipv6only arm64 (read only) 6787188 6788148 960 0.0
(read/write) 279985 280081 96 0.0
.bss 55537 55537 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 176472 176544 72 0.0
.dynamic 560 560 0 0.0
.got 43072 43096 24 0.1
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 388348 388380 32 0.0
.text 5824948 5825588 640 0.0
thermostat-no-ble arm64 (read only) 2080748 2082844 2096 0.1
(read/write) 149537 149633 96 0.1
.bss 67169 67169 0 0.0
.data 960 960 0 0.0
.data.rel.ro 74288 74360 72 0.1
.dynamic 560 560 0 0.0
.got 4144 4168 24 0.6
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 129932 130572 640 0.5
.text 1733472 1734640 1168 0.1
p6 all-clusters-app default (read/write) 2441720 2442688 968 0.0
.bss 116740 116740 0 0.0
.data 2584 2584 0 0.0
.text 1399984 1400952 968 0.1
light-app default (read/write) 2338536 2339504 968 0.0
.bss 104484 104484 0 0.0
.data 2408 2408 0 0.0
.text 1296800 1297768 968 0.1
lock-app default (read/write) 2304080 2305048 968 0.0
.bss 104228 104228 0 0.0
.data 2360 2360 0 0.0
.text 1262344 1263312 968 0.1
qpg lighting-app qpg6105+debug (read only) 570868 570976 108 0.0
(read/write) 146936 146936 0 0.0
.bss 88640 88640 0 0.0
.data 1060 1060 0 0.0
.text 565548 565656 108 0.0
lock-app qpg6105+debug (read only) 517004 517112 108 0.0
(read/write) 146940 146940 0 0.0
.bss 88112 88112 0 0.0
.data 992 992 0 0.0
.text 511684 511792 108 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 845778 845978 200 0.0
bss 86440 86440 0 0.0
noinit 37160 37160 0 0.0
text 592512 592648 136 0.0

@emargolis
Copy link
Contributor Author

PTAL

@emargolis emargolis merged commit a117d85 into project-chip:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
config darwin efr32 esp32 linux platform review - approved zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emargolis @woody-apple @tcarmelveilleux @msandstedt