Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowCovering: Align with Specs Non-Volatile attributes #14317

Merged
merged 3 commits into from
Jan 26, 2022
Merged

WindowCovering: Align with Specs Non-Volatile attributes #14317

merged 3 commits into from
Jan 26, 2022

Conversation

jmeg-sfy
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Align with the specification the attributes with N quality -> their values are persistent across restarts (non-volatile)
  • Note: this is for the demos and CI -> implementer shall not use directly NVM in embedded devices

Change overview

This PR update the ZAP files for:

  • all-cluster-app.zap
  • window-app.zap
  • controller-clusters.zap (no effect, simple alignment)

Testing

How was this tested? (at least one bullet point required)

  • Passing the CI
  • Tested on EFR32 WindowApp example: attributes kept their values accros reboot

@github-actions
Copy link

github-actions bot commented Jan 26, 2022 •
edited
Loading

PR #14317: Size comparison from 20c1f60 to 705207b

Full report (32 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 20c1f60 705207b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 580034 580034 0 0.0
.app_xip_area 484956 484956 0 0.0
.bss 77824 77824 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
efr32 lighting-app BRD4161A (read only) 842788 842788 0 0.0
(read/write) 127364 127364 0 0.0
.bss 125464 125464 0 0.0
.data 1900 1900 0 0.0
.text 842780 842780 0 0.0
BRD4161A+rpc (read only) 830144 830144 0 0.0
(read/write) 144024 144024 0 0.0
.bss 142024 142024 0 0.0
.data 2000 2000 0 0.0
.text 830136 830136 0 0.0
window-app BRD4161A (read only) 815420 815420 0 0.0
(read/write) 126020 126020 0 0.0
.bss 124164 124164 0 0.0
.data 1856 1856 0 0.0
.text 815412 815412 0 0.0
esp32 all-clusters-app c3devkit (read only) 921026 921026 0 0.0
(read/write) 1384650 1384650 0 0.0
.dram0.bss 70840 70840 0 0.0
.dram0.data 14244 14244 0 0.0
.flash.rodata 180632 180632 0 0.0
.flash.text 921026 921026 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 969991 969991 0 0.0
(read/write) 451664 451664 0 0.0
.dram0.bss 75584 75584 0 0.0
.dram0.data 34032 34032 0 0.0
.flash.rodata 209920 209920 0 0.0
.flash.text 964607 964607 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 664828 664828 0 0.0
.bss 77596 77596 0 0.0
.data 1868 1868 0 0.0
.text 579564 579564 0 0.0
lock k32w061+release (read/write) 665824 665824 0 0.0
.bss 77860 77860 0 0.0
.data 1892 1892 0 0.0
.text 580272 580272 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8729716 8729716 0 0.0
(read/write) 392273 392273 0 0.0
.bss 56241 56241 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 261872 261872 0 0.0
.dynamic 560 560 0 0.0
.got 69280 69280 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 534252 534252 0 0.0
.text 7353716 7353716 0 0.0
thermostat-no-ble arm64 (read only) 2059188 2059188 0 0.0
(read/write) 147473 147473 0 0.0
.bss 65857 65857 0 0.0
.data 904 904 0 0.0
.data.rel.ro 73648 73648 0 0.0
.dynamic 560 560 0 0.0
.got 4112 4112 0 0.0
.init 24 24 0 0.0
.init_array 320 320 0 0.0
.rodata 131396 131396 0 0.0
.text 1712000 1712000 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355000 2355000 0 0.0
.bss 189548 189548 0 0.0
.data 5296 5296 0 0.0
.text 1317600 1317600 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2340992 2340992 0 0.0
.bss 181072 181072 0 0.0
.data 5584 5584 0 0.0
.text 1303592 1303592 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307736 2307736 0 0.0
.bss 180968 180968 0 0.0
.data 5568 5568 0 0.0
.text 1270336 1270336 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293900 2293900 0 0.0
.bss 177700 177700 0 0.0
.data 5384 5384 0 0.0
.text 1256472 1256472 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 983299 983299 0 0.0
bss 120828 120828 0 0.0
rodata 116408 116408 0 0.0
text 668272 668272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 967159 967159 0 0.0
bss 117872 117872 0 0.0
rodata 107940 107940 0 0.0
text 662944 662944 0 0.0
nrf52840dongle_nrf52840 (read/write) 999483 999483 0 0.0
bss 122000 122000 0 0.0
rodata 115292 115292 0 0.0
text 673732 673732 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 892518 892518 0 0.0
bss 117616 117616 0 0.0
rodata 109704 109704 0 0.0
text 584452 584452 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 915991 915991 0 0.0
bss 119208 119208 0 0.0
rodata 105076 105076 0 0.0
text 614296 614296 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 826014 826014 0 0.0
bss 116024 116024 0 0.0
rodata 98304 98304 0 0.0
text 531248 531248 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541835 541835 0 0.0
bss 52588 52588 0 0.0
rodata 50104 50104 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 918651 918651 0 0.0
bss 118952 118952 0 0.0
rodata 105464 105464 0 0.0
text 616760 616760 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 913835 913835 0 0.0
bss 118980 118980 0 0.0
rodata 104568 104568 0 0.0
text 612792 612792 0 0.0
shell nrf52840dk_nrf52840 (read/write) 798219 798219 0 0.0
bss 109776 109776 0 0.0
rodata 78288 78288 0 0.0
text 533648 533648 0 0.0
p6 all-clusters-app default (read/write) 2414896 2414896 0 0.0
.bss 117892 117892 0 0.0
.data 2584 2584 0 0.0
.text 1373160 1373160 0 0.0
light-app default (read/write) 2338360 2338360 0 0.0
.bss 105652 105652 0 0.0
.data 2408 2408 0 0.0
.text 1296624 1296624 0 0.0
lock-app default (read/write) 2303912 2303912 0 0.0
.bss 105396 105396 0 0.0
.data 2360 2360 0 0.0
.text 1262176 1262176 0 0.0
qpg lighting-app qpg6105+debug (read only) 571668 571668 0 0.0
(read/write) 146936 146936 0 0.0
.bss 89808 89808 0 0.0
.data 1060 1060 0 0.0
.text 566348 566348 0 0.0
lock-app qpg6105+debug (read only) 517852 517852 0 0.0
(read/write) 146940 146940 0 0.0
.bss 89280 89280 0 0.0
.data 992 992 0 0.0
.text 512532 512532 0 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 847894 847894 0 0.0
bss 87608 87608 0 0.0
noinit 37160 37160 0 0.0
text 592738 592738 0 0.0

@woody-apple woody-apple merged commit c0e4d7d into project-chip:master Jan 26, 2022
@bzbarsky-apple
Copy link
Contributor

Note: this is for the demos and CI -> implementer shall not use directly NVM in embedded devices

Why not?

@jmeg-sfy
Copy link
Contributor Author

Note: this is for the demos and CI -> implementer shall not use directly NVM in embedded devices

Why not?

Just to make aware potential implementers reading this later. By default the regular flash is used in embedded platform
They might require config or development to use an external flash system.

selissia pushed a commit to selissia/connectedhomeip that referenced this pull request Jan 28, 2022
@jmeg-sfy @selissia
WindowCovering: Align with Specs Non-Volatile attributes (project-chi…
86673cb 
…p#14317)

* DEV: WindowCovering Cluster.zap config use NVM according to the specs

* DEV: Zap regen for NVM

* DEV: Align controller zap with updated NVM
@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/window-covering-nvm branch February 10, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmeg-sfy @bzbarsky-apple @andy31415 @woody-apple @jmartinez-silabs