-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Update nRF Connect SDK version to 1.8 #13031
Conversation
PR #13031: Size comparison from c52bc7b to ce36e75 Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
|
/rebase |
55dd9c6
to
3fcdaa0
Compare
PR #13031: Size comparison from 6afd51d to 3fcdaa0 Increases above 0.2%:
Increases (10 builds for nrfconnect)
Decreases (9 builds for nrfconnect)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR updates both code (presumably for the new SDK) and the SDK itself, I believe it has to be broken down:
- PR 1 to update docker image only
- PR 2 to switch to the new docker and update code (and ncs recommended revision)
* Update NCS version to recently released 1.8 * Update configuration for external flash * Shorted the pump controller app BLE name to fit in the default limit.
3fcdaa0
to
0d1ab1a
Compare
PR #13031: Size comparison from 32370de to 0d1ab1a Increases above 0.2%:
Increases (10 builds for nrfconnect)
Decreases (9 builds for nrfconnect)
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
…-chip#13031 it cannot build NRF
…it cannot build NRF (#13078)
Problem
Recommended NCS version is a bit outdated
Change overview
chip_build_pw_rpc_lib
argument. All pigweed components are already built usingCMake
.Testing
Basic smoke tests on nRF Connect lighting-app