Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align OTA Provider Cluster with spec #13019

Merged

Conversation

carol-apple
Copy link
Contributor

Problem

The OTA Provider Cluster spec has changed since it was first added. There are slight differences between spec and zap/xml files.

Change overview

  • Update the Command IDs for the OTA Provider Cluster Commands
  • Add constraints to command fields
  • Add default value for consent fields

Testing

No behavior change, tree compiles.

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

PR #13019: Size comparison from fb19736 to 1cebdfe

Decreases (1 build for esp32)
platform target config section fb19736 1cebdfe change % change
esp32 all-clusters-app m5stack (read only) 965255 965251 -4 -0.0
.flash.text 959871 959867 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section fb19736 1cebdfe change % change
efr32 lighting-app BRD4161A (read only) 834392 834392 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 834384 834384 0 0.0
BRD4161A+rpc (read only) 821996 821996 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 821988 821988 0 0.0
window-app BRD4161A (read only) 811632 811632 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 811624 811624 0 0.0
esp32 all-clusters-app c3devkit (read only) 877324 877324 0 0.0
(read/write) 1313434 1313434 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 175096 175096 0 0.0
.flash.text 877324 877324 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965255 965251 -4 -0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 959871 959867 -4 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688104 688104 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601060 601060 0 0.0
lock-app k32w061+debug (read/write) 638028 638028 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 552872 552872 0 0.0
shell k32w061+debug (read/write) 643432 643432 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 555988 555988 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6901772 6901772 0 0.0
(read/write) 324113 324113 0 0.0
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 209248 209248 0 0.0
.dynamic 560 560 0 0.0
.got 53944 53944 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366716 366716 0 0.0
.text 5851556 5851556 0 0.0
thermostat-no-ble arm64 (read only) 2003660 2003660 0 0.0
(read/write) 145265 145265 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72064 72064 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127996 127996 0 0.0
.text 1664176 1664176 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335480 2335480 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1298056 1298056 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 923619 923619 0 0.0
bss 119852 119852 0 0.0
rodata 103620 103620 0 0.0
text 624536 624536 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 886659 886659 0 0.0
bss 116200 116200 0 0.0
rodata 94916 94916 0 0.0
text 599276 599276 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849634 849634 0 0.0
bss 121224 121224 0 0.0
rodata 98876 98876 0 0.0
text 554976 554976 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898359 898359 0 0.0
bss 119028 119028 0 0.0
rodata 99736 99736 0 0.0
text 604180 604180 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824618 824618 0 0.0
bss 120440 120440 0 0.0
rodata 95028 95028 0 0.0
text 534708 534708 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903299 903299 0 0.0
bss 118940 118940 0 0.0
rodata 101092 101092 0 0.0
text 607780 607780 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896539 896539 0 0.0
bss 118820 118820 0 0.0
rodata 99228 99228 0 0.0
text 602980 602980 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2388424 2388424 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1346688 1346688 0 0.0
light-app default (read/write) 2328712 2328712 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1286976 1286976 0 0.0
lock-app default (read/write) 2304792 2304792 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1263056 1263056 0 0.0
qpg lighting-app qpg6105+debug (read only) 532804 532804 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527484 527484 0 0.0
lock-app qpg6105+debug (read only) 507172 507172 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 501852 501852 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832830 832830 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580524 580524 0 0.0

@andy31415 andy31415 merged commit 4a17ccc into project-chip:master Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants