Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML : Constraints with nullable types fixed for Min, Max & NotValue #12958

Merged
merged 6 commits into from
Dec 15, 2021
Merged

YAML : Constraints with nullable types fixed for Min, Max & NotValue #12958

merged 6 commits into from
Dec 15, 2021

Conversation

jmeg-sfy
Copy link
Contributor

@jmeg-sfy jmeg-sfy commented Dec 13, 2021 •
edited
Loading

Problem

What is being fixed? Examples:

  • YAML tests doesn't support Nullable type limits

Change overview

Modification to support nullable types
This PR is needed to lay down other PR and new YAMLs Tests

EDITs: We allow NULL values to PASS here, we check MIN MAX only if the value is present
since we don't want to fail on such condition, there is another tag dedicated to check the nullity in particular.
We just allow for a test to verify the value is withing a particular range and a nullable attribute is allowed to be NULL

Testing

How was this tested? (at least one bullet point required)

  • No regression + tested with code from another PR where Nullable type were tested against limits

@restyled-io restyled-io bot mentioned this pull request Dec 13, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12958: Size comparison from ed367ec to 384dc3f

Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section ed367ec 384dc3f change % change
efr32 lighting-app BRD4161A (read only) 815676 815676 0 0.0
(read/write) 123208 123208 0 0.0
.bss 121344 121344 0 0.0
.data 1864 1864 0 0.0
.text 815668 815668 0 0.0
BRD4161A+rpc (read only) 803292 803292 0 0.0
(read/write) 139884 139884 0 0.0
.bss 137920 137920 0 0.0
.data 1964 1964 0 0.0
.text 803284 803284 0 0.0
window-app BRD4161A (read only) 792752 792752 0 0.0
(read/write) 122160 122160 0 0.0
.bss 120328 120328 0 0.0
.data 1828 1828 0 0.0
.text 792744 792744 0 0.0
esp32 all-clusters-app c3devkit (read only) 856682 856682 0 0.0
(read/write) 1304650 1304650 0 0.0
.dram0.bss 64752 64752 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 856682 856682 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960783 960783 0 0.0
(read/write) 450468 450468 0 0.0
.dram0.bss 74040 74040 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210592 210592 0 0.0
.flash.text 955399 955399 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670112 670112 0 0.0
.bss 73928 73928 0 0.0
.data 1896 1896 0 0.0
.text 588488 588488 0 0.0
lock-app k32w061+debug (read/write) 620048 620048 0 0.0
.bss 72080 72080 0 0.0
.data 1856 1856 0 0.0
.text 540312 540312 0 0.0
shell k32w061+debug (read/write) 625416 625416 0 0.0
.bss 74388 74388 0 0.0
.data 1836 1836 0 0.0
.text 543392 543392 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6876732 6876732 0 0.0
(read/write) 319281 319281 0 0.0
.bss 51873 51873 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208760 208760 0 0.0
.dynamic 560 560 0 0.0
.got 53720 53720 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366092 366092 0 0.0
.text 5828772 5828772 0 0.0
thermostat-no-ble arm64 (read only) 1952452 1952452 0 0.0
(read/write) 137681 137681 0 0.0
.bss 59537 59537 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70744 70744 0 0.0
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125764 125764 0 0.0
.text 1618336 1618336 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313720 2313720 0 0.0
.bss 184020 184020 0 0.0
.data 5240 5240 0 0.0
.heap 847184 847184 0 0.0
.text 1276296 1276296 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309576 2309576 0 0.0
.bss 175880 175880 0 0.0
.data 5536 5536 0 0.0
.heap 855032 855032 0 0.0
.text 1272176 1272176 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282688 2282688 0 0.0
.bss 174920 174920 0 0.0
.data 5520 5520 0 0.0
.heap 856008 856008 0 0.0
.text 1245288 1245288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907419 907419 0 0.0
bss 116352 116352 0 0.0
rodata 102220 102220 0 0.0
text 613272 613272 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870479 870479 0 0.0
bss 112700 112700 0 0.0
rodata 93520 93520 0 0.0
text 588012 588012 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833422 833422 0 0.0
bss 117728 117728 0 0.0
rodata 97480 97480 0 0.0
text 543696 543696 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 880083 880083 0 0.0
bss 113616 113616 0 0.0
rodata 98340 98340 0 0.0
text 592708 592708 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 806322 806322 0 0.0
bss 115024 115024 0 0.0
rodata 93628 93628 0 0.0
text 523224 523224 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885019 885019 0 0.0
bss 113528 113528 0 0.0
rodata 99692 99692 0 0.0
text 596312 596312 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 878227 878227 0 0.0
bss 113404 113404 0 0.0
rodata 97828 97828 0 0.0
text 591508 591508 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2360712 2360712 0 0.0
.bss 112220 112220 0 0.0
.data 2528 2528 0 0.0
.heap 918592 918592 0 0.0
.text 1318976 1318976 0 0.0
light-app default (read/write) 2301288 2301288 0 0.0
.bss 101136 101136 0 0.0
.data 2368 2368 0 0.0
.heap 929840 929840 0 0.0
.text 1259552 1259552 0 0.0
lock-app default (read/write) 2277376 2277376 0 0.0
.bss 100016 100016 0 0.0
.data 2328 2328 0 0.0
.heap 931000 931000 0 0.0
.text 1235640 1235640 0 0.0
qpg lighting-app qpg6100+debug (read only) 521840 521840 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82768 82768 0 0.0
.data 996 996 0 0.0
.text 516520 516520 0 0.0
lock-app qpg6100+debug (read only) 496204 496204 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81904 81904 0 0.0
.data 952 952 0 0.0
.text 490884 490884 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811966 811966 0 0.0
bss 82920 82920 0 0.0
noinit 37160 37160 0 0.0
text 566724 566724 0 0.0

@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/fix-constraint-with-nullable branch from 384dc3f to 233fb01 Compare December 14, 2021 20:13
@boring-cyborg boring-cyborg bot added the app label Dec 14, 2021
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

PR #12958: Size comparison from c9bc5ae to 233fb01

Increases above 0.2%:

platform target config section c9bc5ae 233fb01 change % change
linux chip-tool-ipv6only arm64 (read only) 6894636 6931036 36400 0.5
.got 53864 54504 640 1.2
.rodata 366380 369292 2912 0.8
.text 5844996 5876564 31568 0.5
Increases (1 build for linux)
platform target config section c9bc5ae 233fb01 change % change
linux chip-tool-ipv6only arm64 (read only) 6894636 6931036 36400 0.5
(read/write) 324033 324673 640 0.2
.got 53864 54504 640 1.2
.rodata 366380 369292 2912 0.8
.text 5844996 5876564 31568 0.5
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c9bc5ae 233fb01 change % change
efr32 lighting-app BRD4161A (read only) 834360 834360 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 834352 834352 0 0.0
BRD4161A+rpc (read only) 821964 821964 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 821956 821956 0 0.0
window-app BRD4161A (read only) 811600 811600 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 811592 811592 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688072 688072 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601028 601028 0 0.0
lock-app k32w061+debug (read/write) 638012 638012 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 552856 552856 0 0.0
shell k32w061+debug (read/write) 643416 643416 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 555972 555972 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6894636 6931036 36400 0.5
(read/write) 324033 324673 640 0.2
.bss 56001 56001 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 209248 209248 0 0.0
.dynamic 560 560 0 0.0
.got 53864 54504 640 1.2
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 366380 369292 2912 0.8
.text 5844996 5876564 31568 0.5
thermostat-no-ble arm64 (read only) 2003596 2003596 0 0.0
(read/write) 145265 145265 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72064 72064 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 127996 127996 0 0.0
.text 1664112 1664112 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335416 2335416 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1297992 1297992 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2330952 2330952 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293552 1293552 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304072 2304072 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266672 1266672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 923587 923587 0 0.0
bss 119852 119852 0 0.0
rodata 103620 103620 0 0.0
text 624508 624508 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 886627 886627 0 0.0
bss 116200 116200 0 0.0
rodata 94916 94916 0 0.0
text 599244 599244 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 849602 849602 0 0.0
bss 121224 121224 0 0.0
rodata 98876 98876 0 0.0
text 554944 554944 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898327 898327 0 0.0
bss 119028 119028 0 0.0
rodata 99736 99736 0 0.0
text 604148 604148 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 824586 824586 0 0.0
bss 120440 120440 0 0.0
rodata 95028 95028 0 0.0
text 534680 534680 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903283 903283 0 0.0
bss 118940 118940 0 0.0
rodata 101092 101092 0 0.0
text 607752 607752 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896507 896507 0 0.0
bss 118820 118820 0 0.0
rodata 99228 99228 0 0.0
text 602948 602948 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2388392 2388392 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1346656 1346656 0 0.0
light-app default (read/write) 2328696 2328696 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1286960 1286960 0 0.0
lock-app default (read/write) 2304760 2304760 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1263024 1263024 0 0.0
qpg lighting-app qpg6105+debug (read only) 532772 532772 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527452 527452 0 0.0
lock-app qpg6105+debug (read only) 507140 507140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 501820 501820 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 832822 832822 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 580510 580510 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that was a lot more tests than I was expecting.... ;)

As the CI shows, this does in fact need darwin changes. You'll want to at least run ./scripts/tools/zap/generate.py -t src/darwin/Framework/CHIP/templates/templates.json src/controller/data_model/controller-clusters.zap to regen there. After that, look at the generated code; I expect the codegen in src/darwin/Framework/CHIP/templates/partials/test_cluster.zapt will probably need to be adjusted to handle Nullable by using a helper method that checks for null before calling XCTAssert* functions....

@jmeg-sfy
Copy link
Contributor Author

Thank you, that was a lot more tests than I was expecting.... ;)

As the CI shows, this does in fact need darwin changes. You'll want to at least run ./scripts/tools/zap/generate.py -t src/darwin/Framework/CHIP/templates/templates.json src/controller/data_model/controller-clusters.zap to regen there. After that, look at the generated code; I expect the codegen in src/darwin/Framework/CHIP/templates/partials/test_cluster.zapt will probably need to be adjusted to handle Nullable by using a helper method that checks for null before calling XCTAssert* functions....

Ok i ll look into this , never did objective-c guess it is time to learn
Where there objective c Nullable object is defined there ? thanks for the tips

@bzbarsky-apple
Copy link
Contributor

So what will happen in the Objc code is that actualValue will be nil if we're nullable and set to null.

So just wrapping a actualValue != nil test around the XCTAssertGreaterThanOrEqual and XCTAssertLessThanOrEqual calls is probably the simplest thing to do. Hopefully the compiler won't complain in the cases when the attribute is not nullable and hence actualValue is declared nonnull...

@boring-cyborg boring-cyborg bot added the darwin label Dec 15, 2021
@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/fix-constraint-with-nullable branch from 03d6446 to 2307ed4 Compare December 15, 2021 14:04
@restyled-io restyled-io bot mentioned this pull request Dec 15, 2021
Closed
@jmeg-sfy jmeg-sfy force-pushed the jmeg-sfy/fix-constraint-with-nullable branch from 2307ed4 to bbea0a6 Compare December 15, 2021 14:36
@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12958: Size comparison from 8bedafa to bbea0a6

Increases above 0.2%:

platform target config section 8bedafa bbea0a6 change % change
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
.got 55512 56152 640 1.2
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
Increases (1 build for linux)
platform target config section 8bedafa bbea0a6 change % change
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
(read/write) 324593 325233 640 0.2
.got 55512 56152 640 1.2
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
Full report (20 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 8bedafa bbea0a6 change % change
efr32 lighting-app BRD4161A (read only) 835976 835976 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 835968 835968 0 0.0
BRD4161A+rpc (read only) 823564 823564 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 823556 823556 0 0.0
window-app BRD4161A (read only) 813200 813200 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813192 813192 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688420 688420 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601376 601376 0 0.0
lock-app k32w061+debug (read/write) 638360 638360 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553204 553204 0 0.0
shell k32w061+debug (read/write) 643748 643748 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556304 556304 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
(read/write) 324593 325233 640 0.2
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 56152 640 1.2
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
thermostat-no-ble arm64 (read only) 2006700 2006700 0 0.0
(read/write) 145281 145281 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1667152 1667152 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335792 2335792 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1298368 1298368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331272 2331272 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293872 1293872 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304392 2304392 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266992 1266992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
p6 all-clusters-app default (read/write) 2390008 2390008 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1348272 1348272 0 0.0
light-app default (read/write) 2330296 2330296 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1288560 1288560 0 0.0
lock-app default (read/write) 2306360 2306360 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1264624 1264624 0 0.0
qpg lighting-app qpg6105+debug (read only) 533120 533120 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527800 527800 0 0.0
lock-app qpg6105+debug (read only) 507488 507488 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502168 502168 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833338 833338 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581030 581030 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12958: Size comparison from 8bedafa to 868f8f0

Increases above 0.2%:

platform target config section 8bedafa 868f8f0 change % change
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
.got 55512 56152 640 1.2
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
Increases (1 build for linux)
platform target config section 8bedafa 868f8f0 change % change
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
(read/write) 324593 325233 640 0.2
.got 55512 56152 640 1.2
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
Decreases (1 build for esp32)
platform target config section 8bedafa 868f8f0 change % change
esp32 all-clusters-app m5stack (read only) 965715 965711 -4 -0.0
.flash.text 960331 960327 -4 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8bedafa 868f8f0 change % change
efr32 lighting-app BRD4161A (read only) 835976 835976 0 0.0
(read/write) 128632 128632 0 0.0
.bss 126760 126760 0 0.0
.data 1868 1868 0 0.0
.text 835968 835968 0 0.0
BRD4161A+rpc (read only) 823564 823564 0 0.0
(read/write) 145304 145304 0 0.0
.bss 143336 143336 0 0.0
.data 1968 1968 0 0.0
.text 823556 823556 0 0.0
window-app BRD4161A (read only) 813200 813200 0 0.0
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813192 813192 0 0.0
esp32 all-clusters-app c3devkit (read only) 877798 877798 0 0.0
(read/write) 1313442 1313442 0 0.0
.dram0.bss 71080 71080 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 175104 175104 0 0.0
.flash.text 877798 877798 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965715 965711 -4 -0.0
(read/write) 454720 454720 0 0.0
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 211332 211332 0 0.0
.flash.text 960331 960327 -4 -0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688420 688420 0 0.0
.bss 79344 79344 0 0.0
.data 1900 1900 0 0.0
.text 601376 601376 0 0.0
lock-app k32w061+debug (read/write) 638360 638360 0 0.0
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553204 553204 0 0.0
shell k32w061+debug (read/write) 643748 643748 0 0.0
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556304 556304 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6977572 7013972 36400 0.5
(read/write) 324593 325233 640 0.2
.bss 55889 55889 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 56152 640 1.2
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376292 379188 2896 0.8
.text 5915236 5946820 31584 0.5
thermostat-no-ble arm64 (read only) 2006700 2006700 0 0.0
(read/write) 145281 145281 0 0.0
.bss 65633 65633 0 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128012 0 0.0
.text 1667152 1667152 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335792 2335792 0 0.0
.bss 190332 190332 0 0.0
.data 5248 5248 0 0.0
.heap 840864 840864 0 0.0
.text 1298368 1298368 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331272 2331272 0 0.0
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293872 1293872 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304392 2304392 0 0.0
.bss 181232 181232 0 0.0
.data 5528 5528 0 0.0
.heap 849688 849688 0 0.0
.text 1266992 1266992 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924015 924015 0 0.0
bss 119852 119852 0 0.0
rodata 103616 103616 0 0.0
text 624940 624940 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 887055 887055 0 0.0
bss 116200 116200 0 0.0
rodata 94912 94912 0 0.0
text 599676 599676 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 850030 850030 0 0.0
bss 121224 121224 0 0.0
rodata 98872 98872 0 0.0
text 555376 555376 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 898755 898755 0 0.0
bss 119028 119028 0 0.0
rodata 99732 99732 0 0.0
text 604580 604580 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 825014 825014 0 0.0
bss 120440 120440 0 0.0
rodata 95024 95024 0 0.0
text 535112 535112 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903711 903711 0 0.0
bss 118940 118940 0 0.0
rodata 101088 101088 0 0.0
text 608184 608184 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 896935 896935 0 0.0
bss 118820 118820 0 0.0
rodata 99224 99224 0 0.0
text 603380 603380 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2390008 2390008 0 0.0
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1348272 1348272 0 0.0
light-app default (read/write) 2330296 2330296 0 0.0
.bss 107448 107448 0 0.0
.data 2376 2376 0 0.0
.heap 923520 923520 0 0.0
.text 1288560 1288560 0 0.0
lock-app default (read/write) 2306360 2306360 0 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1264624 1264624 0 0.0
qpg lighting-app qpg6105+debug (read only) 533120 533120 0 0.0
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 996 0 0.0
.text 527800 527800 0 0.0
lock-app qpg6105+debug (read only) 507488 507488 0 0.0
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502168 502168 0 0.0
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833338 833338 0 0.0
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581030 581030 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 15, 2021 •
edited
Loading

PR #12958: Size comparison from 8bedafa to bfdb108

Increases above 0.2%:

platform target config section 8bedafa bfdb108 change % change
efr32 lighting-app BRD4161A (read only) 835976 840592 4616 0.6
.data 1868 1876 8 0.4
.text 835968 840584 4616 0.6
BRD4161A+rpc (read only) 823564 828196 4632 0.6
.data 1968 1976 8 0.4
.text 823556 828188 4632 0.6
esp32 all-clusters-app c3devkit (read only) 877798 880138 2340 0.3
.flash.rodata 175104 175912 808 0.5
.flash.text 877798 880138 2340 0.3
m5stack (read only) 965715 967871 2156 0.2
.flash.rodata 211332 212116 784 0.4
.flash.text 960331 962487 2156 0.2
k32w lighting-app k32w061+se05x+release (read/write) 688420 691148 2728 0.4
.data 1900 1908 8 0.4
.text 601376 604096 2720 0.5
linux chip-tool-ipv6only arm64 (read only) 6977572 7006460 28888 0.4
.got 55512 56000 488 0.9
.rodata 376292 378540 2248 0.6
.text 5915236 5940420 25184 0.4
mbed all-clusters-app CY8CPROTO_062_4343W+release .text 1298368 1301392 3024 0.2
lighting-app CY8CPROTO_062_4343W+release .text 1293872 1296920 3048 0.2
lock-app CY8CPROTO_062_4343W+release .text 1266992 1270016 3024 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924015 927055 3040 0.3
rodata 103616 104424 808 0.8
text 624940 627160 2220 0.4
nrf52840dk_nrf52840+rpc (read/write) 887055 890095 3040 0.3
rodata 94912 95720 808 0.9
text 599676 601900 2224 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 850030 853062 3032 0.4
rodata 98872 99680 808 0.8
text 555376 557600 2224 0.4
p6 all-clusters-app default .text 1348272 1352864 4592 0.3
light-app default .data 2376 2384 8 0.3
.text 1288560 1293176 4616 0.4
qpg lighting-app qpg6105+debug (read only) 533120 536144 3024 0.6
.data 996 1004 8 0.8
.text 527800 530824 3024 0.6
telink lighting-app tlsr9518adk80d (read/write) 833338 836574 3236 0.4
text 581030 583428 2398 0.4
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8bedafa bfdb108 change % change
efr32 lighting-app BRD4161A (read only) 835976 840592 4616 0.6
(read/write) 128632 128640 8 0.0
.data 1868 1876 8 0.4
.text 835968 840584 4616 0.6
BRD4161A+rpc (read only) 823564 828196 4632 0.6
(read/write) 145304 145312 8 0.0
.data 1968 1976 8 0.4
.text 823556 828188 4632 0.6
window-app BRD4161A (read only) 813200 813968 768 0.1
.text 813192 813960 768 0.1
esp32 all-clusters-app c3devkit (read only) 877798 880138 2340 0.3
(read/write) 1313442 1314250 808 0.1
.flash.rodata 175104 175912 808 0.5
.flash.text 877798 880138 2340 0.3
m5stack (read only) 965715 967871 2156 0.2
(read/write) 454720 455512 792 0.2
.dram0.data 34048 34056 8 0.0
.flash.rodata 211332 212116 784 0.4
.flash.text 960331 962487 2156 0.2
k32w lighting-app k32w061+se05x+release (read/write) 688420 691148 2728 0.4
.data 1900 1908 8 0.4
.text 601376 604096 2720 0.5
lock-app k32w061+debug (read/write) 638360 638712 352 0.1
.text 553204 553556 352 0.1
shell k32w061+debug (read/write) 643748 644100 352 0.1
.text 556304 556656 352 0.1
linux chip-tool-ipv6only arm64 (read only) 6977572 7006460 28888 0.4
(read/write) 324593 325089 496 0.2
.bss 55889 55905 16 0.0
.got 55512 56000 488 0.9
.rodata 376292 378540 2248 0.6
.text 5915236 5940420 25184 0.4
thermostat-no-ble arm64 (read only) 2006700 2008724 2024 0.1
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.rodata 128012 128068 56 0.0
.text 1667152 1669120 1968 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2335792 2338816 3024 0.1
.data 5248 5256 8 0.2
.text 1298368 1301392 3024 0.2
lighting-app CY8CPROTO_062_4343W+release (read/write) 2331272 2334320 3048 0.1
.text 1293872 1296920 3048 0.2
lock-app CY8CPROTO_062_4343W+release (read/write) 2304392 2307416 3024 0.1
.data 5528 5536 8 0.1
.text 1266992 1270016 3024 0.2
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924015 927055 3040 0.3
rodata 103616 104424 808 0.8
text 624940 627160 2220 0.4
nrf52840dk_nrf52840+rpc (read/write) 887055 890095 3040 0.3
bss 116200 116204 4 0.0
rodata 94912 95720 808 0.9
text 599676 601900 2224 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 850030 853062 3032 0.4
bss 121224 121228 4 0.0
rodata 98872 99680 808 0.8
text 555376 557600 2224 0.4
lock-app nrf52840dk_nrf52840 (read/write) 898755 899107 352 0.0
bss 119028 119032 4 0.0
text 604580 604928 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 825014 825366 352 0.0
text 535112 535460 348 0.1
pump-app nrf52840dk_nrf52840 (read/write) 903711 904047 336 0.0
bss 118940 118944 4 0.0
text 608184 608532 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 896935 897287 352 0.0
bss 118820 118824 4 0.0
text 603380 603728 348 0.1
p6 all-clusters-app default (read/write) 2390008 2394600 4592 0.2
.text 1348272 1352864 4592 0.3
light-app default (read/write) 2330296 2334912 4616 0.2
.data 2376 2384 8 0.3
.text 1288560 1293176 4616 0.4
lock-app default (read/write) 2306360 2307128 768 0.0
.text 1264624 1265392 768 0.1
qpg lighting-app qpg6105+debug (read only) 533120 536144 3024 0.6
.data 996 1004 8 0.8
.text 527800 530824 3024 0.6
lock-app qpg6105+debug (read only) 507488 507832 344 0.1
.text 502168 502512 344 0.1
telink lighting-app tlsr9518adk80d (read/write) 833338 836574 3236 0.4
text 581030 583428 2398 0.4
Decreases (3 builds for mbed, p6)
platform target config section 8bedafa bfdb108 change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 840864 840856 -8 -0.0
lock-app CY8CPROTO_062_4343W+release .heap 849688 849680 -8 -0.0
p6 light-app default .heap 923520 923512 -8 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 8bedafa bfdb108 change % change
efr32 lighting-app BRD4161A (read only) 835976 840592 4616 0.6
(read/write) 128632 128640 8 0.0
.bss 126760 126760 0 0.0
.data 1868 1876 8 0.4
.text 835968 840584 4616 0.6
BRD4161A+rpc (read only) 823564 828196 4632 0.6
(read/write) 145304 145312 8 0.0
.bss 143336 143336 0 0.0
.data 1968 1976 8 0.4
.text 823556 828188 4632 0.6
window-app BRD4161A (read only) 813200 813968 768 0.1
(read/write) 127576 127576 0 0.0
.bss 125744 125744 0 0.0
.data 1832 1832 0 0.0
.text 813192 813960 768 0.1
esp32 all-clusters-app c3devkit (read only) 877798 880138 2340 0.3
(read/write) 1313442 1314250 808 0.1
.dram0.bss 71080 71080 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 175104 175912 808 0.5
.flash.text 877798 880138 2340 0.3
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965715 967871 2156 0.2
(read/write) 454720 455512 792 0.2
.dram0.bss 77552 77552 0 0.0
.dram0.data 34048 34056 8 0.0
.flash.rodata 211332 212116 784 0.4
.flash.text 960331 962487 2156 0.2
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 688420 691148 2728 0.4
.bss 79344 79344 0 0.0
.data 1900 1908 8 0.4
.text 601376 604096 2720 0.5
lock-app k32w061+debug (read/write) 638360 638712 352 0.1
.bss 77496 77496 0 0.0
.data 1860 1860 0 0.0
.text 553204 553556 352 0.1
shell k32w061+debug (read/write) 643748 644100 352 0.1
.bss 79804 79804 0 0.0
.data 1840 1840 0 0.0
.text 556304 556656 352 0.1
linux chip-tool-ipv6only arm64 (read only) 6977572 7006460 28888 0.4
(read/write) 324593 325089 496 0.2
.bss 55889 55905 16 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208392 208392 0 0.0
.dynamic 560 560 0 0.0
.got 55512 56000 488 0.9
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 376292 378540 2248 0.6
.text 5915236 5940420 25184 0.4
thermostat-no-ble arm64 (read only) 2006700 2008724 2024 0.1
(read/write) 145281 145297 16 0.0
.bss 65633 65649 16 0.0
.data 832 832 0 0.0
.data.rel.ro 72080 72080 0 0.0
.dynamic 560 560 0 0.0
.got 3840 3840 0 0.0
.init 24 24 0 0.0
.init_array 288 288 0 0.0
.rodata 128012 128068 56 0.0
.text 1667152 1669120 1968 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2335792 2338816 3024 0.1
.bss 190332 190332 0 0.0
.data 5248 5256 8 0.2
.heap 840864 840856 -8 -0.0
.text 1298368 1301392 3024 0.2
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2331272 2334320 3048 0.1
.bss 182192 182192 0 0.0
.data 5544 5544 0 0.0
.heap 848712 848712 0 0.0
.text 1293872 1296920 3048 0.2
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2304392 2307416 3024 0.1
.bss 181232 181232 0 0.0
.data 5528 5536 8 0.1
.heap 849688 849680 -8 -0.0
.text 1266992 1270016 3024 0.2
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.heap 1020320 1020320 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2054328 2054328 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016928 1016928 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 924015 927055 3040 0.3
bss 119852 119852 0 0.0
rodata 103616 104424 808 0.8
text 624940 627160 2220 0.4
nrf52840dk_nrf52840+rpc (read/write) 887055 890095 3040 0.3
bss 116200 116204 4 0.0
rodata 94912 95720 808 0.9
text 599676 601900 2224 0.4
nrf5340dk_nrf5340_cpuapp (read/write) 850030 853062 3032 0.4
bss 121224 121228 4 0.0
rodata 98872 99680 808 0.8
text 555376 557600 2224 0.4
lock-app nrf52840dk_nrf52840 (read/write) 898755 899107 352 0.0
bss 119028 119032 4 0.0
rodata 99732 99732 0 0.0
text 604580 604928 348 0.1
nrf5340dk_nrf5340_cpuapp (read/write) 825014 825366 352 0.0
bss 120440 120440 0 0.0
rodata 95024 95024 0 0.0
text 535112 535460 348 0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497447 497447 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339488 339488 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 903711 904047 336 0.0
bss 118940 118944 4 0.0
rodata 101088 101088 0 0.0
text 608184 608532 348 0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 896935 897287 352 0.0
bss 118820 118824 4 0.0
rodata 99224 99224 0 0.0
text 603380 603728 348 0.1
shell nrf52840dk_nrf52840 (read/write) 782767 782767 0 0.0
bss 109624 109624 0 0.0
rodata 74396 74396 0 0.0
text 524232 524232 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697838 697838 0 0.0
bss 110604 110604 0 0.0
rodata 69040 69040 0 0.0
text 444868 444868 0 0.0
p6 all-clusters-app default (read/write) 2390008 2394600 4592 0.2
.bss 118532 118532 0 0.0
.data 2536 2536 0 0.0
.heap 912272 912272 0 0.0
.text 1348272 1352864 4592 0.3
light-app default (read/write) 2330296 2334912 4616 0.2
.bss 107448 107448 0 0.0
.data 2376 2384 8 0.3
.heap 923520 923512 -8 -0.0
.text 1288560 1293176 4616 0.4
lock-app default (read/write) 2306360 2307128 768 0.0
.bss 106328 106328 0 0.0
.data 2336 2336 0 0.0
.heap 924680 924680 0 0.0
.text 1264624 1265392 768 0.1
qpg lighting-app qpg6105+debug (read only) 533120 536144 3024 0.6
(read/write) 146936 146936 0 0.0
.bss 88096 88096 0 0.0
.data 996 1004 8 0.8
.text 527800 530824 3024 0.6
lock-app qpg6105+debug (read only) 507488 507832 344 0.1
(read/write) 146940 146940 0 0.0
.bss 87232 87232 0 0.0
.data 952 952 0 0.0
.text 502168 502512 344 0.1
persistent-storage-app qpg6105+debug (read only) 106448 106448 0 0.0
(read/write) 146938 146938 0 0.0
.bss 36146 36146 0 0.0
.data 288 288 0 0.0
.text 101128 101128 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 833338 836574 3236 0.4
bss 88336 88336 0 0.0
noinit 37160 37160 0 0.0
text 581030 583428 2398 0.4

bzbarsky-apple
bzbarsky-apple approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but fixing the darwin code to use asTypedLiteral would have fixed those 64-bit things.... I'll do that as a followup.

@bzbarsky-apple bzbarsky-apple merged commit 32370de into project-chip:master Dec 15, 2021
@bzbarsky-apple
Copy link
Contributor

Approving, but fixing the darwin code to use asTypedLiteral would have fixed those 64-bit things.... I'll do that as a followup.

#13057

@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/fix-constraint-with-nullable branch December 16, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app darwin examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmeg-sfy @bzbarsky-apple @andy31415 @restyled-commits