Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inet] Test EndPoint statistics #12885

Merged
merged 1 commit into from
Dec 10, 2021
Merged

[Inet] Test EndPoint statistics #12885

merged 1 commit into from
Dec 10, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Fixes #12378 Use the Impl's underlying ObjectPool statistics

Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

Testing

Added unit test assertions.

@kpschoedel
[Inet] Test EndPoint statistics
82e299a 
#### Problem

Fixes project-chip#12378 Use the Impl's underlying ObjectPool statistics

#### Change overview

Decided to fix the existing method, with a deletion wrapper.

Added stats macros for unit testing.

#### Testing

Added unit test assertions.
@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12885: Size comparison from de0af9a to 82e299a

Increases (22 builds for efr32, esp32, linux, nrfconnect, p6, qpg, telink)
platform target config section de0af9a 82e299a change % change
efr32 lighting-app BRD4161A (read only) 809188 809252 64 0.0
.text 809180 809244 64 0.0
BRD4161A+rpc (read only) 796824 796872 48 0.0
.text 796816 796864 48 0.0
window-app BRD4161A (read only) 786164 786228 64 0.0
.text 786156 786220 64 0.0
esp32 all-clusters-app c3devkit (read only) 856018 856056 38 0.0
.flash.text 856018 856056 38 0.0
m5stack (read only) 959935 959959 24 0.0
.flash.text 954551 954575 24 0.0
linux chip-tool-ipv6only arm64 (read only) 6848196 6848356 160 0.0
.text 5803380 5803540 160 0.0
thermostat-no-ble arm64 (read only) 1947044 1947124 80 0.0
.text 1614096 1614176 80 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 text 612912 612924 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 869827 869843 16 0.0
text 587640 587652 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832810 16 0.0
text 543340 543352 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 879423 16 0.0
text 592356 592368 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805682 16 0.0
text 522876 522888 12 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 884363 16 0.0
text 595948 595960 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877603 16 0.0
text 591144 591156 12 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781943 16 0.0
text 523588 523600 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696990 16 0.0
text 444228 444240 12 0.0
p6 all-clusters-app default (read/write) 2354544 2354592 48 0.0
.text 1312808 1312856 48 0.0
light-app default (read/write) 2294720 2294768 48 0.0
.text 1252984 1253032 48 0.0
lock-app default (read/write) 2270784 2270832 48 0.0
.text 1229048 1229096 48 0.0
qpg lighting-app qpg6100+debug (read only) 521328 521344 16 0.0
.text 516008 516024 16 0.0
lock-app qpg6100+debug (read only) 495696 495704 8 0.0
.text 490376 490384 8 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 811010 32 0.0
text 566032 566060 28 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section de0af9a 82e299a change % change
efr32 lighting-app BRD4161A (read only) 809188 809252 64 0.0
(read/write) 123148 123148 0 0.0
.bss 121288 121288 0 0.0
.data 1860 1860 0 0.0
.text 809180 809244 64 0.0
BRD4161A+rpc (read only) 796824 796872 48 0.0
(read/write) 139824 139824 0 0.0
.bss 137864 137864 0 0.0
.data 1960 1960 0 0.0
.text 796816 796864 48 0.0
window-app BRD4161A (read only) 786164 786228 64 0.0
(read/write) 121280 121280 0 0.0
.bss 119456 119456 0 0.0
.data 1824 1824 0 0.0
.text 786156 786220 64 0.0
esp32 all-clusters-app c3devkit (read only) 856018 856056 38 0.0
(read/write) 1305050 1305050 0 0.0
.dram0.bss 65032 65032 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172856 172856 0 0.0
.flash.text 856018 856056 38 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 959935 959959 24 0.0
(read/write) 450776 450776 0 0.0
.dram0.bss 74320 74320 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210620 210620 0 0.0
.flash.text 954551 954575 24 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669576 669576 0 0.0
.bss 73872 73872 0 0.0
.data 1892 1892 0 0.0
.text 588012 588012 0 0.0
lock-app k32w061+debug (read/write) 619524 619524 0 0.0
.bss 72024 72024 0 0.0
.data 1852 1852 0 0.0
.text 539848 539848 0 0.0
shell k32w061+debug (read/write) 624624 624624 0 0.0
.bss 74252 74252 0 0.0
.data 1832 1832 0 0.0
.text 542740 542740 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6848196 6848356 160 0.0
(read/write) 318945 318945 0 0.0
.bss 51985 51985 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208656 208656 0 0.0
.dynamic 560 560 0 0.0
.got 53384 53384 0 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364116 364116 0 0.0
.text 5803380 5803540 160 0.0
thermostat-no-ble arm64 (read only) 1947044 1947124 80 0.0
(read/write) 137201 137201 0 0.0
.bss 59601 59601 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70304 70304 0 0.0
.dynamic 560 560 0 0.0
.got 3592 3592 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125444 125444 0 0.0
.text 1614096 1614176 80 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313768 2313768 0 0.0
.bss 184300 184300 0 0.0
.data 5232 5232 0 0.0
.heap 846912 846912 0 0.0
.text 1276344 1276344 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308944 2308944 0 0.0
.bss 175824 175824 0 0.0
.data 5528 5528 0 0.0
.heap 855096 855096 0 0.0
.text 1271544 1271544 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282064 2282064 0 0.0
.bss 174864 174864 0 0.0
.data 5520 5520 0 0.0
.heap 856064 856064 0 0.0
.text 1244664 1244664 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053336 2053336 0 0.0
.bss 156900 156900 0 0.0
.data 4864 4864 0 0.0
.heap 874680 874680 0 0.0
.text 1015936 1015936 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 906795 906795 0 0.0
bss 116296 116296 0 0.0
rodata 101980 101980 0 0.0
text 612912 612924 12 0.0
nrf52840dk_nrf52840+rpc (read/write) 869827 869843 16 0.0
bss 112644 112644 0 0.0
rodata 93276 93276 0 0.0
text 587640 587652 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 832794 832810 16 0.0
bss 117672 117672 0 0.0
rodata 97236 97236 0 0.0
text 543340 543352 12 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879407 879423 16 0.0
bss 113560 113560 0 0.0
rodata 98096 98096 0 0.0
text 592356 592368 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805666 805682 16 0.0
bss 114968 114968 0 0.0
rodata 93388 93388 0 0.0
text 522876 522888 12 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884347 884363 16 0.0
bss 113472 113472 0 0.0
rodata 99452 99452 0 0.0
text 595948 595960 12 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877587 877603 16 0.0
bss 113348 113348 0 0.0
rodata 97588 97588 0 0.0
text 591144 591156 12 0.0
shell nrf52840dk_nrf52840 (read/write) 781927 781943 16 0.0
bss 109544 109544 0 0.0
rodata 74276 74276 0 0.0
text 523588 523600 12 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696974 696990 16 0.0
bss 110524 110524 0 0.0
rodata 68920 68920 0 0.0
text 444228 444240 12 0.0
p6 all-clusters-app default (read/write) 2354544 2354592 48 0.0
.bss 112436 112436 0 0.0
.data 2520 2520 0 0.0
.heap 918384 918384 0 0.0
.text 1312808 1312856 48 0.0
light-app default (read/write) 2294720 2294768 48 0.0
.bss 101016 101016 0 0.0
.data 2360 2360 0 0.0
.heap 929968 929968 0 0.0
.text 1252984 1253032 48 0.0
lock-app default (read/write) 2270784 2270832 48 0.0
.bss 99896 99896 0 0.0
.data 2328 2328 0 0.0
.heap 931120 931120 0 0.0
.text 1229048 1229096 48 0.0
qpg lighting-app qpg6100+debug (read only) 521328 521344 16 0.0
(read/write) 122336 122336 0 0.0
.bss 82712 82712 0 0.0
.data 992 992 0 0.0
.text 516008 516024 16 0.0
lock-app qpg6100+debug (read only) 495696 495704 8 0.0
(read/write) 122332 122332 0 0.0
.bss 81848 81848 0 0.0
.data 948 948 0 0.0
.text 490376 490384 8 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 810978 811010 32 0.0
bss 82864 82864 0 0.0
noinit 37160 37160 0 0.0
text 566032 566060 28 0.0

@andy31415 andy31415 merged commit 4c5d042 into project-chip:master Dec 10, 2021
@kpschoedel kpschoedel deleted the x7715-inet-layer-stats branch December 10, 2021 16:21
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Dec 10, 2021
@kpschoedel
Remove some flaky test assertions
7e1c7fe 
#### Problem

SystemStats-related assertions added in project-chip#12885
seem flaky.

#### Change overview

Remove pending investigation.
@kpschoedel kpschoedel mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
inet review - approved system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the Impl's underlying ObjectPool statistics
3 participants
@kpschoedel @andy31415 @Damian-Nordic