Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network Commissioning] Update NetworkCommissioning Cluster define #12875

Merged
merged 10 commits into from
Dec 13, 2021
Merged

[Network Commissioning] Update NetworkCommissioning Cluster define #12875

merged 10 commits into from
Dec 13, 2021

Conversation

erjiaqing
Copy link
Contributor

Problem

  • Update network commissioning cluster define to align with latest spec.

Change overview

  • Update .zap files
  • Rerun codegen
  • Update chip-tool code to use updated commands

Testing

  • CI should still pass after this PR is finished.

@restyled-io restyled-io bot mentioned this pull request Dec 10, 2021
Closed
@erjiaqing erjiaqing force-pushed the nwprov-final/structs branch from 2d2b66a to e715e89 Compare December 10, 2021 09:12
@erjiaqing erjiaqing force-pushed the nwprov-final/structs branch from 0af7788 to 44c25ac Compare December 13, 2021 02:21
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github labels Dec 13, 2021
@erjiaqing erjiaqing mentioned this pull request Dec 13, 2021
Merged
@erjiaqing
Copy link
Contributor Author

This seems to imply we support multiple WiFi and or thread networks, but we don’t?

This PR is focusing on basic renaming, and not the full functions, a refactor of network commissioning cluster is at #12931

@erjiaqing erjiaqing force-pushed the nwprov-final/structs branch 2 times, most recently from 99cf6a4 to cae26ba Compare December 13, 2021 05:53
@erjiaqing erjiaqing force-pushed the nwprov-final/structs branch from cae26ba to 98839a2 Compare December 13, 2021 06:31
@restyled-io restyled-io bot mentioned this pull request Dec 13, 2021
Closed
@erjiaqing erjiaqing force-pushed the nwprov-final/structs branch from 98839a2 to bf7243f Compare December 13, 2021 06:43
@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12875: Size comparison from f85d6ed to bf7243f

Increases above 0.2%:

platform target config section f85d6ed bf7243f change % change
linux chip-tool-ipv6only arm64 .got 53512 53656 144 0.3
Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f85d6ed bf7243f change % change
efr32 lighting-app BRD4161A (read/write) 123152 123208 56 0.0
.bss 121288 121344 56 0.0
BRD4161A+rpc (read/write) 139828 139884 56 0.0
.bss 137864 137920 56 0.0
window-app BRD4161A (read/write) 122104 122160 56 0.0
.bss 120272 120328 56 0.0
esp32 all-clusters-app c3devkit (read/write) 1304378 1304578 200 0.0
.dram0.bss 64696 64752 56 0.1
.flash.rodata 172520 172672 152 0.1
m5stack (read/write) 450092 450300 208 0.0
.dram0.bss 73976 74032 56 0.1
.flash.rodata 210280 210432 152 0.1
k32w lighting-app k32w061+se05x+release .bss 73872 73928 56 0.1
lock-app k32w061+debug .bss 72024 72080 56 0.1
shell k32w061+debug .bss 74332 74388 56 0.1
linux chip-tool-ipv6only arm64 (read only) 6863180 6865388 2208 0.0
(read/write) 318737 318865 128 0.0
.got 53512 53656 144 0.3
.rodata 364988 365404 416 0.1
.text 5817828 5818836 1008 0.0
thermostat-no-ble arm64 (read/write) 137425 137617 192 0.1
.bss 59537 59585 48 0.1
.data.rel.ro 70528 70672 144 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 183964 184020 56 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 175824 175880 56 0.0
lock-app CY8CPROTO_062_4343W+release .bss 174864 174920 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116300 116352 52 0.0
rodata 102008 102168 160 0.2
nrf52840dk_nrf52840+rpc bss 112648 112700 52 0.0
rodata 93308 93468 160 0.2
nrf5340dk_nrf5340_cpuapp bss 117672 117728 56 0.0
rodata 97268 97428 160 0.2
lock-app nrf52840dk_nrf52840 bss 113560 113616 56 0.0
rodata 98128 98288 160 0.2
nrf5340dk_nrf5340_cpuapp bss 114972 115024 52 0.0
rodata 93416 93576 160 0.2
pump-app nrf52840dk_nrf52840 bss 113472 113528 56 0.0
rodata 99480 99640 160 0.2
pump-controller-app nrf52840dk_nrf52840 bss 113352 113404 52 0.0
rodata 97616 97776 160 0.2
p6 all-clusters-app default .bss 112164 112220 56 0.0
light-app default .bss 101080 101136 56 0.1
lock-app default .bss 99960 100016 56 0.1
qpg lighting-app qpg6100+debug .bss 82712 82768 56 0.1
lock-app qpg6100+debug .bss 81848 81904 56 0.1
telink lighting-app tlsr9518adk80d bss 82864 82920 56 0.1
Decreases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f85d6ed bf7243f change % change
efr32 lighting-app BRD4161A (read only) 815980 815484 -496 -0.1
.text 815972 815476 -496 -0.1
BRD4161A+rpc (read only) 803612 803116 -496 -0.1
.text 803604 803108 -496 -0.1
window-app BRD4161A (read only) 793056 792576 -480 -0.1
.text 793048 792568 -480 -0.1
esp32 all-clusters-app c3devkit (read only) 857268 856604 -664 -0.1
.flash.text 857268 856604 -664 -0.1
m5stack (read only) 960819 960215 -604 -0.1
.flash.text 955435 954831 -604 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 670436 670028 -408 -0.1
.text 588868 588404 -464 -0.1
lock-app k32w061+debug (read/write) 620372 619964 -408 -0.1
.text 540692 540228 -464 -0.1
shell k32w061+debug (read/write) 625740 625332 -408 -0.1
.text 543772 543308 -464 -0.1
linux chip-tool-ipv6only arm64 .data.rel.ro 208416 208392 -24 -0.0
thermostat-no-ble arm64 (read only) 1954356 1951188 -3168 -0.2
.rodata 125780 125748 -32 -0.0
.text 1620464 1617328 -3136 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314104 2313600 -504 -0.0
.heap 847240 847184 -56 -0.0
.text 1276680 1276176 -504 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309960 2309456 -504 -0.0
.heap 855088 855032 -56 -0.0
.text 1272560 1272056 -504 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2283072 2282568 -504 -0.0
.heap 856056 856000 -56 -0.0
.text 1245672 1245168 -504 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907735 907319 -416 -0.0
text 613828 613220 -608 -0.1
nrf52840dk_nrf52840+rpc (read/write) 870803 870387 -416 -0.0
text 588572 587964 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 833738 833322 -416 -0.0
text 544256 543648 -608 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 880351 879967 -384 -0.0
text 593264 592656 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 806606 806222 -384 -0.0
text 523784 523176 -608 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 885303 884919 -384 -0.0
text 596868 596260 -608 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 878543 878127 -416 -0.0
text 592064 591456 -608 -0.1
p6 all-clusters-app default (read/write) 2361000 2360512 -488 -0.0
.heap 918648 918592 -56 -0.0
.text 1319264 1318776 -488 -0.0
light-app default (read/write) 2301600 2301096 -504 -0.0
.heap 929896 929840 -56 -0.0
.text 1259864 1259360 -504 -0.0
lock-app default (read/write) 2277672 2277184 -488 -0.0
.heap 931056 931000 -56 -0.0
.text 1235936 1235448 -488 -0.0
qpg lighting-app qpg6100+debug (read only) 522184 521736 -448 -0.1
.text 516864 516416 -448 -0.1
lock-app qpg6100+debug (read only) 496564 496108 -456 -0.1
.text 491244 490788 -456 -0.1
telink lighting-app tlsr9518adk80d (read/write) 812282 811842 -440 -0.1
text 567284 566642 -642 -0.1
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section f85d6ed bf7243f change % change
efr32 lighting-app BRD4161A (read only) 815980 815484 -496 -0.1
(read/write) 123152 123208 56 0.0
.bss 121288 121344 56 0.0
.data 1864 1864 0 0.0
.text 815972 815476 -496 -0.1
BRD4161A+rpc (read only) 803612 803116 -496 -0.1
(read/write) 139828 139884 56 0.0
.bss 137864 137920 56 0.0
.data 1964 1964 0 0.0
.text 803604 803108 -496 -0.1
window-app BRD4161A (read only) 793056 792576 -480 -0.1
(read/write) 122104 122160 56 0.0
.bss 120272 120328 56 0.0
.data 1828 1828 0 0.0
.text 793048 792568 -480 -0.1
esp32 all-clusters-app c3devkit (read only) 857268 856604 -664 -0.1
(read/write) 1304378 1304578 200 0.0
.dram0.bss 64696 64752 56 0.1
.dram0.data 14124 14124 0 0.0
.flash.rodata 172520 172672 152 0.1
.flash.text 857268 856604 -664 -0.1
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960819 960215 -604 -0.1
(read/write) 450092 450300 208 0.0
.dram0.bss 73976 74032 56 0.1
.dram0.data 34048 34048 0 0.0
.flash.rodata 210280 210432 152 0.1
.flash.text 955435 954831 -604 -0.1
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 670436 670028 -408 -0.1
.bss 73872 73928 56 0.1
.data 1896 1896 0 0.0
.text 588868 588404 -464 -0.1
lock-app k32w061+debug (read/write) 620372 619964 -408 -0.1
.bss 72024 72080 56 0.1
.data 1856 1856 0 0.0
.text 540692 540228 -464 -0.1
shell k32w061+debug (read/write) 625740 625332 -408 -0.1
.bss 74332 74388 56 0.1
.data 1836 1836 0 0.0
.text 543772 543308 -464 -0.1
linux chip-tool-ipv6only arm64 (read only) 6863180 6865388 2208 0.0
(read/write) 318737 318865 128 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208416 208392 -24 -0.0
.dynamic 560 560 0 0.0
.got 53512 53656 144 0.3
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364988 365404 416 0.1
.text 5817828 5818836 1008 0.0
thermostat-no-ble arm64 (read only) 1954356 1951188 -3168 -0.2
(read/write) 137425 137617 192 0.1
.bss 59537 59585 48 0.1
.data 832 832 0 0.0
.data.rel.ro 70528 70672 144 0.2
.dynamic 560 560 0 0.0
.got 3648 3648 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125780 125748 -32 -0.0
.text 1620464 1617328 -3136 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314104 2313600 -504 -0.0
.bss 183964 184020 56 0.0
.data 5240 5240 0 0.0
.heap 847240 847184 -56 -0.0
.text 1276680 1276176 -504 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309960 2309456 -504 -0.0
.bss 175824 175880 56 0.0
.data 5536 5536 0 0.0
.heap 855088 855032 -56 -0.0
.text 1272560 1272056 -504 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283072 2282568 -504 -0.0
.bss 174864 174920 56 0.0
.data 5528 5528 0 0.0
.heap 856056 856000 -56 -0.0
.text 1245672 1245168 -504 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907735 907319 -416 -0.0
bss 116300 116352 52 0.0
rodata 102008 102168 160 0.2
text 613828 613220 -608 -0.1
nrf52840dk_nrf52840+rpc (read/write) 870803 870387 -416 -0.0
bss 112648 112700 52 0.0
rodata 93308 93468 160 0.2
text 588572 587964 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 833738 833322 -416 -0.0
bss 117672 117728 56 0.0
rodata 97268 97428 160 0.2
text 544256 543648 -608 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 880351 879967 -384 -0.0
bss 113560 113616 56 0.0
rodata 98128 98288 160 0.2
text 593264 592656 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 806606 806222 -384 -0.0
bss 114972 115024 52 0.0
rodata 93416 93576 160 0.2
text 523784 523176 -608 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885303 884919 -384 -0.0
bss 113472 113528 56 0.0
rodata 99480 99640 160 0.2
text 596868 596260 -608 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 878543 878127 -416 -0.0
bss 113352 113404 52 0.0
rodata 97616 97776 160 0.2
text 592064 591456 -608 -0.1
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2361000 2360512 -488 -0.0
.bss 112164 112220 56 0.0
.data 2528 2528 0 0.0
.heap 918648 918592 -56 -0.0
.text 1319264 1318776 -488 -0.0
light-app default (read/write) 2301600 2301096 -504 -0.0
.bss 101080 101136 56 0.1
.data 2368 2368 0 0.0
.heap 929896 929840 -56 -0.0
.text 1259864 1259360 -504 -0.0
lock-app default (read/write) 2277672 2277184 -488 -0.0
.bss 99960 100016 56 0.1
.data 2328 2328 0 0.0
.heap 931056 931000 -56 -0.0
.text 1235936 1235448 -488 -0.0
qpg lighting-app qpg6100+debug (read only) 522184 521736 -448 -0.1
(read/write) 122332 122332 0 0.0
.bss 82712 82768 56 0.1
.data 996 996 0 0.0
.text 516864 516416 -448 -0.1
lock-app qpg6100+debug (read only) 496564 496108 -456 -0.1
(read/write) 122336 122336 0 0.0
.bss 81848 81904 56 0.1
.data 952 952 0 0.0
.text 491244 490788 -456 -0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812282 811842 -440 -0.1
bss 82864 82920 56 0.1
noinit 37160 37160 0 0.0
text 567284 566642 -642 -0.1

@restyled-io restyled-io bot mentioned this pull request Dec 13, 2021
Closed
@github-actions
Copy link

PR #12875: Size comparison from 73776ef to 6007689

Increases above 0.2%:

platform target config section 73776ef 6007689 change % change
linux chip-tool-ipv6only arm64 .got 53576 53720 144 0.3
thermostat-no-ble arm64 .data.rel.ro 70600 70744 144 0.2
Increases (8 builds for k32w, linux, qpg, telink)
platform target config section 73776ef 6007689 change % change
k32w lock-app k32w061+debug .bss 72024 72080 56 0.1
shell k32w061+debug .bss 74332 74388 56 0.1
lighting-app k32w061+se05x+release .bss 73872 73928 56 0.1
linux chip-tool-ipv6only arm64 (read only) 6873564 6875788 2224 0.0
(read/write) 319201 319329 128 0.0
.got 53576 53720 144 0.3
.rodata 365692 366108 416 0.1
.text 5826788 5827812 1024 0.0
thermostat-no-ble arm64 (read/write) 137537 137729 192 0.1
.bss 59537 59585 48 0.1
.data.rel.ro 70600 70744 144 0.2
qpg lighting-app qpg6100+debug .bss 82712 82768 56 0.1
lock-app qpg6100+debug .bss 81848 81904 56 0.1
telink lighting-app tlsr9518adk80d bss 82864 82920 56 0.1
Decreases (8 builds for k32w, linux, qpg, telink)
platform target config section 73776ef 6007689 change % change
k32w lock-app k32w061+debug (read/write) 620344 619920 -424 -0.1
.text 540664 540184 -480 -0.1
shell k32w061+debug (read/write) 625712 625288 -424 -0.1
.text 543744 543264 -480 -0.1
lighting-app k32w061+se05x+release (read/write) 670408 669984 -424 -0.1
.text 588840 588360 -480 -0.1
linux chip-tool-ipv6only arm64 .data.rel.ro 208784 208760 -24 -0.0
thermostat-no-ble arm64 (read only) 1954660 1951492 -3168 -0.2
.rodata 125796 125764 -32 -0.0
.text 1620512 1617376 -3136 -0.2
qpg lighting-app qpg6100+debug (read only) 522160 521712 -448 -0.1
.text 516840 516392 -448 -0.1
lock-app qpg6100+debug (read only) 496532 496076 -456 -0.1
.text 491212 490756 -456 -0.1
telink lighting-app tlsr9518adk80d (read/write) 812262 811822 -440 -0.1
text 567218 566576 -642 -0.1
Full report (9 builds for k32w, linux, qpg, telink)
platform target config section 73776ef 6007689 change % change
k32w lock-app k32w061+debug (read/write) 620344 619920 -424 -0.1
.bss 72024 72080 56 0.1
.data 1856 1856 0 0.0
.text 540664 540184 -480 -0.1
shell k32w061+debug (read/write) 625712 625288 -424 -0.1
.bss 74332 74388 56 0.1
.data 1836 1836 0 0.0
.text 543744 543264 -480 -0.1
lighting-app k32w061+se05x+release (read/write) 670408 669984 -424 -0.1
.bss 73872 73928 56 0.1
.data 1896 1896 0 0.0
.text 588840 588360 -480 -0.1
linux chip-tool-ipv6only arm64 (read only) 6873564 6875788 2224 0.0
(read/write) 319201 319329 128 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208760 -24 -0.0
.dynamic 560 560 0 0.0
.got 53576 53720 144 0.3
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 366108 416 0.1
.text 5826788 5827812 1024 0.0
thermostat-no-ble arm64 (read only) 1954660 1951492 -3168 -0.2
(read/write) 137537 137729 192 0.1
.bss 59537 59585 48 0.1
.data 832 832 0 0.0
.data.rel.ro 70600 70744 144 0.2
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125764 -32 -0.0
.text 1620512 1617376 -3136 -0.2
qpg lighting-app qpg6100+debug (read only) 522160 521712 -448 -0.1
(read/write) 122332 122332 0 0.0
.bss 82712 82768 56 0.1
.data 996 996 0 0.0
.text 516840 516392 -448 -0.1
lock-app qpg6100+debug (read only) 496532 496076 -456 -0.1
(read/write) 122336 122336 0 0.0
.bss 81848 81904 56 0.1
.data 952 952 0 0.0
.text 491212 490756 -456 -0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 811822 -440 -0.1
bss 82864 82920 56 0.1
noinit 37160 37160 0 0.0
text 567218 566576 -642 -0.1

@github-actions
Copy link

github-actions bot commented Dec 13, 2021 •
edited
Loading

PR #12875: Size comparison from 73776ef to 6eb1b13

Increases above 0.2%:

platform target config section 73776ef 6eb1b13 change % change
linux chip-tool-ipv6only arm64 .got 53576 53720 144 0.3
Increases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 73776ef 6eb1b13 change % change
efr32 lighting-app BRD4161A (read/write) 123152 123208 56 0.0
.bss 121288 121344 56 0.0
BRD4161A+rpc (read/write) 139828 139884 56 0.0
.bss 137864 137920 56 0.0
window-app BRD4161A (read/write) 122104 122160 56 0.0
.bss 120272 120328 56 0.0
k32w lighting-app k32w061+se05x+release .bss 73872 73928 56 0.1
lock-app k32w061+debug .bss 72024 72080 56 0.1
shell k32w061+debug .bss 74332 74388 56 0.1
linux chip-tool-ipv6only arm64 (read only) 6873564 6875788 2224 0.0
(read/write) 319201 319329 128 0.0
.got 53576 53720 144 0.3
.rodata 365692 366108 416 0.1
.text 5826788 5827812 1024 0.0
thermostat-no-ble arm64 (read/write) 137537 137729 192 0.1
.bss 59537 59585 48 0.1
.data.rel.ro 70600 70744 144 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 183964 184020 56 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 175824 175880 56 0.0
lock-app CY8CPROTO_062_4343W+release .bss 174864 174920 56 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 116300 116352 52 0.0
rodata 102060 102220 160 0.2
nrf52840dk_nrf52840+rpc bss 112648 112700 52 0.0
rodata 93360 93520 160 0.2
nrf5340dk_nrf5340_cpuapp bss 117672 117728 56 0.0
rodata 97320 97480 160 0.2
lock-app nrf52840dk_nrf52840 bss 113560 113616 56 0.0
rodata 98180 98340 160 0.2
nrf5340dk_nrf5340_cpuapp bss 114972 115024 52 0.0
rodata 93468 93628 160 0.2
pump-app nrf52840dk_nrf52840 bss 113472 113528 56 0.0
rodata 99532 99692 160 0.2
pump-controller-app nrf52840dk_nrf52840 bss 113352 113404 52 0.0
rodata 97668 97828 160 0.2
p6 all-clusters-app default .bss 112164 112220 56 0.0
light-app default .bss 101080 101136 56 0.1
lock-app default .bss 99960 100016 56 0.1
qpg lighting-app qpg6100+debug .bss 82712 82768 56 0.1
lock-app qpg6100+debug .bss 81848 81904 56 0.1
telink lighting-app tlsr9518adk80d bss 82864 82920 56 0.1
Decreases (24 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 73776ef 6eb1b13 change % change
efr32 lighting-app BRD4161A (read only) 815948 815452 -496 -0.1
.text 815940 815444 -496 -0.1
BRD4161A+rpc (read only) 803580 803084 -496 -0.1
.text 803572 803076 -496 -0.1
window-app BRD4161A (read only) 793008 792528 -480 -0.1
.text 793000 792520 -480 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 670408 669984 -424 -0.1
.text 588840 588360 -480 -0.1
lock-app k32w061+debug (read/write) 620344 619920 -424 -0.1
.text 540664 540184 -480 -0.1
shell k32w061+debug (read/write) 625712 625288 -424 -0.1
.text 543744 543264 -480 -0.1
linux chip-tool-ipv6only arm64 .data.rel.ro 208784 208760 -24 -0.0
thermostat-no-ble arm64 (read only) 1954660 1951492 -3168 -0.2
.rodata 125796 125764 -32 -0.0
.text 1620512 1617376 -3136 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2314032 2313592 -440 -0.0
.heap 847240 847184 -56 -0.0
.text 1276608 1276168 -440 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2309888 2309448 -440 -0.0
.heap 855088 855032 -56 -0.0
.text 1272488 1272048 -440 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2283000 2282560 -440 -0.0
.heap 856056 856000 -56 -0.0
.text 1245600 1245160 -440 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907723 907307 -416 -0.0
text 613756 613148 -608 -0.1
nrf52840dk_nrf52840+rpc (read/write) 870775 870359 -416 -0.0
text 588500 587892 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 833726 833310 -416 -0.0
text 544184 543576 -608 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 880339 879955 -384 -0.0
text 593192 592584 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 806578 806194 -384 -0.0
text 523712 523104 -608 -0.1
pump-app nrf52840dk_nrf52840 (read/write) 885291 884907 -384 -0.0
text 596796 596188 -608 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 878515 878099 -416 -0.0
text 591992 591384 -608 -0.1
p6 all-clusters-app default (read/write) 2360976 2360472 -504 -0.0
.heap 918648 918592 -56 -0.0
.text 1319240 1318736 -504 -0.0
light-app default (read/write) 2301568 2301064 -504 -0.0
.heap 929896 929840 -56 -0.0
.text 1259832 1259328 -504 -0.0
lock-app default (read/write) 2277640 2277136 -504 -0.0
.heap 931056 931000 -56 -0.0
.text 1235904 1235400 -504 -0.0
qpg lighting-app qpg6100+debug (read only) 522160 521712 -448 -0.1
.text 516840 516392 -448 -0.1
lock-app qpg6100+debug (read only) 496532 496076 -456 -0.1
.text 491212 490756 -456 -0.1
telink lighting-app tlsr9518adk80d (read/write) 812262 811822 -440 -0.1
text 567218 566576 -642 -0.1
Full report (30 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 73776ef 6eb1b13 change % change
efr32 lighting-app BRD4161A (read only) 815948 815452 -496 -0.1
(read/write) 123152 123208 56 0.0
.bss 121288 121344 56 0.0
.data 1864 1864 0 0.0
.text 815940 815444 -496 -0.1
BRD4161A+rpc (read only) 803580 803084 -496 -0.1
(read/write) 139828 139884 56 0.0
.bss 137864 137920 56 0.0
.data 1964 1964 0 0.0
.text 803572 803076 -496 -0.1
window-app BRD4161A (read only) 793008 792528 -480 -0.1
(read/write) 122104 122160 56 0.0
.bss 120272 120328 56 0.0
.data 1828 1828 0 0.0
.text 793000 792520 -480 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 670408 669984 -424 -0.1
.bss 73872 73928 56 0.1
.data 1896 1896 0 0.0
.text 588840 588360 -480 -0.1
lock-app k32w061+debug (read/write) 620344 619920 -424 -0.1
.bss 72024 72080 56 0.1
.data 1856 1856 0 0.0
.text 540664 540184 -480 -0.1
shell k32w061+debug (read/write) 625712 625288 -424 -0.1
.bss 74332 74388 56 0.1
.data 1836 1836 0 0.0
.text 543744 543264 -480 -0.1
linux chip-tool-ipv6only arm64 (read only) 6873564 6875788 2224 0.0
(read/write) 319201 319329 128 0.0
.bss 51921 51921 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208784 208760 -24 -0.0
.dynamic 560 560 0 0.0
.got 53576 53720 144 0.3
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 365692 366108 416 0.1
.text 5826788 5827812 1024 0.0
thermostat-no-ble arm64 (read only) 1954660 1951492 -3168 -0.2
(read/write) 137537 137729 192 0.1
.bss 59537 59585 48 0.1
.data 832 832 0 0.0
.data.rel.ro 70600 70744 144 0.2
.dynamic 560 560 0 0.0
.got 3680 3680 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 125796 125764 -32 -0.0
.text 1620512 1617376 -3136 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2314032 2313592 -440 -0.0
.bss 183964 184020 56 0.0
.data 5240 5240 0 0.0
.heap 847240 847184 -56 -0.0
.text 1276608 1276168 -440 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309888 2309448 -440 -0.0
.bss 175824 175880 56 0.0
.data 5536 5536 0 0.0
.heap 855088 855032 -56 -0.0
.text 1272488 1272048 -440 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2283000 2282560 -440 -0.0
.bss 174864 174920 56 0.0
.data 5528 5528 0 0.0
.heap 856056 856000 -56 -0.0
.text 1245600 1245160 -440 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053944 2053944 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016544 1016544 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907723 907307 -416 -0.0
bss 116300 116352 52 0.0
rodata 102060 102220 160 0.2
text 613756 613148 -608 -0.1
nrf52840dk_nrf52840+rpc (read/write) 870775 870359 -416 -0.0
bss 112648 112700 52 0.0
rodata 93360 93520 160 0.2
text 588500 587892 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 833726 833310 -416 -0.0
bss 117672 117728 56 0.0
rodata 97320 97480 160 0.2
text 544184 543576 -608 -0.1
lock-app nrf52840dk_nrf52840 (read/write) 880339 879955 -384 -0.0
bss 113560 113616 56 0.0
rodata 98180 98340 160 0.2
text 593192 592584 -608 -0.1
nrf5340dk_nrf5340_cpuapp (read/write) 806578 806194 -384 -0.0
bss 114972 115024 52 0.0
rodata 93468 93628 160 0.2
text 523712 523104 -608 -0.1
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 885291 884907 -384 -0.0
bss 113472 113528 56 0.0
rodata 99532 99692 160 0.2
text 596796 596188 -608 -0.1
pump-controller-app nrf52840dk_nrf52840 (read/write) 878515 878099 -416 -0.0
bss 113352 113404 52 0.0
rodata 97668 97828 160 0.2
text 591992 591384 -608 -0.1
shell nrf52840dk_nrf52840 (read/write) 782427 782427 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523996 523996 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697506 697506 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444636 444636 0 0.0
p6 all-clusters-app default (read/write) 2360976 2360472 -504 -0.0
.bss 112164 112220 56 0.0
.data 2528 2528 0 0.0
.heap 918648 918592 -56 -0.0
.text 1319240 1318736 -504 -0.0
light-app default (read/write) 2301568 2301064 -504 -0.0
.bss 101080 101136 56 0.1
.data 2368 2368 0 0.0
.heap 929896 929840 -56 -0.0
.text 1259832 1259328 -504 -0.0
lock-app default (read/write) 2277640 2277136 -504 -0.0
.bss 99960 100016 56 0.1
.data 2328 2328 0 0.0
.heap 931056 931000 -56 -0.0
.text 1235904 1235400 -504 -0.0
qpg lighting-app qpg6100+debug (read only) 522160 521712 -448 -0.1
(read/write) 122332 122332 0 0.0
.bss 82712 82768 56 0.1
.data 996 996 0 0.0
.text 516840 516392 -448 -0.1
lock-app qpg6100+debug (read only) 496532 496076 -456 -0.1
(read/write) 122336 122336 0 0.0
.bss 81848 81904 56 0.1
.data 952 952 0 0.0
.text 491212 490756 -456 -0.1
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 812262 811822 -440 -0.1
bss 82864 82920 56 0.1
noinit 37160 37160 0 0.0
text 567218 566576 -642 -0.1

@andy31415 andy31415 merged commit 5d19a98 into project-chip:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
android app controller documentation Improvements or additions to documentation examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erjiaqing @Damian-Nordic @yufengwangca @woody-apple @andy31415 @austinh0