Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Accessors implementations for global attributes. #12839

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

#12808 added declarations but not definitions.

Change overview

Add definitions.

Testing

Code inspection.

@andy31415
Copy link
Contributor

fast track: missing delta from previous change.

@andy31415 andy31415 merged commit b20bf90 into project-chip:master Dec 9, 2021
@bzbarsky-apple bzbarsky-apple deleted the global-accessors-for-real branch December 9, 2021 20:50
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12839: Size comparison from 7b66b77 to 23d8f78

Full report (29 builds for esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 7b66b77 23d8f78 change % change
esp32 all-clusters-app c3devkit (read only) 862122 862122 0 0.0
(read/write) 1305546 1305546 0 0.0
.dram0.bss 65696 65696 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172696 172696 0 0.0
.flash.text 862122 862122 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 965131 965131 0 0.0
(read/write) 451248 451248 0 0.0
.dram0.bss 74992 74992 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210420 210420 0 0.0
.flash.text 959747 959747 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 668788 668788 0 0.0
.bss 73744 73744 0 0.0
.data 1880 1880 0 0.0
.text 587364 587364 0 0.0
lock-app k32w061+debug (read/write) 618380 618380 0 0.0
.bss 71896 71896 0 0.0
.data 1848 1848 0 0.0
.text 538836 538836 0 0.0
shell k32w061+debug (read/write) 623472 623472 0 0.0
.bss 74124 74124 0 0.0
.data 1820 1820 0 0.0
.text 541728 541728 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6791628 6791628 0 0.0
(read/write) 318273 318273 0 0.0
.bss 51713 51713 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 208720 208720 0 0.0
.dynamic 560 560 0 0.0
.got 53048 53048 0 0.0
.init 24 24 0 0.0
.init_array 168 168 0 0.0
.rodata 363836 363836 0 0.0
.text 5748852 5748852 0 0.0
thermostat-no-ble arm64 (read only) 1942516 1942516 0 0.0
(read/write) 136865 136865 0 0.0
.bss 59441 59441 0 0.0
.data 824 824 0 0.0
.data.rel.ro 70160 70160 0 0.0
.dynamic 560 560 0 0.0
.got 3568 3568 0 0.0
.init 24 24 0 0.0
.init_array 264 264 0 0.0
.rodata 125236 125236 0 0.0
.text 1610128 1610128 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2323512 2323512 0 0.0
.bss 184972 184972 0 0.0
.data 5232 5232 0 0.0
.heap 846240 846240 0 0.0
.text 1286088 1286088 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2308144 2308144 0 0.0
.bss 175688 175688 0 0.0
.data 5520 5520 0 0.0
.heap 855240 855240 0 0.0
.text 1270744 1270744 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2280872 2280872 0 0.0
.bss 174728 174728 0 0.0
.data 5520 5520 0 0.0
.heap 856200 856200 0 0.0
.text 1243472 1243472 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 905827 905827 0 0.0
bss 116168 116168 0 0.0
rodata 101620 101620 0 0.0
text 612436 612436 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 868855 868855 0 0.0
bss 112516 112516 0 0.0
rodata 92920 92920 0 0.0
text 587164 587164 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 831822 831822 0 0.0
bss 117544 117544 0 0.0
rodata 96880 96880 0 0.0
text 542864 542864 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 878059 878059 0 0.0
bss 113432 113432 0 0.0
rodata 97740 97740 0 0.0
text 591496 591496 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 804306 804306 0 0.0
bss 114840 114840 0 0.0
rodata 93028 93028 0 0.0
text 522016 522016 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 882987 882987 0 0.0
bss 113344 113344 0 0.0
rodata 99092 99092 0 0.0
text 595084 595084 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 876195 876195 0 0.0
bss 113220 113220 0 0.0
rodata 97228 97228 0 0.0
text 590248 590248 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2360096 2360096 0 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1318360 1318360 0 0.0
light-app default (read/write) 2292912 2292912 0 0.0
.bss 100880 100880 0 0.0
.data 2352 2352 0 0.0
.heap 930112 930112 0 0.0
.text 1251176 1251176 0 0.0
lock-app default (read/write) 2268768 2268768 0 0.0
.bss 99760 99760 0 0.0
.data 2320 2320 0 0.0
.heap 931264 931264 0 0.0
.text 1227032 1227032 0 0.0
qpg lighting-app qpg6100+debug (read only) 520500 520500 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82616 82616 0 0.0
.data 984 984 0 0.0
.text 515180 515180 0 0.0
lock-app qpg6100+debug (read only) 494492 494492 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81752 81752 0 0.0
.data 940 940 0 0.0
.text 489172 489172 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 809818 809818 0 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 565374 565374 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants