Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve the last read handler for ReadInteraction #12764

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Reserve the last read handler for ReadInteraction #12764

merged 1 commit into from
Dec 9, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Dec 9, 2021 •
edited
Loading

Problem

Fix #11720

Change overview

Reserve the last read handler for ReadInteraction

Testing

Update the unit test that return error when subscribe tries to grab the last readHandler

@boring-cyborg boring-cyborg bot added the app label Dec 9, 2021
@yunhanw-google yunhanw-google changed the title Feature/reserve read client Reserver the last read handler for ReadInteraction Dec 9, 2021
@yunhanw-google yunhanw-google force-pushed the feature/reserve_read_client branch from e299a07 to 623295c Compare December 9, 2021 03:15
@yunhanw-google yunhanw-google changed the title Reserver the last read handler for ReadInteraction Reserve the last read handler for ReadInteraction Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12764: Size comparison from 1423df5 to 623295c

Increases (14 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1423df5 623295c change % change
efr32 lighting-app BRD4161A (read only) 804004 804124 120 0.0
.text 803996 804116 120 0.0
BRD4161A+rpc (read only) 791616 791736 120 0.0
.text 791608 791728 120 0.0
window-app BRD4161A (read only) 780716 780852 136 0.0
.text 780708 780844 136 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724700 64 0.0
.text 635752 635816 64 0.0
lock-app k32w061+debug (read/write) 615796 615860 64 0.0
.text 536280 536344 64 0.0
shell k32w061+debug (read/write) 679052 679100 48 0.0
.text 589864 589912 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6786156 6786460 304 0.0
.rodata 342396 342444 48 0.0
.text 5782116 5782372 256 0.0
thermostat-no-ble arm64 (read only) 1931972 1932276 304 0.0
.rodata 124820 124868 48 0.0
.text 1601424 1601680 256 0.0
p6 all-clusters-app default (read/write) 2356216 2356352 136 0.0
.text 1314480 1314616 136 0.0
light-app default (read/write) 2290512 2290632 120 0.0
.text 1248776 1248896 120 0.0
lock-app default (read/write) 2266376 2266496 120 0.0
.text 1224640 1224760 120 0.0
qpg lighting-app qpg6100+debug (read only) 517944 518072 128 0.0
.text 512624 512752 128 0.0
lock-app qpg6100+debug (read only) 491944 492072 128 0.0
.text 486624 486752 128 0.0
telink lighting-app tlsr9518adk80d (read/write) 807470 807614 144 0.0
text 563534 563620 86 0.0
Full report (15 builds for efr32, k32w, linux, p6, qpg, telink)
platform target config section 1423df5 623295c change % change
efr32 lighting-app BRD4161A (read only) 804004 804124 120 0.0
(read/write) 122988 122988 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 803996 804116 120 0.0
BRD4161A+rpc (read only) 791616 791736 120 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 791608 791728 120 0.0
window-app BRD4161A (read only) 780716 780852 136 0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780708 780844 136 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724636 724700 64 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635752 635816 64 0.0
lock-app k32w061+debug (read/write) 615796 615860 64 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536280 536344 64 0.0
shell k32w061+debug (read/write) 679052 679100 48 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589864 589912 48 0.0
linux chip-tool-ipv6only arm64 (read only) 6786156 6786460 304 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342444 48 0.0
.text 5782116 5782372 256 0.0
thermostat-no-ble arm64 (read only) 1931972 1932276 304 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124868 48 0.0
.text 1601424 1601680 256 0.0
p6 all-clusters-app default (read/write) 2356216 2356352 136 0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314480 1314616 136 0.0
light-app default (read/write) 2290512 2290632 120 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248776 1248896 120 0.0
lock-app default (read/write) 2266376 2266496 120 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224640 1224760 120 0.0
qpg lighting-app qpg6100+debug (read only) 517944 518072 128 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512624 512752 128 0.0
lock-app qpg6100+debug (read only) 491944 492072 128 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486624 486752 128 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807470 807614 144 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563534 563620 86 0.0

@yunhanw-google yunhanw-google force-pushed the feature/reserve_read_client branch from 623295c to 3f70b9a Compare December 9, 2021 04:13
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

PR #12764: Size comparison from bba082b to 3f70b9a

Increases (3 builds for linux, telink)
platform target config section bba082b 3f70b9a change % change
linux chip-tool-ipv6only arm64 (read only) 6786172 6786476 304 0.0
.rodata 342396 342444 48 0.0
.text 5782132 5782388 256 0.0
thermostat-no-ble arm64 (read only) 1931988 1932292 304 0.0
.rodata 124820 124868 48 0.0
.text 1601440 1601696 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807614 136 0.0
text 563540 563622 82 0.0
Full report (3 builds for linux, telink)
platform target config section bba082b 3f70b9a change % change
linux chip-tool-ipv6only arm64 (read only) 6786172 6786476 304 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342444 48 0.0
.text 5782132 5782388 256 0.0
thermostat-no-ble arm64 (read only) 1931988 1932292 304 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124868 48 0.0
.text 1601440 1601696 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807614 136 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563540 563622 82 0.0

@yunhanw-google yunhanw-google force-pushed the feature/reserve_read_client branch from 3f70b9a to ca17ed5 Compare December 9, 2021 04:34
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12764: Size comparison from bba082b to ca17ed5

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bba082b ca17ed5 change % change
efr32 lighting-app BRD4161A (read only) 804020 804156 136 0.0
.text 804012 804148 136 0.0
BRD4161A+rpc (read only) 791616 791752 136 0.0
.text 791608 791744 136 0.0
window-app BRD4161A (read only) 780732 780868 136 0.0
.text 780724 780860 136 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859280 74 0.0
(read/write) 1306706 1306762 56 0.0
.flash.rodata 171920 171976 56 0.0
.flash.text 859206 859280 74 0.0
m5stack (read only) 962535 962611 76 0.0
(read/write) 450980 451028 48 0.0
.flash.rodata 210144 210192 48 0.0
.flash.text 957151 957227 76 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724700 48 0.0
.text 635768 635816 48 0.0
lock-app k32w061+debug (read/write) 615812 615860 48 0.0
.text 536296 536344 48 0.0
shell k32w061+debug (read/write) 679068 679100 32 0.0
.text 589880 589912 32 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786476 304 0.0
.rodata 342396 342444 48 0.0
.text 5782132 5782388 256 0.0
thermostat-no-ble arm64 (read only) 1931988 1932292 304 0.0
.rodata 124820 124868 48 0.0
.text 1601440 1601696 256 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2320200 2320256 56 0.0
.text 1282776 1282832 56 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2305992 2306112 120 0.0
.text 1268592 1268712 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2278720 2278840 120 0.0
.text 1241320 1241440 120 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903299 903399 100 0.0
rodata 101164 101216 52 0.1
text 610392 610448 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 866323 866439 116 0.0
rodata 92460 92512 52 0.1
text 585120 585176 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829290 829390 100 0.0
rodata 96420 96472 52 0.1
text 540820 540876 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875643 116 0.0
rodata 97280 97332 52 0.1
text 589452 589512 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801774 801894 120 0.0
rodata 92568 92624 56 0.1
text 519976 520032 56 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880575 120 0.0
rodata 98632 98688 56 0.1
text 593044 593100 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873667 873783 116 0.0
rodata 96772 96824 52 0.1
text 588204 588264 60 0.0
p6 all-clusters-app default (read/write) 2356232 2356368 136 0.0
.text 1314496 1314632 136 0.0
light-app default (read/write) 2290528 2290664 136 0.0
.text 1248792 1248928 136 0.0
lock-app default (read/write) 2266392 2266528 136 0.0
.text 1224656 1224792 136 0.0
qpg lighting-app qpg6100+debug (read only) 517960 518080 120 0.0
.text 512640 512760 120 0.0
lock-app qpg6100+debug (read only) 491960 492080 120 0.0
.text 486640 486760 120 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807606 128 0.0
text 563540 563612 72 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section bba082b ca17ed5 change % change
efr32 lighting-app BRD4161A (read only) 804020 804156 136 0.0
(read/write) 122988 122988 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 804012 804148 136 0.0
BRD4161A+rpc (read only) 791616 791752 136 0.0
(read/write) 139672 139672 0 0.0
.bss 137744 137744 0 0.0
.data 1928 1928 0 0.0
.text 791608 791744 136 0.0
window-app BRD4161A (read only) 780732 780868 136 0.0
(read/write) 121120 121120 0 0.0
.bss 119336 119336 0 0.0
.data 1784 1784 0 0.0
.text 780724 780860 136 0.0
esp32 all-clusters-app c3devkit (read only) 859206 859280 74 0.0
(read/write) 1306706 1306762 56 0.0
.dram0.bss 67632 67632 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171920 171976 56 0.0
.flash.text 859206 859280 74 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 962535 962611 76 0.0
(read/write) 450980 451028 48 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210144 210192 48 0.0
.flash.text 957151 957227 76 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 724652 724700 48 0.0
.bss 81232 81232 0 0.0
.data 1852 1852 0 0.0
.text 635768 635816 48 0.0
lock-app k32w061+debug (read/write) 615812 615860 48 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 536296 536344 48 0.0
shell k32w061+debug (read/write) 679068 679100 32 0.0
.bss 81596 81596 0 0.0
.data 1792 1792 0 0.0
.text 589880 589912 32 0.0
linux chip-tool-ipv6only arm64 (read only) 6786172 6786476 304 0.0
(read/write) 312337 312337 0 0.0
.bss 51633 51633 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 207632 207632 0 0.0
.dynamic 560 560 0 0.0
.got 48384 48384 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 342396 342444 48 0.0
.text 5782132 5782388 256 0.0
thermostat-no-ble arm64 (read only) 1931988 1932292 304 0.0
(read/write) 136337 136337 0 0.0
.bss 59441 59441 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69736 69736 0 0.0
.dynamic 560 560 0 0.0
.got 3520 3520 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124820 124868 48 0.0
.text 1601440 1601696 256 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2320200 2320256 56 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1282776 1282832 56 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2305992 2306112 120 0.0
.bss 175696 175696 0 0.0
.data 5488 5488 0 0.0
.heap 855264 855264 0 0.0
.text 1268592 1268712 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2278720 2278840 120 0.0
.bss 174736 174736 0 0.0
.data 5488 5488 0 0.0
.heap 856224 856224 0 0.0
.text 1241320 1241440 120 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047808 2047808 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010408 1010408 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 903299 903399 100 0.0
bss 116168 116168 0 0.0
rodata 101164 101216 52 0.1
text 610392 610448 56 0.0
nrf52840dk_nrf52840+rpc (read/write) 866323 866439 116 0.0
bss 112516 112516 0 0.0
rodata 92460 92512 52 0.1
text 585120 585176 56 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 829290 829390 100 0.0
bss 117544 117544 0 0.0
rodata 96420 96472 52 0.1
text 540820 540876 56 0.0
lock-app nrf52840dk_nrf52840 (read/write) 875527 875643 116 0.0
bss 113432 113432 0 0.0
rodata 97280 97332 52 0.1
text 589452 589512 60 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 801774 801894 120 0.0
bss 114840 114840 0 0.0
rodata 92568 92624 56 0.1
text 519976 520032 56 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 880455 880575 120 0.0
bss 113344 113344 0 0.0
rodata 98632 98688 56 0.1
text 593044 593100 56 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 873667 873783 116 0.0
bss 113220 113220 0 0.0
rodata 96772 96824 52 0.1
text 588204 588264 60 0.0
shell nrf52840dk_nrf52840 (read/write) 781627 781627 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523280 523280 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696702 696702 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443924 443924 0 0.0
p6 all-clusters-app default (read/write) 2356232 2356368 136 0.0
.bss 113116 113116 0 0.0
.data 2512 2512 0 0.0
.heap 917712 917712 0 0.0
.text 1314496 1314632 136 0.0
light-app default (read/write) 2290528 2290664 136 0.0
.bss 100888 100888 0 0.0
.data 2328 2328 0 0.0
.heap 930128 930128 0 0.0
.text 1248792 1248928 136 0.0
lock-app default (read/write) 2266392 2266528 136 0.0
.bss 99768 99768 0 0.0
.data 2288 2288 0 0.0
.heap 931288 931288 0 0.0
.text 1224656 1224792 136 0.0
qpg lighting-app qpg6100+debug (read only) 517960 518080 120 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 512640 512760 120 0.0
lock-app qpg6100+debug (read only) 491960 492080 120 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 486640 486760 120 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807478 807606 128 0.0
bss 82748 82748 0 0.0
noinit 37160 37160 0 0.0
text 563540 563612 72 0.0

mrjerryjohns
mrjerryjohns suggested changes Dec 9, 2021
View reviewed changes
src/app/InteractionModelEngine.cpp Outdated Show resolved Hide resolved
@yunhanw-google yunhanw-google force-pushed the feature/reserve_read_client branch 2 times, most recently from 5822ca8 to 724e9e4 Compare December 9, 2021 17:07
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12764: Size comparison from 5bb8377 to 724e9e4

Increases (22 builds for efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5bb8377 724e9e4 change % change
efr32 lighting-app BRD4161A (read only) 806260 806444 184 0.0
.text 806252 806436 184 0.0
BRD4161A+rpc (read only) 793896 794080 184 0.0
.text 793888 794072 184 0.0
window-app BRD4161A (read only) 783004 783188 184 0.0
.text 782996 783180 184 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617404 80 0.0
.text 537808 537888 80 0.0
shell k32w061+debug (read/write) 622400 622496 96 0.0
.text 540684 540780 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6783628 6784156 528 0.0
.rodata 363612 363676 64 0.0
.text 5742324 5742788 464 0.0
thermostat-no-ble arm64 (read only) 1935204 1935732 528 0.0
.rodata 124996 125060 64 0.1
.text 1604304 1604768 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2321272 2321456 184 0.0
.text 1283848 1284032 184 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2307128 2307248 120 0.0
.text 1269728 1269848 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2279856 2280040 184 0.0
.text 1242456 1242640 184 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904943 152 0.0
rodata 101440 101496 56 0.1
text 611608 611716 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 867819 867983 164 0.0
rodata 92740 92792 52 0.1
text 586336 586444 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830950 164 0.0
rodata 96700 96752 52 0.1
text 542036 542144 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877023 877187 164 0.0
rodata 97560 97612 52 0.1
text 590668 590776 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803270 803434 164 0.0
rodata 92848 92900 52 0.1
text 521188 521296 108 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 882115 164 0.0
rodata 98912 98964 52 0.1
text 594256 594364 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 875327 168 0.0
rodata 97048 97104 56 0.1
text 589420 589528 108 0.0
p6 all-clusters-app default (read/write) 2357456 2357640 184 0.0
.text 1315720 1315904 184 0.0
light-app default (read/write) 2291752 2291936 184 0.0
.text 1250016 1250200 184 0.0
lock-app default (read/write) 2267616 2267800 184 0.0
.text 1225880 1226064 184 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808878 176 0.0
text 564470 564590 120 0.0
Full report (27 builds for efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5bb8377 724e9e4 change % change
efr32 lighting-app BRD4161A (read only) 806260 806444 184 0.0
(read/write) 122980 122980 0 0.0
.bss 121160 121160 0 0.0
.data 1820 1820 0 0.0
.text 806252 806436 184 0.0
BRD4161A+rpc (read only) 793896 794080 184 0.0
(read/write) 139664 139664 0 0.0
.bss 137736 137736 0 0.0
.data 1928 1928 0 0.0
.text 793888 794072 184 0.0
window-app BRD4161A (read only) 783004 783188 184 0.0
(read/write) 121112 121112 0 0.0
.bss 119328 119328 0 0.0
.data 1784 1784 0 0.0
.text 782996 783180 184 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.bss 73744 73744 0 0.0
.data 1852 1852 0 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617404 80 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 537808 537888 80 0.0
shell k32w061+debug (read/write) 622400 622496 96 0.0
.bss 74124 74124 0 0.0
.data 1792 1792 0 0.0
.text 540684 540780 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6783628 6784156 528 0.0
(read/write) 317777 317777 0 0.0
.bss 51681 51681 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 208360 208360 0 0.0
.dynamic 560 560 0 0.0
.got 52992 52992 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363612 363676 64 0.0
.text 5742324 5742788 464 0.0
thermostat-no-ble arm64 (read only) 1935204 1935732 528 0.0
(read/write) 136353 136353 0 0.0
.bss 59409 59409 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69800 0 0.0
.dynamic 560 560 0 0.0
.got 3512 3512 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124996 125060 64 0.1
.text 1604304 1604768 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321272 2321456 184 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1283848 1284032 184 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307128 2307248 120 0.0
.bss 175688 175688 0 0.0
.data 5488 5488 0 0.0
.heap 855272 855272 0 0.0
.text 1269728 1269848 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279856 2280040 184 0.0
.bss 174728 174728 0 0.0
.data 5488 5488 0 0.0
.heap 856232 856232 0 0.0
.text 1242456 1242640 184 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904943 152 0.0
bss 116168 116168 0 0.0
rodata 101440 101496 56 0.1
text 611608 611716 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 867819 867983 164 0.0
bss 112516 112516 0 0.0
rodata 92740 92792 52 0.1
text 586336 586444 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830950 164 0.0
bss 117544 117544 0 0.0
rodata 96700 96752 52 0.1
text 542036 542144 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877023 877187 164 0.0
bss 113432 113432 0 0.0
rodata 97560 97612 52 0.1
text 590668 590776 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803270 803434 164 0.0
bss 114840 114840 0 0.0
rodata 92848 92900 52 0.1
text 521188 521296 108 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 882115 164 0.0
bss 113344 113344 0 0.0
rodata 98912 98964 52 0.1
text 594256 594364 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 875327 168 0.0
bss 113220 113220 0 0.0
rodata 97048 97104 56 0.1
text 589420 589528 108 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2357456 2357640 184 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1315720 1315904 184 0.0
light-app default (read/write) 2291752 2291936 184 0.0
.bss 100880 100880 0 0.0
.data 2328 2328 0 0.0
.heap 930136 930136 0 0.0
.text 1250016 1250200 184 0.0
lock-app default (read/write) 2267616 2267800 184 0.0
.bss 99760 99760 0 0.0
.data 2288 2288 0 0.0
.heap 931296 931296 0 0.0
.text 1225880 1226064 184 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808878 176 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 564590 120 0.0

@yunhanw-google
Copy link
Contributor Author

/rebase

@woody-apple woody-apple force-pushed the feature/reserve_read_client branch from 724e9e4 to 1892f71 Compare December 9, 2021 18:18
@github-actions
Copy link

github-actions bot commented Dec 9, 2021 •
edited
Loading

PR #12764: Size comparison from b6297f3 to 1892f71

Increases (26 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b6297f3 1892f71 change % change
efr32 lighting-app BRD4161A (read only) 806260 806444 184 0.0
.text 806252 806436 184 0.0
BRD4161A+rpc (read only) 793896 794080 184 0.0
.text 793888 794072 184 0.0
window-app BRD4161A (read only) 783004 783188 184 0.0
.text 782996 783180 184 0.0
esp32 all-clusters-app c3devkit (read only) 860210 860332 122 0.0
(read/write) 1307002 1307058 56 0.0
.flash.rodata 172232 172288 56 0.0
.flash.text 860210 860332 122 0.0
m5stack (read only) 964195 964319 124 0.0
(read/write) 451300 451356 56 0.0
.flash.rodata 210480 210536 56 0.0
.flash.text 958811 958935 124 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617404 80 0.0
.text 537808 537888 80 0.0
shell k32w061+debug (read/write) 622400 622496 96 0.0
.text 540684 540780 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6784428 6784956 528 0.0
.rodata 363612 363676 64 0.0
.text 5743124 5743588 464 0.0
thermostat-no-ble arm64 (read only) 1935204 1935732 528 0.0
.rodata 124996 125060 64 0.1
.text 1604304 1604768 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2321272 2321456 184 0.0
.text 1283848 1284032 184 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2307128 2307248 120 0.0
.text 1269728 1269848 120 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2279856 2280040 184 0.0
.text 1242456 1242640 184 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904943 152 0.0
rodata 101440 101496 56 0.1
text 611608 611716 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 867819 867983 164 0.0
rodata 92740 92792 52 0.1
text 586336 586444 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830950 164 0.0
rodata 96700 96752 52 0.1
text 542036 542144 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877023 877187 164 0.0
rodata 97560 97612 52 0.1
text 590668 590776 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803270 803434 164 0.0
rodata 92848 92900 52 0.1
text 521188 521296 108 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 882115 164 0.0
rodata 98912 98964 52 0.1
text 594256 594364 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 875327 168 0.0
rodata 97048 97104 56 0.1
text 589420 589528 108 0.0
p6 all-clusters-app default (read/write) 2357456 2357640 184 0.0
.text 1315720 1315904 184 0.0
light-app default (read/write) 2291752 2291936 184 0.0
.text 1250016 1250200 184 0.0
lock-app default (read/write) 2267616 2267800 184 0.0
.text 1225880 1226064 184 0.0
qpg lighting-app qpg6100+debug (read only) 519472 519640 168 0.0
.text 514152 514320 168 0.0
lock-app qpg6100+debug (read only) 493464 493632 168 0.0
.text 488144 488312 168 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808878 176 0.0
text 564470 564590 120 0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section b6297f3 1892f71 change % change
efr32 lighting-app BRD4161A (read only) 806260 806444 184 0.0
(read/write) 122980 122980 0 0.0
.bss 121160 121160 0 0.0
.data 1820 1820 0 0.0
.text 806252 806436 184 0.0
BRD4161A+rpc (read only) 793896 794080 184 0.0
(read/write) 139664 139664 0 0.0
.bss 137736 137736 0 0.0
.data 1928 1928 0 0.0
.text 793888 794072 184 0.0
window-app BRD4161A (read only) 783004 783188 184 0.0
(read/write) 121112 121112 0 0.0
.bss 119328 119328 0 0.0
.data 1784 1784 0 0.0
.text 782996 783180 184 0.0
esp32 all-clusters-app c3devkit (read only) 860210 860332 122 0.0
(read/write) 1307002 1307058 56 0.0
.dram0.bss 67616 67616 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172232 172288 56 0.0
.flash.text 860210 860332 122 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 964195 964319 124 0.0
(read/write) 451300 451356 56 0.0
.dram0.bss 74984 74984 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210480 210536 56 0.0
.flash.text 958811 958935 124 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 667732 667812 80 0.0
.bss 73744 73744 0 0.0
.data 1852 1852 0 0.0
.text 586336 586416 80 0.0
lock-app k32w061+debug (read/write) 617324 617404 80 0.0
.bss 71896 71896 0 0.0
.data 1820 1820 0 0.0
.text 537808 537888 80 0.0
shell k32w061+debug (read/write) 622400 622496 96 0.0
.bss 74124 74124 0 0.0
.data 1792 1792 0 0.0
.text 540684 540780 96 0.0
linux chip-tool-ipv6only arm64 (read only) 6784428 6784956 528 0.0
(read/write) 317777 317777 0 0.0
.bss 51681 51681 0 0.0
.data 1048 1048 0 0.0
.data.rel.ro 208360 208360 0 0.0
.dynamic 560 560 0 0.0
.got 52992 52992 0 0.0
.init 24 24 0 0.0
.init_array 160 160 0 0.0
.rodata 363612 363676 64 0.0
.text 5743124 5743588 464 0.0
thermostat-no-ble arm64 (read only) 1935204 1935732 528 0.0
(read/write) 136353 136353 0 0.0
.bss 59409 59409 0 0.0
.data 776 776 0 0.0
.data.rel.ro 69800 69800 0 0.0
.dynamic 560 560 0 0.0
.got 3512 3512 0 0.0
.init 24 24 0 0.0
.init_array 256 256 0 0.0
.rodata 124996 125060 64 0.1
.text 1604304 1604768 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2321272 2321456 184 0.0
.bss 186884 186884 0 0.0
.data 5232 5232 0 0.0
.heap 844328 844328 0 0.0
.text 1283848 1284032 184 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2307128 2307248 120 0.0
.bss 175688 175688 0 0.0
.data 5488 5488 0 0.0
.heap 855272 855272 0 0.0
.text 1269728 1269848 120 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2279856 2280040 184 0.0
.bss 174728 174728 0 0.0
.data 5488 5488 0 0.0
.heap 856232 856232 0 0.0
.text 1242456 1242640 184 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053344 2053344 0 0.0
.bss 156892 156892 0 0.0
.data 4864 4864 0 0.0
.heap 874688 874688 0 0.0
.text 1015944 1015944 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 904791 904943 152 0.0
bss 116168 116168 0 0.0
rodata 101440 101496 56 0.1
text 611608 611716 108 0.0
nrf52840dk_nrf52840+rpc (read/write) 867819 867983 164 0.0
bss 112516 112516 0 0.0
rodata 92740 92792 52 0.1
text 586336 586444 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 830786 830950 164 0.0
bss 117544 117544 0 0.0
rodata 96700 96752 52 0.1
text 542036 542144 108 0.0
lock-app nrf52840dk_nrf52840 (read/write) 877023 877187 164 0.0
bss 113432 113432 0 0.0
rodata 97560 97612 52 0.1
text 590668 590776 108 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 803270 803434 164 0.0
bss 114840 114840 0 0.0
rodata 92848 92900 52 0.1
text 521188 521296 108 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 881951 882115 164 0.0
bss 113344 113344 0 0.0
rodata 98912 98964 52 0.1
text 594256 594364 108 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 875159 875327 168 0.0
bss 113220 113220 0 0.0
rodata 97048 97104 56 0.1
text 589420 589528 108 0.0
shell nrf52840dk_nrf52840 (read/write) 781947 781947 0 0.0
bss 109544 109544 0 0.0
rodata 74280 74280 0 0.0
text 523604 523604 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696994 696994 0 0.0
bss 110524 110524 0 0.0
rodata 68924 68924 0 0.0
text 444244 444244 0 0.0
p6 all-clusters-app default (read/write) 2357456 2357640 184 0.0
.bss 113108 113108 0 0.0
.data 2512 2512 0 0.0
.heap 917720 917720 0 0.0
.text 1315720 1315904 184 0.0
light-app default (read/write) 2291752 2291936 184 0.0
.bss 100880 100880 0 0.0
.data 2328 2328 0 0.0
.heap 930136 930136 0 0.0
.text 1250016 1250200 184 0.0
lock-app default (read/write) 2267616 2267800 184 0.0
.bss 99760 99760 0 0.0
.data 2288 2288 0 0.0
.heap 931296 931296 0 0.0
.text 1225880 1226064 184 0.0
qpg lighting-app qpg6100+debug (read only) 519472 519640 168 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 514152 514320 168 0.0
lock-app qpg6100+debug (read only) 493464 493632 168 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 488144 488312 168 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808702 808878 176 0.0
bss 82736 82736 0 0.0
noinit 37160 37160 0 0.0
text 564470 564590 120 0.0

@yunhanw-google yunhanw-google merged commit f804c70 into project-chip:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

followup: we should reserve some read handlers for reads.
4 participants
@yunhanw-google @mrjerryjohns @woody-apple @bzbarsky-apple