-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ota-requestor] Build QueryImage based on Basic cluster attributes #12671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
December 7, 2021 13:43
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 7, 2021 13:43
PR #12671: Size comparison from 1b24137 to b2a5486 Increases above 0.2%:
Increases (1 build for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
reviewed
Dec 7, 2021
Damian-Nordic
force-pushed
the
queryimage-basic
branch
from
December 7, 2021 15:11
b2a5486
to
eb033fc
Compare
Damian-Nordic
force-pushed
the
queryimage-basic
branch
from
December 7, 2021 15:29
eb033fc
to
0c4ca53
Compare
PR #12671: Size comparison from de09687 to 0c4ca53 Increases above 0.2%:
Increases (1 build for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 7, 2021
andy31415
reviewed
Dec 8, 2021
andy31415
approved these changes
Dec 8, 2021
LuDuda
approved these changes
Dec 8, 2021
tcarmelveilleux
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OTA requestor uses hard-coded arguments for the QueryImage command instead of matching Basic Information Cluster attributes.
Change overview
Initialize the arguments based on the Basic Information Cluster attribute values.
Enable Basic cluster in the OTA-requestor app.
Testing
Tested using OTA-provider and OTA-requestor apps for Linux.