Add support for the AttributeList attribute. #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
eedead2 to
6d63a6e
Compare
|
PR #12660: Size comparison from 21392ef to 6d63a6e Increases above 0.2%:
Increases (25 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Full report (29 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
6d63a6e to
e22c4e8
Compare
|
The size increase seems to largely be from emberAfAttributeValueListSize and emberAfCopyList. I'll see what I can do to make those smaller. |
|
PR #12660: Size comparison from f647393 to e22c4e8 Increases above 0.2%:
Increases (20 builds for efr32, k32w, linux, p6, qpg, telink)
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
e22c4e8 to
a726b8d
Compare
|
PR #12660: Size comparison from f647393 to a726b8d Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
vivien-apple
reviewed
Dec 7, 2021
Hmm. So adding it there does let me get rid of the manual changes to cluster-objects.zapt and Attributes.zapt, since those just look at the attribute's existence, not whether it's enabled. What it does not do on its own is enable the controller cluster codegen we actually need, but maybe I can figure out a better workaround for that. |
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
a726b8d to
231e343
Compare
woody-apple
approved these changes
Dec 7, 2021
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
231e343 to
b6fb909
Compare
|
PR #12660: Size comparison from 051685b to b6fb909 Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
b6fb909 to
f46762b
Compare
|
PR #12660: Size comparison from 7ce81e5 to f46762b Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Getting this into the ZAP database as things stand involves modifying every single cluster XML and every single cluster definition in every single .zap file. Instead of that, we just enable it for the controller codegen and manually work around it not being present in endpoint_config.
bzbarsky-apple
force-pushed
the
attribute-list-attribute
branch
from
f46762b to
aaa209a
Compare
|
PR #12660: Size comparison from 6f89b9b to aaa209a Increases above 0.2%:
Increases (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
|
fast track: change made by domain owner, has been up sufficiently for cross timezone review, unit test contained in the change |
|
@mrjerryjohns @yufengwangca @erjiaqing could one of you take a look at this? Would really like a non-rubberstamp review here. |
yufengwangca
approved these changes
Dec 8, 2021
mrjerryjohns
approved these changes
Dec 8, 2021
mlepage-google
added a commit
to mlepage-google/connectedhomeip
that referenced
this pull request
Jan 11, 2022
PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way that the access control check may be skipped. (Possibly due to merge?) Fix this by refactoring the function to a sensible flow of checks. Progress towards project-chip#10239
bzbarsky-apple
added a commit
that referenced
this pull request
Jan 12, 2022
* Fix and refactor ReadSingleClusterData PR #12660 seems to have refactored ReadSingleClusterData in such a way that the access control check may be skipped. (Possibly due to merge?) Fix this by refactoring the function to a sensible flow of checks. Progress towards #10239 * Apply review comment. Co-authored-by: Boris Zbarsky <[email protected]>
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
* Fix and refactor ReadSingleClusterData PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way that the access control check may be skipped. (Possibly due to merge?) Fix this by refactoring the function to a sensible flow of checks. Progress towards project-chip#10239 * Apply review comment. Co-authored-by: Boris Zbarsky <[email protected]>
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
* Fix and refactor ReadSingleClusterData PR project-chip#12660 seems to have refactored ReadSingleClusterData in such a way that the access control check may be skipped. (Possibly due to merge?) Fix this by refactoring the function to a sensible flow of checks. Progress towards project-chip#10239 * Apply review comment. Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting this into the ZAP database as things stand involves modifying
every single cluster XML and every single cluster definition in every
single .zap file. Instead of that, we just enable it for the
controller codegen and manually work around it not being present in
endpoint_config.
Problem
No support for global AttributeList attribute.
Change overview
Add support.
Testing
Added YAML test with a cluster we already had a test file for.
Fixes #12055