-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the CHIPClusters ReadAttribute* APIs. #12652
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-old-read-api
Dec 7, 2021
Merged
Remove the CHIPClusters ReadAttribute* APIs. #12652
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-old-read-api
Dec 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were unused except by chip-tool. chip-tool is switched to use the type-safe read API.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia and
tcarmelveilleux
December 7, 2021 03:25
pullapprove
bot
requested review from
tecimovic,
turon,
vijs,
wbschiller,
woody-apple and
yunhanw-google
December 7, 2021 03:25
PR #12652: Size comparison from 5c70530 to 128fad7 Increases above 0.2%:
Increases (1 build for linux)
Decreases (4 builds for esp32, linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this is updating a test tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were unused except by chip-tool. chip-tool is switched to use
the type-safe read API.
Problem
Command-line chip-tool can't read nullable attributes properly (i.e. if the value is null). And it's using the CHIPClusters APIs that nothing else uses.
Change overview
See above.
Testing
Manually tested a read of a null-valued attribute by hacking chip-tool to write a null value to it (which does not work normally work). Tested some reads of non-null attributes as well.