Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run commissioning from external class. #12643

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Run commissioning from external class. #12643

merged 3 commits into from
Dec 10, 2021

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Dec 6, 2021 •
edited
Loading

Problem

Right now the CHIPDeviceCommissioner class is very opinionated about commissioning and requires that all of the commissioning information be available at the time of the PairDevice call. Moving to have the commissioning steps being driven from an external class so sequencing and timing can be more easily controlled by the developers. As we move the DAC and opcerts into the commissioning state machine, this will also let developers have the ability to do "just-in-time" provisioning of the commissioning parameters. Right now, the auto commissioner is held by the DeviceCommissioner, but will be made optional in future PRs so that developers may write their own to better suit their own timing and certificate provisioning requirements.

Change overview

Moves the control of the commissioning process to an external class and provides a default

Testing

IP commissioning is tested by the cirque tests, also tested manually using IP testing with chip-tool and with chip-device-ctrl. Tested BLE on M5.

@cecille cecille marked this pull request as draft December 6, 2021 21:27
@todo
Copy link

todo bot commented Dec 6, 2021

(cecille): device attestation casues operational cert provisioinging to happen, This should be a separate stage.

connectedhomeip/src/controller/AutoCommissioner.cpp

Lines 37 to 47 in 27032a1

// TODO(cecille): device attestation casues operational cert provisioinging to happen, This should be a separate stage.
// For thread and wifi, this should go to network setup then enable. For on-network we can skip right to finding the
// operational network because the provisioning of certificates will trigger the device to start operational advertising.
#if CHIP_DEVICE_CONFIG_ENABLE_DNSSD
return CommissioningStage::kFindOperational; // TODO : once case is working, need to add stages to find and reconnect
// here.
#else
return CommissioningStage::kSendComplete;
#endif
case CommissioningStage::kFindOperational:
return CommissioningStage::kSendComplete;

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

once case is working, need to add stages to find and reconnect

connectedhomeip/src/controller/AutoCommissioner.cpp

Lines 41 to 51 in 27032a1

return CommissioningStage::kFindOperational; // TODO : once case is working, need to add stages to find and reconnect
// here.
#else
return CommissioningStage::kSendComplete;
#endif
case CommissioningStage::kFindOperational:
return CommissioningStage::kSendComplete;
case CommissioningStage::kSendComplete:
return CommissioningStage::kCleanup;
// Currently unimplemented.

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

check that there is no commissioning in progress currently.

connectedhomeip/src/controller/AutoCommissioner.cpp

Lines 68 to 78 in 27032a1

// TODO: check that there is no commissioning in progress currently.
mCommissioneeDeviceProxy = proxy;
mCommissioner->PerformCommissioningStep(mCommissioneeDeviceProxy, CommissioningStage::kArmFailsafe, mParams, this);
}
void AutoCommissioner::CommissioningStepFinished(CHIP_ERROR err, CommissioningDelegate::CommissioningReport report)
{
if (report.stageCompleted == CommissioningStage::kFindOperational)
{
mOperationalDeviceProxy = report.OperationalNodeFoundData.operationalProxy;

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

(cecille): Once the commissioning stages are separated, this can be removed from the device and moved down into the

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 903 to 907 in 27032a1

// TODO(cecille): Once the commissioning stages are separated, this can be removed from the device and moved down into the
// approprirate commissioning step.
if (params.HasCSRNonce())
{
ReturnErrorOnFailure(device->SetCSRNonce(params.GetCSRNonce().Value()));

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@restyled-io restyled-io bot mentioned this pull request Dec 6, 2021
Closed
@todo
Copy link

todo bot commented Dec 6, 2021

(cecille): Add to parameters and have the caller pass this in.

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 1778 to 1781 in 27032a1

// TODO(cecille): Add to parameters and have the caller pass this in.
uint32_t regulatoryLocation = EMBER_ZCL_REGULATORY_LOCATION_TYPE_OUTDOOR;
#if CONFIG_DEVICE_LAYER
CHIP_ERROR status = DeviceLayer::ConfigurationMgr().GetRegulatoryLocation(regulatoryLocation);

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

(cecille): Remove the certificates from the CommissioneeDeviceProxy and take from the commissioning parameters.

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 1813 to 1823 in 27032a1

// TODO(cecille): Remove the certificates from the CommissioneeDeviceProxy and take from the commissioning parameters.
CHIP_ERROR status =
SendCertificateChainRequestCommand(reinterpret_cast<CommissioneeDeviceProxy *>(proxy), CertificateType::kPAI);
if (status != CHIP_NO_ERROR)
{
ChipLogError(Controller, "Failed in sending 'Certificate Chain Request' command to the device: err %s",
ErrorStr(status));
OnSessionEstablishmentError(status);
return;
}
}

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

(cecille): The pointer re-interpret here is ugly. Once these steps are moved into the commissioning state machine,

connectedhomeip/src/controller/CHIPDeviceController.cpp

Lines 1829 to 1839 in 27032a1

// TODO(cecille): The pointer re-interpret here is ugly. Once these steps are moved into the commissioning state machine,
// the commissioning state machine can hold the parameters instead of the CommissioneeDeviceProxy and we can use the base
// class here.
CHIP_ERROR status = SendOperationalCertificateSigningRequestCommand(reinterpret_cast<CommissioneeDeviceProxy *>(proxy));
if (status != CHIP_NO_ERROR)
{
ChipLogError(Controller, "Failed in sending 'CSR Request' command to the device: err %s", ErrorStr(status));
OnSessionEstablishmentError(status);
return;
}
}

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@todo
Copy link

todo bot commented Dec 6, 2021

Add other things the delegate needs to know.

connectedhomeip/src/controller/CommissioningDelegate.h

Lines 53 to 63 in 27032a1

// TODO: Add other things the delegate needs to know.
union
{
struct
{
OperationalDeviceProxy * operationalProxy;
} OperationalNodeFoundData;
};
};
virtual void CommissioningStepFinished(CHIP_ERROR err, CommissioningReport report) = 0;
};

This comment was generated by todo based on a TODO comment in 27032a1 in #12643. cc @cecille.

@github-actions
Copy link

github-actions bot commented Dec 6, 2021 •
edited
Loading

PR #12643: Size comparison from db6d572 to 27032a1

Increases above 0.2%:

platform target config section db6d572 27032a1 change % change
linux chip-tool debug .init_array 568 576 8 1.4
tv-app debug .init_array 736 744 8 1.1
Increases (2 builds for linux)
platform target config section db6d572 27032a1 change % change
linux chip-tool debug (read only) 6646077 6647269 1192 0.0
(read/write) 200040 200120 80 0.0
.bss 34728 34736 8 0.0
.data.rel.ro 158600 158672 72 0.0
.init_array 568 576 8 1.4
.rodata 313112 313144 32 0.0
.text 5928069 5929109 1040 0.0
tv-app debug (read only) 2046321 2047529 1208 0.1
(read/write) 320320 320456 136 0.0
.bss 247480 247544 64 0.0
.data.rel.ro 64240 64304 64 0.1
.init_array 736 744 8 1.1
.rodata 174768 174832 64 0.0
.text 1716642 1717666 1024 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section db6d572 27032a1 change % change
efr32 lighting-app BRD4161A (read only) 797548 797548 0 0.0
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797540 797540 0 0.0
BRD4161A+rpc (read only) 825516 825516 0 0.0
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825508 825508 0 0.0
lock-app BRD4161A (read only) 772216 772216 0 0.0
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 772208 0 0.0
window-app BRD4161A (read only) 774504 774504 0 0.0
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 774496 0 0.0
esp32 all-clusters-app c3devkit (read only) 852296 852296 0 0.0
(read/write) 1295154 1295154 0 0.0
.dram0.bss 58232 58232 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 169792 169792 0 0.0
.flash.text 852296 852296 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 956495 956495 0 0.0
(read/write) 439528 439528 0 0.0
.dram0.bss 65592 65592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 208132 208132 0 0.0
.flash.text 951111 951111 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731576 731576 0 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644508 644508 0 0.0
lock-app k32w061+debug (read/write) 622292 622292 0 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544592 544592 0 0.0
shell k32w061+debug (read/write) 688184 688184 0 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598864 598864 0 0.0
linux all-clusters-app debug (read only) 1865497 1865497 0 0.0
(read/write) 124592 124592 0 0.0
.bss 50832 50832 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 67216 67216 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 696 0 0.0
.rodata 152917 152917 0 0.0
.text 1569282 1569282 0 0.0
bridge-app debug+rpc (read only) 1444525 1444525 0 0.0
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 121916 0 0.0
.text 1217541 1217541 0 0.0
chip-tool debug (read only) 6646077 6647269 1192 0.0
(read/write) 200040 200120 80 0.0
.bss 34728 34736 8 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 158672 72 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 576 8 1.4
.rodata 313112 313144 32 0.0
.text 5928069 5929109 1040 0.0
lighting-app debug+rpc (read only) 1730329 1730329 0 0.0
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 142513 0 0.0
.text 1444978 1444978 0 0.0
ota-provider-app debug (read only) 1402049 1402049 0 0.0
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 123272 0 0.0
.text 1173922 1173922 0 0.0
ota-requestor-app debug (read only) 1511225 1511225 0 0.0
(read/write) 78152 78152 0 0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29720 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136016 0 0.0
.text 1266402 1266402 0 0.0
shell debug (read only) 823449 823449 0 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84658 0 0.0
.text 631954 631954 0 0.0
tv-app debug (read only) 2046321 2047529 1208 0.1
(read/write) 320320 320456 136 0.0
.bss 247480 247544 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64304 64 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 744 8 1.1
.rodata 174768 174832 64 0.0
.text 1716642 1717666 1024 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2312192 0 0.0
.bss 181412 181412 0 0.0
.data 5192 5192 0 0.0
.heap 849840 849840 0 0.0
.text 1274768 1274768 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2300032 0 0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262632 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 894603 894603 0 0.0
bss 113852 113852 0 0.0
rodata 99676 99676 0 0.0
text 605532 605532 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 857979 857979 0 0.0
bss 110200 110200 0 0.0
rodata 91036 91036 0 0.0
text 580528 580528 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 820502 820502 0 0.0
bss 115224 115224 0 0.0
rodata 94936 94936 0 0.0
text 535856 535856 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 867203 867203 0 0.0
bss 111112 111112 0 0.0
rodata 95796 95796 0 0.0
text 584904 584904 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 793338 793338 0 0.0
bss 112524 112524 0 0.0
rodata 91084 91084 0 0.0
text 515324 515324 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 871939 871939 0 0.0
bss 111024 111024 0 0.0
rodata 97148 97148 0 0.0
text 588304 588304 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 865147 865147 0 0.0
bss 110904 110904 0 0.0
rodata 95284 95284 0 0.0
text 583512 583512 0 0.0
shell nrf52840dk_nrf52840 (read/write) 779939 779939 0 0.0
bss 109696 109696 0 0.0
rodata 73792 73792 0 0.0
text 521948 521948 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 694966 694966 0 0.0
bss 110680 110680 0 0.0
rodata 68432 68432 0 0.0
text 442548 442548 0 0.0
p6 all-clusters-app default (read/write) 2346600 2346600 0 0.0
.bss 107692 107692 0 0.0
.data 2464 2464 0 0.0
.heap 923184 923184 0 0.0
.text 1304864 1304864 0 0.0
light-app default (read/write) 2283848 2283848 0 0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1242112 0 0.0
lock-app default (read/write) 2259984 2259984 0 0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1218248 0 0.0
qpg lighting-app qpg6100+debug (read only) 513276 513276 0 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507956 0 0.0
lock-app qpg6100+debug (read only) 487580 487580 0 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482260 0 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798390 0 0.0
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557996 557996 0 0.0

@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

PR #12643: Size comparison from db6d572 to acdabfe

Increases above 0.2%:

platform target config section db6d572 acdabfe change % change
linux all-clusters-app debug (read only) 1865497 1902257 36760 2.0
(read/write) 124592 128712 4120 3.3
.bss 50832 54064 3232 6.4
.data 1120 1216 96 8.6
.data.rel.ro 67216 67968 752 1.1
.init_array 696 720 24 3.4
.rodata 152917 155061 2144 1.4
.text 1569282 1601666 32384 2.1
bridge-app debug+rpc (read only) 1444525 1450901 6376 0.4
.rodata 121916 122804 888 0.7
.text 1217541 1223029 5488 0.5
chip-tool debug (read only) 6646077 6681493 35416 0.5
(read/write) 200040 201592 1552 0.8
.data.rel.ro 158600 160144 1544 1.0
.init_array 568 576 8 1.4
.rodata 313112 334617 21505 6.9
lighting-app debug+rpc (read only) 1730329 1736697 6368 0.4
.rodata 142513 143409 896 0.6
.text 1444978 1450450 5472 0.4
ota-provider-app debug (read only) 1402049 1408201 6152 0.4
.rodata 123272 124190 918 0.7
.text 1173922 1179154 5232 0.4
ota-requestor-app debug .rodata 136016 136943 927 0.7
shell debug .rodata 84658 84882 224 0.3
tv-app debug .init_array 736 744 8 1.1
.rodata 174768 175604 836 0.5
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 181412 184596 3184 1.8
.data 5192 5240 48 0.9
.text 1274768 1278848 4080 0.3
p6 all-clusters-app default .bss 107692 110868 3176 2.9
.data 2464 2520 56 2.3
.text 1304864 1310472 5608 0.4
Increases (16 builds for k32w, linux, mbed, p6, qpg, telink)
platform target config section db6d572 acdabfe change % change
k32w lighting-app k32w061+se05x+release (read/write) 731576 731592 16 0.0
.text 644508 644524 16 0.0
lock-app k32w061+debug (read/write) 622292 622308 16 0.0
.text 544592 544608 16 0.0
shell k32w061+debug (read/write) 688184 688216 32 0.0
.text 598864 598896 32 0.0
linux all-clusters-app debug (read only) 1865497 1902257 36760 2.0
(read/write) 124592 128712 4120 3.3
.bss 50832 54064 3232 6.4
.data 1120 1216 96 8.6
.data.rel.ro 67216 67968 752 1.1
.init_array 696 720 24 3.4
.rodata 152917 155061 2144 1.4
.text 1569282 1601666 32384 2.1
bridge-app debug+rpc (read only) 1444525 1450901 6376 0.4
.rodata 121916 122804 888 0.7
.text 1217541 1223029 5488 0.5
chip-tool debug (read only) 6646077 6681493 35416 0.5
(read/write) 200040 201592 1552 0.8
.bss 34728 34736 8 0.0
.data.rel.ro 158600 160144 1544 1.0
.init_array 568 576 8 1.4
.rodata 313112 334617 21505 6.9
.text 5928069 5938261 10192 0.2
lighting-app debug+rpc (read only) 1730329 1736697 6368 0.4
.rodata 142513 143409 896 0.6
.text 1444978 1450450 5472 0.4
ota-provider-app debug (read only) 1402049 1408201 6152 0.4
.rodata 123272 124190 918 0.7
.text 1173922 1179154 5232 0.4
ota-requestor-app debug (read only) 1511225 1512985 1760 0.1
.rodata 136016 136943 927 0.7
.text 1266402 1267282 880 0.1
shell debug (read only) 823449 823705 256 0.0
.rodata 84658 84882 224 0.3
.text 631954 631986 32 0.0
tv-app debug (read only) 2046321 2051313 4992 0.2
(read/write) 320320 320424 104 0.0
.bss 247480 247544 64 0.0
.data.rel.ro 64240 64288 48 0.1
.init_array 736 744 8 1.1
.rodata 174768 175604 836 0.5
.text 1716642 1720754 4112 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2312192 2316272 4080 0.2
.bss 181412 184596 3184 1.8
.data 5192 5240 48 0.9
.text 1274768 1278848 4080 0.3
p6 all-clusters-app default (read/write) 2346600 2352208 5608 0.2
.bss 107692 110868 3176 2.9
.data 2464 2520 56 2.3
.text 1304864 1310472 5608 0.4
qpg lighting-app qpg6100+debug (read only) 513276 513300 24 0.0
.text 507956 507980 24 0.0
lock-app qpg6100+debug (read only) 487580 487604 24 0.0
.text 482260 482284 24 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798846 456 0.1
text 557996 558338 342 0.1
Decreases (10 builds for efr32, linux, mbed, p6)
platform target config section db6d572 acdabfe change % change
efr32 lighting-app BRD4161A (read only) 797548 796540 -1008 -0.1
.text 797540 796532 -1008 -0.1
BRD4161A+rpc (read only) 825516 824508 -1008 -0.1
.text 825508 824500 -1008 -0.1
lock-app BRD4161A (read only) 772216 771224 -992 -0.1
.text 772208 771216 -992 -0.1
window-app BRD4161A (read only) 774504 773496 -1008 -0.1
.text 774496 773488 -1008 -0.1
linux ota-requestor-app debug (read/write) 78152 78120 -32 -0.0
.data.rel.ro 29720 29704 -16 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release .heap 849840 846608 -3232 -0.4
lighting-app CY8CPROTO_062_4343W+release (read/write) 2300032 2299968 -64 -0.0
.text 1262632 1262568 -64 -0.0
p6 all-clusters-app default .heap 923184 919952 -3232 -0.4
light-app default (read/write) 2283848 2283256 -592 -0.0
.text 1242112 1241520 -592 -0.0
lock-app default (read/write) 2259984 2259424 -560 -0.0
.text 1218248 1217688 -560 -0.0
Full report (27 builds for efr32, k32w, linux, mbed, p6, qpg, telink)
platform target config section db6d572 acdabfe change % change
efr32 lighting-app BRD4161A (read only) 797548 796540 -1008 -0.1
(read/write) 120740 120740 0 0.0
.bss 118912 118912 0 0.0
.data 1828 1828 0 0.0
.text 797540 796532 -1008 -0.1
BRD4161A+rpc (read only) 825516 824508 -1008 -0.1
(read/write) 139048 139048 0 0.0
.bss 137112 137112 0 0.0
.data 1936 1936 0 0.0
.text 825508 824500 -1008 -0.1
lock-app BRD4161A (read only) 772216 771224 -992 -0.1
(read/write) 118680 118680 0 0.0
.bss 116888 116888 0 0.0
.data 1788 1788 0 0.0
.text 772208 771216 -992 -0.1
window-app BRD4161A (read only) 774504 773496 -1008 -0.1
(read/write) 118880 118880 0 0.0
.bss 117088 117088 0 0.0
.data 1792 1792 0 0.0
.text 774496 773488 -1008 -0.1
k32w lighting-app k32w061+se05x+release (read/write) 731576 731592 16 0.0
.bss 79408 79408 0 0.0
.data 1860 1860 0 0.0
.text 644508 644524 16 0.0
lock-app k32w061+debug (read/write) 622292 622308 16 0.0
.bss 70072 70072 0 0.0
.data 1828 1828 0 0.0
.text 544592 544608 16 0.0
shell k32w061+debug (read/write) 688184 688216 32 0.0
.bss 81720 81720 0 0.0
.data 1800 1800 0 0.0
.text 598864 598896 32 0.0
linux all-clusters-app debug (read only) 1865497 1902257 36760 2.0
(read/write) 124592 128712 4120 3.3
.bss 50832 54064 3232 6.4
.data 1120 1216 96 8.6
.data.rel.ro 67216 67968 752 1.1
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 696 720 24 3.4
.rodata 152917 155061 2144 1.4
.text 1569282 1601666 32384 2.1
bridge-app debug+rpc (read only) 1444525 1450901 6376 0.4
(read/write) 74904 74904 0 0.0
.bss 36464 36464 0 0.0
.data 1728 1728 0 0.0
.data.rel.ro 31632 31632 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 480 480 0 0.0
.rodata 121916 122804 888 0.7
.text 1217541 1223029 5488 0.5
chip-tool debug (read only) 6646077 6681493 35416 0.5
(read/write) 200040 201592 1552 0.8
.bss 34728 34736 8 0.0
.data 1024 1024 0 0.0
.data.rel.ro 158600 160144 1544 1.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 568 576 8 1.4
.rodata 313112 334617 21505 6.9
.text 5928069 5938261 10192 0.2
lighting-app debug+rpc (read only) 1730329 1736697 6368 0.4
(read/write) 107968 107968 0 0.0
.bss 42160 42160 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 59136 59136 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 142513 143409 896 0.6
.text 1444978 1450450 5472 0.4
ota-provider-app debug (read only) 1402049 1408201 6152 0.4
(read/write) 73104 73104 0 0.0
.bss 39040 39040 0 0.0
.data 928 928 0 0.0
.data.rel.ro 27944 27944 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 123272 124190 918 0.7
.text 1173922 1179154 5232 0.4
ota-requestor-app debug (read only) 1511225 1512985 1760 0.1
(read/write) 78152 78120 -32 -0.0
.bss 42208 42208 0 0.0
.data 992 992 0 0.0
.data.rel.ro 29720 29704 -16 -0.1
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 136016 136943 927 0.7
.text 1266402 1267282 880 0.1
shell debug (read only) 823449 823705 256 0.0
(read/write) 60616 60616 0 0.0
.bss 16936 16936 0 0.0
.data 256 256 0 0.0
.data.rel.ro 38936 38936 0 0.0
.dynamic 592 592 0 0.0
.got 3520 3520 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 84658 84882 224 0.3
.text 631954 631986 32 0.0
tv-app debug (read only) 2046321 2051313 4992 0.2
(read/write) 320320 320424 104 0.0
.bss 247480 247544 64 0.0
.data 2768 2768 0 0.0
.data.rel.ro 64240 64288 48 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 736 744 8 1.1
.rodata 174768 175604 836 0.5
.text 1716642 1720754 4112 0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2312192 2316272 4080 0.2
.bss 181412 184596 3184 1.8
.data 5192 5240 48 0.9
.heap 849840 846608 -3232 -0.4
.text 1274768 1278848 4080 0.3
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2300032 2299968 -64 -0.0
.bss 173400 173400 0 0.0
.data 5496 5496 0 0.0
.heap 857552 857552 0 0.0
.text 1262632 1262568 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273072 2273072 0 0.0
.bss 172440 172440 0 0.0
.data 5496 5496 0 0.0
.heap 858512 858512 0 0.0
.text 1235672 1235672 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047472 2047472 0 0.0
.bss 156732 156732 0 0.0
.data 4872 4872 0 0.0
.heap 874840 874840 0 0.0
.text 1010072 1010072 0 0.0
p6 all-clusters-app default (read/write) 2346600 2352208 5608 0.2
.bss 107692 110868 3176 2.9
.data 2464 2520 56 2.3
.heap 923184 919952 -3232 -0.4
.text 1304864 1310472 5608 0.4
light-app default (read/write) 2283848 2283256 -592 -0.0
.bss 98632 98632 0 0.0
.data 2336 2336 0 0.0
.heap 932376 932376 0 0.0
.text 1242112 1241520 -592 -0.0
lock-app default (read/write) 2259984 2259424 -560 -0.0
.bss 97512 97512 0 0.0
.data 2296 2296 0 0.0
.heap 933536 933536 0 0.0
.text 1218248 1217688 -560 -0.0
qpg lighting-app qpg6100+debug (read only) 513276 513300 24 0.0
(read/write) 122332 122332 0 0.0
.bss 80360 80360 0 0.0
.data 964 964 0 0.0
.text 507956 507980 24 0.0
lock-app qpg6100+debug (read only) 487580 487604 24 0.0
(read/write) 122336 122336 0 0.0
.bss 79496 79496 0 0.0
.data 920 920 0 0.0
.text 482260 482284 24 0.0
persistent-storage-app qpg6100+debug (read only) 108224 108224 0 0.0
(read/write) 122332 122332 0 0.0
.bss 36696 36696 0 0.0
.data 292 292 0 0.0
.text 102904 102904 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798390 798846 456 0.1
bss 80428 80428 0 0.0
noinit 37160 37160 0 0.0
text 557996 558338 342 0.1

@cecille cecille marked this pull request as ready for review December 7, 2021 16:31
cecille and others added 2 commits December 7, 2021 18:56
@cecille
Run commissioning from external class.
0f31a87 
Adding a (soon to be) optional auto-commissioner to maintain
current functionality as-is.
@restyled-commits @cecille
Restyled by whitespace
45579f9
@cecille cecille force-pushed the commissioning_from_separate_class branch from acdabfe to 45579f9 Compare December 8, 2021 00:15
@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited
Loading

PR #12643: Size comparison from 6f89b9b to 45579f9

Increases above 0.2%:

platform target config section 6f89b9b 45579f9 change % change
linux chip-tool debug .init_array 560 568 8 1.4
tv-app debug .init_array 728 736 8 1.1
Increases (2 builds for linux)
platform target config section 6f89b9b 45579f9 change % change
linux chip-tool debug (read only) 6690005 6691245 1240 0.0
(read/write) 202336 202416 80 0.0
.bss 35272 35280 8 0.0
.data.rel.ro 160360 160432 72 0.0
.init_array 560 568 8 1.4
.rodata 335657 335689 32 0.0
.text 5945253 5946341 1088 0.0
tv-app debug (read only) 2044273 2045497 1224 0.1
(read/write) 324120 324256 136 0.0
.bss 251160 251224 64 0.0
.data.rel.ro 64408 64488 80 0.1
.init_array 728 736 8 1.1
.rodata 176444 176508 64 0.0
.text 1712802 1713842 1040 0.1
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 6f89b9b 45579f9 change % change
efr32 lighting-app BRD4161A (read only) 794784 794784 0 0.0
(read/write) 122992 122992 0 0.0
.bss 121168 121168 0 0.0
.data 1820 1820 0 0.0
.text 794776 794776 0 0.0
BRD4161A+rpc (read only) 822832 822832 0 0.0
(read/write) 141296 141296 0 0.0
.bss 139368 139368 0 0.0
.data 1928 1928 0 0.0
.text 822824 822824 0 0.0
lock-app BRD4161A (read only) 769404 769404 0 0.0
(read/write) 120924 120924 0 0.0
.bss 119144 119144 0 0.0
.data 1780 1780 0 0.0
.text 769396 769396 0 0.0
window-app BRD4161A (read only) 771672 771672 0 0.0
(read/write) 121128 121128 0 0.0
.bss 119344 119344 0 0.0
.data 1784 1784 0 0.0
.text 771664 771664 0 0.0
esp32 all-clusters-app c3devkit (read only) 855576 855576 0 0.0
(read/write) 1305994 1305994 0 0.0
.dram0.bss 67640 67640 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 171192 171192 0 0.0
.flash.text 855576 855576 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 958323 958323 0 0.0
(read/write) 450236 450236 0 0.0
.dram0.bss 75000 75000 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 209400 209400 0 0.0
.flash.text 952939 952939 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 731948 731948 0 0.0
.bss 81240 81240 0 0.0
.data 1852 1852 0 0.0
.text 643056 643056 0 0.0
lock-app k32w061+debug (read/write) 622532 622532 0 0.0
.bss 71904 71904 0 0.0
.data 1820 1820 0 0.0
.text 543008 543008 0 0.0
shell k32w061+debug (read/write) 685624 685624 0 0.0
.bss 81604 81604 0 0.0
.data 1792 1792 0 0.0
.text 596428 596428 0 0.0
linux all-clusters-app debug (read only) 1904073 1904073 0 0.0
(read/write) 131584 131584 0 0.0
.bss 56688 56688 0 0.0
.data 1200 1200 0 0.0
.data.rel.ro 68240 68240 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 155684 155684 0 0.0
.text 1602626 1602626 0 0.0
bridge-app debug+rpc (read only) 1447877 1447877 0 0.0
(read/write) 77712 77712 0 0.0
.bss 39120 39120 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 31800 31800 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 123460 123460 0 0.0
.text 1219205 1219205 0 0.0
chip-tool debug (read only) 6690005 6691245 1240 0.0
(read/write) 202336 202416 80 0.0
.bss 35272 35280 8 0.0
.data 1024 1024 0 0.0
.data.rel.ro 160360 160432 72 0.0
.dynamic 592 592 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 560 568 8 1.4
.rodata 335657 335689 32 0.0
.text 5945253 5946341 1088 0.0
lighting-app debug+rpc (read only) 1735633 1735633 0 0.0
(read/write) 110776 110776 0 0.0
.bss 44816 44816 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 59312 59312 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 144348 144348 0 0.0
.text 1448306 1448306 0 0.0
ota-provider-app debug (read only) 1412313 1412313 0 0.0
(read/write) 75688 75688 0 0.0
.bss 41600 41600 0 0.0
.data 896 896 0 0.0
.data.rel.ro 28008 28008 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 124894 124894 0 0.0
.text 1182514 1182514 0 0.0
ota-requestor-app debug (read only) 1517033 1517033 0 0.0
(read/write) 80704 80704 0 0.0
.bss 44768 44768 0 0.0
.data 960 960 0 0.0
.data.rel.ro 29768 29768 0 0.0
.dynamic 592 592 0 0.0
.got 4064 4064 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137583 137583 0 0.0
.text 1270642 1270642 0 0.0
shell debug (read only) 828593 828593 0 0.0
(read/write) 60608 60608 0 0.0
.bss 16872 16872 0 0.0
.data 256 256 0 0.0
.data.rel.ro 39000 39000 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 85970 85970 0 0.0
.text 635522 635522 0 0.0
tv-app debug (read only) 2044273 2045497 1224 0.1
(read/write) 324120 324256 136 0.0
.bss 251160 251224 64 0.0
.data 2736 2736 0 0.0
.data.rel.ro 64408 64488 80 0.1
.dynamic 592 592 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 728 736 8 1.1
.rodata 176444 176508 64 0.0
.text 1712802 1713842 1040 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2316128 2316128 0 0.0
.bss 186892 186892 0 0.0
.data 5232 5232 0 0.0
.heap 844320 844320 0 0.0
.text 1278704 1278704 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2298776 2298776 0 0.0
.bss 175704 175704 0 0.0
.data 5488 5488 0 0.0
.heap 855256 855256 0 0.0
.text 1261376 1261376 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2271688 2271688 0 0.0
.bss 174744 174744 0 0.0
.data 5488 5488 0 0.0
.heap 856216 856216 0 0.0
.text 1234288 1234288 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2047992 2047992 0 0.0
.bss 156564 156564 0 0.0
.data 4864 4864 0 0.0
.heap 875016 875016 0 0.0
.text 1010592 1010592 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 896779 896779 0 0.0
bss 116176 116176 0 0.0
rodata 100132 100132 0 0.0
text 604904 604904 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 859803 859803 0 0.0
bss 112524 112524 0 0.0
rodata 91428 91428 0 0.0
text 579632 579632 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 822706 822706 0 0.0
bss 117552 117552 0 0.0
rodata 95388 95388 0 0.0
text 535276 535276 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 869215 869215 0 0.0
bss 113440 113440 0 0.0
rodata 96248 96248 0 0.0
text 584160 584160 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 795402 795402 0 0.0
bss 114848 114848 0 0.0
rodata 91540 91540 0 0.0
text 514624 514624 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 874099 874099 0 0.0
bss 113352 113352 0 0.0
rodata 97604 97604 0 0.0
text 587676 587676 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 867323 867323 0 0.0
bss 113228 113228 0 0.0
rodata 95740 95740 0 0.0
text 582896 582896 0 0.0
shell nrf52840dk_nrf52840 (read/write) 781611 781611 0 0.0
bss 109552 109552 0 0.0
rodata 74280 74280 0 0.0
text 523268 523268 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 696686 696686 0 0.0
bss 110532 110532 0 0.0
rodata 68920 68920 0 0.0
text 443908 443908 0 0.0
p6 all-clusters-app default (read/write) 2349808 2349808 0 0.0
.bss 113124 113124 0 0.0
.data 2512 2512 0 0.0
.heap 917704 917704 0 0.0
.text 1308072 1308072 0 0.0
light-app default (read/write) 2281112 2281112 0 0.0
.bss 100896 100896 0 0.0
.data 2328 2328 0 0.0
.heap 930120 930120 0 0.0
.text 1239376 1239376 0 0.0
lock-app default (read/write) 2257200 2257200 0 0.0
.bss 99776 99776 0 0.0
.data 2288 2288 0 0.0
.heap 931280 931280 0 0.0
.text 1215464 1215464 0 0.0
qpg lighting-app qpg6100+debug (read only) 511772 511772 0 0.0
(read/write) 122332 122332 0 0.0
.bss 82616 82616 0 0.0
.data 956 956 0 0.0
.text 506452 506452 0 0.0
lock-app qpg6100+debug (read only) 485956 485956 0 0.0
(read/write) 122336 122336 0 0.0
.bss 81752 81752 0 0.0
.data 912 912 0 0.0
.text 480636 480636 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36152 36152 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800102 800102 0 0.0
bss 82756 82756 0 0.0
noinit 37160 37160 0 0.0
text 557204 557204 0 0.0

@woody-apple
Copy link
Contributor

/rebase

@github-actions
Copy link

github-actions bot commented Dec 10, 2021 •
edited
Loading

PR #12643: Size comparison from d27ac43 to dc9792a

Increases (1 build for linux)
platform target config section d27ac43 dc9792a change % change
linux chip-tool-ipv6only arm64 (read only) 6846220 6847180 960 0.0
(read/write) 318849 318945 96 0.0
.data.rel.ro 208632 208712 80 0.0
.got 53408 53424 16 0.0
.text 5801396 5802228 832 0.0
Decreases (1 build for linux)
platform target config section d27ac43 dc9792a change % change
linux chip-tool-ipv6only arm64 .rodata 364028 363964 -64 -0.0
Full report (32 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section d27ac43 dc9792a change % change
efr32 lighting-app BRD4161A (read only) 815260 815260 0 0.0
(read/write) 123132 123132 0 0.0
.bss 121272 121272 0 0.0
.data 1860 1860 0 0.0
.text 815252 815252 0 0.0
BRD4161A+rpc (read only) 802908 802908 0 0.0
(read/write) 139808 139808 0 0.0
.bss 137848 137848 0 0.0
.data 1960 1960 0 0.0
.text 802900 802900 0 0.0
window-app BRD4161A (read only) 792224 792224 0 0.0
(read/write) 121264 121264 0 0.0
.bss 119440 119440 0 0.0
.data 1824 1824 0 0.0
.text 792216 792216 0 0.0
esp32 all-clusters-app c3devkit (read only) 856528 856528 0 0.0
(read/write) 1304970 1304970 0 0.0
.dram0.bss 65016 65016 0 0.0
.dram0.data 14124 14124 0 0.0
.flash.rodata 172792 172792 0 0.0
.flash.text 856528 856528 0 0.0
.iram0.text 62076 62076 0 0.0
m5stack (read only) 960191 960191 0 0.0
(read/write) 450704 450704 0 0.0
.dram0.bss 74304 74304 0 0.0
.dram0.data 34048 34048 0 0.0
.flash.rodata 210564 210564 0 0.0
.flash.text 954807 954807 0 0.0
.iram0.text 123451 123451 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 669744 669744 0 0.0
.bss 73856 73856 0 0.0
.data 1892 1892 0 0.0
.text 588196 588196 0 0.0
lock-app k32w061+debug (read/write) 619696 619696 0 0.0
.bss 72008 72008 0 0.0
.data 1852 1852 0 0.0
.text 540036 540036 0 0.0
shell k32w061+debug (read/write) 625016 625016 0 0.0
.bss 74316 74316 0 0.0
.data 1832 1832 0 0.0
.text 543068 543068 0 0.0
linux chip-tool-ipv6only arm64 (read only) 6846220 6847180 960 0.0
(read/write) 318849 318945 96 0.0
.bss 51889 51889 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 208632 208712 80 0.0
.dynamic 560 560 0 0.0
.got 53408 53424 16 0.0
.init 24 24 0 0.0
.init_array 176 176 0 0.0
.rodata 364028 363964 -64 -0.0
.text 5801396 5802228 832 0.0
thermostat-no-ble arm64 (read only) 1947668 1947668 0 0.0
(read/write) 137185 137185 0 0.0
.bss 59505 59505 0 0.0
.data 832 832 0 0.0
.data.rel.ro 70344 70344 0 0.0
.dynamic 560 560 0 0.0
.got 3624 3624 0 0.0
.init 24 24 0 0.0
.init_array 272 272 0 0.0
.rodata 125476 125476 0 0.0
.text 1614416 1614416 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2313680 2313680 0 0.0
.bss 184284 184284 0 0.0
.data 5232 5232 0 0.0
.heap 846928 846928 0 0.0
.text 1276256 1276256 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2309168 2309168 0 0.0
.bss 175808 175808 0 0.0
.data 5528 5528 0 0.0
.heap 855112 855112 0 0.0
.text 1271768 1271768 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2282288 2282288 0 0.0
.bss 174848 174848 0 0.0
.data 5520 5520 0 0.0
.heap 856080 856080 0 0.0
.text 1244888 1244888 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1140008 1140008 0 0.0
.bss 11756 11756 0 0.0
.data 4376 4376 0 0.0
.heap 1020312 1020312 0 0.0
.text 103392 103392 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2053672 2053672 0 0.0
.bss 156980 156980 0 0.0
.data 4864 4864 0 0.0
.heap 874600 874600 0 0.0
.text 1016272 1016272 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 907035 907035 0 0.0
bss 116280 116280 0 0.0
rodata 101932 101932 0 0.0
text 613240 613240 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 870099 870099 0 0.0
bss 112628 112628 0 0.0
rodata 93228 93228 0 0.0
text 587984 587984 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 833034 833034 0 0.0
bss 117656 117656 0 0.0
rodata 97188 97188 0 0.0
text 543668 543668 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 879695 879695 0 0.0
bss 113544 113544 0 0.0
rodata 98048 98048 0 0.0
text 592684 592684 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 805934 805934 0 0.0
bss 114952 114952 0 0.0
rodata 93336 93336 0 0.0
text 523204 523204 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497463 497463 0 0.0
bss 51820 51820 0 0.0
rodata 45852 45852 0 0.0
text 339492 339492 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 884631 884631 0 0.0
bss 113456 113456 0 0.0
rodata 99400 99400 0 0.0
text 596276 596276 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 877843 877843 0 0.0
bss 113332 113332 0 0.0
rodata 97540 97540 0 0.0
text 591472 591472 0 0.0
shell nrf52840dk_nrf52840 (read/write) 782267 782267 0 0.0
bss 109624 109624 0 0.0
rodata 74296 74296 0 0.0
text 523840 523840 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 697346 697346 0 0.0
bss 110604 110604 0 0.0
rodata 68940 68940 0 0.0
text 444480 444480 0 0.0
p6 all-clusters-app default (read/write) 2360584 2360584 0 0.0
.bss 112484 112484 0 0.0
.data 2520 2520 0 0.0
.heap 918336 918336 0 0.0
.text 1318848 1318848 0 0.0
light-app default (read/write) 2300800 2300800 0 0.0
.bss 101064 101064 0 0.0
.data 2360 2360 0 0.0
.heap 929920 929920 0 0.0
.text 1259064 1259064 0 0.0
lock-app default (read/write) 2276872 2276872 0 0.0
.bss 99944 99944 0 0.0
.data 2328 2328 0 0.0
.heap 931072 931072 0 0.0
.text 1235136 1235136 0 0.0
qpg lighting-app qpg6100+debug (read only) 521532 521532 0 0.0
(read/write) 122336 122336 0 0.0
.bss 82696 82696 0 0.0
.data 992 992 0 0.0
.text 516212 516212 0 0.0
lock-app qpg6100+debug (read only) 495896 495896 0 0.0
(read/write) 122332 122332 0 0.0
.bss 81832 81832 0 0.0
.data 948 948 0 0.0
.text 490576 490576 0 0.0
persistent-storage-app qpg6100+debug (read only) 108104 108104 0 0.0
(read/write) 122336 122336 0 0.0
.bss 36160 36160 0 0.0
.data 288 288 0 0.0
.text 102784 102784 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 811522 811522 0 0.0
bss 82848 82848 0 0.0
noinit 37160 37160 0 0.0
text 566628 566628 0 0.0

@andy31415 andy31415 merged commit 798d7d2 into project-chip:master Dec 10, 2021
@cecille cecille deleted the commissioning_from_separate_class branch December 10, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt Awaiting requested review from msandstedt

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@chshu chshu Awaiting requested review from chshu

@dhrishi dhrishi Awaiting requested review from dhrishi

@gjc13 gjc13 Awaiting requested review from gjc13

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
controller review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cecille @woody-apple @andy31415 @restyled-commits