-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename several IM IB in MessageDef #12516
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/cleanup_messagedef
Dec 3, 2021
Merged
Rename several IM IB in MessageDef #12516
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/cleanup_messagedef
Dec 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
December 2, 2021 22:32
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
wbschiller and
woody-apple
December 2, 2021 22:32
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 2, 2021 22:42
426f7f5
to
bf08d09
Compare
woody-apple
approved these changes
Dec 2, 2021
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
2 times, most recently
from
December 2, 2021 23:47
eef989c
to
ba47f36
Compare
yufengwangca
approved these changes
Dec 2, 2021
PR #12516: Size comparison from ae57e32 to ba47f36 Increases (2 builds for linux)
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 3, 2021 01:10
ba47f36
to
ceed310
Compare
jmartinez-silabs
approved these changes
Dec 3, 2021
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 3, 2021 01:15
ceed310
to
921b41d
Compare
PR #12516: Size comparison from 1ad526b to 921b41d Increases (2 builds for linux)
Full report (22 builds for efr32, k32w, linux, p6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 3, 2021 02:07
921b41d
to
ca130b1
Compare
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 3, 2021 02:10
ca130b1
to
0e2ebec
Compare
--Rename AttributeStatuses to AttributeStatusIBs --Rename EventFilters to EventFilterIBs --Rename EventPaths to EventPathIBs --Rename EventReports to EventReportIBs --Rename InvokeResponse to InvokeResponseIBs
yunhanw-google
force-pushed
the
feature/cleanup_messagedef
branch
from
December 3, 2021 02:12
0e2ebec
to
4c5fd68
Compare
PR #12516: Size comparison from a484e4c to 4c5fd68 Increases (3 builds for linux)
Full report (39 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
billwatersiii
pushed a commit
to billwatersiii/connectedhomeip
that referenced
this pull request
Dec 3, 2021
--Rename AttributeStatuses to AttributeStatusIBs --Rename EventFilters to EventFilterIBs --Rename EventPaths to EventPathIBs --Rename EventReports to EventReportIBs --Rename InvokeResponse to InvokeResponseIBs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
--Rename AttributeStatuses to AttributeStatusIBs
--Rename EventFilters to EventFilterIBs
--Rename EventPaths to EventPathIBs
--Rename EventReports to EventReportIBs
--Rename InvokeResponse to InvokeResponseIBs
--Fix several typos
Change overview
See above
Testing
The existing test covers