-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable asan for unit tests when compiling with clang. #11824
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:asan-unit-tests
Nov 17, 2021
Merged
Enable asan for unit tests when compiling with clang. #11824
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:asan-unit-tests
Nov 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon and
vivien-apple
November 16, 2021 07:13
pullapprove
bot
requested review from
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
November 16, 2021 07:13
PR #11824: Size comparison from 10be5f6 to 7158e12 Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Damian-Nordic
approved these changes
Nov 16, 2021
msandstedt
approved these changes
Nov 16, 2021
@mspang any idea why the Linux build fails to link? |
bzbarsky-apple
force-pushed
the
asan-unit-tests
branch
from
November 17, 2021 17:05
7158e12
to
462781b
Compare
mrjerryjohns
approved these changes
Nov 17, 2021
PR #11824: Size comparison from e568d70 to 462781b Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
This immediately caught two bugs in things that were being unit-tested. The Linux version fails to link for some reason, hence this is Darwin-only.
bzbarsky-apple
force-pushed
the
asan-unit-tests
branch
from
November 17, 2021 20:42
462781b
to
18af833
Compare
PR #11824: Size comparison from 1359f6e to 18af833 Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This immediately caught two bugs in things that were being unit-tested.
Problem
ASAN not enabled anywhere in our CI.
Change overview
At least enable it for unit tests on the "Build" job for Darwin [Edit: tried Linux too, but it fails to link there].
Testing
Ran the relevant Darwin commands locally.