Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Tvserver to examples #11780

Merged
merged 6 commits into from
Nov 17, 2021
Merged

Move Tvserver to examples #11780

merged 6 commits into from
Nov 17, 2021

Conversation

xylophone21
Copy link
Collaborator

Problem

  • Old CHIPTVServer is under src/android ( APK) and src/app/server ( zap ), this cause that we can not have a factory defined CHIPTVServer ( we may change the APK and zap defines )

Change overview

  • Move app-server JNI shared lib and tv-common(zzz_generated/tv-app/zap-generated) link to example
  • Move CHIPTVServer to example and let it build under example as other platforms

Testing

  • Basic test CHIPTVServer with chip-tool

@todo
Copy link

todo bot commented Nov 15, 2021

copy from examples/tv-app/linux but later will be moved to jni and upto java word

connectedhomeip/examples/tv-app/android/BUILD.gn

Lines 22 to 29 in 3dbd9a1

# Todo: copy from examples/tv-app/linux but later will be moved to jni and upto java word
shared_library("jni") {
output_name = "libTvApp"
sources = [
"${chip_root}/examples/tv-app/tv-common/include/CHIPProjectAppConfig.h",
"include/account-login/AccountLoginManager.cpp",

This comment was generated by todo based on a Todo comment in 3dbd9a1 in #11780. cc @xylophone21.

@todo
Copy link

todo bot commented Nov 15, 2021

add classpath support (we likely need to add something like

connectedhomeip/examples/tv-app/android/BUILD.gn

Lines 93 to 103 in 3dbd9a1

# TODO: add classpath support (we likely need to add something like
# ..../platforms/android-21/android.jar to access BLE items)
}
java_prebuilt("android") {
jar_path = "${android_sdk_root}/platforms/android-21/android.jar"
}
group("default") {
deps = [
":android",

This comment was generated by todo based on a TODO comment in 3dbd9a1 in #11780. cc @xylophone21.

@todo
Copy link

todo bot commented Nov 15, 2021

Runtime dependencies should be computed by the build system rather than hardcoded

connectedhomeip/scripts/build/builders/android.py

Lines 147 to 157 in 3dbd9a1

# TODO: Runtime dependencies should be computed by the build system rather than hardcoded
# GN supports getting these dependencies like:
# gn desc out/android-x64-chip_tool/ //src/controller/java runtime_deps
# gn desc out/android-x64-chip_tool/ //src/setup_payload/java runtime_deps
# However this assumes that the output folder has been populated, which will not be
# the case for `dry-run` executions. Hence this harcoding here.
#
# If we unify the JNI libraries, libc++_shared.so may not be needed anymore, which could
# be another path of resolving this inconsistency.
for libName in ['libSetupPayloadParser.so', 'libCHIPController.so', 'libc++_shared.so']:
self._Execute(['cp', os.path.join(self.output_dir, 'lib', 'jni', self.board.AbiName(

This comment was generated by todo based on a TODO comment in 3dbd9a1 in #11780. cc @xylophone21.

@restyled-io restyled-io bot mentioned this pull request Nov 15, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11780: Size comparison from 5623978 to d750561

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5623978 d750561 change % change
efr32 lighting-app BRD4161A (read only) 750088 750088 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 750080 750080 0 0.0
BRD4161A+rpc (read only) 737636 737636 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737628 737628 0 0.0
lock-app BRD4161A (read only) 726752 726752 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726744 726744 0 0.0
window-app BRD4161A (read only) 727744 727744 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727736 727736 0 0.0
esp32 all-clusters-app c3devkit (read only) 826956 826956 0 0.0
(read/write) 1224466 1224466 0 0.0
.dram0.bss 57088 57088 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 168040 168040 0 0.0
.flash.text 826956 826956 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897631 897631 0 0.0
(read/write) 422624 422624 0 0.0
.dram0.bss 62184 62184 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 195060 195060 0 0.0
.flash.text 892247 892247 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 702540 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 617324 617324 0 0.0
lock-app k32w061+debug (read/write) 593548 593548 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517844 517844 0 0.0
shell k32w061+debug (read/write) 659232 659232 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572768 572768 0 0.0
linux all-clusters-app debug (read only) 1722337 1722337 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140277 0 0.0
.text 1447842 1447842 0 0.0
bridge-app debug+rpc (read only) 1312741 1312741 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111860 0 0.0
.text 1103909 1103909 0 0.0
chip-tool debug (read only) 4921493 4921493 0 0.0
(read/write) 167208 167208 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268242 0 0.0
.text 4343605 4343605 0 0.0
lighting-app debug+rpc (read only) 1582281 1582281 0 0.0
(read/write) 110192 110192 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129841 0 0.0
.text 1317746 1317746 0 0.0
ota-provider-app debug (read only) 1267337 1267337 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057106 1057106 0 0.0
ota-requestor-app debug (read only) 1352009 1352009 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124208 0 0.0
.text 1128402 1128402 0 0.0
shell debug (read only) 789081 789081 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 609282 609282 0 0.0
tv-app debug (read only) 1858569 1858569 0 0.0
(read/write) 407896 407896 0 0.0
.bss 339752 339752 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157069 0 0.0
.text 1556418 1556418 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292200 0 0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1254800 1254800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2274688 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1237288 1237288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250128 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212728 1212728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865175 0 0.0
bss 110964 110964 0 0.0
rodata 97080 97080 0 0.0
text 581516 581516 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827567 827567 0 0.0
bss 107320 107320 0 0.0
rodata 88272 88272 0 0.0
text 555688 555688 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790234 0 0.0
bss 112340 112340 0 0.0
rodata 92340 92340 0 0.0
text 510984 510984 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840199 840199 0 0.0
bss 109988 109988 0 0.0
rodata 93144 93144 0 0.0
text 561616 561616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765514 765514 0 0.0
bss 111400 111400 0 0.0
rodata 88452 88452 0 0.0
text 491176 491176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 846327 0 0.0
bss 110128 110128 0 0.0
rodata 94856 94856 0 0.0
text 565800 565800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 839903 0 0.0
bss 110024 110024 0 0.0
rodata 93104 93104 0 0.0
text 561236 561236 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775499 775499 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520020 520020 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690554 690554 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440628 440628 0 0.0
p6 all-clusters-app default (read/write) 2301232 2301232 0 0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1259496 1259496 0 0.0
lock-app default (read/write) 2214704 2214704 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1172968 1172968 0 0.0
qpg lighting-app qpg6100+debug (read only) 494216 494216 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488896 488896 0 0.0
lock-app qpg6100+debug (read only) 468752 468752 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463432 463432 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 667854 0 0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 462372 462372 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11780: Size comparison from 5623978 to 4f6010f

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 5623978 4f6010f change % change
efr32 lighting-app BRD4161A (read only) 750088 750088 0 0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 750080 750080 0 0.0
BRD4161A+rpc (read only) 737636 737636 0 0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737628 737628 0 0.0
lock-app BRD4161A (read only) 726752 726752 0 0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726744 726744 0 0.0
window-app BRD4161A (read only) 727744 727744 0 0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727736 727736 0 0.0
esp32 all-clusters-app c3devkit (read only) 826956 826956 0 0.0
(read/write) 1224466 1224466 0 0.0
.dram0.bss 57088 57088 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 168040 168040 0 0.0
.flash.text 826956 826956 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 897631 897631 0 0.0
(read/write) 422624 422624 0 0.0
.dram0.bss 62184 62184 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 195060 195060 0 0.0
.flash.text 892247 892247 0 0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702540 702540 0 0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 617324 617324 0 0.0
lock-app k32w061+debug (read/write) 593548 593548 0 0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517844 517844 0 0.0
shell k32w061+debug (read/write) 659232 659232 0 0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572768 572768 0 0.0
linux all-clusters-app debug (read only) 1722337 1722337 0 0.0
(read/write) 126816 126816 0 0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62720 62720 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140277 0 0.0
.text 1447842 1447842 0 0.0
bridge-app debug+rpc (read only) 1312741 1312741 0 0.0
(read/write) 77424 77424 0 0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 27960 27960 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111860 0 0.0
.text 1103909 1103909 0 0.0
chip-tool debug (read only) 4921493 4921493 0 0.0
(read/write) 167208 167208 0 0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118256 118256 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268242 0 0.0
.text 4343605 4343605 0 0.0
lighting-app debug+rpc (read only) 1582281 1582281 0 0.0
(read/write) 110192 110192 0 0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55552 55552 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129841 129841 0 0.0
.text 1317746 1317746 0 0.0
ota-provider-app debug (read only) 1267337 1267337 0 0.0
(read/write) 75176 75176 0 0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24776 24776 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057106 1057106 0 0.0
ota-requestor-app debug (read only) 1352009 1352009 0 0.0
(read/write) 78944 78944 0 0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26040 26040 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124208 0 0.0
.text 1128402 1128402 0 0.0
shell debug (read only) 789081 789081 0 0.0
(read/write) 65064 65064 0 0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36928 36928 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 609282 609282 0 0.0
tv-app debug (read only) 1858569 1858569 0 0.0
(read/write) 407896 407896 0 0.0
.bss 339752 339752 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59696 59696 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157069 0 0.0
.text 1556418 1556418 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292200 2292200 0 0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1254800 1254800 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274688 2274688 0 0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1237288 1237288 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250128 2250128 0 0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212728 1212728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048376 2048376 0 0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1010976 1010976 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865175 865175 0 0.0
bss 110964 110964 0 0.0
rodata 97080 97080 0 0.0
text 581516 581516 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 827567 827567 0 0.0
bss 107320 107320 0 0.0
rodata 88272 88272 0 0.0
text 555688 555688 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790234 790234 0 0.0
bss 112340 112340 0 0.0
rodata 92340 92340 0 0.0
text 510984 510984 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 840199 840199 0 0.0
bss 109988 109988 0 0.0
rodata 93144 93144 0 0.0
text 561616 561616 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765514 765514 0 0.0
bss 111400 111400 0 0.0
rodata 88452 88452 0 0.0
text 491176 491176 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846327 846327 0 0.0
bss 110128 110128 0 0.0
rodata 94856 94856 0 0.0
text 565800 565800 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839903 839903 0 0.0
bss 110024 110024 0 0.0
rodata 93104 93104 0 0.0
text 561236 561236 0 0.0
shell nrf52840dk_nrf52840 (read/write) 775499 775499 0 0.0
bss 108736 108736 0 0.0
rodata 72160 72160 0 0.0
text 520020 520020 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690554 690554 0 0.0
bss 109720 109720 0 0.0
rodata 66804 66804 0 0.0
text 440628 440628 0 0.0
p6 all-clusters-app default (read/write) 2301232 2301232 0 0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1259496 1259496 0 0.0
lock-app default (read/write) 2214704 2214704 0 0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1172968 1172968 0 0.0
qpg lighting-app qpg6100+debug (read only) 494216 494216 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 488896 488896 0 0.0
lock-app qpg6100+debug (read only) 468752 468752 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463432 463432 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667854 667854 0 0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 462372 462372 0 0.0

@woody-apple
Copy link
Contributor

Fast tracking, given this is a platform maintainer updating their platform.

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11780: Size comparison from cbd3e95 to ecab319

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 ecab319 change % change
efr32 lighting-app BRD4161A (read only) 745448 745448 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745440 745440 0 0.0
BRD4161A+rpc (read only) 732964 732964 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732956 732956 0 0.0
lock-app BRD4161A (read only) 722536 722536 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722528 722528 0 0.0
window-app BRD4161A (read only) 723496 723496 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723488 723488 0 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825128 0 0.0
(read/write) 1219762 1219762 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163912 163912 0 0.0
.flash.text 825128 825128 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896127 896127 0 0.0
(read/write) 419084 419084 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191884 191884 0 0.0
.flash.text 890743 890743 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703856 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619156 619156 0 0.0
lock-app k32w061+debug (read/write) 595300 595300 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520120 520120 0 0.0
shell k32w061+debug (read/write) 660532 660532 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574320 574320 0 0.0
linux all-clusters-app debug (read only) 1702849 1702849 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135349 0 0.0
.text 1434050 1434050 0 0.0
bridge-app debug+rpc (read only) 1298021 1298021 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110764 0 0.0
.text 1090357 1090357 0 0.0
chip-tool debug (read only) 4957053 4957053 0 0.0
(read/write) 166504 166504 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267186 0 0.0
.text 4380437 4380437 0 0.0
lighting-app debug+rpc (read only) 1567113 1567113 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128401 0 0.0
.text 1304210 1304210 0 0.0
ota-provider-app debug (read only) 1253449 1253449 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113063 0 0.0
.text 1043298 1043298 0 0.0
ota-requestor-app debug (read only) 1337025 1337025 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1113490 1113490 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846009 1846009 0 0.0
(read/write) 318136 318136 0 0.0
.bss 249960 249960 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 156653 0 0.0
.text 1544802 1544802 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284296 2284296 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246896 1246896 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232824 1232824 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2246128 2246128 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208728 1208728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 860463 0 0.0
bss 110384 110384 0 0.0
rodata 95136 95136 0 0.0
text 579316 579316 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822831 822831 0 0.0
bss 106740 106740 0 0.0
rodata 86320 86320 0 0.0
text 553488 553488 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785502 785502 0 0.0
bss 111760 111760 0 0.0
rodata 90392 90392 0 0.0
text 508788 508788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835859 835859 0 0.0
bss 109408 109408 0 0.0
rodata 91604 91604 0 0.0
text 559416 559416 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761182 0 0.0
bss 110820 110820 0 0.0
rodata 86912 86912 0 0.0
text 488976 488976 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842003 0 0.0
bss 109548 109548 0 0.0
rodata 93316 93316 0 0.0
text 563596 563596 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835595 0 0.0
bss 109444 109444 0 0.0
rodata 91564 91564 0 0.0
text 559036 559036 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292832 2292832 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251096 1251096 0 0.0
lock-app default (read/write) 2210320 2210320 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168584 1168584 0 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484760 484760 0 0.0
lock-app qpg6100+debug (read only) 465044 465044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459724 459724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763250 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529344 529344 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11780: Size comparison from cbd3e95 to 402eccb

Full report (13 builds for efr32, k32w, p6, qpg, telink)
platform target config section cbd3e95 402eccb change % change
efr32 lighting-app BRD4161A (read only) 745448 745448 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745440 745440 0 0.0
BRD4161A+rpc (read only) 732964 732964 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732956 732956 0 0.0
lock-app BRD4161A (read only) 722536 722536 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722528 722528 0 0.0
window-app BRD4161A (read only) 723496 723496 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723488 723488 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703856 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619156 619156 0 0.0
lock-app k32w061+debug (read/write) 595300 595300 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520120 520120 0 0.0
shell k32w061+debug (read/write) 660532 660532 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574320 574320 0 0.0
p6 all-clusters-app default (read/write) 2292832 2292832 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251096 1251096 0 0.0
lock-app default (read/write) 2210320 2210320 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168584 1168584 0 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484760 484760 0 0.0
lock-app qpg6100+debug (read only) 465044 465044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459724 459724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763250 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529344 529344 0 0.0

@github-actions
Copy link

github-actions bot commented Nov 17, 2021 •
edited
Loading

PR #11780: Size comparison from cbd3e95 to f7ddab7

Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section cbd3e95 f7ddab7 change % change
efr32 lighting-app BRD4161A (read only) 745448 745448 0 0.0
(read/write) 115364 115364 0 0.0
.bss 113564 113564 0 0.0
.data 1800 1800 0 0.0
.text 745440 745440 0 0.0
BRD4161A+rpc (read only) 732964 732964 0 0.0
(read/write) 131992 131992 0 0.0
.bss 130068 130068 0 0.0
.data 1924 1924 0 0.0
.text 732956 732956 0 0.0
lock-app BRD4161A (read only) 722536 722536 0 0.0
(read/write) 113148 113148 0 0.0
.bss 111388 111388 0 0.0
.data 1756 1756 0 0.0
.text 722528 722528 0 0.0
window-app BRD4161A (read only) 723496 723496 0 0.0
(read/write) 113468 113468 0 0.0
.bss 111708 111708 0 0.0
.data 1760 1760 0 0.0
.text 723488 723488 0 0.0
esp32 all-clusters-app c3devkit (read only) 825128 825128 0 0.0
(read/write) 1219762 1219762 0 0.0
.dram0.bss 56512 56512 0 0.0
.dram0.data 14084 14084 0 0.0
.flash.rodata 163912 163912 0 0.0
.flash.text 825128 825128 0 0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 896127 896127 0 0.0
(read/write) 419084 419084 0 0.0
.dram0.bss 61864 61864 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 191884 191884 0 0.0
.flash.text 890743 890743 0 0.0
.iram0.text 122943 122943 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 703856 703856 0 0.0
.bss 76988 76988 0 0.0
.data 1912 1912 0 0.0
.text 619156 619156 0 0.0
lock-app k32w061+debug (read/write) 595300 595300 0 0.0
.bss 67500 67500 0 0.0
.data 1880 1880 0 0.0
.text 520120 520120 0 0.0
shell k32w061+debug (read/write) 660532 660532 0 0.0
.bss 78564 78564 0 0.0
.data 1848 1848 0 0.0
.text 574320 574320 0 0.0
linux all-clusters-app debug (read only) 1702849 1702849 0 0.0
(read/write) 126624 126624 0 0.0
.bss 57520 57520 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62784 62784 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 135349 135349 0 0.0
.text 1434050 1434050 0 0.0
bridge-app debug+rpc (read only) 1298021 1298021 0 0.0
(read/write) 76816 76816 0 0.0
.bss 42224 42224 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28024 28024 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 110764 110764 0 0.0
.text 1090357 1090357 0 0.0
chip-tool debug (read only) 4957053 4957053 0 0.0
(read/write) 166504 166504 0 0.0
.bss 40584 40584 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118136 118136 0 0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 267186 267186 0 0.0
.text 4380437 4380437 0 0.0
lighting-app debug+rpc (read only) 1567113 1567113 0 0.0
(read/write) 110064 110064 0 0.0
.bss 47888 47888 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55616 55616 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 128401 128401 0 0.0
.text 1304210 1304210 0 0.0
ota-provider-app debug (read only) 1253449 1253449 0 0.0
(read/write) 75560 75560 0 0.0
.bss 44832 44832 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24840 24840 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113063 113063 0 0.0
.text 1043298 1043298 0 0.0
ota-requestor-app debug (read only) 1337025 1337025 0 0.0
(read/write) 79264 79264 0 0.0
.bss 47296 47296 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26024 26024 0 0.0
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124112 124112 0 0.0
.text 1113490 1113490 0 0.0
shell debug (read only) 794665 794665 0 0.0
(read/write) 66088 66088 0 0.0
.bss 23816 23816 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37520 37520 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 78479 78479 0 0.0
.text 612674 612674 0 0.0
tv-app debug (read only) 1846009 1846009 0 0.0
(read/write) 318136 318136 0 0.0
.bss 249960 249960 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 59720 59720 0 0.0
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 156653 156653 0 0.0
.text 1544802 1544802 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2284296 2284296 0 0.0
.bss 179108 179108 0 0.0
.data 5216 5216 0 0.0
.heap 852120 852120 0 0.0
.text 1246896 1246896 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2270224 2270224 0 0.0
.bss 171972 171972 0 0.0
.data 5576 5576 0 0.0
.heap 858896 858896 0 0.0
.text 1232824 1232824 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2246128 2246128 0 0.0
.bss 170860 170860 0 0.0
.data 5568 5568 0 0.0
.heap 860016 860016 0 0.0
.text 1208728 1208728 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049520 2049520 0 0.0
.bss 156160 156160 0 0.0
.data 4968 4968 0 0.0
.heap 875320 875320 0 0.0
.text 1012120 1012120 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860463 860463 0 0.0
bss 110384 110384 0 0.0
rodata 95136 95136 0 0.0
text 579316 579316 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 822831 822831 0 0.0
bss 106740 106740 0 0.0
rodata 86320 86320 0 0.0
text 553488 553488 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785502 785502 0 0.0
bss 111760 111760 0 0.0
rodata 90392 90392 0 0.0
text 508788 508788 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 835859 835859 0 0.0
bss 109408 109408 0 0.0
rodata 91604 91604 0 0.0
text 559416 559416 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 761182 761182 0 0.0
bss 110820 110820 0 0.0
rodata 86912 86912 0 0.0
text 488976 488976 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 842003 842003 0 0.0
bss 109548 109548 0 0.0
rodata 93316 93316 0 0.0
text 563596 563596 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 835595 835595 0 0.0
bss 109444 109444 0 0.0
rodata 91564 91564 0 0.0
text 559036 559036 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776239 776239 0 0.0
bss 109004 109004 0 0.0
rodata 72516 72516 0 0.0
text 520124 520124 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691294 691294 0 0.0
bss 109988 109988 0 0.0
rodata 67160 67160 0 0.0
text 440732 440732 0 0.0
p6 all-clusters-app default (read/write) 2292832 2292832 0 0.0
.bss 112096 112096 0 0.0
.data 2520 2520 0 0.0
.heap 918728 918728 0 0.0
.text 1251096 1251096 0 0.0
lock-app default (read/write) 2210320 2210320 0 0.0
.bss 100720 100720 0 0.0
.data 2400 2400 0 0.0
.heap 930224 930224 0 0.0
.text 1168584 1168584 0 0.0
qpg lighting-app qpg6100+debug (read only) 490080 490080 0 0.0
(read/write) 114144 114144 0 0.0
.bss 50056 50056 0 0.0
.data 1008 1008 0 0.0
.text 484760 484760 0 0.0
lock-app qpg6100+debug (read only) 465044 465044 0 0.0
(read/write) 114140 114140 0 0.0
.bss 49000 49000 0 0.0
.data 964 964 0 0.0
.text 459724 459724 0 0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 763250 763250 0 0.0
bss 78896 78896 0 0.0
noinit 37160 37160 0 0.0
text 529344 529344 0 0.0

@andy31415 andy31415 merged commit 828b96f into project-chip:master Nov 17, 2021
andy31415
andy31415 reviewed Nov 17, 2021
View reviewed changes
examples/tv-app/android/java/TVApp-JNI.cpp

/**
* @file
* Implementation of JNI bridge for Tv App on Android.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this @file comment does not seem to help me understand code more: it is obvious that a file named TVApp-JNI.cpp contains an implementation of JNI for a TV APP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will remove it in next PR

kpschoedel pushed a commit to kpschoedel/connectedhomeip that referenced this pull request Nov 18, 2021
@xylophone21 @kpschoedel
Move Tvserver to examples (project-chip#11780)
993df12 
* move share lib and tv-common(zzz_generated/tv-app/zap-generated) link to example, so that we cloud have different android tv apps for different clusters

* make it buildable under example

* move CHIPTVServer to examples/tv-app/android

* fix runtime issue, force load jni before using AndroidChipPlatform

* change build_example.py for new app struct

* fix restyled-io and ci issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 left review comments

@woody-apple woody-apple woody-apple approved these changes

@lazarkov lazarkov lazarkov approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xylophone21 @woody-apple @andy31415 @lazarkov