Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] BLE central implementation #11619

Merged
merged 1 commit into from
Nov 15, 2021
Merged

[Tizen] BLE central implementation #11619

merged 1 commit into from
Nov 15, 2021

Conversation

RoyAnupam
Copy link
Contributor

@RoyAnupam RoyAnupam commented Nov 10, 2021 •
edited
Loading

Problem
The BLE central role is not implemented.

Change overview
Add BLE central for Tizen.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Nov 10, 2021
Closed
@andy31415
Copy link
Contributor

fast track: platform specific changes made by a platform developer

bzbarsky-apple
bzbarsky-apple reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamping pending @Damian-Nordic being happy.

@andy31415
Copy link
Contributor

@Damian-Nordic - are you ok with comment reply from @RoyAnupam ?

@Damian-Nordic
Copy link
Contributor

@andy31415 Yes, fine with me!

@andy31415
Copy link
Contributor

/rebase

@RoyAnupam @andy31415
[Tizen] BLE central implementation
b421fd4 
Problem
The BLE central role is not implemented.

Change overview
Add BLE central for Tizen.

Signed-off-by: Anupam Roy <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 15, 2021 •
edited
Loading

PR #11619: Size comparison from eb03a25 to b421fd4

Decreases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb03a25 b421fd4 change % change
efr32 lighting-app BRD4161A (read only) 750160 750128 -32 -0.0
.text 750152 750120 -32 -0.0
BRD4161A+rpc (read only) 737724 737692 -32 -0.0
.text 737716 737684 -32 -0.0
lock-app BRD4161A (read only) 726824 726792 -32 -0.0
.text 726816 726784 -32 -0.0
window-app BRD4161A (read only) 727816 727784 -32 -0.0
.text 727808 727776 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 828284 828266 -18 -0.0
(read/write) 1226050 1226042 -8 -0.0
.flash.rodata 169608 169600 -8 -0.0
.flash.text 828284 828266 -18 -0.0
m5stack (read only) 898671 898639 -32 -0.0
(read/write) 424832 424816 -16 -0.0
.flash.rodata 197268 197252 -16 -0.0
.flash.text 893287 893255 -32 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 702692 702664 -28 -0.0
.text 617476 617448 -28 -0.0
lock-app k32w061+debug (read/write) 593700 593672 -28 -0.0
.text 517996 517968 -28 -0.0
shell k32w061+debug (read/write) 659372 659344 -28 -0.0
.text 572908 572880 -28 -0.0
linux all-clusters-app debug (read only) 1722929 1722641 -288 -0.0
(read/write) 126976 126944 -32 -0.0
.data.rel.ro 62880 62848 -32 -0.1
.text 1447954 1447762 -192 -0.0
bridge-app debug+rpc (read only) 1313333 1313045 -288 -0.0
(read/write) 77584 77552 -32 -0.0
.data.rel.ro 28120 28088 -32 -0.1
.text 1104021 1103829 -192 -0.0
chip-tool debug (read only) 4922085 4921333 -752 -0.0
(read/write) 167368 167336 -32 -0.0
.data.rel.ro 118416 118384 -32 -0.0
.rodata 268242 268178 -64 -0.0
.text 4343717 4343125 -592 -0.0
lighting-app debug+rpc (read only) 1582905 1582617 -288 -0.0
(read/write) 110352 110320 -32 -0.0
.data.rel.ro 55712 55680 -32 -0.1
.text 1317858 1317666 -192 -0.0
ota-provider-app debug (read only) 1267929 1267641 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.data.rel.ro 24936 24904 -32 -0.1
.text 1057218 1057026 -192 -0.0
ota-requestor-app debug (read only) 1352601 1352313 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.data.rel.ro 26200 26168 -32 -0.1
.text 1128514 1128322 -192 -0.0
shell debug (read only) 793705 793417 -288 -0.0
(read/write) 65544 65512 -32 -0.0
.data.rel.ro 37392 37360 -32 -0.1
.text 612626 612434 -192 -0.0
tv-app debug (read only) 1859177 1858457 -720 -0.0
(read/write) 408056 407512 -544 -0.1
.bss 339752 339240 -512 -0.2
.data.rel.ro 59856 59824 -32 -0.1
.rodata 157069 157037 -32 -0.0
.text 1556546 1555954 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2292504 2292496 -8 -0.0
.text 1255104 1255096 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2274928 2274912 -16 -0.0
.text 1237528 1237512 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250368 2250352 -16 -0.0
.text 1212968 1212952 -16 -0.0
shell CY8CPROTO_062_4343W+release (read/write) 2049144 2049136 -8 -0.0
.text 1011744 1011736 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865315 865287 -28 -0.0
rodata 97124 97112 -12 -0.0
text 581612 581596 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827707 827679 -28 -0.0
rodata 88316 88304 -12 -0.0
text 555784 555768 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790374 790346 -28 -0.0
rodata 92384 92372 -12 -0.0
text 511080 511064 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840355 840327 -28 -0.0
rodata 93188 93176 -12 -0.0
text 561716 561700 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765654 765626 -28 -0.0
rodata 88496 88484 -12 -0.0
text 491276 491260 -16 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 846467 846439 -28 -0.0
rodata 94900 94888 -12 -0.0
text 565896 565880 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840059 840031 -28 -0.0
rodata 93148 93136 -12 -0.0
text 561336 561320 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 775671 775643 -28 -0.0
rodata 72204 72192 -12 -0.0
text 520120 520104 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690694 690666 -28 -0.0
rodata 66848 66836 -12 -0.0
text 440728 440712 -16 -0.0
p6 all-clusters-app default (read/write) 2301280 2301248 -32 -0.0
.text 1259544 1259512 -32 -0.0
lock-app default (read/write) 2214768 2214736 -32 -0.0
.text 1173032 1173000 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 494368 494340 -28 -0.0
.text 489048 489020 -28 -0.0
lock-app qpg6100+debug (read only) 468896 468868 -28 -0.0
.text 463576 463548 -28 -0.0
telink lighting-app tlsr9518adk80d (read/write) 667994 667966 -28 -0.0
text 462468 462450 -18 -0.0
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section eb03a25 b421fd4 change % change
efr32 lighting-app BRD4161A (read only) 750160 750128 -32 -0.0
(read/write) 115940 115940 0 0.0
.bss 114140 114140 0 0.0
.data 1800 1800 0 0.0
.text 750152 750120 -32 -0.0
BRD4161A+rpc (read only) 737724 737692 -32 -0.0
(read/write) 132568 132568 0 0.0
.bss 130644 130644 0 0.0
.data 1924 1924 0 0.0
.text 737716 737684 -32 -0.0
lock-app BRD4161A (read only) 726824 726792 -32 -0.0
(read/write) 113724 113724 0 0.0
.bss 111964 111964 0 0.0
.data 1756 1756 0 0.0
.text 726816 726784 -32 -0.0
window-app BRD4161A (read only) 727816 727784 -32 -0.0
(read/write) 114044 114044 0 0.0
.bss 112284 112284 0 0.0
.data 1760 1760 0 0.0
.text 727808 727776 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 828284 828266 -18 -0.0
(read/write) 1226050 1226042 -8 -0.0
.dram0.bss 57096 57096 0 0.0
.dram0.data 14092 14092 0 0.0
.flash.rodata 169608 169600 -8 -0.0
.flash.text 828284 828266 -18 -0.0
.iram0.text 61394 61394 0 0.0
m5stack (read only) 898671 898639 -32 -0.0
(read/write) 424832 424816 -16 -0.0
.dram0.bss 62184 62184 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 197268 197252 -16 -0.0
.flash.text 893287 893255 -32 -0.0
.iram0.text 122987 122987 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 702692 702664 -28 -0.0
.bss 77508 77508 0 0.0
.data 1908 1908 0 0.0
.text 617476 617448 -28 -0.0
lock-app k32w061+debug (read/write) 593700 593672 -28 -0.0
.bss 68028 68028 0 0.0
.data 1876 1876 0 0.0
.text 517996 517968 -28 -0.0
shell k32w061+debug (read/write) 659372 659344 -28 -0.0
.bss 78820 78820 0 0.0
.data 1844 1844 0 0.0
.text 572908 572880 -28 -0.0
linux all-clusters-app debug (read only) 1722929 1722641 -288 -0.0
(read/write) 126976 126944 -32 -0.0
.bss 57776 57776 0 0.0
.data 1042 1042 0 0.0
.data.rel.ro 62880 62848 -32 -0.1
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 140277 140277 0 0.0
.text 1447954 1447762 -192 -0.0
bridge-app debug+rpc (read only) 1313333 1313045 -288 -0.0
(read/write) 77584 77552 -32 -0.0
.bss 42896 42896 0 0.0
.data 1568 1568 0 0.0
.data.rel.ro 28120 28088 -32 -0.1
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 408 408 0 0.0
.rodata 111860 111860 0 0.0
.text 1104021 1103829 -192 -0.0
chip-tool debug (read only) 4922085 4921333 -752 -0.0
(read/write) 167368 167336 -32 -0.0
.bss 41192 41192 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 118416 118384 -32 -0.0
.dynamic 592 592 0 0.0
.got 4416 4416 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 268242 268178 -64 -0.0
.text 4343717 4343125 -592 -0.0
lighting-app debug+rpc (read only) 1582905 1582617 -288 -0.0
(read/write) 110352 110320 -32 -0.0
.bss 48080 48080 0 0.0
.data 1234 1234 0 0.0
.data.rel.ro 55712 55680 -32 -0.1
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 129873 129873 0 0.0
.text 1317858 1317666 -192 -0.0
ota-provider-app debug (read only) 1267929 1267641 -288 -0.0
(read/write) 75336 75304 -32 -0.0
.bss 44512 44512 0 0.0
.data 784 784 0 0.0
.data.rel.ro 24936 24904 -32 -0.1
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 448 448 0 0.0
.rodata 113383 113383 0 0.0
.text 1057218 1057026 -192 -0.0
ota-requestor-app debug (read only) 1352601 1352313 -288 -0.0
(read/write) 79104 79072 -32 -0.0
.bss 46976 46976 0 0.0
.data 848 848 0 0.0
.data.rel.ro 26200 26168 -32 -0.1
.dynamic 592 592 0 0.0
.got 3992 3992 0 0.0
.init 27 27 0 0.0
.init_array 472 472 0 0.0
.rodata 124208 124208 0 0.0
.text 1128514 1128322 -192 -0.0
shell debug (read only) 793705 793417 -288 -0.0
(read/write) 65544 65512 -32 -0.0
.bss 23400 23400 0 0.0
.data 242 242 0 0.0
.data.rel.ro 37392 37360 -32 -0.1
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 344 344 0 0.0
.rodata 77903 77903 0 0.0
.text 612626 612434 -192 -0.0
tv-app debug (read only) 1859177 1858457 -720 -0.0
(read/write) 408056 407512 -544 -0.1
.bss 339752 339240 -512 -0.2
.data 2768 2768 0 0.0
.data.rel.ro 59856 59824 -32 -0.1
.dynamic 592 592 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 157069 157037 -32 -0.0
.text 1556546 1555954 -592 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2292504 2292496 -8 -0.0
.bss 179692 179692 0 0.0
.data 5216 5216 0 0.0
.heap 851536 851536 0 0.0
.text 1255104 1255096 -8 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2274928 2274912 -16 -0.0
.bss 172556 172556 0 0.0
.data 5576 5576 0 0.0
.heap 858312 858312 0 0.0
.text 1237528 1237512 -16 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250368 2250352 -16 -0.0
.bss 171436 171436 0 0.0
.data 5568 5568 0 0.0
.heap 859440 859440 0 0.0
.text 1212968 1212952 -16 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2049144 2049136 -8 -0.0
.bss 155912 155912 0 0.0
.data 4968 4968 0 0.0
.heap 875568 875568 0 0.0
.text 1011744 1011736 -8 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 865315 865287 -28 -0.0
bss 110964 110964 0 0.0
rodata 97124 97112 -12 -0.0
text 581612 581596 -16 -0.0
nrf52840dk_nrf52840+rpc (read/write) 827707 827679 -28 -0.0
bss 107320 107320 0 0.0
rodata 88316 88304 -12 -0.0
text 555784 555768 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 790374 790346 -28 -0.0
bss 112340 112340 0 0.0
rodata 92384 92372 -12 -0.0
text 511080 511064 -16 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 840355 840327 -28 -0.0
bss 109988 109988 0 0.0
rodata 93188 93176 -12 -0.0
text 561716 561700 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 765654 765626 -28 -0.0
bss 111400 111400 0 0.0
rodata 88496 88484 -12 -0.0
text 491276 491260 -16 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497327 497327 0 0.0
bss 51824 51824 0 0.0
rodata 45780 45780 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 846467 846439 -28 -0.0
bss 110128 110128 0 0.0
rodata 94900 94888 -12 -0.0
text 565896 565880 -16 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 840059 840031 -28 -0.0
bss 110024 110024 0 0.0
rodata 93148 93136 -12 -0.0
text 561336 561320 -16 -0.0
shell nrf52840dk_nrf52840 (read/write) 775671 775643 -28 -0.0
bss 108744 108744 0 0.0
rodata 72204 72192 -12 -0.0
text 520120 520104 -16 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 690694 690666 -28 -0.0
bss 109728 109728 0 0.0
rodata 66848 66836 -12 -0.0
text 440728 440712 -16 -0.0
p6 all-clusters-app default (read/write) 2301280 2301248 -32 -0.0
.bss 112680 112680 0 0.0
.data 2520 2520 0 0.0
.heap 918144 918144 0 0.0
.text 1259544 1259512 -32 -0.0
lock-app default (read/write) 2214768 2214736 -32 -0.0
.bss 101296 101296 0 0.0
.data 2400 2400 0 0.0
.heap 929648 929648 0 0.0
.text 1173032 1173000 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 494368 494340 -28 -0.0
(read/write) 114144 114144 0 0.0
.bss 50640 50640 0 0.0
.data 1008 1008 0 0.0
.text 489048 489020 -28 -0.0
lock-app qpg6100+debug (read only) 468896 468868 -28 -0.0
(read/write) 114140 114140 0 0.0
.bss 49576 49576 0 0.0
.data 964 964 0 0.0
.text 463576 463548 -28 -0.0
persistent-storage-app qpg6100+debug (read only) 105408 105408 0 0.0
(read/write) 114142 114142 0 0.0
.bss 8978 8978 0 0.0
.data 272 272 0 0.0
.text 100088 100088 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 667994 667966 -28 -0.0
bss 69320 69320 0 0.0
noinit 33216 33216 0 0.0
text 462468 462450 -18 -0.0

@andy31415 andy31415 merged commit 16d2d17 into project-chip:master Nov 15, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@RoyAnupam
[Tizen] BLE central implementation (project-chip#11619)
d55a8cb 
Problem
The BLE central role is not implemented.

Change overview
Add BLE central for Tizen.

Signed-off-by: Anupam Roy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic left review comments

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
fast track platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RoyAnupam @CLAassistant @andy31415 @Damian-Nordic @bzbarsky-apple