Fix YAML checking of return values handle lists and structs correctly #11570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #11570: Size comparison from 94c5144 to 80c730c Full report (9 builds for k32w, p6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
better-expected-matching
branch
from
80c730c to
8239162
Compare
Check the length, at least?This comment was generated by todo based on a
|
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
wbschiller,
woody-apple and
yunhanw-google
|
PR #11570: Size comparison from 94c5144 to 8239162 Increases above 0.2%:
Increases (2 builds for esp32, linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
The change to CheckValue is to make it clearer which value is the actual value and which value is the expected value. The change to TestAttrAccess::ReadListInt8uAttribute is to make the actual value it produces match the expected value, in a way that keeps the values different from the indices.
The CheckValueAsString change is just to show what the actual value was that does not match the expected value. The CheckValue (enum version) change is to make it compile, now that it's actually being used.
andy31415
approved these changes
Nov 9, 2021
bzbarsky-apple
force-pushed
the
better-expected-matching
branch
from
8239162 to
aa704b8
Compare
|
PR #11570: Size comparison from 613f27f to aa704b8 Increases above 0.2%:
Increases (2 builds for esp32, linux)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 9, 2021
yufengwangca
approved these changes
Nov 9, 2021
vivien-apple
approved these changes
Nov 9, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…project-chip#11570) * Turn on checking of list contents for YAML tests. The change to CheckValue is to make it clearer which value is the actual value and which value is the expected value. The change to TestAttrAccess::ReadListInt8uAttribute is to make the actual value it produces match the expected value, in a way that keeps the values different from the indices. * Turn on checking of struct fields for YAML tests The CheckValueAsString change is just to show what the actual value was that does not match the expected value. The CheckValue (enum version) change is to make it compile, now that it's actually being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
YAML checking of return values currently only checks list lengths in most cases, and can't handle struct-typed command fields.
Change overview
Implement checking of arbitrarily-deeply-nested lists and structs.
Testing
Some test updates for existing tests that are now doing more checks.