Migrate System::Timer to BitMapObjectPool #11487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The multiple object pool implementations are being consolidated, but `System::Timer` isn't ready. #### Change overview Transitionally, convert `System::Timer` to use `BitMapObjectPool` instead of `System::ObjectPool`, so that it doesn't obstruct refactoring. Any platform using both `System::Timer` and `CHIP_SYSTEM_CONFIG_USE_HEAP` will show a `.bss` increase from this PR; this will be undone by a later step in pool conversion. #### Testing CI; no changes to functionality.
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tecimovic
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller,
woody-apple and
yufengwangca
msandstedt
approved these changes
Nov 5, 2021
|
PR #11487: Size comparison from 7addec8 to 475d4f6 Increases above 0.2%:
Increases (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (18 builds for linux, mbed, nrfconnect, p6, qpg)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 5, 2021
kghost
approved these changes
Nov 5, 2021
woody-apple
approved these changes
Nov 5, 2021
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 11, 2021
#### Problem We have too many pool allocators. Previous PRs (project-chip#11428, project-chip#11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from project-chip#9590) - Add allocation selection (from project-chip#11371) - Use this for `System::Timer` (complementing project-chip#11487) Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing project-chip#11428); that is not done here because it would conflict with other Inet changes under way. #### Testing CI; no changes to functionality. CI should show `.bss` decreases corresponding to increases in project-chip#11487.
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 11, 2021
#### Problem We have too many pool allocators. Previous PRs (project-chip#11428, project-chip#11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from project-chip#9590) - Add allocation selection (from project-chip#11371) - Use this for `System::Timer` (complementing project-chip#11487) Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing project-chip#11428); that is not done here because it would conflict with other Inet changes under way. #### Testing Added heap versions of unit tests in TestPool. (A future PR will add `System::Object`-style statistics and re-unify most of these tests.) CI should show `.bss` decreases corresponding to increases in project-chip#11487.
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 15, 2021
#### Problem We have too many pool allocators. Previous PRs (project-chip#11428, project-chip#11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from project-chip#9590) - Add allocation selection (from project-chip#11371) - Use this for `System::Timer` (complementing project-chip#11487) Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing project-chip#11428); that is not done here because it would conflict with other Inet changes under way. #### Testing Added heap versions of unit tests in TestPool. (A future PR will add `System::Object`-style statistics and re-unify most of these tests.) CI should show `.bss` decreases corresponding to increases in project-chip#11487.
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 16, 2021
#### Problem We have too many pool allocators. Previous PRs (project-chip#11428, project-chip#11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from project-chip#9590) - Add allocation selection (from project-chip#11371) - Use this for `System::Timer` (complementing project-chip#11487) Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing project-chip#11428); that is not done here because it would conflict with other Inet changes under way. #### Testing Added heap versions of unit tests in TestPool. (A future PR will add `System::Object`-style statistics and re-unify most of these tests.) CI should show `.bss` decreases corresponding to increases in project-chip#11487.
kpschoedel
added a commit
to kpschoedel/connectedhomeip
that referenced
this pull request
Nov 16, 2021
#### Problem We have too many pool allocators. Previous PRs (project-chip#11428, project-chip#11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from project-chip#9590) - Add allocation selection (from project-chip#11371) - Use this for `System::Timer` (complementing project-chip#11487) Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing project-chip#11428); that is not done here because it would conflict with other Inet changes under way. #### Testing Added heap versions of unit tests in TestPool. (A future PR will add `System::Object`-style statistics and re-unify most of these tests.) CI should show `.bss` decreases corresponding to increases in project-chip#11487.
kpschoedel
added a commit
that referenced
this pull request
Nov 19, 2021
#### Problem We have too many pool allocators. Previous PRs (#11428, #11487) transitionally use `BitMapObjectPool` where previously `System::ObjectPool` had been used, but this lost the ability to configure heap allocation. #### Change overview - Add a heap allocator (from #9590) - Add allocation selection (from #11371) - Use this for `System::Timer` (complementing #11487) - Factor out common code. - Use a heap-allocated list to track heap-allocated objects. - More unit tests. Co-authored-by: Zang MingJie <[email protected]> Co-authored-by: C Freeman <[email protected]> A future PR will use this for Inet pools (complementing #11428); that is not done here because it would conflict with other Inet changes under way. #### Testing Added heap versions of unit tests in TestPool. (A future PR will add `System::Object`-style statistics and re-unify most of these tests.) CI should show `.bss` decreases corresponding to increases in #11487.
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
#### Problem The multiple object pool implementations are being consolidated, but `System::Timer` isn't ready. #### Change overview Transitionally, convert `System::Timer` to use `BitMapObjectPool` instead of `System::ObjectPool`, so that it doesn't obstruct refactoring. Any platform using both `System::Timer` and `CHIP_SYSTEM_CONFIG_USE_HEAP` will show a `.bss` increase from this PR; this will be undone by a later step in pool conversion. #### Testing CI; no changes to functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The multiple object pool implementations are being consolidated,
but
System::Timerisn't ready.Change overview
Transitionally, convert
System::Timerto useBitMapObjectPoolinstead of
System::ObjectPool, so that it doesn't obstructrefactoring.
Any platform using both
System::TimerandCHIP_SYSTEM_CONFIG_USE_HEAPwill show a.bssincrease from this PR;this will be undone by a later step in pool conversion.
Testing
CI; no changes to functionality.