-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CD Device Type Id field to 32-bits to match the spec change. #11350
Merged
woody-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/update-device-type-id-element
Nov 4, 2021
Merged
Updated CD Device Type Id field to 32-bits to match the spec change. #11350
woody-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/update-device-type-id-element
Nov 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
November 3, 2021 00:18
pullapprove
bot
requested review from
turon,
vivien-apple,
wbschiller and
woody-apple
November 3, 2021 00:18
PR #11350: Size comparison from c9db3dc to 671932f Decreases (1 build for esp32)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 3, 2021
msandstedt
approved these changes
Nov 4, 2021
woody-apple
approved these changes
Nov 4, 2021
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
emargolis
deleted the
emargolis/feature/update-device-type-id-element
branch
December 14, 2021 10:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently device_type_id field is 16-bits. This should be changed to 32-bits to match DCL's DeviceTypeId field.
Change overview
Changing that to 32-bits to match the proposed spec change.
Testing
unit tested