Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename EventPath and EventPathList #11278

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Rename EventPath and EventPathList #11278

merged 1 commit into from
Nov 1, 2021

Conversation

yunhanw-google
Copy link
Contributor

@yunhanw-google yunhanw-google commented Nov 1, 2021 •
edited
Loading

Problem

Rename EventPath to EventPathIB, rename EventPathList to EventPaths.
Update EventPath/EventPathList with ListBuilder/ListParser and ArrayBuilder/ArrayParser

Change overview

See above

Testing

Exiting test covers

@boring-cyborg boring-cyborg bot added the app label Nov 1, 2021
@yunhanw-google yunhanw-google force-pushed the feature/refresh_event_path branch from 4f90e14 to ac5d031 Compare November 1, 2021 19:31
@andy31415
Copy link
Contributor

Fast track: PR created by domain owner, rename refactoring + trivial change (base clase update), covered by unit tests

@github-actions
Copy link

github-actions bot commented Nov 1, 2021 •
edited
Loading

PR #11278: Size comparison from 79ba23d to ac5d031

Decreases (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 79ba23d ac5d031 change % change
efr32 lighting-app BRD4161A (read only) 735656 735624 -32 -0.0
.text 735648 735616 -32 -0.0
BRD4161A+rpc (read only) 723096 723048 -48 -0.0
.text 723088 723040 -48 -0.0
lock-app BRD4161A (read only) 714940 714908 -32 -0.0
.text 714932 714900 -32 -0.0
window-app BRD4161A (read only) 715852 715820 -32 -0.0
.text 715844 715812 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880282 880234 -48 -0.0
.flash.text 880282 880234 -48 -0.0
m5stack (read only) 911203 911159 -44 -0.0
.flash.text 911203 911159 -44 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 698460 698412 -48 -0.0
.text 613072 613024 -48 -0.0
lock-app k32w061+debug (read/write) 590756 590708 -48 -0.0
.text 514904 514856 -48 -0.0
linux all-clusters-app debug (read only) 1684905 1684633 -272 -0.0
.rodata 137909 137877 -32 -0.0
.text 1413938 1413698 -240 -0.0
bridge-app debug+rpc (read only) 1279349 1279093 -256 -0.0
.text 1074437 1074181 -256 -0.0
chip-tool debug (read only) 4313901 4313469 -432 -0.0
.text 3830693 3830261 -432 -0.0
lighting-app debug+rpc (read only) 1538289 1538033 -256 -0.0
.text 1278114 1277858 -256 -0.0
ota-provider-app debug (read only) 1237241 1236953 -288 -0.0
.rodata 110440 110408 -32 -0.0
.text 1030674 1030418 -256 -0.0
ota-requestor-app debug (read only) 1294497 1294241 -256 -0.0
.text 1075042 1074786 -256 -0.0
tv-app debug (read only) 1771673 1771433 -240 -0.0
.text 1476562 1476322 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2293984 2293816 -168 -0.0
.text 1256584 1256416 -168 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2273112 2272888 -224 -0.0
.text 1235712 1235488 -224 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2250768 2250608 -160 -0.0
.text 1213368 1213208 -160 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860399 860367 -32 -0.0
text 577160 577128 -32 -0.0
nrf52840dk_nrf52840+rpc (read/write) 821223 821191 -32 -0.0
text 550336 550300 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785426 785394 -32 -0.0
text 506628 506596 -32 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 837091 837059 -32 -0.0
text 558640 558608 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762402 762370 -32 -0.0
text 488200 488168 -32 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 843087 843055 -32 -0.0
text 562700 562664 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836963 836931 -32 -0.0
text 558376 558344 -32 -0.0
p6 lock-app default (read/write) 2166800 2166768 -32 -0.0
.text 1125064 1125032 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 489828 489788 -40 -0.0
.text 484508 484468 -40 -0.0
lock-app qpg6100+debug (read only) 466156 466116 -40 -0.0
.text 460836 460796 -40 -0.0
telink lighting-app tlsr9518adk80d (read/write) 661838 661790 -48 -0.0
text 457442 457394 -48 -0.0
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 79ba23d ac5d031 change % change
efr32 lighting-app BRD4161A (read only) 735656 735624 -32 -0.0
(read/write) 114444 114444 0 0.0
.bss 112692 112692 0 0.0
.data 1752 1752 0 0.0
.text 735648 735616 -32 -0.0
BRD4161A+rpc (read only) 723096 723048 -48 -0.0
(read/write) 131052 131052 0 0.0
.bss 129196 129196 0 0.0
.data 1852 1852 0 0.0
.text 723088 723040 -48 -0.0
lock-app BRD4161A (read only) 714940 714908 -32 -0.0
(read/write) 112260 112260 0 0.0
.bss 110548 110548 0 0.0
.data 1712 1712 0 0.0
.text 714932 714900 -32 -0.0
window-app BRD4161A (read only) 715852 715820 -32 -0.0
(read/write) 112584 112584 0 0.0
.bss 110868 110868 0 0.0
.data 1716 1716 0 0.0
.text 715844 715812 -32 -0.0
esp32 all-clusters-app c3devkit (read only) 880282 880234 -48 -0.0
(read/write) 1307664 1307664 0 0.0
.dram0.bss 58424 58424 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 199536 199536 0 0.0
.flash.text 880282 880234 -48 -0.0
.iram0.text 57554 57554 0 0.0
m5stack (read only) 911203 911159 -44 -0.0
(read/write) 427432 427432 0 0.0
.dram0.bss 60920 60920 0 0.0
.dram0.data 32100 32100 0 0.0
.flash.rodata 208248 208248 0 0.0
.flash.text 911203 911159 -44 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 698460 698412 -48 -0.0
.bss 77688 77688 0 0.0
.data 1900 1900 0 0.0
.text 613072 613024 -48 -0.0
lock-app k32w061+debug (read/write) 590756 590708 -48 -0.0
.bss 68188 68188 0 0.0
.data 1864 1864 0 0.0
.text 514904 514856 -48 -0.0
shell k32w061+debug (read/write) 424988 424988 0 0.0
.bss 63280 63280 0 0.0
.data 672 672 0 0.0
.text 359332 359332 0 0.0
linux all-clusters-app debug (read only) 1684905 1684633 -272 -0.0
(read/write) 118992 118992 0 0.0
.bss 50608 50608 0 0.0
.data 1010 1010 0 0.0
.data.rel.ro 62112 62112 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 536 536 0 0.0
.rodata 137909 137877 -32 -0.0
.text 1413938 1413698 -240 -0.0
bridge-app debug+rpc (read only) 1279349 1279093 -256 -0.0
(read/write) 84104 84104 0 0.0
.bss 50768 50768 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27368 27368 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109668 109668 0 0.0
.text 1074437 1074181 -256 -0.0
chip-tool debug (read only) 4313901 4313469 -432 -0.0
(read/write) 123552 123552 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 98880 98880 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 217552 217552 0 0.0
.text 3830693 3830261 -432 -0.0
lighting-app debug+rpc (read only) 1538289 1538033 -256 -0.0
(read/write) 100976 100976 0 0.0
.bss 40152 40152 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 54448 54448 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127793 127793 0 0.0
.text 1278114 1277858 -256 -0.0
ota-provider-app debug (read only) 1237241 1236953 -288 -0.0
(read/write) 67072 67072 0 0.0
.bss 36608 36608 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24616 24616 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110440 110408 -32 -0.0
.text 1030674 1030418 -256 -0.0
ota-requestor-app debug (read only) 1294497 1294241 -256 -0.0
(read/write) 76392 76392 0 0.0
.bss 44864 44864 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25576 25576 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 121664 121664 0 0.0
.text 1075042 1074786 -256 -0.0
shell debug (read only) 785665 785665 0 0.0
(read/write) 57664 57664 0 0.0
.bss 16072 16072 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36848 36848 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 77423 77423 0 0.0
.text 606706 606706 0 0.0
tv-app debug (read only) 1771673 1771433 -240 -0.0
(read/write) 288536 288536 0 0.0
.bss 222192 222192 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58672 58672 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 153208 153208 0 0.0
.text 1476562 1476322 -240 -0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2293984 2293816 -168 -0.0
.bss 179796 179796 0 0.0
.data 5216 5216 0 0.0
.heap 851432 851432 0 0.0
.text 1256584 1256416 -168 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2273112 2272888 -224 -0.0
.bss 171836 171836 0 0.0
.data 5568 5568 0 0.0
.heap 859040 859040 0 0.0
.text 1235712 1235488 -224 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2250768 2250608 -160 -0.0
.bss 170740 170740 0 0.0
.data 5552 5552 0 0.0
.heap 860152 860152 0 0.0
.text 1213368 1213208 -160 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139744 1139744 0 0.0
.bss 11752 11752 0 0.0
.data 4368 4368 0 0.0
.heap 1020328 1020328 0 0.0
.text 103128 103128 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2048592 2048592 0 0.0
.bss 156232 156232 0 0.0
.data 4968 4968 0 0.0
.heap 875248 875248 0 0.0
.text 1011192 1011192 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 860399 860367 -32 -0.0
bss 111148 111148 0 0.0
rodata 96472 96472 0 0.0
text 577160 577128 -32 -0.0
nrf52840dk_nrf52840+rpc (read/write) 821223 821191 -32 -0.0
bss 107392 107392 0 0.0
rodata 87248 87248 0 0.0
text 550336 550300 -36 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 785426 785394 -32 -0.0
bss 112524 112524 0 0.0
rodata 91716 91716 0 0.0
text 506628 506596 -32 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 837091 837059 -32 -0.0
bss 110184 110184 0 0.0
rodata 92828 92828 0 0.0
text 558640 558608 -32 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 762402 762370 -32 -0.0
bss 111596 111596 0 0.0
rodata 88132 88132 0 0.0
text 488200 488168 -32 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497323 497323 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339436 339436 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 843087 843055 -32 -0.0
bss 110320 110320 0 0.0
rodata 94536 94536 0 0.0
text 562700 562664 -36 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 836963 836931 -32 -0.0
bss 110220 110220 0 0.0
rodata 92828 92828 0 0.0
text 558376 558344 -32 -0.0
shell nrf52840dk_nrf52840 (read/write) 776099 776099 0 0.0
bss 109096 109096 0 0.0
rodata 72536 72536 0 0.0
text 519868 519868 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691122 691122 0 0.0
bss 110080 110080 0 0.0
rodata 67180 67180 0 0.0
text 440476 440476 0 0.0
p6 lock-app default (read/write) 2166800 2166768 -32 -0.0
.bss 66184 66184 0 0.0
.data 2416 2416 0 0.0
.heap 964744 964744 0 0.0
.text 1125064 1125032 -32 -0.0
qpg lighting-app qpg6100+debug (read only) 489828 489788 -40 -0.0
(read/write) 114144 114144 0 0.0
.bss 50320 50320 0 0.0
.data 1000 1000 0 0.0
.text 484508 484468 -40 -0.0
lock-app qpg6100+debug (read only) 466156 466116 -40 -0.0
(read/write) 114140 114140 0 0.0
.bss 49272 49272 0 0.0
.data 956 956 0 0.0
.text 460836 460796 -40 -0.0
persistent-storage-app qpg6100+debug (read only) 155820 155820 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 150500 150500 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 661838 661790 -48 -0.0
bss 68960 68960 0 0.0
noinit 33216 33216 0 0.0
text 457442 457394 -48 -0.0

@yunhanw-google yunhanw-google merged commit 2fe9024 into project-chip:master Nov 1, 2021
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@yunhanw-google
Rename EventPath and EventPathList (project-chip#11278)
3c9ca15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunhanw-google @andy31415